233009 2021-11-11 13:03:47 -0800 [Live Text] Augment TextRecognitionResult with a new type of text recognition data 2021-11-11 14:44:20 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1814178 0 wenson_hsieh 2021-11-11 13:03:47 -0800 Add `TextRecognitionBlockData`, which represents a whole paragraph of recognized text. Unlike the existing `TextRecognitionLineData`, this structure does not contain data for individual child text elements, and is instead intended to represent a granular block of text from VisionKit. 1814181 1 443994 wenson_hsieh 2021-11-11 13:07:09 -0800 Created attachment 443994 Patch 1814185 2 443994 hi 2021-11-11 13:21:16 -0800 Comment on attachment 443994 Patch rs=me 1814209 3 443994 wenson_hsieh 2021-11-11 13:53:01 -0800 Comment on attachment 443994 Patch Thanks for the review! 1814244 4 ews-feeder 2021-11-11 14:43:58 -0800 Committed r285670 (244157@main): <https://commits.webkit.org/244157@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443994. 1814245 5 webkit-bug-importer 2021-11-11 14:44:20 -0800 <rdar://problem/85316580> 443994 2021-11-11 13:07:09 -0800 2021-11-11 14:43:59 -0800 Patch bug-233009-20211111130709.patch text/plain 4452 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDFmM2U0MTgxMWRmNTM0 NjA3MzNlNjc0ZmVkNWQ4MmY5NWY4YmY5ZS4uODY4MWU3Zjc4OTkzNGY3MTFkYzU0MjcxN2VjNDIw ODkwNWEzNmExYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTExLTExICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtMaXZlIFRleHRd IEF1Z21lbnQgVGV4dFJlY29nbml0aW9uUmVzdWx0IHdpdGggYSBuZXcgdHlwZSBvZiB0ZXh0IHJl Y29nbml0aW9uIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMzAwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB0aGUgbmV3IHR5cGUsIGFsb25nIHdpdGggZW5jb2RpbmcvZGVjb2Rpbmcgc3Vw cG9ydC4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vVGV4dFJl Y29nbml0aW9uUmVzdWx0Lmg6CisgICAgICAgIChXZWJDb3JlOjpUZXh0UmVjb2duaXRpb25CbG9j a0RhdGE6OlRleHRSZWNvZ25pdGlvbkJsb2NrRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0 UmVjb2duaXRpb25CbG9ja0RhdGE6OmVuY29kZSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpU ZXh0UmVjb2duaXRpb25CbG9ja0RhdGE6OmRlY29kZSk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0 UmVjb2duaXRpb25SZXN1bHQ6OmlzRW1wdHkgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6VGV4 dFJlY29nbml0aW9uUmVzdWx0OjplbmNvZGUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6VGV4 dFJlY29nbml0aW9uUmVzdWx0OjpkZWNvZGUpOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6aW5zdGFsbEltYWdlT3ZlcmxheSk6 CisKIDIwMjEtMTEtMTEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK ICAgICAgICAgTW92ZSBpbWFnZSBvdmVybGF5IGNvZGUgb3V0IG9mIEhUTUxFbGVtZW50IGFuZCBp bnRvIGEgc2VwYXJhdGUgaGVscGVyIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1RleHRSZWNvZ25pdGlvblJlc3VsdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v VGV4dFJlY29nbml0aW9uUmVzdWx0LmgKaW5kZXggY2ZjN2MxZjI0ODU3Nzg0ZDNmODQ1MGJiMWFj OTI1NjA1NGRmYmRlMy4uZTA5OWYxNDU5NmMyMjE4NDcwNjZjOTU2MjRiOGI4YTk3ZDBlNWRiNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGV4dFJlY29nbml0aW9uUmVzdWx0 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGV4dFJlY29nbml0aW9uUmVzdWx0LmgK QEAgLTEzMSw2ICsxMzEsNDEgQEAgdGVtcGxhdGU8Y2xhc3MgRGVjb2Rlcj4gc3RkOjpvcHRpb25h bDxUZXh0UmVjb2duaXRpb25MaW5lRGF0YT4gVGV4dFJlY29nbml0aW9uTGkKICAgICByZXR1cm4g e3sgV1RGTW92ZSgqbm9ybWFsaXplZFF1YWQpLCBXVEZNb3ZlKCpjaGlsZHJlbikgfX07CiB9CiAK K3N0cnVjdCBUZXh0UmVjb2duaXRpb25CbG9ja0RhdGEgeworICAgIFRleHRSZWNvZ25pdGlvbkJs b2NrRGF0YShjb25zdCBTdHJpbmcmIHRoZVRleHQsIEZsb2F0UXVhZCYmIHF1YWQpCisgICAgICAg IDogdGV4dCh0aGVUZXh0KQorICAgICAgICAsIG5vcm1hbGl6ZWRRdWFkKFdURk1vdmUocXVhZCkp CisgICAgeworICAgIH0KKworICAgIFN0cmluZyB0ZXh0OworICAgIEZsb2F0UXVhZCBub3JtYWxp emVkUXVhZDsKKworICAgIHRlbXBsYXRlPGNsYXNzIEVuY29kZXI+IHZvaWQgZW5jb2RlKEVuY29k ZXImKSBjb25zdDsKKyAgICB0ZW1wbGF0ZTxjbGFzcyBEZWNvZGVyPiBzdGF0aWMgc3RkOjpvcHRp b25hbDxUZXh0UmVjb2duaXRpb25CbG9ja0RhdGE+IGRlY29kZShEZWNvZGVyJik7Cit9OworCit0 ZW1wbGF0ZTxjbGFzcyBFbmNvZGVyPiB2b2lkIFRleHRSZWNvZ25pdGlvbkJsb2NrRGF0YTo6ZW5j b2RlKEVuY29kZXImIGVuY29kZXIpIGNvbnN0Cit7CisgICAgZW5jb2RlciA8PCB0ZXh0OworICAg IGVuY29kZXIgPDwgbm9ybWFsaXplZFF1YWQ7Cit9CisKK3RlbXBsYXRlPGNsYXNzIERlY29kZXI+ IHN0ZDo6b3B0aW9uYWw8VGV4dFJlY29nbml0aW9uQmxvY2tEYXRhPiBUZXh0UmVjb2duaXRpb25C bG9ja0RhdGE6OmRlY29kZShEZWNvZGVyJiBkZWNvZGVyKQoreworICAgIHN0ZDo6b3B0aW9uYWw8 U3RyaW5nPiB0ZXh0OworICAgIGRlY29kZXIgPj4gdGV4dDsKKyAgICBpZiAoIXRleHQpCisgICAg ICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisKKyAgICBzdGQ6Om9wdGlvbmFsPEZsb2F0UXVhZD4g bm9ybWFsaXplZFF1YWQ7CisgICAgZGVjb2RlciA+PiBub3JtYWxpemVkUXVhZDsKKyAgICBpZiAo IW5vcm1hbGl6ZWRRdWFkKQorICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OworCisgICAgcmV0 dXJuIHsgeyBXVEZNb3ZlKCp0ZXh0KSwgV1RGTW92ZSgqbm9ybWFsaXplZFF1YWQpIH0gfTsKK30K Kwogc3RydWN0IFRleHRSZWNvZ25pdGlvblJlc3VsdCB7CiAgICAgVmVjdG9yPFRleHRSZWNvZ25p dGlvbkxpbmVEYXRhPiBsaW5lczsKIApAQCAtMTM4LDYgKzE3Myw4IEBAIHN0cnVjdCBUZXh0UmVj b2duaXRpb25SZXN1bHQgewogICAgIFZlY3RvcjxUZXh0UmVjb2duaXRpb25EYXRhRGV0ZWN0b3I+ IGRhdGFEZXRlY3RvcnM7CiAjZW5kaWYKIAorICAgIFZlY3RvcjxUZXh0UmVjb2duaXRpb25CbG9j a0RhdGE+IGJsb2NrczsKKwogICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0CiAgICAgewogICAgICAg ICBpZiAoIWxpbmVzLmlzRW1wdHkoKSkKQEAgLTE0OCw2ICsxODUsOSBAQCBzdHJ1Y3QgVGV4dFJl Y29nbml0aW9uUmVzdWx0IHsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogCisg ICAgICAgIGlmICghYmxvY2tzLmlzRW1wdHkoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsK KwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTE2MSw2ICsyMDEsNyBAQCB0ZW1w bGF0ZTxjbGFzcyBFbmNvZGVyPiB2b2lkIFRleHRSZWNvZ25pdGlvblJlc3VsdDo6ZW5jb2RlKEVu Y29kZXImIGVuY29kZXIpIGNvbgogI2lmIEVOQUJMRShEQVRBX0RFVEVDVElPTikKICAgICBlbmNv ZGVyIDw8IGRhdGFEZXRlY3RvcnM7CiAjZW5kaWYKKyAgICBlbmNvZGVyIDw8IGJsb2NrczsKIH0K IAogdGVtcGxhdGU8Y2xhc3MgRGVjb2Rlcj4gc3RkOjpvcHRpb25hbDxUZXh0UmVjb2duaXRpb25S ZXN1bHQ+IFRleHRSZWNvZ25pdGlvblJlc3VsdDo6ZGVjb2RlKERlY29kZXImIGRlY29kZXIpCkBA IC0xNzcsMTEgKzIxOCwxNyBAQCB0ZW1wbGF0ZTxjbGFzcyBEZWNvZGVyPiBzdGQ6Om9wdGlvbmFs PFRleHRSZWNvZ25pdGlvblJlc3VsdD4gVGV4dFJlY29nbml0aW9uUmVzdQogICAgICAgICByZXR1 cm4gc3RkOjpudWxsb3B0OwogI2VuZGlmCiAKKyAgICBzdGQ6Om9wdGlvbmFsPFZlY3RvcjxUZXh0 UmVjb2duaXRpb25CbG9ja0RhdGE+PiBibG9ja3M7CisgICAgZGVjb2RlciA+PiBibG9ja3M7Cisg ICAgaWYgKCFibG9ja3MpCisgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisKICAgICByZXR1 cm4ge3sKICAgICAgICAgV1RGTW92ZSgqbGluZXMpLAogI2lmIEVOQUJMRShEQVRBX0RFVEVDVElP TikKICAgICAgICAgV1RGTW92ZSgqZGF0YURldGVjdG9ycyksCiAjZW5kaWYKKyAgICAgICAgV1RG TW92ZSgqYmxvY2tzKSwKICAgICB9fTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv dGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu Y3BwCmluZGV4IGY2MjVkNmY3MGYxZTJiOWExOTk4YTZiNTljNzU0M2Y0MDM5NzA4MmEuLmE1ZWNl MDgxMGJmZWU0NjAxZDAwZWRjNmJjNWQ3YWRlMDEwNWM3ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKQEAgLTU4MTUsNiArNTgxNSw3IEBAIHZvaWQgSW50ZXJuYWxzOjppbnN0 YWxsSW1hZ2VPdmVybGF5KEVsZW1lbnQmIGVsZW1lbnQsIFZlY3RvcjxJbWFnZU92ZXJsYXlMaW5l PiYmCiAjaWYgRU5BQkxFKERBVEFfREVURUNUSU9OKQogICAgICAgICAsIFZlY3RvcjxUZXh0UmVj b2duaXRpb25EYXRhRGV0ZWN0b3I+KCkKICNlbmRpZgorICAgICAgICAsIFZlY3RvcjxUZXh0UmVj b2duaXRpb25CbG9ja0RhdGE+KCkKICAgICB9KTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKGxp bmVzKTsK