233008 2021-11-11 13:00:46 -0800 REGRESSION (r285618): [mac-wk1] ASSERTION FAILED: cgContext == [currentContext CGContext] 2021-11-13 16:19:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=232469 InRadar P2 Normal --- 231253 1 ryanhaddad sabouhallawa bfulgham changseok darin dino esprehn+autocc ews-watchlist glenn kondapallykalyan pdr sabouhallawa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1814172 0 ryanhaddad 2021-11-11 13:00:46 -0800 http/tests/css/filters-on-iframes-transform.html is asserting on macOS Debug WK1 bots: ASSERTION FAILED: cgContext == [currentContext CGContext] ./platform/mac/WidgetMac.mm(242) : virtual void WebCore::Widget::paint(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext *) 1 0x11e2d81a9 WTFCrash 2 0x12d35abbb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12f6fbc25 WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 4 0x1317e9f33 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*) 5 0x13226f8c8 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 6 0x13227016b WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 7 0x132096319 WebCore::paintPhase(WebCore::RenderElement&, WebCore::PaintPhase, WebCore::PaintInfo&, WebCore::LayoutPoint const&) 8 0x1320962a8 WebCore::RenderElement::paintAsInlineBlock(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 9 0x131230b8c WebCore::LayoutIntegration::LineLayout::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 10 0x131ffd9d4 WebCore::RenderBlockFlow::paintInlineChildren(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 11 0x131fd4982 WebCore::RenderBlock::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 12 0x131fd5d74 WebCore::RenderBlock::paintObject(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 13 0x131fd429b WebCore::RenderBlock::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 14 0x132117c04 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 15 0x13211589f WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 16 0x132111129 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 17 0x132110621 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 18 0x1321103fe WebCore::RenderLayer::paintLayerByApplyingTransform(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>, WebCore::LayoutSize const&) 19 0x13210f51a WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 20 0x13210e8b7 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 21 0x13211526e WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 22 0x13211124f WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 23 0x132110621 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 24 0x13210f55d WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 25 0x13210e8b7 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 26 0x13211526e WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 27 0x13211124f WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 28 0x132110621 WebCore::RenderLayer::paintLayerContentsAndReflection(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 29 0x13210f55d WebCore::RenderLayer::paintLayerWithEffects(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 30 0x13210e8b7 WebCore::RenderLayer::paintLayer(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 31 0x13211526e WebCore::RenderLayer::paintList(WebCore::RenderLayer::LayerList, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) https://results.webkit.org/?suite=layout-tests&test=http/tests/css/filters-on-iframes-transform.html 1814173 1 webkit-bug-importer 2021-11-11 13:01:02 -0800 <rdar://problem/85311948> 1814175 2 ryanhaddad 2021-11-11 13:02:51 -0800 Test history clearly suggests https://trac.webkit.org/changeset/285618/webkit is what caused this regression 1814208 3 ryanhaddad 2021-11-11 13:53:00 -0800 Skipped test in r285656 since Said is working on the fix now. 1814689 4 darin 2021-11-12 16:54:44 -0800 Unbalanced save/restore? 1814729 5 444131 sabouhallawa 2021-11-12 20:24:36 -0800 Created attachment 444131 Patch 1814730 6 sabouhallawa 2021-11-12 20:29:29 -0800 (In reply to Darin Adler from comment #4) > Unbalanced save/restore? Yes kind of. We switch the context of PaintInto to the context of the filter ImageBuffer and we do not restore back. 1814815 7 ews-feeder 2021-11-13 16:19:33 -0800 Committed r285785 (244229@main): <https://commits.webkit.org/244229@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444131. 444131 2021-11-12 20:24:36 -0800 2021-11-13 16:19:35 -0800 Patch bug-233008-20211112202435.patch text/plain 4773 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJkYjM3NWRkMGY1N2Yx Y2RhZWNkZmUyMmY5MWM2Y2M5NzQwYmZiYS4uMzYwOTI4OTJlYmY1MjQxNWMxZDZhN2MzNGEzMjA4 ODRkZmQxZTExMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDIxLTExLTEyICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIy ODU2MTgpOiBbbWFjLXdrMV0gQVNTRVJUSU9OIEZBSUxFRDogY2dDb250ZXh0ID09IFtjdXJyZW50 Q29udGV4dCBDR0NvbnRleHRdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzMwMDgKKyAgICAgICAgcmRhcjovLzg1MzExOTQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFzc2VydGlvbiBmYWlscyB3 aGVuIGxvYWRpbmcgdGhlIGV4cGVjdGVkIGh0bWwgcGFnZSBiZWNhdXNlIG9uZSBvZgorICAgICAg ICB0aGUgZWxlbWVudHMgaGFzIGEgQ1NTIGZpbHRlciBuYW1lZCAiKCNub29wKSIgYnV0IHRoZSBm aWx0ZXIgIm5vb3AiIGlzCisgICAgICAgIG5vdCBkZWZpbmVkLgorCisgICAgICAgIFRoZSByZWFz b24gZm9yIHRoZSBhc3NlcnRpb24gdG8gZmFpbCBpcyB3ZSBzd2l0Y2ggdGhlIFBhaW50SW5mbyB0 byB0aGUKKyAgICAgICAgY29udGV4dCBvZiB0aGUgQ1NTRmlsdGVyOjpzb3VyY2VJbWFnZSgpIGFu ZCB3ZSBkbyBub3QgcmVzdG9yZSBpdCBiYWNrLgorICAgICAgICBJbiBmYWN0IENTU0ZpbHRlcjo6 YnVpbGRGaWx0ZXJGdW5jdGlvbnMoKSBzaG91bGQgZmFpbCBzaW5jZSB0aGUgZmlsdGVyCisgICAg ICAgIGhhcyBvbmx5IGEgcmVmZXJlbmNlIGZpbHRlciBhbmQgdGhpcyByZWZlcmVuY2UgZmlsdGVy IGRvZXMgbm90IGV4aXQuIFRoZQorICAgICAgICBidWcgaXMgQ1NTRmlsdGVyOjpidWlsZEZpbHRl ckZ1bmN0aW9ucygpIGRvZXMgbm90IGZhaWwgaW4gdGhpcyBjYXNlLgorCisgICAgICAgIEJlZm9y ZSByMjg1NjE4LCBDU1NGaWx0ZXI6OmJ1aWxkRmlsdGVyRnVuY3Rpb25zKCkgd2FzIG5vdCBhZGRp bmcgCisgICAgICAgIFNvdXJjZUdyYXBoaWMgdG8gbV9mdW5jdGlvbnMuIEl0IHdhcyBhZGRlZCBh cyB0aGUgaW5wdXQgb2YgdGhlIGZpcnN0CisgICAgICAgIEZpbHRlckVmZmVjdC4gVGhpcyB3YXMg ZmluZSBzaW5jZSB3ZSB3ZXJlIGFwcGx5aW5nIHRoZSBsYXN0RWZmZWN0IHdoaWNoCisgICAgICAg IGdvZXMgYmFja3dhcmQgdGlsbCBpdCByZWFjaGVzIHRoZSBTb3VyY2VHcmFwaGljLgorCisgICAg ICAgIEJ1dCB0aGUgcGxhbiBpcyB0byBhcHBseSB0aGUgRmlsdGVyRnVuY3Rpb25zIGZyb20gdGhl IGZpcnN0IHRvIHRoZSBsYXN0CisgICAgICAgIHdpdGhvdXQgaGF2aW5nIHRvIGdvIGJhY2t3YXJk LCBzbyB3ZSBuZWVkIHRvIGFkZCB0aGUgU291cmNlR3JhcGhpYyB0bworICAgICAgICBtX2Z1bmN0 aW9ucyBleHBsaWNpdGx5LiBUaGUgYnVnIGhhcHBlbnMgd2hlbiBubyBGaWx0ZXJGdW5jdGlvbiBp cyBidWlsdAorICAgICAgICBzdWNjZXNzZnVsbHkgYW5kIHdlIHJldHVybiAndHJ1ZScgYmVjYXVz ZSBtX2Z1bmN0aW9ucyBpcyBub3QgZW1wdHkuIEl0CisgICAgICAgIGhhcyB0aGUgU291cmNlR3Jh cGhpYy4KKworICAgICAgICBUaGUgZml4IGlzIHRvIGFkZCB0aGUgU291cmNlR3JhcGhpYyBvbmx5 IHdoZW4gdGhlcmUgaXMgYXQgbGVhc3QgYW5vdGhlciAKKyAgICAgICAgRmlsdGVyRnVuY3Rpb24g d2lsbCBiZSBhZGRlZCB0byBtX2Z1bmN0aW9ucy4KKworICAgICAgICAqIHJlbmRlcmluZy9DU1NG aWx0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTRmlsdGVyOjpidWlsZEZpbHRlckZ1bmN0 aW9ucyk6CisKIDIwMjEtMTEtMTIgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjg1NDgxKTogSW5maW5pdGUgcmVjdXJzaW9uIHdpdGgg Y3ljbGljIGZpbHRlciByZWZlcmVuY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9DU1NGaWx0ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0NTU0ZpbHRlci5j cHAKaW5kZXggNTUxNTA0MzRjNDMwMGU0Y2E5ZGUzODIyNDk3ZWE5YzllM2ZlMDNkMS4uMWNhMGEw OTM0MzgxN2IxMzdmMTlmMTU2ZWRjNDRiOTA5NTg1OTNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0NTU0ZpbHRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0NTU0ZpbHRlci5jcHAKQEAgLTI0Miw4ICsyNDIsNiBAQCBib29sIENTU0ZpbHRlcjo6YnVp bGRGaWx0ZXJGdW5jdGlvbnMoUmVuZGVyRWxlbWVudCYgcmVuZGVyZXIsIGNvbnN0IEZpbHRlck9w ZXJhdAogICAgIG1fb3V0c2V0cyA9IHsgfTsKIAogICAgIFJlZlB0cjxGaWx0ZXJFZmZlY3Q+IHBy ZXZpb3VzRWZmZWN0ID0gU291cmNlR3JhcGhpYzo6Y3JlYXRlKCp0aGlzKTsKLSAgICBtX2Z1bmN0 aW9ucy5hcHBlbmQoeyAqcHJldmlvdXNFZmZlY3QgfSk7Ci0KICAgICBSZWZQdHI8U1ZHRmlsdGVy PiBmaWx0ZXI7CiAgICAgCiAgICAgZm9yIChhdXRvJiBvcGVyYXRpb24gOiBvcGVyYXRpb25zLm9w ZXJhdGlvbnMoKSkgewpAQCAtMzAzLDYgKzMwMSwxMSBAQCBib29sIENTU0ZpbHRlcjo6YnVpbGRG aWx0ZXJGdW5jdGlvbnMoUmVuZGVyRWxlbWVudCYgcmVuZGVyZXIsIGNvbnN0IEZpbHRlck9wZXJh dAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoKGZpbHRlciB8 fCBlZmZlY3QpICYmIG1fZnVuY3Rpb25zLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgQVNTRVJU KHByZXZpb3VzRWZmZWN0LT5maWx0ZXJUeXBlKCkgPT0gRmlsdGVyRWZmZWN0OjpUeXBlOjpTb3Vy Y2VHcmFwaGljKTsKKyAgICAgICAgICAgIG1fZnVuY3Rpb25zLmFwcGVuZCh7ICpwcmV2aW91c0Vm ZmVjdCB9KTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgaWYgKGZpbHRlcikgewogICAg ICAgICAgICAgZWZmZWN0ID0gZmlsdGVyLT5sYXN0RWZmZWN0KCk7CiAgICAgICAgICAgICBzZXR1 cExhc3RFZmZlY3RQcm9wZXJ0aWVzKCplZmZlY3QsIGNvbnN1bWVyKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyOTA0OThk M2JjODQ5NTgzM2Y2NmMzY2MwZmJhNzM4ZTlkMGZmNTdlLi4yN2I3YThlMGMwZmI2MzkyOTZjOWM5 ZDA0ODcyMjQzOGExOTUxNDliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTEtMTIgIFNh aWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI4NTYxOCk6IFttYWMtd2sxXSBBU1NFUlRJT04gRkFJTEVEOiBjZ0NvbnRleHQgPT0gW2N1cnJl bnRDb250ZXh0IENHQ29udGV4dF0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMzAwOAorICAgICAgICByZGFyOi8vODUzMTE5NDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgdGhlIHRlc3QgaHR0 cC90ZXN0cy9jc3MvZmlsdGVycy1vbi1pZnJhbWVzLXRyYW5zZm9ybS5odG1sIHdoaWNoIAorICAg ICAgICB3YXMgc2tpcHBlZCBpbiByMjg1NjU2LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdr MS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTExLTEyICBTYWlkIEFib3UtSGFsbGF3YSAgPHNh aWRAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI4NTQ4MSk6IEluZmluaXRlIHJl Y3Vyc2lvbiB3aXRoIGN5Y2xpYyBmaWx0ZXIgcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTBiMTEyNmY0MWExZGI4YzMwZDg5 NTZhNjNhMzQ5Y2Y5ZjFlZmQ0Zi4uMWRmOTVkMDUzMzUzMDY1MzkyNzNlMjAxMzkxZjMwZjRjZWYy ZGQ0OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMTUxNiw3ICsxNTE2LDUgQEAgd2Via2l0Lm9yZy9iLzIzMjQ0NiBbIENhdGFsaW5hIERl YnVnIF0gbWVkaWEvdHJhY2svdHJhY2stZWxlbWVudC1kb20tY2hhbmdlLWNyYXMKIAogd2Via2l0 Lm9yZy9iLzIzMjU4NSBbIENhdGFsaW5hIERlYnVnIF0gbWVkaWEvdHJhY2svdHJhY2stZWxlbWVu dC1sb2FkLWV2ZW50Lmh0bWwgWyBQYXNzIENyYXNoIF0KIAotd2Via2l0Lm9yZy9iLzIzMzAwOCBb IERlYnVnIF0gaHR0cC90ZXN0cy9jc3MvZmlsdGVycy1vbi1pZnJhbWVzLXRyYW5zZm9ybS5odG1s IFsgU2tpcCBdCi0KICMgRHVtcFJlbmRlclRyZWUgZG9lc24ndCBpbnZva2UgaW5zcGVjdG9yIGlu c3RydW1lbnRhdGlvbiB3aGVuIHJlcGFpbnRpbmcuCiB3ZWJraXQub3JnL2IvMjMyODUyIGluc3Bl Y3Rvci9wYWdlL3NldFNob3dQYWludFJlY3RzLmh0bWwgWyBTa2lwIF0K