233002 2021-11-11 10:00:30 -0800 [LFC][IFC] Reset InlineTextItem width on bidi split 2021-11-11 11:08:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham darin simon.fraser webkit-bug-importer zalan oldest_to_newest 1814076 0 zalan 2021-11-11 10:00:30 -0800 ssia 1814079 1 443963 zalan 2021-11-11 10:03:27 -0800 Created attachment 443963 Patch 1814080 2 443963 darin 2021-11-11 10:05:43 -0800 Comment on attachment 443963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443963&action=review > Source/WebCore/ChangeLog:8 > + We remeasure the individual inline items right before line breaking. Was there a test that could have caught this mistake? 1814085 3 zalan 2021-11-11 10:14:17 -0800 (In reply to Darin Adler from comment #2) > Comment on attachment 443963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443963&action=review > > > Source/WebCore/ChangeLog:8 > > + We remeasure the individual inline items right before line breaking. > > Was there a test that could have caught this mistake? fast/text/international/bidi-layout-across-linebreak.html would have caught this, if this codepath was enabled (which it did at my trybot bug 229638). I am in the middle of enabling bidi content (including this codepath) for IFC (bug 232980) and going through the failures at https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK1-Tests-EWS/r443898-20106/results.html (the trybot output) 1814123 4 ews-feeder 2021-11-11 11:07:03 -0800 Committed r285642 (244143@main): <https://commits.webkit.org/244143@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443963. 1814126 5 webkit-bug-importer 2021-11-11 11:08:52 -0800 <rdar://problem/85307114> 443963 2021-11-11 10:03:27 -0800 2021-11-11 11:07:05 -0800 Patch bug-233002-20211111100326.patch text/plain 1505 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JhMmNjYWI1NWE5OTJi ZDNiODM3MjMyMTdmMzEwODVhZmRhZDJkNS4uMjAyMzQ4MDVkMmE5MDczMDdmOGQ4N2U0YTc4YTBh ZWI5MmY5ZDYyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTExLTExICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIFJlc2V0IElu bGluZVRleHRJdGVtIHdpZHRoIG9uIGJpZGkgc3BsaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzAwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHJlbWVhc3VyZSB0aGUgaW5kaXZpZHVhbCBpbmxp bmUgaXRlbXMgcmlnaHQgYmVmb3JlIGxpbmUgYnJlYWtpbmcuCisKKyAgICAgICAgKiBsYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVUZXh0SXRlbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OklubGluZVRleHRJdGVtOjpzcGxpdCk6CisKIDIwMjEtMTEtMTEgIEFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9u XSBCcmluZyBzaG93UmVuZGVyVHJlZSBmb3IgSUZDIGludGVncmF0aW9uIGJhY2sKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGlu ZVRleHRJdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMv aW5saW5lL0lubGluZVRleHRJdGVtLmNwcAppbmRleCA4NjQwY2QyNTdlZTBkOWJlODM2OGQyYzZk NGUyMGRmNmNlNDA1NTI3Li5kZTE1ZGQwY2M4NzFiN2I2ZTczN2JmODZlYzQ2OWM5MDA0ZWU4ZGEz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lu bGluZS9JbmxpbmVUZXh0SXRlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1h dHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lVGV4dEl0ZW0uY3BwCkBAIC03Nyw2ICs3Nyw4IEBA IElubGluZVRleHRJdGVtIElubGluZVRleHRJdGVtOjpzcGxpdChzaXplX3QgbGVmdFNpZGVMZW5n dGgpCiAgICAgUkVMRUFTRV9BU1NFUlQobGVmdFNpZGVMZW5ndGggJiYgbGVmdFNpZGVMZW5ndGgg PCBsZW5ndGgoKSk7CiAgICAgYXV0byByaWdodFNpZGUgPSByaWdodChsZW5ndGgoKSAtIGxlZnRT aWRlTGVuZ3RoLCB7IH0pOwogICAgIG1fbGVuZ3RoID0gbGVuZ3RoKCkgLSByaWdodFNpZGUubGVu Z3RoKCk7CisgICAgbV9oYXNXaWR0aCA9IGZhbHNlOworICAgIG1fd2lkdGggPSB7IH07CiAgICAg cmV0dXJuIHJpZ2h0U2lkZTsKIH0KIAo=