232989 2021-11-11 02:25:13 -0800 Misc compiler warnings 2021-11-12 13:07:39 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcrha mcatanzaro bugs-noreply darin mcatanzaro oldest_to_newest 1813962 0 mcrha 2021-11-11 02:25:13 -0800 I configured the 2.34.1 release tarball sources as this: -- Enabled features: -- ENABLE_BUBBLEWRAP_SANDBOX ..................... ON -- ENABLE_DRAG_SUPPORT ON -- ENABLE_GAMEPAD ................................ OFF -- ENABLE_GLES2 OFF -- ENABLE_GTKDOC ................................. OFF -- ENABLE_INTROSPECTION OFF -- ENABLE_MEDIA_SOURCE ........................... ON -- ENABLE_MINIBROWSER ON -- ENABLE_QUARTZ_TARGET .......................... OFF -- ENABLE_SPELLCHECK ON -- ENABLE_TOUCH_EVENTS ........................... ON -- ENABLE_VIDEO ON -- ENABLE_WAYLAND_TARGET ......................... OFF -- ENABLE_WEBDRIVER ON -- ENABLE_WEB_AUDIO .............................. ON -- ENABLE_WEB_CRYPTO ON -- ENABLE_X11_TARGET ............................. ON -- USE_AVIF OFF -- USE_GTK4 ...................................... OFF -- USE_LCMS OFF -- USE_LIBHYPHEN ................................. ON -- USE_LIBNOTIFY ON -- USE_LIBSECRET ................................. ON -- USE_OPENGL_OR_ES ON -- USE_OPENJPEG .................................. ON -- USE_SOUP2 OFF -- USE_SYSTEMD ................................... ON -- USE_WOFF2 ON -- USE_WPE_RENDERER .............................. OFF and I see several compiler warnings, some quite important, from my point of view. [1026/5040] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-37.cpp.o In file included from .../webkitgtk-2.34.1/_build/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-37.cpp:6: .../webkitgtk-2.34.1/Source/JavaScriptCore/runtime/TemporalDuration.cpp: In function ‘JSC::PropertyName JSC::propertyName(JSC::VM&, unsigned int)’: .../webkitgtk-2.34.1/Source/JavaScriptCore/runtime/TemporalDuration.cpp:45:1: warning: control reaches end of non-void function [-Wreturn-type] 45 | } | ^ [1030/5040] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-38.cpp.o In file included from .../webkitgtk-2.34.1/_build/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-38.cpp:2: .../webkitgtk-2.34.1/Source/JavaScriptCore/runtime/TemporalObject.cpp: In function ‘double JSC::roundNumberToIncrement(double, double, JSC::RoundingMode)’: .../webkitgtk-2.34.1/Source/JavaScriptCore/runtime/TemporalObject.cpp:331:1: warning: control reaches end of non-void function [-Wreturn-type] 331 | } | ^ [2263/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-7.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-7.cpp:6: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSAudioWorkletNodeOptions.cpp: In function ‘T WebCore::convertDictionary(JSC::JSGlobalObject&, JSC::JSValue) [with T = WebCore::AudioWorkletNodeOptions]’: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSAudioWorkletNodeOptions.cpp:57:29: warning: ‘((unsigned int*)((char*)&result + offsetof(WebCore::AudioWorkletNodeOptions, WebCore::AudioWorkletNodeOptions::outputChannelCount.std::optional<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >::<unnamed>.std::_Optional_base<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, false, false>::_M_payload.std::_Optional_payload<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, false, false, false>::<unnamed>.std::_Optional_payload<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, true, false, false>::<unnamed>.std:: _Optional_payload_base<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >::_M_payload)))[2]’ is used uninitialized [-Wuninitialized] 57 | AudioWorkletNodeOptions result; | ^~~~~~ .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSAudioWorkletNodeOptions.cpp:57:29: warning: ‘((unsigned int*)((char*)&result + offsetof(WebCore::AudioWorkletNodeOptions, WebCore::AudioWorkletNodeOptions::outputChannelCount.std::optional<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >::<unnamed>.std::_Optional_base<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, false, false>::_M_payload.std::_Optional_payload<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, false, false, false>::<unnamed>.std::_Optional_payload<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, true, false, false>::<unnamed>.std:: _Optional_payload_base<WTF::Vector<unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >::_M_payload)))[3]’ is used uninitialized [-Wuninitialized] [2312/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-58.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-58.cpp:1: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaEncodingConfiguration.cpp: In function ‘T WebCore::convertDictionary(JSC::JSGlobalObject&, JSC::JSValue) [with T = WebCore::MediaEncodingConfiguration]’: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaEncodingConfiguration.cpp:46:32: warning: ‘*(WebCore::VideoConfiguration*)((char*)&result + offsetof(WebCore::MediaEncodingConfiguration, WebCore::MediaEncodingConfiguration::<unnamed>.WebCore::MediaConfiguration::video.std::optional<WebCore::VideoConfiguration>::<unnamed>.std::_Optional_base<WebCore::VideoConfiguration, false, false>::<unnamed>)).WebCore::VideoConfiguration::width’ is used uninitialized [-Wuninitialized] 46 | MediaEncodingConfiguration result; | ^~~~~~ .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaEncodingConfiguration.cpp:46:32: warning: ‘*(WebCore::VideoConfiguration*)((char*)&result + offsetof(WebCore::MediaEncodingConfiguration, WebCore::MediaEncodingConfiguration::<unnamed>.WebCore::MediaConfiguration::video.std::optional<WebCore::VideoConfiguration>::<unnamed>.std::_Optional_base<WebCore::VideoConfiguration, false, false>::<unnamed>)) .WebCore::VideoConfiguration::height’ is used uninitialized [-Wuninitialized] [2313/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-57.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-57.cpp:3: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaDecodingConfiguration.cpp: In function ‘T WebCore::convertDictionary(JSC::JSGlobalObject&, JSC::JSValue) [with T = WebCore::MediaDecodingConfiguration]’: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaDecodingConfiguration.cpp:46:32: warning: ‘*(WebCore::VideoConfiguration*)((char*)&result + offsetof(WebCore::MediaDecodingConfiguration, WebCore::MediaDecodingConfiguration::<unnamed>.WebCore::MediaConfiguration::video.std::optional<WebCore::VideoConfiguration>::<unnamed>.std::_Optional_base<WebCore::VideoConfiguration, false, false>::<unnamed>)) .WebCore::VideoConfiguration::width’ is used uninitialized [-Wuninitialized] 46 | MediaDecodingConfiguration result; | ^~~~~~ .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaDecodingConfiguration.cpp:46:32: warning: ‘*(WebCore::VideoConfiguration*)((char*)&result + offsetof(WebCore::MediaDecodingConfiguration, WebCore::MediaDecodingConfiguration::<unnamed>.WebCore::MediaConfiguration::video.std::optional<WebCore::VideoConfiguration>::<unnamed>.std::_Optional_base<WebCore::VideoConfiguration, false, false>::<unnamed>)) .WebCore::VideoConfiguration::height’ is used uninitialized [-Wuninitialized] [2604/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-6.cpp:8: .../webkitgtk-2.34.1/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘WebCore::LayoutIntegration::RunIterator WebCore::LayoutIntegration::LineIterator::closestRunForLogicalLeftPosition(int, bool)’: .../webkitgtk-2.34.1/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:178:10: warning: ‘((WTF::RefCountedArray<const WebCore::LegacyInlineBox*, WTF::RawPtrTraits<const WebCore::LegacyInlineBox*> >*)((char*)&closestRun + offsetof(WebCore::LayoutIntegration::RunIterator, WebCore::LayoutIntegration::RunIterator::m_run.WebCore::LayoutIntegration::PathRun::m_pathVariant.WTF::Variant<WebCore::LayoutIntegration::RunIteratorLegacyPath>::__storage)))[1] .WTF::RefCountedArray<const WebCore::LegacyInlineBox*>::m_data’ is used uninitialized [-Wuninitialized] 178 | auto closestRun = lastRun; | ^~~~~~~~~~ .../webkitgtk-2.34.1/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:178:10: warning: ‘*(WebCore::LayoutIntegration::RunIteratorLegacyPath*)((char*)&closestRun + offsetof(WebCore::LayoutIntegration::RunIterator, WebCore::LayoutIntegration::RunIterator::m_run.WebCore::LayoutIntegration::PathRun::m_pathVariant.WTF::Variant<WebCore::LayoutIntegration::RunIteratorLegacyPath>::<unnamed>)) .WebCore::LayoutIntegration::RunIteratorLegacyPath::m_inlineBox’ is used uninitialized [-Wuninitialized] [2704/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-50.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-50.cpp:3: .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp: In member function ‘Out WTF::Detail::CallableWrapper< <template-parameter-1-1>, <template-parameter-1-2>, <template-parameter-1-3> >::call(In ...) [with CallableType = WebCore::DataURLDecoder::decode(const WTF::URL&, const WebCore::DataURLDecoder::ScheduleContext&, WebCore::DataURLDecoder::Mode, WebCore::DataURLDecoder::DecodeCompletionHandler&&)::<lambda()>; Out = void; In = {}]’: .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘((WTF::StringImpl**)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed>.std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::_M_payload.std::_Optional_payload<WebCore::DataURLDecoder::Result, false, false, false>::<unnamed>.std::_Optional_payload<WebCore::DataURLDecoder::Result, true, false, false>::<unnamed> .std::_Optional_payload_base<WebCore::DataURLDecoder::Result>::_M_payload)))[1]’ is used uninitialized [-Wuninitialized] 202 | auto callCompletionHandler = [result = WTFMove(result), completionHandler = WTFMove(decodeTask->completionHandler)]() mutable { | ^~~~~~~~~~~~~~~~~~~~~ .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘*(WTF::StringImpl**)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed> .std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::<unnamed>))’ is used uninitialized [-Wuninitialized] .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘((WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>*)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed>.std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::_M_payload.std::_Optional_payload<WebCore::DataURLDecoder::Result, false, false, false>::<unnamed>.std::_Optional_payload<WebCore::DataURLDecoder::Result, true, false, false>::<unnamed>.std::_Optional_payload_base<WebCore::DataURLDecoder::Result>::_M_payload) + 8))[1] .WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>::m_buffer’ is used uninitialized [-Wuninitialized] .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘((WTF::StringImpl**)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed>.std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::_M_payload.std::_Optional_payload<WebCore::DataURLDecoder::Result, false, false, false>::<unnamed>.std::_Optional_payload<WebCore::DataURLDecoder::Result, true, false, false>::<unnamed> .std::_Optional_payload_base<WebCore::DataURLDecoder::Result>::_M_payload)))[2]’ is used uninitialized [-Wuninitialized] .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘((WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>*)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed>.std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::_M_payload.std::_Optional_payload<WebCore::DataURLDecoder::Result, false, false, false>::<unnamed>.std::_Optional_payload<WebCore::DataURLDecoder::Result, true, false, false>::<unnamed>.std::_Optional_payload_base<WebCore::DataURLDecoder::Result>::_M_payload) + 8))[1] .WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>::m_capacity’ is used uninitialized [-Wuninitialized] .../webkitgtk-2.34.1/Source/WebCore/platform/network/DataURLDecoder.cpp:202:14: warning: ‘((WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>*)((char*)&callCompletionHandler + offsetof(WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248, WebCore::DataURLDecoder::decode::._anon_247::operator()::._anon_248::__result.std::optional<WebCore::DataURLDecoder::Result>::<unnamed>.std::_Optional_base<WebCore::DataURLDecoder::Result, false, false>::_M_payload.std::_Optional_payload<WebCore::DataURLDecoder::Result, false, false, false>::<unnamed>.std::_Optional_payload<WebCore::DataURLDecoder::Result, true, false, false>::<unnamed>.std::_Optional_payload_base<WebCore::DataURLDecoder::Result>::_M_payload) + 8))[1] .WTF::VectorBufferBase<unsigned char, WTF::FastMalloc>::m_size’ is used uninitialized [-Wuninitialized] ================================================================================================================================ The (currently) latest build for the Fedora does not show all of those, but there are some important too: https://kojipkgs.fedoraproject.org//packages/webkit2gtk3/2.34.1/6.fc36/data/logs/x86_64/build.log I search for "[-w" (quotes for clarity only) to filter them out, after replacing "[-Wodr]" (quotes for clarity only) with something else, because there are a lot of those. One which may worth a note is: In function 'memcpy', inlined from 'get' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/Packed.h:146:15, inlined from '__conv_op ' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/Packed.h:195:48, inlined from '__conv_op ' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/RefPtr.h:89:57, inlined from 'isShared' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:84:36, inlined from 'isShared' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:202:31, inlined from 'unsharedBuffer' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:60:9, inlined from 'send' at /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/Modules/websockets/WebSocket.cpp:389:52, inlined from 'operator()' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/DerivedSources/JSWebSocket.cpp:535:5, inlined from 'toJS' at /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/bindings/js/JSDOMConvertBase.h:168:18, inlined from 'jsWebSocketPrototypeFunction_send2Body' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/DerivedSources/JSWebSocket.cpp:535:5, inlined from 'jsWebSocketPrototypeFunction_sendOverloadDispatcher' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/DerivedSources/JSWebSocket.cpp:576:13, inlined from 'call' at /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/bindings/js/JSDOMOperation.h:63:9, inlined from 'jsWebSocketPrototypeFunction_send' at /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/DerivedSources/JSWebSocket.cpp:586:96: /usr/include/bits/string_fortified.h:29:33: warning: '__builtin_memcpy' reading 6 bytes from a region of size 0 [-Wstringop-overread] 29 | return __builtin___memcpy_chk (__dest, __src, __len, | ^ I do not know whether it's a false positive or not. 1814028 1 mcatanzaro 2021-11-11 07:55:07 -0800 They all look like spam to me. Which of those do you consider important? I try to keep trunk warning-free, so these should mostly all be fixed already on trunk, but I don't make any such effort for the release branches. > In function 'memcpy', > inlined from 'get' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/ > Packed.h:146:15, > inlined from '__conv_op ' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/ > Packed.h:195:48, > inlined from '__conv_op ' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WTF/Headers/wtf/ > RefPtr.h:89:57, > inlined from 'isShared' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/ > PrivateHeaders/JavaScriptCore/ArrayBuffer.h:84:36, > inlined from 'isShared' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/ > PrivateHeaders/JavaScriptCore/ArrayBuffer.h:202:31, > inlined from 'unsharedBuffer' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/JavaScriptCore/ > PrivateHeaders/JavaScriptCore/ArrayBufferView.h:60:9, > inlined from 'send' at > /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/Modules/websockets/ > WebSocket.cpp:389:52, > inlined from 'operator()' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/ > DerivedSources/JSWebSocket.cpp:535:5, > inlined from 'toJS' at > /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/bindings/js/ > JSDOMConvertBase.h:168:18, > inlined from 'jsWebSocketPrototypeFunction_send2Body' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/ > DerivedSources/JSWebSocket.cpp:535:5, > inlined from 'jsWebSocketPrototypeFunction_sendOverloadDispatcher' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/ > DerivedSources/JSWebSocket.cpp:576:13, > inlined from 'call' at > /builddir/build/BUILD/webkitgtk-2.34.1/Source/WebCore/bindings/js/ > JSDOMOperation.h:63:9, > inlined from 'jsWebSocketPrototypeFunction_send' at > /builddir/build/BUILD/webkitgtk-2.34.1/redhat-linux-build/WebCore/ > DerivedSources/JSWebSocket.cpp:586:96: > /usr/include/bits/string_fortified.h:29:33: warning: '__builtin_memcpy' > reading 6 bytes from a region of size 0 [-Wstringop-overread] > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > | ^ > > I do not know whether it's a false positive or not. I haven't looked closely, but my experience with -Wstringop-overread is the warning is almost always a false positive, or else so obtuse and unclear that it's unclear whether anything is actually wrong. This one is particularly annoying since it's coming from generated sources, so we'd have to investigate the generator to see what's going on. I think it's only worth investigating if the warning still happens when building trunk. -Wodr is bug #229867. 1814043 2 mcatanzaro 2021-11-11 08:37:34 -0800 (In reply to Michael Catanzaro from comment #1) > I haven't looked closely, but my experience with -Wstringop-overread is the > warning is almost always a false positive, or else so obtuse and unclear > that it's unclear whether anything is actually wrong. This one is > particularly annoying since it's coming from generated sources, so we'd have > to investigate the generator to see what's going on. I think it's only worth > investigating if the warning still happens when building trunk. This one is actually happening with trunk. Maybe GCC changed? Fortunately, I have a much better warning message in my build: [5489/5749] Linking CXX executable bin/TestWebKitAPI/TestWebCore /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.h:33: note: type name ‘sh::TParseContext’ should match type name ‘angle::pp::Tokenizer::Context’ 33 | class TParseContext : angle::NonCopyable | /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h:25: note: the incompatible type is defined here 25 | struct Context | In member function ‘get’, inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:198:48, inlined from ‘__conv_op ’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/RefPtr.h:89:57, inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:93:36, inlined from ‘isShared’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBuffer.h:211:31, inlined from ‘unsharedBuffer’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/JavaScriptCore/PrivateHeaders/JavaScriptCore/ArrayBufferView.h:61:9, inlined from ‘send’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/Modules/websockets/WebSocket.cpp:386:52, inlined from ‘operator()’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5, inlined from ‘toJS’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMConvertBase.h:168:18, inlined from ‘jsWebSocketPrototypeFunction_send2Body’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:537:5, inlined from ‘jsWebSocketPrototypeFunction_sendOverloadDispatcher’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:578:13, inlined from ‘call’ at /home/mcatanzaro/Projects/WebKit/Source/WebCore/bindings/js/JSDOMOperation.h:63:9, inlined from ‘jsWebSocketPrototypeFunction_send’ at /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WebCore/DerivedSources/JSWebSocket.cpp:588:96: /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME/WTF/Headers/wtf/Packed.h:146:15: warning: ‘__builtin_memcpy’ reading 6 bytes from a region of size 0 [-Wstringop-overread] 146 | memcpy(&value, m_storage.data(), storageSize); | ^ So it's bug #226557 again, but this time with a different file. Sigh. Probably this warning will have to be turned off globally. I have some relevant discussion with the GCC developers in https://bugzilla.redhat.com/show_bug.cgi?id=2002031#c5. 1814050 3 mcatanzaro 2021-11-11 08:53:46 -0800 (In reply to Michael Catanzaro from comment #2) > Maybe GCC changed? I think it's only emitted with LTO enabled. 1814113 4 mcatanzaro 2021-11-11 10:44:48 -0800 I've uploaded a patch for -Wodr in bug #229867. Also reopened bug #226557. I'll submit one more patch here to fix current misc warnings that appear on trunk. I don't notice any of the -Wuninitialized warnings, so won't bother with those (maybe they're already fixed on trunk). 1814114 5 443973 mcatanzaro 2021-11-11 10:47:18 -0800 Created attachment 443973 [fast-cq] Patch 1814216 6 ews-feeder 2021-11-11 14:04:35 -0800 Found 1 new test failure: imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-revert.html 1814289 7 ews-feeder 2021-11-11 16:19:59 -0800 Found 1 new test failure: imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-revert.html 1814315 8 ews-feeder 2021-11-11 17:21:08 -0800 Committed r285694 (244164@main): <https://commits.webkit.org/244164@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443973. 1814360 9 mcrha 2021-11-11 23:12:22 -0800 (In reply to Michael Catanzaro from comment #1) > Which of those do you consider important? (In reply to Michael Catanzaro from comment #4) > I don't notice any of the -Wuninitialized warnings, so won't bother > with those (maybe they're already fixed on trunk). Those are those I consider important, because using uninitialized memory can lead to undefined behavior. I believe you do not see them, because you have those optional parts enabled, while I have them disabled. Compare your "Enabled features:" with mine (comment #0). 1814574 10 mcatanzaro 2021-11-12 13:07:39 -0800 If you get the warnings on trunk, I can take a closer look, but I really don't think it's worth looking at 2.34.1. These look pretty dumb tbh: [2312/5040] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-58.cpp.o In file included from .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-58.cpp:1: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaEncodingConfiguration.cpp: In function ‘T WebCore::convertDictionary(JSC::JSGlobalObject&, JSC::JSValue) [with T = WebCore::MediaEncodingConfiguration]’: .../webkitgtk-2.34.1/_build/WebCore/DerivedSources/JSMediaEncodingConfiguration.cpp:46:32: warning: ‘*(WebCore::VideoConfiguration*)((char*)&result + offsetof(WebCore::MediaEncodingConfiguration, WebCore::MediaEncodingConfiguration::<unnamed>.WebCore::MediaConfiguration::video.std::optional<WebCore::VideoConfiguration>::<unnamed>.std::_Optional_base<WebCore::VideoConfiguration, false, false>::<unnamed>)).WebCore::VideoConfiguration::width’ is used uninitialized [-Wuninitialized] 46 | MediaEncodingConfiguration result; | ^~~~~~ MediaEncodingConfiguration inherits from MediaConfiguration, which contains a std::optional<VideoConfiguration>. It's going to be disengaged after construction so unless I'm missing something, the warning doesn't make any sense. I also looked at the warning about DataURLDecoder.cpp and couldn't make any sense of it. 443973 2021-11-11 10:47:18 -0800 2021-11-11 18:37:24 -0800 [fast-cq] Patch bug-232989-20211111124717.patch text/plain 5243 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZjMGY5MzEwNGI5ODlk MTIyMzdiM2IwZGEzNzBkYTQ1NTk2Y2M1Ni4uZjM3MmYxYzA3MzFiMzU2YjVkMTkyN2I3NzRjNGY0 ZmMwMWE0YWRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTExLTExICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIE1pc2MgY29t cGlsZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMjk4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvbkFjdGlvbnMuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q29udGVudEV4dGVuc2lvbnM6OlJlZGlyZWN0QWN0aW9uOjpVUkxU cmFuc2Zvcm1BY3Rpb246OnBhcnNlKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNp b25zOjpSZWRpcmVjdEFjdGlvbjo6VVJMVHJhbnNmb3JtQWN0aW9uOjpRdWVyeVRyYW5zZm9ybTo6 cGFyc2UpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvU2NhbGVUcmFu c2Zvcm1PcGVyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6YmxlbmRTY2FsZUNvbXBvbmVu dCk6CisgICAgICAgICogc3R5bGUvQ2FzY2FkZUxldmVsLmg6CisgICAgICAgIChXZWJDb3JlOjpT dHlsZTo6b3BlcmF0b3ItLSk6CisKIDIwMjEtMTEtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgogCiAgICAgICAgIEludHJvZHVjZSBTZWxlY3Rvck1hdGNoaW5nU3RhdGUgYW5k IG1vdmUgU2VsZWN0b3JGaWx0ZXIgdGhlcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNGUxNTE5NmQ4Y2ZkZDc0MDI0 YmE3YWRmNmNmZDU4N2VjZDVkZDQ4Mi4uNmMyZWVkY2E4ZjdkMTlkNWI4NzhhZmI4NTA5ZDQyOWZj ZWJiNzVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0xMS0xMSAgTWljaGFlbCBD YXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KKworICAgICAgICBNaXNjIGNvbXBpbGVy IHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzI5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorCiAyMDIxLTExLTEwICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgV2Ugc2hvdWxkIG5vdCBraWxsIGFsbCBX ZWJDb250ZW50IHByb2Nlc3NlcyB3aGVuZXZlciB0aGUgV2ViQXV0aG4gcHJvY2VzcyBjcmFzaGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9Db250ZW50RXh0 ZW5zaW9uQWN0aW9ucy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9Db250 ZW50RXh0ZW5zaW9uQWN0aW9ucy5jcHAKaW5kZXggNTM1ZjM2YjU3YTI1MWFiNjEyOWZiYjdjZGRi ZDhkYTEyYjAzYWU3My4uYWJkMDU4MDFjZjEyYjAwMTliYjY5M2Q0N2IxNTYwZDgxNGY2NjA1NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVu c2lvbkFjdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0Nv bnRlbnRFeHRlbnNpb25BY3Rpb25zLmNwcApAQCAtMzU5LDcgKzM1OSw3IEBAIGF1dG8gUmVkaXJl Y3RBY3Rpb246OlVSTFRyYW5zZm9ybUFjdGlvbjo6cGFyc2UoY29uc3QgSlNPTjo6T2JqZWN0JiB0 cmFuc2Zvcm0sIGNvCiAgICAgICAgIGFjdGlvbi5xdWVyeVRyYW5zZm9ybSA9ICpwYXJzZWRRdWVy eVRyYW5zZm9ybTsKICAgICB9IGVsc2UKICAgICAgICAgYWN0aW9uLnF1ZXJ5VHJhbnNmb3JtID0g dHJhbnNmb3JtLmdldFN0cmluZygicXVlcnkiKTsKLSAgICByZXR1cm4gV1RGTW92ZShhY3Rpb24p OworICAgIHJldHVybiBhY3Rpb247CiB9CiAKIGF1dG8gUmVkaXJlY3RBY3Rpb246OlVSTFRyYW5z Zm9ybUFjdGlvbjo6aXNvbGF0ZWRDb3B5KCkgY29uc3QgLT4gVVJMVHJhbnNmb3JtQWN0aW9uCkBA IC01NTIsNyArNTUyLDcgQEAgYXV0byBSZWRpcmVjdEFjdGlvbjo6VVJMVHJhbnNmb3JtQWN0aW9u OjpRdWVyeVRyYW5zZm9ybTo6cGFyc2UoY29uc3QgSlNPTjo6T2JqZWMKICAgICAgICAgcGFyc2Vk UXVlcnlUcmFuc2Zvcm0uYWRkT3JSZXBsYWNlUGFyYW1zID0gV1RGTW92ZShrZXlWYWx1ZXMpOwog ICAgIH0KIAotICAgIHJldHVybiBXVEZNb3ZlKHBhcnNlZFF1ZXJ5VHJhbnNmb3JtKTsKKyAgICBy ZXR1cm4gcGFyc2VkUXVlcnlUcmFuc2Zvcm07CiB9CiAKIGF1dG8gUmVkaXJlY3RBY3Rpb246OlVS TFRyYW5zZm9ybUFjdGlvbjo6UXVlcnlUcmFuc2Zvcm06Omlzb2xhdGVkQ29weSgpIGNvbnN0IC0+ IFF1ZXJ5VHJhbnNmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90cmFuc2Zvcm1zL1NjYWxlVHJhbnNmb3JtT3BlcmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvU2NhbGVUcmFuc2Zvcm1PcGVyYXRpb24u Y3BwCmluZGV4IDgwMDJlOWZhNjRhNWNmNTJjZjI0YjgyZWM1NTk5Y2Q4ZDYwMDM2YzguLjMxNjJi ODE0ZDI1ZmQ4OTI5YTU1NDg1OTg0YmNhNTg4ZGQ2MzU3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvU2NhbGVUcmFuc2Zvcm1PcGVyYXRp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMv U2NhbGVUcmFuc2Zvcm1PcGVyYXRpb24uY3BwCkBAIC00Nyw2ICs0Nyw3IEBAIHN0YXRpYyBkb3Vi bGUgYmxlbmRTY2FsZUNvbXBvbmVudChkb3VibGUgZnJvbSwgZG91YmxlIHRvLCBjb25zdCBCbGVu ZGluZ0NvbnRleHQmCiAgICAgICAgIEFTU0VSVChjb250ZXh0LnByb2dyZXNzID09IDEuMCk7CiAg ICAgICAgIHJldHVybiBmcm9tICsgdG8gLSAxOwogICAgIH0KKyAgICBSRUxFQVNFX0FTU0VSVF9O T1RfUkVBQ0hFRCgpOwogfQogCiBSZWY8VHJhbnNmb3JtT3BlcmF0aW9uPiBTY2FsZVRyYW5zZm9y bU9wZXJhdGlvbjo6YmxlbmQoY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9uKiBmcm9tLCBjb25zdCBC bGVuZGluZ0NvbnRleHQmIGNvbnRleHQsIGJvb2wgYmxlbmRUb0lkZW50aXR5KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvQ2FzY2FkZUxldmVsLmggYi9Tb3VyY2UvV2ViQ29yZS9z dHlsZS9DYXNjYWRlTGV2ZWwuaAppbmRleCBjMmQyYTFiMTgyMGMwNWY1N2Q1ZGFlOGZjMzM5ZjM1 NDBlZDJiMmIyLi5lYTEwN2Q0NjNlM2EwYjNiOGRmMjVkNWIyNDExZTk3OTA1YzNiMmQ5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9DYXNjYWRlTGV2ZWwuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9zdHlsZS9DYXNjYWRlTGV2ZWwuaApAQCAtNDcsNiArNDcsNyBAQCBpbmxpbmUgQ2Fz Y2FkZUxldmVsJiBvcGVyYXRvci0tKENhc2NhZGVMZXZlbCYgbGV2ZWwpCiAgICAgICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICByZXR1cm4gbGV2ZWw7CiAgICAgfQorICAgIFJFTEVB U0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCmluZGV4IDk4ODFhZjY5MjcwZTJiMTQyZTVmOGJkZTRlYTFkMDQwZTIw ZWI5ZjQuLjkzMGZhNTdkM2NhNWFmMjQ4YjUyYzQxYzlhNjZmYmE0NWMwMDFkZTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNTI1NCw2ICs1MjU0LDcgQEAg dm9pZCBXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb25Bc3luY1No YXJlZChSZWY8V2ViUHJvY2Vzc1Byb3gKICAgICAgICAgb3JpZ2luYWxSZXF1ZXN0LCBXVEZNb3Zl KHJlcXVlc3QpLCBXVEZNb3ZlKHJlcXVlc3RCb2R5KSwgV1RGTW92ZShyZWRpcmVjdFJlc3BvbnNl KSwgdXNlckRhdGEsIFdURk1vdmUoc2VuZGVyKSk7CiB9CiAKKyNpZiBQTEFURk9STShDT0NPQSkK IC8vIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvI2hhbmQtb2ZmLXRvLWV4dGVybmFsLXNv ZnR3YXJlCiBzdGF0aWMgYm9vbCBmcmFtZVNhbmRib3hBbGxvd3NPcGVuaW5nRXh0ZXJuYWxDdXN0 b21Qcm90b2NvbHMoU2FuZGJveEZsYWdzIHNhbmRib3hGbGFncywgYm9vbCBoYXNVc2VyR2VzdHVy ZSkKIHsKQEAgLTUyNjIsNiArNTI2Myw3IEBAIHN0YXRpYyBib29sIGZyYW1lU2FuZGJveEFsbG93 c09wZW5pbmdFeHRlcm5hbEN1c3RvbVByb3RvY29scyhTYW5kYm94RmxhZ3Mgc2FuZGJvCiAKICAg ICByZXR1cm4gIShzYW5kYm94RmxhZ3MgJiBTYW5kYm94VG9wTmF2aWdhdGlvbkJ5VXNlckFjdGl2 YXRpb24pICYmIGhhc1VzZXJHZXN0dXJlOwogfQorI2VuZGlmCiAKIHZvaWQgV2ViUGFnZVByb3h5 OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFJlZjxXZWJQcm9jZXNzUHJveHk+JiYg cHJvY2VzcywgUGFnZUlkZW50aWZpZXIgd2ViUGFnZUlELCBXZWJGcmFtZVByb3h5JiBmcmFtZSwg RnJhbWVJbmZvRGF0YSYmIGZyYW1lSW5mbywgdWludDY0X3QgbmF2aWdhdGlvbklELAogICAgIE5h dmlnYXRpb25BY3Rpb25EYXRhJiYgbmF2aWdhdGlvbkFjdGlvbkRhdGEsIEZyYW1lSW5mb0RhdGEm JiBvcmlnaW5hdGluZ0ZyYW1lSW5mb0RhdGEsIHN0ZDo6b3B0aW9uYWw8V2ViUGFnZVByb3h5SWRl bnRpZmllcj4gb3JpZ2luYXRpbmdQYWdlSUQsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVz dCYgb3JpZ2luYWxSZXF1ZXN0LCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0LAo=