232986 2021-11-11 00:21:51 -0800 [RemoteInspector][Socket] Can't find the target since r277787 2021-11-11 18:28:55 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tomoki.imai tomoki.imai ap don.olmstead ews-watchlist fujii hi joepeck kkinnunen pangle webkit-bug-importer oldest_to_newest 1813939 0 tomoki.imai 2021-11-11 00:21:51 -0800 How to reproduce: - Launch MiniBrowser on the target - Launch MiniBrowser on the host (WinCairo) - Try to connect to the target by inspector://. Expected result: - The target should be listed. Actual result: - "No targets found" message is shown. This issue is same as bug 226908. r277787 changed WebURLSchemeTask::request()'s return type and caused the issue. 1813943 1 443918 tomoki.imai 2021-11-11 00:28:09 -0800 Created attachment 443918 patch Patch to fix the issue in the same way as r278748. 1814121 2 ews-feeder 2021-11-11 11:06:05 -0800 Committed r285641 (244142@main): <https://commits.webkit.org/244142@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443918. 1814125 3 webkit-bug-importer 2021-11-11 11:07:49 -0800 <rdar://problem/85307053> 1814146 4 443918 ap 2021-11-11 11:53:03 -0800 Comment on attachment 443918 patch View in context: https://bugs.webkit.org/attachment.cgi?id=443918&action=review > Source/WebKit/ChangeLog:9 > + Remote Inspector has the same issue as bug 226908. > + RemoteInspectorProtocolHandler needs the same fix as r278748. I haven't seen that patch at the time, but I don't see how either of the fixes is correct. Could you please clarify? 1814331 5 tomoki.imai 2021-11-11 18:28:55 -0800 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 443918 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443918&action=review > > > Source/WebKit/ChangeLog:9 > > + Remote Inspector has the same issue as bug 226908. > > + RemoteInspectorProtocolHandler needs the same fix as r278748. > > I haven't seen that patch at the time, but I don't see how either of the > fixes is correct. Could you please clarify? Sure, sorry for not explaining in this bugzilla. (quoted from bug 226908 comment 1) > r277787 (Bug 226001) changed the return type of > WebURLSchemeTask::request() > from const WebCore::ResourceRequest& to WebCore::ResourceRequest. > InspectorResourceURLSchemeHandler::platformStartTask shouldn't > hold the reference of temporary object. Currently, task.request() creates a temporal ResourceRequest, which is destructed immediately after "auto& requestURL = task.request().url();". ResourceRequest.url() returns the reference of ResourceRequest.m_url, so it's also destructed immediately too. Therefore requestURL becomes a invalid reference to destructed object, which should not be happened. (In this case, it's recognized as null URL.) So we changed "auto&" to "auto" to copy the temporal URL. 443918 2021-11-11 00:28:09 -0800 2021-11-11 11:06:06 -0800 patch bug-232986-1.patch text/plain 1626 tomoki.imai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzMxOTEwNzU0ZDYxLi5iOTdkYmUxMGQ5MjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMTEtMTEgIFRvbW9raSBJbWFpICA8VG9tb2tpLkltYWlAc29ueS5jb20+ CisKKyAgICAgICAgW1JlbW90ZUluc3BlY3Rvcl1bU29ja2V0XSBDYW4ndCBmaW5kIHRoZSB0YXJn ZXQgc2luY2UgcjI3Nzc4NworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjMyOTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3RlIEluc3BlY3RvciBoYXMgdGhlIHNhbWUgaXNzdWUgYXMgYnVnIDIyNjkw OC4KKyAgICAgICAgUmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyIG5lZWRzIHRoZSBzYW1l IGZpeCBhcyByMjc4NzQ4LgorCisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3Rvci9zb2NrZXQv UmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyLmNwcDogQ29weSBXZWJVUkxTY2hlbWVUYXNr LnJlcXVlc3QoKS51cmwoKSB0byBhdm9pZCBvYnRhaW5pbmcgdGhlIHRlbXBvcmFyeSBvYmplY3Qu CisKIDIwMjEtMTEtMTAgIEogUGFzY29lICA8al9wYXNjb2VAYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJBdXRobl0gVW5pZnkgX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbCBTUEkgYW5kIEF1dGhl bnRpY2F0b3JDb29yZGluYXRvcidzIENsaWVudERhdGFKc29uIGdlbmVyYXRpb24gCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Ivc29ja2V0L1JlbW90ZUluc3Bl Y3RvclByb3RvY29sSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0 b3Ivc29ja2V0L1JlbW90ZUluc3BlY3RvclByb3RvY29sSGFuZGxlci5jcHAKaW5kZXggYTBhYzky YWI5OTliLi40NmY1ZTI1NThmYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0luc3BlY3Rvci9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3Ivc29ja2V0L1JlbW90ZUluc3BlY3Rv clByb3RvY29sSGFuZGxlci5jcHAKQEAgLTE2Miw3ICsxNjIsNyBAQCB2b2lkIFJlbW90ZUluc3Bl Y3RvclByb3RvY29sSGFuZGxlcjo6dXBkYXRlVGFyZ2V0TGlzdCgpCiAKIHZvaWQgUmVtb3RlSW5z cGVjdG9yUHJvdG9jb2xIYW5kbGVyOjpwbGF0Zm9ybVN0YXJ0VGFzayhXZWJQYWdlUHJveHkmIHBh Z2VQcm94eSwgV2ViVVJMU2NoZW1lVGFzayYgdGFzaykKIHsKLSAgICBhdXRvJiByZXF1ZXN0VVJM ID0gdGFzay5yZXF1ZXN0KCkudXJsKCk7CisgICAgYXV0byByZXF1ZXN0VVJMID0gdGFzay5yZXF1 ZXN0KCkudXJsKCk7CiAKICAgICAvLyBEZXN0cm95IHRoZSBjbGllbnQgYmVmb3JlIGNyZWF0aW5n IGEgbmV3IGNvbm5lY3Rpb24gc28gaXQgY2FuIGNvbm5lY3QgdG8gdGhlIHNhbWUgcG9ydAogICAg IG1faW5zcGVjdG9yQ2xpZW50ID0gbnVsbHB0cjsK