232970 2021-11-10 16:15:17 -0800 We should not kill all WebContent processes whenever the WebAuthn process crashes 2021-11-11 10:45:34 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233001 InRadar P2 Normal --- 1 cdumez cdumez achristensen bfulgham ews-watchlist ggaren jiewen_tan kkinnunen webkit-bug-importer youennf oldest_to_newest 1813834 0 cdumez 2021-11-10 16:15:17 -0800 We should not kill all WebContent processes whenever the WebAuthn process crashes. This is overly aggressive. We should instead do like for the network process and have the WebProcess re-initiate the connection to the WebAuthn process when it's gone. 1813835 1 cdumez 2021-11-10 16:15:40 -0800 <rdar://83941760> 1813836 2 443876 cdumez 2021-11-10 16:19:20 -0800 Created attachment 443876 Patch 1813837 3 443876 ggaren 2021-11-10 16:24:05 -0800 Comment on attachment 443876 Patch r=me 1813838 4 ggaren 2021-11-10 16:24:40 -0800 Does this API test (or another) demonstrate that use of WebAuthn does succeed after restarting the WebAuthn process? 1813841 5 cdumez 2021-11-10 16:28:59 -0800 (In reply to Geoffrey Garen from comment #4) > Does this API test (or another) demonstrate that use of WebAuthn does > succeed after restarting the WebAuthn process? Hmm, this particular test only calls `internals.setMockWebAuthenticationConfiguration({ })` which causes the WebAuthn process to get re-launched but it indeed doesn't attempt to use WebAuthn afterwards. This seems to be the only test that involves killing the WebAuthn process... I know very little about WebAuthn :o) but I'll look into extending the test to actually use WebAuthn after the crash. 1813867 6 443887 cdumez 2021-11-10 17:50:10 -0800 Created attachment 443887 Patch 1813902 7 ews-feeder 2021-11-10 21:03:22 -0800 Committed r285619 (244120@main): <https://commits.webkit.org/244120@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443887. 443876 2021-11-10 16:19:20 -0800 2021-11-10 17:50:08 -0800 Patch bug-232970-20211110161919.patch text/plain 5052 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2MGI1ODUzZjBmMjE2YzRl NThkM2VjOGVhYWViOGYxYzM1OTM3NWUuLjhiN2RiMDgyOTJmZWVlOThmN2I2NDc1NTdjN2M5NGVl NGU3NTY2ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjEtMTEtMTAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZSBzaG91bGQgbm90IGtpbGwgYWxs IFdlYkNvbnRlbnQgcHJvY2Vzc2VzIHdoZW5ldmVyIHRoZSBXZWJBdXRobiBwcm9jZXNzIGNyYXNo ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjk3 MAorICAgICAgICA8cmRhcjovLzgzOTQxNzYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3Qga2lsbCBhbGwgV2ViQ29udGVudCBw cm9jZXNzZXMgd2hlbmV2ZXIgdGhlIFdlYkF1dGhuIHByb2Nlc3MgY3Jhc2hlcy4gVGhpcyBpcyBv dmVybHkgYWdncmVzc2l2ZS4gV2Ugc2hvdWxkCisgICAgICAgIGluc3RlYWQgZG8gbGlrZSBmb3Ig dGhlIG5ldHdvcmsgcHJvY2VzcyBhbmQgaGF2ZSB0aGUgV2ViUHJvY2VzcyByZS1pbml0aWF0ZSB0 aGUgY29ubmVjdGlvbiB0byB0aGUgV2ViQXV0aG4gcHJvY2VzcyB3aGVuCisgICAgICAgIGl0J3Mg Z29uZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVwZGF0ZWQgZXhpc3RpbmcgQVBJIHRlc3Qu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNz UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJBdXRoblByb2Nlc3NQcm94eTo6d2ViQXV0 aG5Qcm9jZXNzQ3Jhc2hlZCk6CisgICAgICAgIERvIG5vdCB0ZXJtaW5hdGUgYWxsIFdlYlByb2Nl c3NlcyB3aGVuIHRoZSBXZWJBdXRobiBwcm9jZXNzIGNyYXNoZXMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1dlYkF1dGhuUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uOjpkaWRDbG9zZSk6Cisg ICAgICAgIE1ha2Ugc3VyZSB3ZSBjYWxsIFdlYlByb2Nlc3M6OndlYkF1dGhuUHJvY2Vzc0Nvbm5l Y3Rpb25DbG9zZWQoKSB3aGVuIHRoZSBXZWJQcm9jZXNzCisgICAgICAgIGxvc2VzIGl0cyBjb25u ZWN0aW9uIHRvIHRoZSBXZWJBdXRobiBwcm9jZXNzLiBUaGlzIG1ha2VzIHN1cmUgd2UgY2xlYXIg bV93ZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uCisgICAgICAgIGFuZCBwcm9wZXJseSByZS1pbml0 aWF0ZSBhIG5ldyBXZWJBdXRobiBwcm9jZXNzIGNvbm5lY3Rpb24gdGhlIG5leHQgdGltZSBXZWJQ cm9jZXNzOjplbnN1cmVXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uKCkKKyAgICAgICAgaXMgY2Fs bGVkLgorCiAyMDIxLTExLTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgVHVybiBvZmYgdmFyaW91cyBwcmVmZXJlbmNlcyB3aGVuIGluIGNhcHRpdmUgcG9ydGFs IG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0 aW9uL1dlYkF1dGhuUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YkF1dGhlbnRpY2F0aW9uL1dlYkF1dGhuUHJvY2Vzc1Byb3h5LmNwcAppbmRleCBlZGM3NGM4MTQ3 MTc4ZTBlYzgyNTg4YTRjYjU5NzE0M2ZiYjAwNDRlLi42OWRhNGI1YjBiZmIzMGRkZTRlMWQ3OGQ2 ODk4NzFkNjQyNDUxZDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9XZWJBdXRoblByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNzUHJveHkuY3BwCkBA IC0xMjcsOCArMTI3LDYgQEAgdm9pZCBXZWJBdXRoblByb2Nlc3NQcm94eTo6Z2V0V2ViQXV0aG5Q cm9jZXNzQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkmIHdlYlByb2MKIAogdm9pZCBXZWJBdXRo blByb2Nlc3NQcm94eTo6d2ViQXV0aG5Qcm9jZXNzQ3Jhc2hlZCgpCiB7Ci0gICAgZm9yIChhdXRv JiBwcm9jZXNzUG9vbCA6IFdlYlByb2Nlc3NQb29sOjphbGxQcm9jZXNzUG9vbHMoKSkKLSAgICAg ICAgcHJvY2Vzc1Bvb2wtPnRlcm1pbmF0ZUFsbFdlYkNvbnRlbnRQcm9jZXNzZXMoKTsKICAgICBz aGFyZWRQcm9jZXNzKCkgPSBudWxscHRyOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNzQ29ubmVjdGlvbi5j cHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Q cm9jZXNzQ29ubmVjdGlvbi5jcHAKaW5kZXggZjRjYjYwYzU0MWRlM2UyM2Y4MzJmYzFhZTkxZWVh NmY1ZmRjZDM5Ni4uNWQxM2Y3M2JiN2Y4OTM5MmYzNzc3NjgzNDMwNzlhM2FhNzVkMTNjOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1dlYkF1 dGhuUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJBdXRoZW50aWNhdGlvbi9XZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uLmNwcApAQCAtNDgsNiAr NDgsNyBAQCBXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uOjp+V2ViQXV0aG5Qcm9jZXNzQ29ubmVj dGlvbigpCiAKIHZvaWQgV2ViQXV0aG5Qcm9jZXNzQ29ubmVjdGlvbjo6ZGlkQ2xvc2UoSVBDOjpD b25uZWN0aW9uJikKIHsKKyAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS53ZWJBdXRoblByb2Nl c3NDb25uZWN0aW9uQ2xvc2VkKHRoaXMpOwogfQogCiB2b2lkIFdlYkF1dGhuUHJvY2Vzc0Nvbm5l Y3Rpb246OmRpZFJlY2VpdmVJbnZhbGlkTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24mLCBJUEM6Ok1l c3NhZ2VOYW1lKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IGY4YmUxNjI1NzkzM2IzMmFlZWQyYzA3Y2ZlMDQ0OTAwY2VlNmM1NGIuLmE1OTE1OGUz MmZlNTJmNTAwM2RjOTg2OThiYzQ5ZjA3OGUxZDljYTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0xMS0xMCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFdlIHNob3VsZCBub3Qg a2lsbCBhbGwgV2ViQ29udGVudCBwcm9jZXNzZXMgd2hlbmV2ZXIgdGhlIFdlYkF1dGhuIHByb2Nl c3MgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyOTcwCisgICAgICAgIDxyZGFyOi8vODM5NDE3NjA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIEFQSSB0ZXN0IGNvdmVyYWdlIHRv IHJlZmxlY3QgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tOgorICAgICAgICAoVGVz dFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMjEtMTEtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9mZiB2YXJpb3VzIHByZWZlcmVuY2VzIHdoZW4gaW4g Y2FwdGl2ZSBwb3J0YWwgbW9kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tCmlu ZGV4IGFlZmUwMTU4MzlhYzNkMDRiMTQyZDU2ZTJjNmFlYTBhY2IwZGY0MjIuLmYzYzgwM2I4YjVl Nzg2NTVhODViMDRkZmRjMThlNmFhYmYyOWQzMWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbC5tbQorKysg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL19XS1dlYkF1dGhlbnRpY2F0 aW9uUGFuZWwubW0KQEAgLTIxNjAsNyArMjE2MCw3IEBAIFRFU1QoV2ViQXV0aGVudGljYXRpb25Q YW5lbCwgUmVjb3ZlckFmdGVyQXV0aE5Qcm9jZXNzQ3Jhc2gpCiAgICAgRVhQRUNUX05FKGZpcnN0 V2ViQXV0aG5QSUQsIDApOwogCiAgICAga2lsbChmaXJzdFdlYkF1dGhuUElELCBTSUdLSUxMKTsK LSAgICB3aGlsZSAoW1dLUHJvY2Vzc1Bvb2wgX3dlYkF1dGhuUHJvY2Vzc0lkZW50aWZpZXJdIHx8 IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl0pCisgICAgd2hpbGUgKFtXS1Byb2Nlc3NQ b29sIF93ZWJBdXRoblByb2Nlc3NJZGVudGlmaWVyXSkKICAgICAgICAgVXRpbDo6c3BpblJ1bkxv b3AoKTsKICAgICBbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaW50ZXJu YWxzLnNldE1vY2tXZWJBdXRoZW50aWNhdGlvbkNvbmZpZ3VyYXRpb24oeyB9KSJdOwogICAgIGF1 dG8gc2Vjb25kV2ViUElEID0gW3dlYlZpZXcgX3dlYlByb2Nlc3NJZGVudGlmaWVyXTsKQEAgLTIx NjgsNyArMjE2OCw3IEBAIFRFU1QoV2ViQXV0aGVudGljYXRpb25QYW5lbCwgUmVjb3ZlckFmdGVy QXV0aE5Qcm9jZXNzQ3Jhc2gpCiAgICAgRVhQRUNUX05FKHNlY29uZFdlYkF1dGhuUElELCAwKTsK ICAgICBFWFBFQ1RfTkUoc2Vjb25kV2ViQXV0aG5QSUQsIGZpcnN0V2ViQXV0aG5QSUQpOwogICAg IEVYUEVDVF9ORShzZWNvbmRXZWJQSUQsIDApOwotICAgIEVYUEVDVF9ORShzZWNvbmRXZWJQSUQs IGZpcnN0V2ViUElEKTsKKyAgICBFWFBFQ1RfRVEoc2Vjb25kV2ViUElELCBmaXJzdFdlYlBJRCk7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK 443887 2021-11-10 17:50:10 -0800 2021-11-10 21:11:32 -0800 Patch bug-232970-20211110175009.patch text/plain 7617 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2MGI1ODUzZjBmMjE2YzRl NThkM2VjOGVhYWViOGYxYzM1OTM3NWUuLmMxOWRlM2M5ODgxZmVlYzkxZDUxNTgxOTJhYThmMDg3 OGY3Mzg5ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjEtMTEtMTAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZSBzaG91bGQgbm90IGtpbGwgYWxs IFdlYkNvbnRlbnQgcHJvY2Vzc2VzIHdoZW5ldmVyIHRoZSBXZWJBdXRobiBwcm9jZXNzIGNyYXNo ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjk3 MAorICAgICAgICA8cmRhcjovLzgzOTQxNzYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IEdlb2Zm IEdhcmVuLgorCisgICAgICAgIFdlIHNob3VsZCBub3Qga2lsbCBhbGwgV2ViQ29udGVudCBwcm9j ZXNzZXMgd2hlbmV2ZXIgdGhlIFdlYkF1dGhuIHByb2Nlc3MgY3Jhc2hlcy4gVGhpcyBpcyBvdmVy bHkgYWdncmVzc2l2ZS4gV2Ugc2hvdWxkCisgICAgICAgIGluc3RlYWQgZG8gbGlrZSBmb3IgdGhl IG5ldHdvcmsgcHJvY2VzcyBhbmQgaGF2ZSB0aGUgV2ViUHJvY2VzcyByZS1pbml0aWF0ZSB0aGUg Y29ubmVjdGlvbiB0byB0aGUgV2ViQXV0aG4gcHJvY2VzcyB3aGVuCisgICAgICAgIGl0J3MgZ29u ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVwZGF0ZWQgZXhpc3RpbmcgQVBJIHRlc3QuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNzUHJv eHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJBdXRoblByb2Nlc3NQcm94eTo6d2ViQXV0aG5Q cm9jZXNzQ3Jhc2hlZCk6CisgICAgICAgIERvIG5vdCB0ZXJtaW5hdGUgYWxsIFdlYlByb2Nlc3Nl cyB3aGVuIHRoZSBXZWJBdXRobiBwcm9jZXNzIGNyYXNoZXMuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1dlYkF1dGhuUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uOjpkaWRDbG9zZSk6CisgICAg ICAgIE1ha2Ugc3VyZSB3ZSBjYWxsIFdlYlByb2Nlc3M6OndlYkF1dGhuUHJvY2Vzc0Nvbm5lY3Rp b25DbG9zZWQoKSB3aGVuIHRoZSBXZWJQcm9jZXNzCisgICAgICAgIGxvc2VzIGl0cyBjb25uZWN0 aW9uIHRvIHRoZSBXZWJBdXRobiBwcm9jZXNzLiBUaGlzIG1ha2VzIHN1cmUgd2UgY2xlYXIgbV93 ZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uCisgICAgICAgIGFuZCBwcm9wZXJseSByZS1pbml0aWF0 ZSBhIG5ldyBXZWJBdXRobiBwcm9jZXNzIGNvbm5lY3Rpb24gdGhlIG5leHQgdGltZSBXZWJQcm9j ZXNzOjplbnN1cmVXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uKCkKKyAgICAgICAgaXMgY2FsbGVk LgorCiAyMDIxLTExLTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgVHVybiBvZmYgdmFyaW91cyBwcmVmZXJlbmNlcyB3aGVuIGluIGNhcHRpdmUgcG9ydGFsIG1v ZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9u L1dlYkF1dGhuUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1 dGhlbnRpY2F0aW9uL1dlYkF1dGhuUHJvY2Vzc1Byb3h5LmNwcAppbmRleCBlZGM3NGM4MTQ3MTc4 ZTBlYzgyNTg4YTRjYjU5NzE0M2ZiYjAwNDRlLi42OWRhNGI1YjBiZmIzMGRkZTRlMWQ3OGQ2ODk4 NzFkNjQyNDUxZDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRo ZW50aWNhdGlvbi9XZWJBdXRoblByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNzUHJveHkuY3BwCkBAIC0x MjcsOCArMTI3LDYgQEAgdm9pZCBXZWJBdXRoblByb2Nlc3NQcm94eTo6Z2V0V2ViQXV0aG5Qcm9j ZXNzQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkmIHdlYlByb2MKIAogdm9pZCBXZWJBdXRoblBy b2Nlc3NQcm94eTo6d2ViQXV0aG5Qcm9jZXNzQ3Jhc2hlZCgpCiB7Ci0gICAgZm9yIChhdXRvJiBw cm9jZXNzUG9vbCA6IFdlYlByb2Nlc3NQb29sOjphbGxQcm9jZXNzUG9vbHMoKSkKLSAgICAgICAg cHJvY2Vzc1Bvb2wtPnRlcm1pbmF0ZUFsbFdlYkNvbnRlbnRQcm9jZXNzZXMoKTsKICAgICBzaGFy ZWRQcm9jZXNzKCkgPSBudWxscHRyOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9jZXNzQ29ubmVjdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vV2ViQXV0aG5Qcm9j ZXNzQ29ubmVjdGlvbi5jcHAKaW5kZXggZjRjYjYwYzU0MWRlM2UyM2Y4MzJmYzFhZTkxZWVhNmY1 ZmRjZDM5Ni4uNWQxM2Y3M2JiN2Y4OTM5MmYzNzc3NjgzNDMwNzlhM2FhNzVkMTNjOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL1dlYkF1dGhu UHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9XZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uLmNwcApAQCAtNDgsNiArNDgs NyBAQCBXZWJBdXRoblByb2Nlc3NDb25uZWN0aW9uOjp+V2ViQXV0aG5Qcm9jZXNzQ29ubmVjdGlv bigpCiAKIHZvaWQgV2ViQXV0aG5Qcm9jZXNzQ29ubmVjdGlvbjo6ZGlkQ2xvc2UoSVBDOjpDb25u ZWN0aW9uJikKIHsKKyAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS53ZWJBdXRoblByb2Nlc3ND b25uZWN0aW9uQ2xvc2VkKHRoaXMpOwogfQogCiB2b2lkIFdlYkF1dGhuUHJvY2Vzc0Nvbm5lY3Rp b246OmRpZFJlY2VpdmVJbnZhbGlkTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24mLCBJUEM6Ok1lc3Nh Z2VOYW1lKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGY4YmUxNjI1NzkzM2IzMmFlZWQyYzA3Y2ZlMDQ0OTAwY2VlNmM1NGIuLmY2NTQxOGE0MjNj YTY5M2JhYWI4ZGI4NTA1ZWVkMGZiNjg5NTk0NTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0xMS0xMCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFdlIHNob3VsZCBub3Qga2ls bCBhbGwgV2ViQ29udGVudCBwcm9jZXNzZXMgd2hlbmV2ZXIgdGhlIFdlYkF1dGhuIHByb2Nlc3Mg Y3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMyOTcwCisgICAgICAgIDxyZGFyOi8vODM5NDE3NjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg R2VvZmYgR2FyZW4uCisKKyAgICAgICAgVXBkYXRlIEFQSSB0ZXN0IGNvdmVyYWdlIHRvIHJlZmxl Y3QgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6VEVTVCk6CisKIDIwMjEtMTEtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBUdXJuIG9mZiB2YXJpb3VzIHByZWZlcmVuY2VzIHdoZW4gaW4gY2FwdGl2 ZSBwb3J0YWwgbW9kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9fV0tXZWJBdXRoZW50aWNhdGlvblBhbmVsLm1tCmluZGV4IGFl ZmUwMTU4MzlhYzNkMDRiMTQyZDU2ZTJjNmFlYTBhY2IwZGY0MjIuLmUxMzEyMGZmZmRjMjY4YmY1 YmMwZTMwMjcwMWVkZDI5YzY4ZmQ3NjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvX1dLV2ViQXV0aGVudGljYXRpb25QYW5lbC5tbQorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL19XS1dlYkF1dGhlbnRpY2F0aW9uUGFu ZWwubW0KQEAgLTIxNDcsMTIgKzIxNDcsMjAgQEAgVEVTVChXZWJBdXRoZW50aWNhdGlvblBhbmVs LCBEZWxldGVPbmVDcmVkZW50aWFsKQogCiBURVNUKFdlYkF1dGhlbnRpY2F0aW9uUGFuZWwsIFJl Y292ZXJBZnRlckF1dGhOUHJvY2Vzc0NyYXNoKQogeworICAgIFRlc3RXZWJLaXRBUEk6OkhUVFBT ZXJ2ZXIgc2VydmVyKHsKKyAgICAgICAgeyAiLyIsIHsgIkZPTyJfc3RyIH0gfQorICAgIH0pOwor CiAgICAgYXV0byAqY29uZmlndXJhdGlvbiA9IFtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF90ZXN0 X2NvbmZpZ3VyYXRpb25XaXRoVGVzdFBsdWdJbkNsYXNzTmFtZTpAIldlYlByb2Nlc3NQbHVnSW5X aXRoSW50ZXJuYWxzIiBjb25maWd1cmVKU0NGb3JUZXN0aW5nOllFU107CiAgICAgW1tjb25maWd1 cmF0aW9uIHByZWZlcmVuY2VzXSBfc2V0RW5hYmxlZDpZRVMgZm9yRXhwZXJpbWVudGFsRmVhdHVy ZTp3ZWJBdXRoZW50aWNhdGlvbkV4cGVyaW1lbnRhbEZlYXR1cmUoKV07CiAgICAgW1tjb25maWd1 cmF0aW9uIHByZWZlcmVuY2VzXSBfc2V0RW5hYmxlZDpZRVMgZm9yRXhwZXJpbWVudGFsRmVhdHVy ZTp3ZWJBdXRoZW50aWNhdGlvbk1vZGVybkV4cGVyaW1lbnRhbEZlYXR1cmUoKV07CiAKICAgICBh dXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpOU1plcm9SZWN0IGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbl0pOwogICAgIEVYUEVDVF9F UShbV0tQcm9jZXNzUG9vbCBfd2ViQXV0aG5Qcm9jZXNzSWRlbnRpZmllcl0sIDApOworCisgICAg W3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdp dGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6W05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJo dHRwOi8vbG9jYWxob3N0OiVkLyIsIHNlcnZlci5wb3J0KCldXV1dOworICAgIFt3ZWJWaWV3IGZv Y3VzXTsKKwogICAgIFt3ZWJWaWV3IG9iamVjdEJ5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJpbnRl cm5hbHMuc2V0TW9ja1dlYkF1dGhlbnRpY2F0aW9uQ29uZmlndXJhdGlvbih7IH0pIl07CiAgICAg YXV0byBmaXJzdFdlYlBJRCA9IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl07CiAgICAg YXV0byBmaXJzdFdlYkF1dGhuUElEID0gW1dLUHJvY2Vzc1Bvb2wgX3dlYkF1dGhuUHJvY2Vzc0lk ZW50aWZpZXJdOwpAQCAtMjE2MCwxNSArMjE2OCwzMiBAQCBURVNUKFdlYkF1dGhlbnRpY2F0aW9u UGFuZWwsIFJlY292ZXJBZnRlckF1dGhOUHJvY2Vzc0NyYXNoKQogICAgIEVYUEVDVF9ORShmaXJz dFdlYkF1dGhuUElELCAwKTsKIAogICAgIGtpbGwoZmlyc3RXZWJBdXRoblBJRCwgU0lHS0lMTCk7 Ci0gICAgd2hpbGUgKFtXS1Byb2Nlc3NQb29sIF93ZWJBdXRoblByb2Nlc3NJZGVudGlmaWVyXSB8 fCBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJdKQorICAgIHdoaWxlIChbV0tQcm9jZXNz UG9vbCBfd2ViQXV0aG5Qcm9jZXNzSWRlbnRpZmllcl0pCiAgICAgICAgIFV0aWw6OnNwaW5SdW5M b29wKCk7Ci0gICAgW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImludGVy bmFscy5zZXRNb2NrV2ViQXV0aGVudGljYXRpb25Db25maWd1cmF0aW9uKHsgfSkiXTsKLSAgICBh dXRvIHNlY29uZFdlYlBJRCA9IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl07CisKKyAg ICBbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaW50ZXJuYWxzLnNldE1v Y2tXZWJBdXRoZW50aWNhdGlvbkNvbmZpZ3VyYXRpb24oeyBoaWQ6IHsgc3RhZ2U6ICdyZXF1ZXN0 Jywgc3ViU3RhZ2U6ICdtc2cnLCBlcnJvcjogJ3N1Y2Nlc3MnLCBpc1UyZjogdHJ1ZSwgcGF5bG9h ZEJhc2U2NDogWydBUUFBQURzd1JBSWdlOTRLVXF3ZlRJc240QU9qY00xbXBNY1JqZEl0VkVlRFgw VzVuR2hDUC9jQ0lEeFJlMGVIZjRWNExlRUFocWVEMGVmZlRqWTU1M0gxOXEraldxMVRjNFdPa0FB PSddIH0gfSk7Il07CisKKyAgICB3aGlsZSAoIVtXS1Byb2Nlc3NQb29sIF93ZWJBdXRoblByb2Nl c3NJZGVudGlmaWVyXSkKKyAgICAgICAgVXRpbDo6c3BpblJ1bkxvb3AoKTsKKwogICAgIGF1dG8g c2Vjb25kV2ViQXV0aG5QSUQgPSBbV0tQcm9jZXNzUG9vbCBfd2ViQXV0aG5Qcm9jZXNzSWRlbnRp Zmllcl07Ci0gICAgRVhQRUNUX05FKHNlY29uZFdlYkF1dGhuUElELCAwKTsKICAgICBFWFBFQ1Rf TkUoc2Vjb25kV2ViQXV0aG5QSUQsIGZpcnN0V2ViQXV0aG5QSUQpOwotICAgIEVYUEVDVF9ORShz ZWNvbmRXZWJQSUQsIDApOwotICAgIEVYUEVDVF9ORShzZWNvbmRXZWJQSUQsIGZpcnN0V2ViUElE KTsKKyAgICBFWFBFQ1RfRVEoW3dlYlZpZXcgX3dlYlByb2Nlc3NJZGVudGlmaWVyXSwgZmlyc3RX ZWJQSUQpOworCisgICAgX19ibG9jayBib29sIGdvdE1lc3NhZ2UgPSBmYWxzZTsKKyAgICBbd2Vi VmlldyBwZXJmb3JtQWZ0ZXJSZWNlaXZpbmdBbnlNZXNzYWdlOl4oTlNTdHJpbmcgKm1lc3NhZ2Up IHsKKyAgICAgICAgRVhQRUNUX1dLX1NUUkVRKEAicHVibGljLWtleSIsIG1lc3NhZ2UpOworICAg ICAgICBnb3RNZXNzYWdlID0gdHJ1ZTsKKyAgICB9XTsKKworICAgIF9fYmxvY2sgYm9vbCBleGVj dXRlZFNjcmlwdCA9IGZhbHNlOworICAgIFt3ZWJWaWV3IGV2YWx1YXRlSmF2YVNjcmlwdDpAIm5h dmlnYXRvci5jcmVkZW50aWFscy5nZXQoeyBwdWJsaWNLZXk6IHsgY2hhbGxlbmdlOiBuZXcgVWlu dDhBcnJheShbNDksIDUwLCA1MSwgNTIsIDUzLCA1NF0pLCBhbGxvd0NyZWRlbnRpYWxzOiBbeyB0 eXBlOiAncHVibGljLWtleScsIGlkOiBuZXcgVWludDhBcnJheShBcnJheS5wcm90b3R5cGUubWFw LmNhbGwoYXRvYignUHIySnYzZnNVSmRWN3B3bU5lK3FySHNybkZ6dkZ6YkRjWDJraFRUSXhyWlUx LytVWDFDMXpFNTRCVnZkT1d0azk0Mml4ZmxpQU16VUZjMEkva0lBT0EnKSwgZnVuY3Rpb24gKGMp IHsgcmV0dXJuIGMuY2hhckNvZGVBdCgwKSB9KSkgfV0sIHRpbWVvdXQ6IDEwMCB9IH0pLnRoZW4o Y3JlZGVudGlhbCA9PiB7IHdlYmtpdC5tZXNzYWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1l c3NhZ2UoY3JlZGVudGlhbC50eXBlKTsgfSwgZSA9PiB7IHdlYmtpdC5tZXNzYWdlSGFuZGxlcnMu dGVzdEhhbmRsZXIucG9zdE1lc3NhZ2UoJycgKyBlKTsgfSkgJiYgdHJ1ZSIgY29tcGxldGlvbkhh bmRsZXI6XihpZCByZXN1bHQsIE5TRXJyb3IgKmVycm9yKSB7CisgICAgICAgIEFTU0VSVF9GQUxT RShlcnJvcik7CisgICAgICAgIGV4ZWN1dGVkU2NyaXB0ID0gdHJ1ZTsKKyAgICB9XTsKKyAgICBV dGlsOjpydW4oJmV4ZWN1dGVkU2NyaXB0KTsKKworICAgIFV0aWw6OnJ1bigmZ290TWVzc2FnZSk7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK