232936 2021-11-10 03:09:35 -0800 [GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler flags. 2022-02-22 09:43:32 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex.kanavin webkit-unassigned annulen aperez bugs-noreply ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ryuan.choi saam sergio tzagallo oldest_to_newest 1813529 0 alex.kanavin 2021-11-10 03:09:35 -0800 When building introspection files, add CMAKE_C_FLAGS to the compiler flags. 1813530 1 443793 alex.kanavin 2021-11-10 03:10:40 -0800 Created attachment 443793 Patch 1841658 2 443793 mcatanzaro 2022-02-15 04:57:33 -0800 Comment on attachment 443793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443793&action=review Hi, thanks for your patch. Hm, it sure seems like the right thing to do, so I suppose we should try it. That said, this seems very familiar. Pretty sure we've discussed this before at some point, likely years ago. I wonder if this will surface some unexpected problem. Oh well, only one way to find out! r- is only because you've failed the style bot due to the "No new tests (OOPS!)." > Source/JavaScriptCore/ChangeLog:3 > + When building introspection files, add CMAKE_C_FLAGS to the compiler flags. [GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler flags. > Source/WebKit/ChangeLog:3 > + When building introspection files, add CMAKE_C_FLAGS to the compiler flags. [GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler flags. > Source/WebKit/ChangeLog:8 > + No new tests (OOPS!). You can simply remove this line in order to pass the style bot. Your change doesn't require adding new tests. > Source/JavaScriptCore/PlatformGTK.cmake:74 > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} LDFLAGS= Can you write it without a backslash as CFLAGS="-Wno-deprecated-declarations ${CMAKE_C_FLAGS}"? 1841659 3 mcatanzaro 2022-02-15 04:58:54 -0800 P.S. If you set the WebKitGTK component when reporting the bug, we'll see it faster. 1841664 4 mcatanzaro 2022-02-15 05:56:05 -0800 (In reply to Michael Catanzaro from comment #2) > Hi, thanks for your patch. Hm, it sure seems like the right thing to do, so > I suppose we should try it. That said, this seems very familiar. Pretty sure > we've discussed this before at some point, likely years ago. I wonder if > this will surface some unexpected problem. Oh well, only one way to find out! Actually it looks like gobject-introspection is supposed to handle this itself. Let me check with them. 1841677 5 mcatanzaro 2022-02-15 06:29:31 -0800 (In reply to Michael Catanzaro from comment #4) > Actually it looks like gobject-introspection is supposed to handle this > itself. Let me check with them. Sorry, I misunderstood the patch. This looks fine to me. 1841679 6 443793 aperez 2022-02-15 06:37:17 -0800 Comment on attachment 443793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443793&action=review >> Source/JavaScriptCore/PlatformGTK.cmake:74 >> + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} LDFLAGS= > > Can you write it without a backslash as CFLAGS="-Wno-deprecated-declarations ${CMAKE_C_FLAGS}"? Should work without the backslash, yup. Here it is harmless because escaping a space character in the shell results in a space character ("\ " → " ") but it would be nicer to remove it, for clarity. > Source/WebKit/PlatformGTK.cmake:677 > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} LDFLAGS= Same issue here with the backslash. > Source/WebKit/PlatformGTK.cmake:723 > + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} ...and here. 1842411 7 452217 alex.kanavin 2022-02-16 11:37:19 -0800 Created attachment 452217 Patch 1844608 8 aperez 2022-02-22 02:02:29 -0800 (In reply to Alexander Kanavin from comment #7) > Created attachment 452217 [details] > Patch I think the patch needs a rebase, could you update it and resubmit it? 1844620 9 452846 alex.kanavin 2022-02-22 02:45:46 -0800 Created attachment 452846 Patch 1844757 10 ews-feeder 2022-02-22 09:43:24 -0800 Committed r290312 (247635@main): <https://commits.webkit.org/247635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452846. 443793 2021-11-10 03:10:40 -0800 2022-02-16 11:37:11 -0800 Patch bug-232936-20211110121038.patch text/plain 3775 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MTJjYjM0NzU4NTc2NDdhOWNhNTgyMWIxYzIyZjdkNGI5NDZmMjM0Li5iMjgwZTE0OGM5MjU2NDBm ZThkNjNlMDkwNmViNmM4ZjViOTgzYjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0xMS0xMCAgQWxleGFuZGVyIEthbmF2aW4gIDxhbGV4QGxpbnV0cm9u aXguZGU+CisKKyAgICAgICAgV2hlbiBidWlsZGluZyBpbnRyb3NwZWN0aW9uIGZpbGVzLCBhZGQg Q01BS0VfQ19GTEFHUyB0byB0aGUgY29tcGlsZXIgZmxhZ3MuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnLWlyLWNvbXBpbGVyIGlzIHVzaW5nIGEgQyBj b21waWxlciBpbnRlcm5hbGx5LCBzbyBpdCBuZWVkcyB0byBzZXQKKyAgICAgICAgdGhlIHByb3Bl ciBmbGFncyBmb3IgaXQuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKwogMjAyMS0x MS0wOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODUyNDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhY2E1Y2NhMmVjMGE5 NWI1N2I3NzMwYjI2MmQzODIyYTVhYmE5ODkuLjJkOTIyNDFjMTJiOTMwMzEzOTJjNGYyY2ZjMDhm OTA1NWU1MGI5MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTEtMTAgIEFsZXhh bmRlciBLYW5hdmluICA8YWxleEBsaW51dHJvbml4LmRlPgorCisgICAgICAgIFdoZW4gYnVpbGRp bmcgaW50cm9zcGVjdGlvbiBmaWxlcywgYWRkIENNQUtFX0NfRkxBR1MgdG8gdGhlIGNvbXBpbGVy IGZsYWdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMyOTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgZy1pci1jb21waWxlciBpcyB1c2luZyBh IEMgY29tcGlsZXIgaW50ZXJuYWxseSwgc28gaXQgbmVlZHMgdG8gc2V0CisgICAgICAgIHRoZSBw cm9wZXIgZmxhZ3MgZm9yIGl0LgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisKIDIw MjEtMTEtMTAgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgUGVy Zm9ybSBGaWxlU3lzdGVtU3luY0FjY2Vzc0hhbmRsZSBvcGVyYXRpb25zIGluIHdlYiBwcm9jZXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggZWY3ODNkYjkzNjY4 ZjM5MGE3OTcyMDVmNWJlM2I5NTA0M2Y1Y2Q3MC4uMDMyYzQwZTBhOTFkMDBhZTY0ZGY5NGI2OGIw ODBmMGMxM2Q0YzM4ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3Jt R1RLLmNtYWtlCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpA QCAtNzEsNyArNzEsNyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgYWRkX2N1c3Rv bV9jb21tYW5kKAogICAgICAgICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9KYXZhU2NyaXB0 Q29yZS0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVORFMgSmF2YVNj cmlwdENvcmUKLSAgICAgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9IENGTEFHUz0t V25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIExERkxBR1M9CisgICAgICAgIENPTU1BTkQgQ0M9 JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9uc1wg JHtDTUFLRV9DX0ZMQUdTfSBMREZMQUdTPQogICAgICAgICAgICAgJHtMT0FERVJfTElCUkFSWV9Q QVRIX1ZBUn09IiR7SU5UUk9TUEVDVElPTl9BRERJVElPTkFMX0xJQlJBUllfUEFUSH0iCiAgICAg ICAgICAgICAke0lOVFJPU1BFQ1RJT05fU0NBTk5FUn0KICAgICAgICAgICAgIC0tcXVpZXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDE0MTcwNWEyMDRlMDI4YzE4YzQ0MmEwZDk0Mjk0MzFh ZTg4ODFmYWYuLmVmNjA2ZjE0NjE3YTAwYWM0MzA1YTIxZWUwYTNlM2Q5MjI5Y2U0NWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNjc0LDcgKzY3NCw3IEBAIGlmIChFTkFCTEVfSU5UUk9T UEVDVElPTikKICAgICAgICAgT1VUUFVUICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dF QktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVORFMgV2ViS2l0CiAgICAgICAg IERFUEVORFMgJHtDTUFLRV9CSU5BUllfRElSfS9KYXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19B UElfVkVSU0lPTn0uZ2lyCi0gICAgICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBD RkxBR1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucyBMREZMQUdTPQorICAgICAgICBDT01N QU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVjYXRlZC1kZWNsYXJh dGlvbnNcICR7Q01BS0VfQ19GTEFHU30gTERGTEFHUz0KICAgICAgICAgICAgICR7TE9BREVSX0xJ QlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BBVEh9 IgogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX1NDQU5ORVJ9CiAgICAgICAgICAgICAtLXF1 aWV0CkBAIC03MjAsNyArNzIwLDcgQEAgaWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogICAgICAg ICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyV2ViRXh0ZW5zaW9uLSR7V0VCS0lU R1RLX0FQSV9WRVJTSU9OfS5naXIKICAgICAgICAgREVQRU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9 L0phdmFTY3JpcHRDb3JlLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKICAgICAgICAgREVQ RU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059 LmdpcgotICAgICAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8t ZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMKKyAgICAgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09N UElMRVJ9IENGTEFHUz0tV25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zXCAke0NNQUtFX0NfRkxB R1N9CiAgICAgICAgICAgICBMREZMQUdTPSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MREZM QUdTfSIKICAgICAgICAgICAgICR7TE9BREVSX0xJQlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BF Q1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BBVEh9IgogICAgICAgICAgICAgJHtJTlRST1NQRUNU SU9OX1NDQU5ORVJ9Cg== 452217 2022-02-16 11:37:19 -0800 2022-02-22 02:45:38 -0800 Patch bug-232936-20220216203718.patch text/plain 3757 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 OWNjYjA4N2ZhNWExNDg1MDNiNjZiNDQzOTEyMDNkOTVmMzFlMWQzLi4yNmIzZTY0ZTgwYTVlOTkw NTM1MjAyYTZjMjA5ZDlmMGI5YzQ2ZDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMi0wMi0xNiAgQWxleGFuZGVyIEthbmF2aW4gIDxhbGV4QGxpbnV0cm9u aXguZGU+CisKKyAgICAgICAgV2hlbiBidWlsZGluZyBpbnRyb3NwZWN0aW9uIGZpbGVzLCBhZGQg Q01BS0VfQ19GTEFHUyB0byB0aGUgY29tcGlsZXIgZmxhZ3MuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnLWlyLWNvbXBpbGVyIGlzIHVzaW5nIGEgQyBj b21waWxlciBpbnRlcm5hbGx5LCBzbyBpdCBuZWVkcyB0byBzZXQKKyAgICAgICAgdGhlIHByb3Bl ciBmbGFncyBmb3IgaXQuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKwogMjAyMi0w Mi0xNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRGVmZXIgVGVy bWluYXRpb25zRXhjZXB0aW9ucyB3aGlsZSBpbiBvcGVyYXRpb25NYXRlcmlhbGl6ZU9iamVjdElu T1NSLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZwppbmRleCA4ZjM0MjYwZjY4YzY0Y2E5MmRkYjQzNThmNzhmNDMzNzNjMThmMjcz Li4yNTk2MWE4NzIxMDU0MjczMTIwZDliNDgzY2M0ZTNlNDJkOWRhZDExIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIyLTAyLTE2ICBBbGV4YW5kZXIgS2FuYXZpbiAgPGFsZXhAbGludXRy b25peC5kZT4KKworICAgICAgICBXaGVuIGJ1aWxkaW5nIGludHJvc3BlY3Rpb24gZmlsZXMsIGFk ZCBDTUFLRV9DX0ZMQUdTIHRvIHRoZSBjb21waWxlciBmbGFncy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjkzNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGctaXItY29tcGlsZXIgaXMgdXNpbmcgYSBD IGNvbXBpbGVyIGludGVybmFsbHksIHNvIGl0IG5lZWRzIHRvIHNldAorICAgICAgICB0aGUgcHJv cGVyIGZsYWdzIGZvciBpdC4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAyMDIy LTAyLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODkxNTAuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv UGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMzdjMzQzZGUzNGIwMTI1ZTkzOTExODE0ZmUyZmFjYmJj YzU2NDEzOS4uMWMzYzhmYjc4OGVlNmVjMmY4MGY4Y2E4N2IzNzg0ZTNjMjJkYjg0NSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNzEsNyArNzEsNyBAQCBpZiAo RU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAogICAgICAgICBP VVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9KYXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElf VkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVORFMgSmF2YVNjcmlwdENvcmUKLSAgICAgICAgQ09N TUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9IENGTEFHUz0tV25vLWRlcHJlY2F0ZWQtZGVjbGFy YXRpb25zIExERkxBR1M9CisgICAgICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBD RkxBR1M9Ii1Xbm8tZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMgJHtDTUFLRV9DX0ZMQUdTfSIgTERG TEFHUz0KICAgICAgICAgICAgICR7TE9BREVSX0xJQlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BF Q1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BBVEh9IgogICAgICAgICAgICAgJHtJTlRST1NQRUNU SU9OX1NDQU5ORVJ9CiAgICAgICAgICAgICAtLXF1aWV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQpp bmRleCA4MjZlMmRiNTIyYzJhN2IzYjg5NWU4NzM1YWViNDdiMmMzOGUyOTlmLi45NzdhMjYwY2Ez MmYwYWE2MjU2MTI3NGQzZWRjYjM3Yjc2NzM0ODMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UK QEAgLTY3NCw3ICs2NzQsNyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgICAgIE9V VFBVVCAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059 LmdpcgogICAgICAgICBERVBFTkRTIFdlYktpdAogICAgICAgICBERVBFTkRTICR7Q01BS0VfQklO QVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgotICAg ICAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVjYXRl ZC1kZWNsYXJhdGlvbnMgTERGTEFHUz0KKyAgICAgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09N UElMRVJ9IENGTEFHUz0iLVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucyAke0NNQUtFX0NfRkxB R1N9IiBMREZMQUdTPQogICAgICAgICAgICAgJHtMT0FERVJfTElCUkFSWV9QQVRIX1ZBUn09IiR7 SU5UUk9TUEVDVElPTl9BRERJVElPTkFMX0xJQlJBUllfUEFUSH0iCiAgICAgICAgICAgICAke0lO VFJPU1BFQ1RJT05fU0NBTk5FUn0KICAgICAgICAgICAgIC0tcXVpZXQKQEAgLTcyMCw3ICs3MjAs NyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgICAgIE9VVFBVVCAke0NNQUtFX0JJ TkFSWV9ESVJ9L1dlYktpdDJXZWJFeHRlbnNpb24tJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059Lmdp cgogICAgICAgICBERVBFTkRTICR7Q01BS0VfQklOQVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtX RUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgICAgICBERVBFTkRTICR7Q01BS0VfQklOQVJZ X0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCi0gICAgICAgIENPTU1B TkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0 aW9ucworICAgICAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPSItV25v LWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zICR7Q01BS0VfQ19GTEFHU30iCiAgICAgICAgICAgICBM REZMQUdTPSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MREZMQUdTfSIKICAgICAgICAgICAg ICR7TE9BREVSX0xJQlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9M SUJSQVJZX1BBVEh9IgogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX1NDQU5ORVJ9Cg== 452846 2022-02-22 02:45:46 -0800 2022-02-22 09:43:28 -0800 Patch bug-232936-20220222114545.patch text/plain 3811 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx Y2YwNTkxYzNlZGVlYzU2OTI2NmRjYzlkMDNkYTBiMzNkNmVhMjEwLi5lNTU1ZDcxZTcyOTViZjZi ZWY1NDMwYWRlODNlNzM1NWQ3YWE3N2JhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMi0wMi0yMiAgQWxleGFuZGVyIEthbmF2aW4gIDxhbGV4QGxpbnV0cm9u aXguZGU+CisKKyAgICAgICAgV2hlbiBidWlsZGluZyBpbnRyb3NwZWN0aW9uIGZpbGVzLCBhZGQg Q01BS0VfQ19GTEFHUyB0byB0aGUgY29tcGlsZXIgZmxhZ3MuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MzYKKworICAgICAgICBSZXZpZXdlZCBi eSBNaWNoYWVsIENhdGFuemFyby4KKworICAgICAgICBnLWlyLWNvbXBpbGVyIGlzIHVzaW5nIGEg QyBjb21waWxlciBpbnRlcm5hbGx5LCBzbyBpdCBuZWVkcyB0byBzZXQKKyAgICAgICAgdGhlIHBy b3BlciBmbGFncyBmb3IgaXQuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZToKKwogMjAy Mi0wMi0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtK U0NdIFNoYWRvd1JlYWxtIEpTUmVtb3RlRnVuY3Rpb24gY3JlYXRpb24gc2hvdWxkIGNvbnZlcnQg Q29weU5hbWVBbmRMZW5ndGggZXJyb3JzIHRvIFR5cGVFcnJvcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA3N2JiYjE1 Y2YxZTZmYzM3ZDQ0NjUwYTc3NWY2ZmY0MmIzNmZkMTAyLi5lMDkzMjUwMGFjZjdjZGM4ODc4Mzky YWEyOTFmNDAxNGNlMTBlZGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTIy ICBBbGV4YW5kZXIgS2FuYXZpbiAgPGFsZXhAbGludXRyb25peC5kZT4KKworICAgICAgICBXaGVu IGJ1aWxkaW5nIGludHJvc3BlY3Rpb24gZmlsZXMsIGFkZCBDTUFLRV9DX0ZMQUdTIHRvIHRoZSBj b21waWxlciBmbGFncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMjkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJvLgor CisgICAgICAgIGctaXItY29tcGlsZXIgaXMgdXNpbmcgYSBDIGNvbXBpbGVyIGludGVybmFsbHks IHNvIGl0IG5lZWRzIHRvIHNldAorICAgICAgICB0aGUgcHJvcGVyIGZsYWdzIGZvciBpdC4KKwor ICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAyMDIyLTAyLTIyICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgaGF2aW5nIHRvIGl0ZXJhdGUgdGhl IHdob2xlIGZyYW1lIHRyZWUocykgZXZlcnkgdGltZSB3ZSBuZWVkIHRvIGRpc3BhdGNoIHN0b3Jh Z2UgZXZlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsu Y21ha2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMzdj MzQzZGUzNGIwMTI1ZTkzOTExODE0ZmUyZmFjYmJjYzU2NDEzOS4uMWMzYzhmYjc4OGVlNmVjMmY4 MGY4Y2E4N2IzNzg0ZTNjMjJkYjg0NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdU Sy5jbWFrZQpAQCAtNzEsNyArNzEsNyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAg YWRkX2N1c3RvbV9jb21tYW5kKAogICAgICAgICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9K YXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVO RFMgSmF2YVNjcmlwdENvcmUKLSAgICAgICAgQ09NTUFORCBDQz0ke0NNQUtFX0NfQ09NUElMRVJ9 IENGTEFHUz0tV25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIExERkxBR1M9CisgICAgICAgIENP TU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9Ii1Xbm8tZGVwcmVjYXRlZC1kZWNs YXJhdGlvbnMgJHtDTUFLRV9DX0ZMQUdTfSIgTERGTEFHUz0KICAgICAgICAgICAgICR7TE9BREVS X0xJQlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MSUJSQVJZX1BB VEh9IgogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX1NDQU5ORVJ9CiAgICAgICAgICAgICAt LXF1aWV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291 cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAyMmIwMDMzN2E5N2U1MzY1YTdkYmQ1 N2Q0OGEyMGZjNjMxNTlhZWFmLi40OGQxODIwZGRhZjBhNzI1ZWY4YzkyY2VmNGE2MGFiOGYwZWY1 NzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTY3NSw3ICs2NzUsNyBAQCBpZiAoRU5B QkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgYWRkX2N1c3RvbV90YXJnZXQoV2ViS2l0Mi0ke1dFQktJ VEdUS19BUElfVkVSU0lPTn0tZ2lyCiAgICAgICAgIERFUEVORFMgV2ViS2l0CiAgICAgICAgIERF UEVORFMgJHtDTUFLRV9CSU5BUllfRElSfS9KYXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElf VkVSU0lPTn0uZ2lyCi0gICAgICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxB R1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9ucyBMREZMQUdTPQorICAgICAgICBDT01NQU5E IENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPSItV25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRp b25zICR7Q01BS0VfQ19GTEFHU30iIExERkxBR1M9CiAgICAgICAgICAgICAke0xPQURFUl9MSUJS QVJZX1BBVEhfVkFSfT0iJHtJTlRST1NQRUNUSU9OX0FERElUSU9OQUxfTElCUkFSWV9QQVRIfSIK ICAgICAgICAgICAgICR7SU5UUk9TUEVDVElPTl9TQ0FOTkVSfQogICAgICAgICAgICAgLS1xdWll dApAQCAtNzIxLDcgKzcyMSw3IEBAIGlmIChFTkFCTEVfSU5UUk9TUEVDVElPTikKICAgICAgICAg T1VUUFVUICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0MldlYkV4dGVuc2lvbi0ke1dFQktJVEdU S19BUElfVkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVORFMgJHtDTUFLRV9CSU5BUllfRElSfS9K YXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCiAgICAgICAgIERFUEVO RFMgV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0tZ2lyCi0gICAgICAgIENPTU1BTkQg Q0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXByZWNhdGVkLWRlY2xhcmF0aW9u cworICAgICAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPSItV25vLWRl cHJlY2F0ZWQtZGVjbGFyYXRpb25zICR7Q01BS0VfQ19GTEFHU30iCiAgICAgICAgICAgICBMREZM QUdTPSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MREZMQUdTfSIKICAgICAgICAgICAgICR7 TE9BREVSX0xJQlJBUllfUEFUSF9WQVJ9PSIke0lOVFJPU1BFQ1RJT05fQURESVRJT05BTF9MSUJS QVJZX1BBVEh9IgogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX1NDQU5ORVJ9Cg==