232935 2021-11-10 03:03:54 -0800 Fix racy parallel build of WebKit2-4.0.gir 2022-02-21 17:44:09 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 alex.kanavin webkit-unassigned annulen aperez bugs-noreply ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio webkit-bug-importer oldest_to_newest 1813526 0 alex.kanavin 2021-11-10 03:03:54 -0800 Fix racy parallel build of WebKit2-4.0.gir 1813528 1 443792 alex.kanavin 2021-11-10 03:05:14 -0800 Created attachment 443792 Patch 1815887 2 webkit-bug-importer 2021-11-17 03:04:23 -0800 <rdar://problem/85497279> 1842477 3 443792 mcatanzaro 2022-02-16 13:06:30 -0800 Comment on attachment 443792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443792&action=review Oh wow, interesting. LGTM. Maybe we'd want to use add custom_target() for all of these (including the ones in JavaScriptCore). Probably doesn't matter, but I'll defer to Don or Adrian for opinions on that. > Source/WebKit/ChangeLog:8 > + No new tests (OOPS!). You need to remove this, then your patch will pass the style bot. 1842484 4 452239 alex.kanavin 2022-02-16 13:16:41 -0800 Created attachment 452239 Patch 1842496 5 452239 mcatanzaro 2022-02-16 13:29:34 -0800 Comment on attachment 452239 Patch LGTM, will just wait a bit for any more comments. If nobody replies in the next couple days, please do ping again so we don't forget your patch. 1842501 6 alex.kanavin 2022-02-16 13:39:34 -0800 By the way Michael, there was no indication at any point - in the documentation, or in the patch submission script - that I need to set 'component' to webkitgtk to get maintainer attention. I was starting to wonder why none of my submissions are moving forward. Perhaps there should be a bug to address this? https://webkit.org/contributing-code/ Tools/Scripts/webkit-patch upload should both mention this. 1842508 7 mcatanzaro 2022-02-16 13:51:24 -0800 Indeed, this is not a good trap, and not the first time it has happened. In theory, it shouldn't be required because eventually somebody should notice the component is wrong and reassign it. In practice, we're drowning in bugs and that doesn't always happen.... 1844480 8 ews-feeder 2022-02-21 17:44:01 -0800 Committed r290279 (247603@main): <https://commits.webkit.org/247603@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452239. 443792 2021-11-10 03:05:14 -0800 2022-02-16 13:16:33 -0800 Patch bug-232935-20211110120512.patch text/plain 2863 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhY2E1Y2NhMmVjMGE5NWI1 N2I3NzMwYjI2MmQzODIyYTVhYmE5ODkuLmY3ZTFjZGJhY2RlODFlY2RjZmU2OWM4ZWRkYTQyN2Fh MzkxZTI2YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMTEtMTAgIEFsZXhhbmRl ciBLYW5hdmluICA8YWxleEBsaW51dHJvbml4LmRlPgorCisgICAgICAgIEZpeCByYWN5IHBhcmFs bGVsIGJ1aWxkIG9mIFdlYktpdDItNC4wLmdpcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyOTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBhIHRhcmdldCBhbmQgbm90IGEgY29tbWFuZCBiZWNhdXNlIGl0J3MgdXNlZCB0byBidWls ZCBhbm90aGVyIC5naXIKKyAgICAgICAgYW5kIGEgLnR5cGVsaWIsIHdoaWNoIHdvdWxkIHRyaWdn ZXIgdHdvIHJhY3kgcGFyYWxsZWwgYnVpbGRzIHdoZW4gdXNpbmcgY29tbWFuZAorICAgICAgICAo ZS5nLiBjb21tYW5kIHdvdWxkIHJ1biB0d2ljZSwgdGFyZ2V0IHJ1bnMgb25seSBvbmNlKS4KKwor ICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAyMDIxLTExLTEwICBTaWh1aSBMaXUgIDxz aWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAgIFBlcmZvcm0gRmlsZVN5c3RlbVN5bmNBY2Nl c3NIYW5kbGUgb3BlcmF0aW9ucyBpbiB3ZWIgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UK aW5kZXggMTQxNzA1YTIwNGUwMjhjMThjNDQyYTBkOTQyOTQzMWFlODg4MWZhZi4uMjVhMDVjMjNi MWZjYzc0YTJlZWYxNDQ1OWNhZjI4NTQ2M2UyNDJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtl CkBAIC02NzAsOCArNjcwLDkgQEAgaWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogICAgICAgICBz ZXQoR0lSX1NPVVJDRVNfVE9QX0RJUlMgIi0tc291cmNlcy10b3AtZGlycz0ke0NNQUtFX0JJTkFS WV9ESVJ9IikKICAgICBlbmRpZiAoKQogCi0gICAgYWRkX2N1c3RvbV9jb21tYW5kKAotICAgICAg ICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJT SU9OfS5naXIKKyAgICAjIFRoaXMgaXMgYSB0YXJnZXQgYW5kIG5vdCBhIGNvbW1hbmQgYmVjYXVz ZSBpdCdzIHVzZWQgdG8gYnVpbGQgYW5vdGhlciAuZ2lyCisgICAgIyBhbmQgYSAudHlwZWxpYiwg d2hpY2ggd291bGQgdHJpZ2dlciB0d28gcmFjeSBwYXJhbGxlbCBidWlsZHMgd2hlbiB1c2luZyBj b21tYW5kCisgICAgYWRkX2N1c3RvbV90YXJnZXQoV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVS U0lPTn0tZ2lyCiAgICAgICAgIERFUEVORFMgV2ViS2l0CiAgICAgICAgIERFUEVORFMgJHtDTUFL RV9CSU5BUllfRElSfS9KYXZhU2NyaXB0Q29yZS0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2ly CiAgICAgICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXBy ZWNhdGVkLWRlY2xhcmF0aW9ucyBMREZMQUdTPQpAQCAtNzE5LDcgKzcyMCw3IEBAIGlmIChFTkFC TEVfSU5UUk9TUEVDVElPTikKICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgICAgIE9VVFBV VCAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDJXZWJFeHRlbnNpb24tJHtXRUJLSVRHVEtfQVBJ X1ZFUlNJT059LmdpcgogICAgICAgICBERVBFTkRTICR7Q01BS0VfQklOQVJZX0RJUn0vSmF2YVNj cmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgotICAgICAgICBERVBFTkRTICR7 Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyCisg ICAgICAgIERFUEVORFMgV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0tZ2lyCiAgICAg ICAgIENPTU1BTkQgQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSBDRkxBR1M9LVduby1kZXByZWNhdGVk LWRlY2xhcmF0aW9ucwogICAgICAgICAgICAgTERGTEFHUz0iJHtJTlRST1NQRUNUSU9OX0FERElU SU9OQUxfTERGTEFHU30iCiAgICAgICAgICAgICAke0xPQURFUl9MSUJSQVJZX1BBVEhfVkFSfT0i JHtJTlRST1NQRUNUSU9OX0FERElUSU9OQUxfTElCUkFSWV9QQVRIfSIKQEAgLTc4MSw3ICs3ODIs NyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAKICAgICBhZGRfY3VzdG9tX2NvbW1hbmQo CiAgICAgICAgIE9VVFBVVCAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdDItJHtXRUJLSVRHVEtf QVBJX1ZFUlNJT059LnR5cGVsaWIKLSAgICAgICAgREVQRU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9 L1dlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgorICAgICAgICBERVBFTkRTIFdl YktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LWdpcgogICAgICAgICBDT01NQU5EICR7SU5U Uk9TUEVDVElPTl9DT01QSUxFUn0gLS1pbmNsdWRlZGlyPSR7Q01BS0VfQklOQVJZX0RJUn0gJHtD TUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIgLW8g JHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS50eXBl bGliCiAgICAgKQogCg== 452239 2022-02-16 13:16:41 -0800 2022-02-21 17:44:05 -0800 Patch bug-232935-20220216221640.patch text/plain 2861 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyMTNlZjNlMWNhNDI1NWMy NmZlNDg1MGUwNDQzNDBlMWM4YjY2OWYuLjVmYWFkMjhjNjllM2U1ZjIzZDRkNGM4MmNkMmM0Njcw N2NjZjE1M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDItMTYgIEFsZXhhbmRl ciBLYW5hdmluICA8YWxleEBsaW51dHJvbml4LmRlPgorCisgICAgICAgIEZpeCByYWN5IHBhcmFs bGVsIGJ1aWxkIG9mIFdlYktpdDItNC4wLmdpcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyOTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhIHRhcmdldCBhbmQgbm90IGEgY29tbWFuZCBi ZWNhdXNlIGl0J3MgdXNlZCB0byBidWlsZCBhbm90aGVyIC5naXIKKyAgICAgICAgYW5kIGEgLnR5 cGVsaWIsIHdoaWNoIHdvdWxkIHRyaWdnZXIgdHdvIHJhY3kgcGFyYWxsZWwgYnVpbGRzIHdoZW4g dXNpbmcgY29tbWFuZAorICAgICAgICAoZS5nLiBjb21tYW5kIHdvdWxkIHJ1biB0d2ljZSwgdGFy Z2V0IHJ1bnMgb25seSBvbmNlKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAy MDIyLTAyLTE2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtD b2NvYV0gQWRvcHQgLXN0cmVhbURhdGFQYXJzZXI6ZGlkUHJvdmlkZUNvbnRlbnRLZXlTcGVjaWZp ZXI6Zm9yVHJhY2tJRDogZGVsZWdhdGUgY2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCmlu ZGV4IDgyNmUyZGI1MjJjMmE3YjNiODk1ZTg3MzVhZWI0N2IyYzM4ZTI5OWYuLjIyYjAwMzM3YTk3 ZTUzNjVhN2RiZDU3ZDQ4YTIwZmM2MzE1OWFlYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQpA QCAtNjcwLDggKzY3MCw5IEBAIGlmIChFTkFCTEVfSU5UUk9TUEVDVElPTikKICAgICAgICAgc2V0 KEdJUl9TT1VSQ0VTX1RPUF9ESVJTICItLXNvdXJjZXMtdG9wLWRpcnM9JHtDTUFLRV9CSU5BUllf RElSfSIpCiAgICAgZW5kaWYgKCkKIAotICAgIGFkZF9jdXN0b21fY29tbWFuZCgKLSAgICAgICAg T1VUUFVUICR7Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lP Tn0uZ2lyCisgICAgIyBUaGlzIGlzIGEgdGFyZ2V0IGFuZCBub3QgYSBjb21tYW5kIGJlY2F1c2Ug aXQncyB1c2VkIHRvIGJ1aWxkIGFub3RoZXIgLmdpcgorICAgICMgYW5kIGEgLnR5cGVsaWIsIHdo aWNoIHdvdWxkIHRyaWdnZXIgdHdvIHJhY3kgcGFyYWxsZWwgYnVpbGRzIHdoZW4gdXNpbmcgY29t bWFuZAorICAgIGFkZF9jdXN0b21fdGFyZ2V0KFdlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJ T059LWdpcgogICAgICAgICBERVBFTkRTIFdlYktpdAogICAgICAgICBERVBFTkRTICR7Q01BS0Vf QklOQVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059Lmdpcgog ICAgICAgICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVj YXRlZC1kZWNsYXJhdGlvbnMgTERGTEFHUz0KQEAgLTcxOSw3ICs3MjAsNyBAQCBpZiAoRU5BQkxF X0lOVFJPU1BFQ1RJT04pCiAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAogICAgICAgICBPVVRQVVQg JHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyV2ViRXh0ZW5zaW9uLSR7V0VCS0lUR1RLX0FQSV9W RVJTSU9OfS5naXIKICAgICAgICAgREVQRU5EUyAke0NNQUtFX0JJTkFSWV9ESVJ9L0phdmFTY3Jp cHRDb3JlLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKLSAgICAgICAgREVQRU5EUyAke0NN QUtFX0JJTkFSWV9ESVJ9L1dlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgorICAg ICAgICBERVBFTkRTIFdlYktpdDItJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LWdpcgogICAgICAg ICBDT01NQU5EIENDPSR7Q01BS0VfQ19DT01QSUxFUn0gQ0ZMQUdTPS1Xbm8tZGVwcmVjYXRlZC1k ZWNsYXJhdGlvbnMKICAgICAgICAgICAgIExERkxBR1M9IiR7SU5UUk9TUEVDVElPTl9BRERJVElP TkFMX0xERkxBR1N9IgogICAgICAgICAgICAgJHtMT0FERVJfTElCUkFSWV9QQVRIX1ZBUn09IiR7 SU5UUk9TUEVDVElPTl9BRERJVElPTkFMX0xJQlJBUllfUEFUSH0iCkBAIC03ODEsNyArNzgyLDcg QEAgaWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogCiAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAog ICAgICAgICBPVVRQVVQgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQ SV9WRVJTSU9OfS50eXBlbGliCi0gICAgICAgIERFUEVORFMgJHtDTUFLRV9CSU5BUllfRElSfS9X ZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKKyAgICAgICAgREVQRU5EUyBXZWJL aXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS1naXIKICAgICAgICAgQ09NTUFORCAke0lOVFJP U1BFQ1RJT05fQ09NUElMRVJ9IC0taW5jbHVkZWRpcj0ke0NNQUtFX0JJTkFSWV9ESVJ9ICR7Q01B S0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0uZ2lyIC1vICR7 Q01BS0VfQklOQVJZX0RJUn0vV2ViS2l0Mi0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0udHlwZWxp YgogICAgICkKIAo=