232933 2021-11-10 02:46:30 -0800 FindGObjectIntrospection.cmake: prefix variables obtained from pkg-config with PKG_CONFIG_SYSROOT_DIR 2022-04-15 10:23:08 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 alex.kanavin webkit-unassigned annulen aperez bugs-noreply ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1813517 0 alex.kanavin 2021-11-10 02:46:30 -0800 FindGObjectIntrospection.cmake: prefix variables obtained from pkg-config with PKG_CONFIG_SYSROOT_DIR 1813521 1 443789 alex.kanavin 2021-11-10 02:50:54 -0800 Created attachment 443789 Patch 1841661 2 443789 mcatanzaro 2022-02-15 05:18:24 -0800 Comment on attachment 443789 Patch It took me a little while to convince myself that this was correct, but I suppose there's no way for cross-compilation to work otherwise, so OK. That said, not all pkg-config variables are paths, but you're prepending this to all of them, e.g. version numbers are now going to contain filesystem paths. Also, it's generally not appropriate to prepend this variable even to most filesystem paths: it only makes sense in this particular case because you're executing those binaries during the build itself. Now, because the macro is only used immediately below, we know that's not a problem with how it is currently used, but it is still a semantic problem that we need to solve before landing. You can fix it in either of two ways: you could rename the macro to indicate it is only supposed to be used to get paths to binaries for use during compilation (this might result in a weird name, _GIR_GET_ PKGCONFIG_VAR_BUT_ONLY_IF_ITS_A_PATH_TO_A_BINARY_THAT_WE_ARE_ABOUT_TO_EXECUTE does not sound very swell), or maybe it would be better to do the append later after calling the macro so that we can leave it as a generic macro for getting any variable. Either way would work. 1842446 3 alex.kanavin 2022-02-16 12:21:11 -0800 A change has landed that removes the code altogether, so I need to check if this patch is still relevant, and rework accordingly. 1842483 4 452238 alex.kanavin 2022-02-16 13:12:43 -0800 Created attachment 452238 Patch 1844621 5 alex.kanavin 2022-02-22 02:52:09 -0800 Ping :) 1844706 6 452238 mcatanzaro 2022-02-22 07:58:28 -0800 Comment on attachment 452238 Patch This looks fine to me, but Adrian mentioned something about not liking this. Adrian? 1857950 7 alex.kanavin 2022-04-04 11:09:19 -0700 Ping! 1858613 8 aperez 2022-04-05 15:11:38 -0700 (In reply to Michael Catanzaro from comment #6) > Comment on attachment 452238 [details] > Patch > > This looks fine to me, but Adrian mentioned something about not liking this. > Adrian? So what's suspicious about this is that when cross-compiling, the sysroot refers to the location of the *target platform* files (libraries, headers, etc.) but in the case of programs to execute during the build, we cannot (typically, at least) run them on the *build host*. Prefixing the sysroot is the wrong thing to do in the general case, what one does is passing -DCMAKE_PROGRAM_PATH= to tell if where to look for programs used during compilation and that will run in the *build host*. Now, I do know that GI is cross-compilation trouble, and at least Yocto and Buildroot use qemu's userspace emulation to run the tools; but how to treat the particularities of GI tooling is the choice of each particular build system. I would rather not have a workaround for some compilation system in the WebKit source tree—such a think should not be needed, and proof of that is Buildroot can builds WebKitGTK with introspection enabled without a patch like this: https://git.busybox.net/buildroot/tree/package/webkitgtk/webkitgtk.mk?h=2022.02.x#n68 1858615 9 aperez 2022-04-05 15:12:25 -0700 (ooops, s/think/thing/ in my previous comment) 1860588 10 alex.kanavin 2022-04-11 23:36:13 -0700 Right, this actually makes sense. I can withdraw this patch and mark it as yocto-specific in our tree to prevent further submissions. 1860606 11 aperez 2022-04-12 00:26:31 -0700 (In reply to Alexander Kanavin from comment #10) > Right, this actually makes sense. I can withdraw this patch and mark it as > yocto-specific in our tree to prevent further submissions. 👍️ Of course if you run into any other issues, please do ask and we can try to help out -- 1860607 12 aperez 2022-04-12 00:27:00 -0700 (In reply to Alexander Kanavin from comment #10) > Right, this actually makes sense. I can withdraw this patch and mark it as > yocto-specific in our tree to prevent further submissions. 👍️ Of course if you run into any other issues, please do ask and we can try to help out -- we do want people to be able to package and cross build WebKit after all :) 1860674 13 mcatanzaro 2022-04-12 08:07:31 -0700 (In reply to Alexander Kanavin from comment #10) > Right, this actually makes sense. I can withdraw this patch and mark it as > yocto-specific in our tree to prevent further submissions. And add a link to this bug too, if you don't mind, so people can find this discussion in the future. 443789 2021-11-10 02:50:54 -0800 2022-02-16 13:12:35 -0800 Patch bug-232933-20211110115052.patch text/plain 1486 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHT2JqZWN0SW50 cm9zcGVjdGlvbi5jbWFrZQppbmRleCBiYmU0NzQyNDY1YzdiZmU1YTZhYzAzN2I4NTRhODc0OGE5 NzRkNjkwLi40ZDQyMGVjNjcwZjFiNjhmY2ViM2E5N2Y2YTRjZTVkODA3Yjc3NDZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvRmluZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9GaW5kR09iamVjdEludHJvc3BlY3Rpb24uY21ha2UKQEAgLTI2LDYgKzI2LDcg QEAgbWFjcm8oX0dJUl9HRVRfUEtHQ09ORklHX1ZBUiBfb3V0dmFyIF92YXJuYW1lIF9leHRyYV9h cmdzKQogICAgIGVsc2UgKCkKICAgICAgICAgc3RyaW5nKFJFR0VYIFJFUExBQ0UgIltcclxuXSIg IiAiIF9yZXN1bHQgIiR7X3Jlc3VsdH0iKQogICAgICAgICBzdHJpbmcoUkVHRVggUkVQTEFDRSAi ICskIiAiIiAgX3Jlc3VsdCAiJHtfcmVzdWx0fSIpCisgICAgICAgIHN0cmluZyhDT05DQVQgX3Jl c3VsdCAkRU5We1BLR19DT05GSUdfU1lTUk9PVF9ESVJ9ICIke19yZXN1bHR9IikKICAgICAgICAg c2VwYXJhdGVfYXJndW1lbnRzKF9yZXN1bHQpCiAgICAgICAgIHNldCgke19vdXR2YXJ9ICR7X3Jl c3VsdH0gQ0FDSEUgSU5URVJOQUwgIiIpCiAgICAgZW5kaWYgKCkKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjYjg3NTIzYjUxY2QxYTQyYzI4NWJlODdiMDM4MWM5ZTM2 NGU4MGM1Li5hMDkyYWY0OTA2ODgzOThlMmEzN2M0ZDhjM2UyNWUwZDI0MWY2ZTVjIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTEt MTAgIEFsZXhhbmRlciBLYW5hdmluICA8YWxleEBsaW51dHJvbml4LmRlPgorCisgICAgICAgIEZp bmRHT2JqZWN0SW50cm9zcGVjdGlvbi5jbWFrZTogcHJlZml4IHZhcmlhYmxlcyBvYnRhaW5lZCBm cm9tIHBrZy1jb25maWcgd2l0aCBQS0dfQ09ORklHX1NZU1JPT1RfRElSCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhlbHBzIGJ1aWxkaW5nIGlu IHN5c3Jvb3RzLCB3aGVyZSBkaXJlY3RvcnkgdmFsdWVzIGZyb20gcGtnLWNvbmZpZyBuZWVkIHRv IGJlCisgICAgICAgIHByZWZpeGVkIHdpdGggdGhlIHN5c3Jvb3QgZGlyZWN0b3J5LgorCisgICAg ICAgICogU291cmNlL2NtYWtlL0ZpbmRHT2JqZWN0SW50cm9zcGVjdGlvbi5jbWFrZToKKwogMjAy MS0wOS0xNyAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NAaWdhbGlhLmNvbT4KIAog ICAgICAgICBVbmJyZWFrIEdDQ19PRkZMSU5FQVNNX1NPVVJDRV9NQVAgd2hlbiBMVE8gaXMgaW4g dXNlCg== 452238 2022-02-16 13:12:43 -0800 2022-04-15 10:23:08 -0700 Patch bug-232933-20220216221242.patch text/plain 1869 alex.kanavin U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHT2JqZWN0SW50 cm9zcGVjdGlvbi5jbWFrZQppbmRleCBiZTk2ODE0YTdmZjcxZDExYTUxYWEwMGNjNzc3ZWM2OTBh YTFmOWY3Li5lZThhOGZhYjMwZGIzMDk4MTkxYmE4NTVjNTJkYWNjNzcxODBhNjAyIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvRmluZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9GaW5kR09iamVjdEludHJvc3BlY3Rpb24uY21ha2UKQEAgLTMwLDYgKzMwLDkg QEAgaWYgKFBLR19DT05GSUdfRk9VTkQpCiAgICAgICAgIHBrZ19nZXRfdmFyaWFibGUoSU5UUk9T UEVDVElPTl9HRU5FUkFURSBnb2JqZWN0LWludHJvc3BlY3Rpb24tMS4wIGdfaXJfZ2VuZXJhdGUp CiAgICAgICAgIHBrZ19nZXRfdmFyaWFibGUoSU5UUk9TUEVDVElPTl9HSVJESVIgZ29iamVjdC1p bnRyb3NwZWN0aW9uLTEuMCBnaXJkaXIpCiAgICAgICAgIHBrZ19nZXRfdmFyaWFibGUoSU5UUk9T UEVDVElPTl9UWVBFTElCRElSIGdvYmplY3QtaW50cm9zcGVjdGlvbi0xLjAgdHlwZWxpYmRpcikK KyAgICAgICAgc2V0KElOVFJPU1BFQ1RJT05fU0NBTk5FUiAiJEVOVntQS0dfQ09ORklHX1NZU1JP T1RfRElSfSR7SU5UUk9TUEVDVElPTl9TQ0FOTkVSfSIpCisgICAgICAgIHNldChJTlRST1NQRUNU SU9OX0NPTVBJTEVSICIkRU5We1BLR19DT05GSUdfU1lTUk9PVF9ESVJ9JHtJTlRST1NQRUNUSU9O X0NPTVBJTEVSfSIpCisgICAgICAgIHNldChJTlRST1NQRUNUSU9OX0dFTkVSQVRFICIkRU5We1BL R19DT05GSUdfU1lTUk9PVF9ESVJ9JHtJTlRST1NQRUNUSU9OX0dFTkVSQVRFfSIpCiAgICAgICAg IHNldChJTlRST1NQRUNUSU9OX1ZFUlNJT04gIiR7X3BjX2dpcl9WRVJTSU9OfSIpCiAgICAgICAg IGlmICgke0lOVFJPU1BFQ1RJT05fVkVSU0lPTn0gVkVSU0lPTl9HUkVBVEVSX0VRVUFMICIxLjU5 LjEiKQogICAgICAgICAgICAgc2V0KElOVFJPU1BFQ1RJT05fSEFWRV9TT1VSQ0VTX1RPUF9ESVJT IFlFUykKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNWE3NmJlOGE3 YWFhMDQwYTZkYmE3YTViZGY5ZTllOWQ2YmVlZjBkLi4yNzY1YzE4NzIxMmEyOTBkOWE1ZDIyMjdi Y2VhYzUwMTk1YzkyNDVmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMjItMDItMTYgIEFsZXhhbmRlciBLYW5hdmluICA8YWxleEBsaW51 dHJvbml4LmRlPgorCisgICAgICAgIEZpbmRHT2JqZWN0SW50cm9zcGVjdGlvbi5jbWFrZTogcHJl Zml4IHZhcmlhYmxlcyBvYnRhaW5lZCBmcm9tIHBrZy1jb25maWcgd2l0aCBQS0dfQ09ORklHX1NZ U1JPT1RfRElSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzI5MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGhlbHBzIGJ1aWxkaW5nIGluIHN5c3Jvb3RzLCB3aGVyZSBkaXJlY3RvcnkgdmFsdWVz IGZyb20gcGtnLWNvbmZpZyBuZWVkIHRvIGJlCisgICAgICAgIHByZWZpeGVkIHdpdGggdGhlIHN5 c3Jvb3QgZGlyZWN0b3J5LgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRHT2JqZWN0SW50 cm9zcGVjdGlvbi5jbWFrZToKKwogMjAyMi0wMi0xNSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAg PGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gQ2hlY2tzIHVzZXMgb2YgZXhl Y3V0ZV9wcm9jZXNzKCkgZm9yIGNvcnJlY3QgY29tbWFuZCBzcGxpdHRpbmcK