232931 2021-11-10 01:43:16 -0800 [GLib] Developer build with release logs disabled fails 2021-11-12 07:45:21 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand aperez don.olmstead eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1813511 0 pnormand 2021-11-10 01:43:16 -0800 In Internals.cpp we require convertEnumerationToString(PlatformMediaSession::RemoteControlCommandType) but that is guarded by an ifdef in PlatformMediaSession. 1813512 1 443785 pnormand 2021-11-10 01:45:12 -0800 Created attachment 443785 [fast-cq] Patch 1813997 2 443785 aperez 2021-11-11 05:53:27 -0800 Comment on attachment 443785 [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443785&action=review > Source/WebCore/ChangeLog:9 > + functions, required by Internals. This looks adjacent to the issue from bug #226088 — I didn't get to the bottom of it, but there we run in a multiple definition issue due to the same method (exactly the same!) being generated from a WebIDL file. Why is this not a problem here? Is something latent here being hidden as well by unified builds, I wonder? 1814003 3 pnormand 2021-11-11 06:30:19 -0800 I don't think it's related with unified builds, if you open PlatformMediaSession.h you'll see, not guarded by ifdef: WEBCORE_EXPORT String convertEnumerationToString(PlatformMediaSession::RemoteControlCommandType); But in the cpp unit it is currently guarded by an ifdef, hence the link error happening when MEDIA_SESSION is enabled, but release logs are disabled. 1814423 4 aperez 2021-11-12 07:10:45 -0800 (In reply to Philippe Normand from comment #3) > I don't think it's related with unified builds, if you open > PlatformMediaSession.h you'll see, not guarded by ifdef: > > WEBCORE_EXPORT String > convertEnumerationToString(PlatformMediaSession::RemoteControlCommandType); > > But in the cpp unit it is currently guarded by an ifdef, hence the link > error happening when MEDIA_SESSION is enabled, but release logs are disabled. It's only related in that I am trying to solve another bug that happens to result in multiple definitions of this symbol when unified builds are disabled because my test builds I typically do with logging enabled so the function was being compiled in my case, too — but that's all. 1814428 5 ews-feeder 2021-11-12 07:44:37 -0800 Committed r285718 (244177@main): <https://commits.webkit.org/244177@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443785. 1814429 6 webkit-bug-importer 2021-11-12 07:45:21 -0800 <rdar://problem/85343300> 443785 2021-11-10 01:45:12 -0800 2021-11-12 07:44:38 -0800 [fast-cq] Patch bug-232931-20211110014511.patch text/plain 1766 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTgxOWE1YmUyYzRiODkw ODc4ODE3MzVhZmU5ODEwMTg0MTJhNTRmMC4uOWQ1MjhhYWNhZWYyNGRhMGE4NWUyZGRkMDY1MWIw OThjZTIzYTIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTExLTEwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xpYl0gRGV2 ZWxvcGVyIGJ1aWxkIHdpdGggcmVsZWFzZSBsb2dzIGRpc2FibGVkIGZhaWxzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1Bs YXRmb3JtTWVkaWFTZXNzaW9uLmNwcDogUmVtb3ZlIGlmZGVmIGFyb3VuZCBjb252ZXJ0RW51bWVy YXRpb25Ub1N0cmluZworICAgICAgICBmdW5jdGlvbnMsIHJlcXVpcmVkIGJ5IEludGVybmFscy4K KwogMjAyMS0xMS0xMCAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4K IAogICAgICAgICBXYXZ5IGRlY29yYXRpb25zIGRvbid0IGNvdmVyIHRoZSB3aG9sZSBsaW5lIGxl bmd0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1N ZWRpYVNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1N ZWRpYVNlc3Npb24uY3BwCmluZGV4IGQzNzRjODJjMjUwYzEyYTM3MjBhZjNhNTYyNGY3OGNkN2E5 YzU0YzYuLjA5NmI2MDE1Nzk5ZTQ1NTI1NDc3OWZhZjdlNjA1ZmRkOTk3MmVlOGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNzaW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0Zm9ybU1lZGlhU2Vzc2lv bi5jcHAKQEAgLTM3LDcgKzM3LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgY29u c3RleHByIFNlY29uZHMgY2xpZW50RGF0YUJ1ZmZlcmluZ1RpbWVyVGhyb3R0bGVEZWxheSB7IDEw MF9tcyB9OwogCi0jaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiBTdHJpbmcgY29udmVydEVudW1l cmF0aW9uVG9TdHJpbmcoUGxhdGZvcm1NZWRpYVNlc3Npb246OlN0YXRlIHN0YXRlKQogewogICAg IHN0YXRpYyBjb25zdCBOZXZlckRlc3Ryb3llZDxTdHJpbmc+IHZhbHVlc1tdID0gewpAQCAtMTIx LDggKzEyMCw2IEBAIFN0cmluZyBjb252ZXJ0RW51bWVyYXRpb25Ub1N0cmluZyhQbGF0Zm9ybU1l ZGlhU2Vzc2lvbjo6UmVtb3RlQ29udHJvbENvbW1hbmRUeXBlCiAgICAgcmV0dXJuIHZhbHVlc1tz dGF0aWNfY2FzdDxzaXplX3Q+KGNvbW1hbmQpXTsKIH0KIAotI2VuZGlmCi0KIHN0ZDo6dW5pcXVl X3B0cjxQbGF0Zm9ybU1lZGlhU2Vzc2lvbj4gUGxhdGZvcm1NZWRpYVNlc3Npb246OmNyZWF0ZShQ bGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXImIG1hbmFnZXIsIFBsYXRmb3JtTWVkaWFTZXNzaW9u Q2xpZW50JiBjbGllbnQpCiB7CiAgICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxQbGF0Zm9ybU1l ZGlhU2Vzc2lvbj4obmV3IFBsYXRmb3JtTWVkaWFTZXNzaW9uKG1hbmFnZXIsIGNsaWVudCkpOwo=