232927 2021-11-10 01:12:35 -0800 Hasher should be able to hash pointers 2021-11-10 05:46:30 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232930 1 koivisto koivisto benjamin cdumez cmarcelo ews-watchlist kkinnunen webkit-bug-importer oldest_to_newest 1813498 0 koivisto 2021-11-10 01:12:35 -0800 Currently the implicitly convert to bool leading bad results. 1813502 1 443782 koivisto 2021-11-10 01:25:41 -0800 Created attachment 443782 Patch 1813519 2 443782 kkinnunen 2021-11-10 02:49:11 -0800 Comment on attachment 443782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443782&action=review > Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp:200 > + EXPECT_EQ(is32Bit ? zero32BitHash : zero64BitHash, computeHash(nullPtr)); maybe use just uintptr_t, not is32Bit 1813520 3 443782 kkinnunen 2021-11-10 02:49:58 -0800 Comment on attachment 443782 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443782&action=review > Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp:202 > + EXPECT_EQ(is32Bit ? computeHash(static_cast<uint32_t>(0xffffff)) : computeHash(static_cast<uint64_t>(0xffffff)), computeHash(ffffffPtr)); maybe test computeHash(nullptr) == computeHash(nullPtr) 1813541 4 443796 koivisto 2021-11-10 03:56:31 -0800 Created attachment 443796 Patch for landing 1813553 5 ews-feeder 2021-11-10 04:49:32 -0800 Committed r285572 (244080@main): <https://commits.webkit.org/244080@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443796. 1813554 6 webkit-bug-importer 2021-11-10 04:50:22 -0800 <rdar://problem/85250129> 443782 2021-11-10 01:25:41 -0800 2021-11-10 03:56:26 -0800 Patch bug-232927-20211110112539.patch text/plain 2881 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUxMjdlMjY5ZDM3NjM3NGI1NzBhNmIw YzI2ZmNkZDc2ZjMxYTc2MWUuLjBlYTljMDhjOGZmMTU0ZTg0NWE4Njg4Mjg0NTk5NmJhNWEyZWM0 YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMTEtMTAgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgorCisgICAgICAgIEhhc2hlciBzaG91bGQgYmUgYWJsZSB0byBoYXNoIHBv aW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzI5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHd0Zi9IYXNoZXIuaDoKKyAgICAgICAgKFdURjo6YWRkKToKKwogMjAyMS0xMS0wOCAgTXlsZXMg Qy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV2ViR1BV Lnhjb2RlcHJvaiBhbmQgV2ViR1BVLmZyYW1ld29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvSGFzaGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoZXIuaAppbmRleCBhNzdhNDhhOWVjYTg4 YTUxNzcyZWI0ODE1Y2U4YmEwMDU5OTMzN2E4Li5mNDBmZGVmOWI0NmJkNTIxZDE5OGY2NGNhYzc2 YWVmOGMyNzA1N2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoZXIuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9IYXNoZXIuaApAQCAtOTYsNiArOTYsMTEgQEAgaW5saW5lIHZvaWQgYWRk KEhhc2hlciYgaGFzaGVyLCBmbG9hdCBudW1iZXIpCiAgICAgYWRkKGhhc2hlciwgYml0d2lzZV9j YXN0PHVpbnQzMl90PihudW1iZXIpKTsKIH0KIAordGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5l IHZvaWQgYWRkKEhhc2hlciYgaGFzaGVyLCBUKiBwdHIpCit7CisgICAgYWRkKGhhc2hlciwgYml0 d2lzZV9jYXN0PHVpbnRwdHJfdD4ocHRyKSk7Cit9CisKIGlubGluZSB2b2lkIGFkZChIYXNoZXIm IGhhc2hlciwgY29uc3QgU3RyaW5nJiBzdHJpbmcpCiB7CiAgICAgLy8gQ2hvc2UgdG8gaGFzaCB0 aGUgY2hhcmFjdGVycyBoZXJlLiBBc3N1bWluZyB0aGlzIGlzIGJldHRlciB0aGFuIGhhc2hpbmcg dGhlIHBvc3NpYmx5LWFscmVhZHktY29tcHV0ZWQgaGFzaCBvZiB0aGUgY2hhcmFjdGVycy4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZTRlOTA1 ODU4NGQ1MTI0OWMxMzQ1YzZiNjhlNWYxNmMyODY5ZDVkLi41ZjkxYTIxMDA2OTIxNjJjOWVkZDcz NzI4MWU4NDQ2ZTU5NzI0OGUyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMTEtMTAgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIEhhc2hlciBzaG91bGQgYmUgYWJsZSB0byBo YXNoIHBvaW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzI5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hlci5jcHA6CisgICAgICAgIChUZXN0 V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0xMS0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIE5ldyBzcGVjOiBCbG9jayBleHRlcm5hbCBwcm90b2NvbCBoYW5k bGVyIGluIHNhbmRib3hlZCBmcmFtZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL0hhc2hlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNo ZXIuY3BwCmluZGV4IDg2NDg5Njg1MjU4ZWYxYzk4ZGM5MGIyNjU0NGM0ZjRlY2VkZWM0ODcuLjM3 MmM4ZTc3NDY2YmUyMTRiNmRiYWE5MTc1NDIxNTJjNGIyZGI2NDUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvSGFzaGVyLmNwcApAQCAtMTg5LDYgKzE4OSwxOSBAQCBURVNUKFdURiwg SGFzaGVyX211bHRpcGxlKQogICAgIEVYUEVDVF9FUSgxNjUyMzUyMzIxVSwgY29tcHV0ZUhhc2go c3RkOjptYWtlX3BhaXIoc3RkOjptYWtlX3BhaXIoMSwgMiksIHN0ZDo6bWFrZV9wYWlyKDMsIDQp KSkpOwogfQogCitURVNUKFdURiwgSGFzaGVyX3BvaW50ZXIpCit7CisgICAgY2hhciogbnVsbFB0 ciA9IG51bGxwdHI7CisgICAgY2hhciogb25lUHRyID0gbnVsbFB0ciArIDE7CisgICAgY2hhciog ZmZmZmZmUHRyID0gbnVsbFB0ciArIDB4ZmZmZmZmOworCisgICAgY29uc3RleHByIGJvb2wgaXMz MkJpdCA9IHNpemVvZih1aW50MzJfdCkgPT0gc2l6ZW9mKHZvaWQqKTsKKworICAgIEVYUEVDVF9F UShpczMyQml0ID8gemVybzMyQml0SGFzaCA6IHplcm82NEJpdEhhc2gsIGNvbXB1dGVIYXNoKG51 bGxQdHIpKTsKKyAgICBFWFBFQ1RfRVEoaXMzMkJpdCA/IG9uZTMyQml0SGFzaCA6IG9uZTY0Qml0 SGFzaCwgY29tcHV0ZUhhc2gob25lUHRyKSk7CisgICAgRVhQRUNUX0VRKGlzMzJCaXQgPyBjb21w dXRlSGFzaChzdGF0aWNfY2FzdDx1aW50MzJfdD4oMHhmZmZmZmYpKSA6IGNvbXB1dGVIYXNoKHN0 YXRpY19jYXN0PHVpbnQ2NF90PigweGZmZmZmZikpLCBjb21wdXRlSGFzaChmZmZmZmZQdHIpKTsK K30KKwogc3RydWN0IEhhc2hlckFkZEN1c3RvbTEgeyB9OwogCiB2b2lkIGFkZChIYXNoZXImIGhh c2hlciwgY29uc3QgSGFzaGVyQWRkQ3VzdG9tMSYpCg== 443796 2021-11-10 03:56:31 -0800 2021-11-10 04:49:33 -0800 Patch for landing bug-232927-20211110135629.patch text/plain 2760 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUxMjdlMjY5ZDM3NjM3NGI1NzBhNmIw YzI2ZmNkZDc2ZjMxYTc2MWUuLmYzZjJiYzBkOTJlYjg0OTEwOWRmMTEzMGZiNjM3OWI1OWQzNGU2 MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMTEtMTAgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgorCisgICAgICAgIEhhc2hlciBzaG91bGQgYmUgYWJsZSB0byBoYXNoIHBv aW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzI5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBLaW1tbyBLaW5udW5lbi4KKworICAgICAgICAq IHd0Zi9IYXNoZXIuaDoKKyAgICAgICAgKFdURjo6YWRkKToKKwogMjAyMS0xMS0wOCAgTXlsZXMg Qy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV2ViR1BV Lnhjb2RlcHJvaiBhbmQgV2ViR1BVLmZyYW1ld29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvSGFzaGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoZXIuaAppbmRleCBhNzdhNDhhOWVjYTg4 YTUxNzcyZWI0ODE1Y2U4YmEwMDU5OTMzN2E4Li5mNDBmZGVmOWI0NmJkNTIxZDE5OGY2NGNhYzc2 YWVmOGMyNzA1N2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoZXIuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9IYXNoZXIuaApAQCAtOTYsNiArOTYsMTEgQEAgaW5saW5lIHZvaWQgYWRk KEhhc2hlciYgaGFzaGVyLCBmbG9hdCBudW1iZXIpCiAgICAgYWRkKGhhc2hlciwgYml0d2lzZV9j YXN0PHVpbnQzMl90PihudW1iZXIpKTsKIH0KIAordGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5l IHZvaWQgYWRkKEhhc2hlciYgaGFzaGVyLCBUKiBwdHIpCit7CisgICAgYWRkKGhhc2hlciwgYml0 d2lzZV9jYXN0PHVpbnRwdHJfdD4ocHRyKSk7Cit9CisKIGlubGluZSB2b2lkIGFkZChIYXNoZXIm IGhhc2hlciwgY29uc3QgU3RyaW5nJiBzdHJpbmcpCiB7CiAgICAgLy8gQ2hvc2UgdG8gaGFzaCB0 aGUgY2hhcmFjdGVycyBoZXJlLiBBc3N1bWluZyB0aGlzIGlzIGJldHRlciB0aGFuIGhhc2hpbmcg dGhlIHBvc3NpYmx5LWFscmVhZHktY29tcHV0ZWQgaGFzaCBvZiB0aGUgY2hhcmFjdGVycy4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZTRlOTA1 ODU4NGQ1MTI0OWMxMzQ1YzZiNjhlNWYxNmMyODY5ZDVkLi44OGQwOGNhNTc0MzFjYzg2ZTI0MjEz NTg0ZDZkMWY3ZWU5ZThiYTcxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMTEtMTAgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIEhhc2hlciBzaG91bGQgYmUgYWJsZSB0byBo YXNoIHBvaW50ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzI5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBLaW1tbyBLaW5udW5lbi4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hlci5jcHA6CisgICAgICAgIChUZXN0 V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0xMS0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIE5ldyBzcGVjOiBCbG9jayBleHRlcm5hbCBwcm90b2NvbCBoYW5k bGVyIGluIHNhbmRib3hlZCBmcmFtZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL0hhc2hlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNo ZXIuY3BwCmluZGV4IDg2NDg5Njg1MjU4ZWYxYzk4ZGM5MGIyNjU0NGM0ZjRlY2VkZWM0ODcuLjBl ODBmMmFlMWE4YTUxZDExMzAwZDJmZDNlNDBmNDEzZjlkNzU2MzAgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvSGFzaGVyLmNwcApAQCAtMTg5LDYgKzE4OSwxNyBAQCBURVNUKFdURiwg SGFzaGVyX211bHRpcGxlKQogICAgIEVYUEVDVF9FUSgxNjUyMzUyMzIxVSwgY29tcHV0ZUhhc2go c3RkOjptYWtlX3BhaXIoc3RkOjptYWtlX3BhaXIoMSwgMiksIHN0ZDo6bWFrZV9wYWlyKDMsIDQp KSkpOwogfQogCitURVNUKFdURiwgSGFzaGVyX3BvaW50ZXIpCit7CisgICAgY2hhciogbnVsbFB0 ciA9IG51bGxwdHI7CisgICAgY2hhciogb25lUHRyID0gbnVsbFB0ciArIDE7CisgICAgY2hhciog ZmZmZmZmUHRyID0gbnVsbFB0ciArIDB4ZmZmZmZmOworCisgICAgRVhQRUNUX0VRKGNvbXB1dGVI YXNoKHN0YXRpY19jYXN0PHVpbnRwdHJfdD4oMCkpLCBjb21wdXRlSGFzaChudWxsUHRyKSk7Cisg ICAgRVhQRUNUX0VRKGNvbXB1dGVIYXNoKHN0YXRpY19jYXN0PHVpbnRwdHJfdD4oMHgxKSksIGNv bXB1dGVIYXNoKG9uZVB0cikpOworICAgIEVYUEVDVF9FUShjb21wdXRlSGFzaChzdGF0aWNfY2Fz dDx1aW50cHRyX3Q+KDB4ZmZmZmZmKSksIGNvbXB1dGVIYXNoKGZmZmZmZlB0cikpOworfQorCiBz dHJ1Y3QgSGFzaGVyQWRkQ3VzdG9tMSB7IH07CiAKIHZvaWQgYWRkKEhhc2hlciYgaGFzaGVyLCBj b25zdCBIYXNoZXJBZGRDdXN0b20xJikK