232905 2021-11-09 14:12:29 -0800 Upstream: Fix occlusion query buffer synchronization in angle end2end tests 2022-01-19 11:15:21 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 220896 https://bugs.webkit.org/show_bug.cgi?id=230749 InRadar P2 Normal --- 1 kpiddington kpiddington dino ews-watchlist kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1813323 0 kpiddington 2021-11-09 14:12:29 -0800 Upstream: Fix occlusion query buffer synchronization in angle end2end tests 1813325 1 443727 kpiddington 2021-11-09 14:13:10 -0800 Created attachment 443727 Patch 1813327 2 ews-watchlist 2021-11-09 14:14:11 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1813640 3 443727 kkinnunen 2021-11-10 09:12:06 -0800 Comment on attachment 443727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443727&action=review looks good with the nits fixed > Source/ThirdParty/ANGLE/ChangeLog:6 > + Ensure that GPU synchronization is flushed before ChangeLog needs a certain format, these need the tabs > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h:91 > + // encoded on the GPU, and a map operation must wait comment lines don't align 1815643 4 webkit-bug-importer 2021-11-16 14:13:18 -0800 <rdar://problem/85474799> 1832094 5 kpiddington 2022-01-19 11:15:21 -0800 Fixed in Roll ANGLE to include upstreamed Metal backend https://bugs.webkit.org/show_bug.cgi?id=220896 <rdar://problem/73539682> *** This bug has been marked as a duplicate of bug 220896 *** 443727 2021-11-09 14:13:10 -0800 2021-11-10 09:12:06 -0800 Patch bug-232905-20211109141309.patch text/plain 4566 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOWI4ZDIzYTZjNzFhYmNkZGNjZWI2N2M0YmZhMjcyYTIyMGQ5YmJlNy4uZDdhY2RhNTQ0NTQ5 OTE3YTM0MmY2MmY0ZDYwMWIxMmNjMjFjMWJjNCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTExLTA5ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBzdHJlYW06IEZpeCBvY2NsdXNpb24gcXVlcnkg YnVmZmVyIHN5bmNocm9uaXphdGlvbiBpbiBhbmdsZSBlbmQyZW5kIHRlc3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI5MDUKKworCUVuc3VyZSB0 aGF0IEdQVSBzeW5jaHJvbml6YXRpb24gaXMgZmx1c2hlZCBiZWZvcmUKKwl3ZSB0cnkgdG8gcmVh ZGJhY2sgZnJvbSBhIGJ1ZmZlci4gT25seSBpbXBhY3RzCisJbWFjT1MuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVy ZXIvbWV0YWwvbXRsX3Jlc291cmNlcy5oOgorICAgICAgICAocng6Om10bDo6UmVzb3VyY2U6Omlz Q1BVUmVhZE1lbVN5bmNQZW5kaW5nIGNvbnN0KToKKyAgICAgICAgKHJ4OjptdGw6OlJlc291cmNl OjpzZXRDUFVSZWFkTWVtU3luY1BlbmRpbmcgY29uc3QpOgorICAgICAgICAocng6Om10bDo6UmVz b3VyY2U6OnJlc2V0Q1BVUmVhZE1lbVN5bmNQZW5kaW5nKToKKyAgICAgICAgKiBzcmMvbGliQU5H TEUvcmVuZGVyZXIvbWV0YWwvbXRsX3Jlc291cmNlcy5tbToKKyAgICAgICAgKHJ4OjptdGw6OlJl c291cmNlOjpyZXNldCk6CisgICAgICAgIChyeDo6bXRsOjpCdWZmZXI6Om1hcFdpdGhPcHQpOgor CiAyMDIxLTEwLTI3ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAoU2FmYXJpIDE1KTogUG9vciBXZWJHTCBwZXJmb3JtYW5jZSBvbiBo dHRwczovL2Rvd25sb2Fkcy5zY2lycmEuY29tL2xhYnMvcGFydGljbGVzCmRpZmYgLS1naXQgYS9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvbXRsX3Jl c291cmNlcy5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVy L21ldGFsL210bF9yZXNvdXJjZXMuaAppbmRleCA0YTIwM2FhYzBiNjljZWE4MTg2MjM4YjhhNDQ3 ZmU0MTAyNzZkNWQ0Li4xODFmODdhZmI2N2ZlODc5YWU2MDA5NzgyOTVkMzBmNGQ5N2NkZmY5IDEw MDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIv bWV0YWwvbXRsX3Jlc291cmNlcy5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9yZW5kZXJlci9tZXRhbC9tdGxfcmVzb3VyY2VzLmgKQEAgLTYzLDYgKzYzLDEwIEBA IGNsYXNzIFJlc291cmNlIDogYW5nbGU6Ok5vbkNvcHlhYmxlCiAgICAgYm9vbCBpc0NQVVJlYWRN ZW1OZWVkU3luYygpIGNvbnN0IHsgcmV0dXJuIG1Vc2FnZVJlZi0+Y3B1UmVhZE1lbU5lZWRTeW5j OyB9CiAgICAgdm9pZCByZXNldENQVVJlYWRNZW1OZWVkU3luYygpIHsgbVVzYWdlUmVmLT5jcHVS ZWFkTWVtTmVlZFN5bmMgPSBmYWxzZTsgfQogCisgICAgYm9vbCBpc0NQVVJlYWRNZW1TeW5jUGVu ZGluZygpIGNvbnN0IHsgcmV0dXJuIG1Vc2FnZVJlZi0+Y3B1UmVhZE1lbVN5bmNQZW5kaW5nOyB9 CisgICAgdm9pZCBzZXRDUFVSZWFkTWVtU3luY1BlbmRpbmcoYm9vbCB2YWx1ZSkgY29uc3QgeyBt VXNhZ2VSZWYtPmNwdVJlYWRNZW1TeW5jUGVuZGluZyA9IHZhbHVlOyB9CisgICAgdm9pZCByZXNl dENQVVJlYWRNZW1TeW5jUGVuZGluZygpIHsgbVVzYWdlUmVmLT5jcHVSZWFkTWVtU3luY1BlbmRp bmcgPSBmYWxzZTsgfQorICAgIAogICAgIGJvb2wgaXNDUFVSZWFkTWVtRGlydHkoKSBjb25zdCB7 IHJldHVybiBtVXNhZ2VSZWYtPmNwdVJlYWRNZW1EaXJ0eTsgfQogICAgIHZvaWQgcmVzZXRDUFVS ZWFkTWVtRGlydHkoKSB7IG1Vc2FnZVJlZi0+Y3B1UmVhZE1lbURpcnR5ID0gZmFsc2U7IH0KIApA QCAtODIsNiArODYsMTEgQEAgY2xhc3MgUmVzb3VyY2UgOiBhbmdsZTo6Tm9uQ29weWFibGUKICAg ICAgICAgLy8gVGhpcyBmbGFnIG1lYW5zIHRoZSByZXNvdXJjZSB3YXMgaXNzdWVkIHRvIGJlIG1v ZGlmaWVkIGJ5IEdQVSwgaWYgQ1BVIHdhbnRzIHRvIHJlYWQKICAgICAgICAgLy8gaXRzIGNvbnRl bnQsIGV4cGxpY2l0IHN5bmNob3JuaXphdGlvbiBjYWxsIG11c3QgYmUgaW52b2tlZC4KICAgICAg ICAgYm9vbCBjcHVSZWFkTWVtTmVlZFN5bmMgPSBmYWxzZTsKKyAgICAgICAgCisgICAgICAgIC8v IFRoaXMgZmxhZyBpcyBzZXQgd2hlbiBzeW5jaHJvbml6YXRpb24gZm9yIHRoZSByZXNvdXJjZSBo YXMgYmVlbgorICAgICAgICAgLy8gZW5jb2RlZCBvbiB0aGUgR1BVLCBhbmQgYSBtYXAgb3BlcmF0 aW9uIG11c3Qgd2FpdAorICAgICAgICAgLy8gdW50aWwgaXQncyBjb21wbGV0ZWQuCisgICAgICAg ICBib29sIGNwdVJlYWRNZW1TeW5jUGVuZGluZyA9IGZhbHNlOwogCiAgICAgICAgIC8vIFRoaXMg ZmxhZyBpcyB1c2VmdWwgZm9yIEJ1ZmZlck10bCB0byBrbm93IHdoZXRoZXIgaXQgc2hvdWxkIHVw ZGF0ZSB0aGUgc2hhZG93IGNvcHkKICAgICAgICAgYm9vbCBjcHVSZWFkTWVtRGlydHkgPSBmYWxz ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5k ZXJlci9tZXRhbC9tdGxfcmVzb3VyY2VzLm1tIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9yZXNvdXJjZXMubW0KaW5kZXggZmQ4OWI4NmFk MWNlZTVkYWI1MTFiNmFkOWU2NGVhYjk2MjlkZmU5Yy4uMjg1ZjdiOTNmOTMxOTllYTYxZWI3Mzg3 Yjc3NjQ3YTU3NTJhMmIzOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9yZXNvdXJjZXMubW0KKysrIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL210bF9yZXNvdXJjZXMu bW0KQEAgLTQ0LDYgKzQ0LDcgQEAgdm9pZCBTeW5jQ29udGVudChDb250ZXh0TXRsICpjb250ZXh0 LAogICAgICAgICBibGl0RW5jb2Rlci0+c3luY2hyb25pemVSZXNvdXJjZShyZXNvdXJjZSk7CiAK ICAgICAgICAgcmVzb3VyY2UtPnJlc2V0Q1BVUmVhZE1lbU5lZWRTeW5jKCk7CisgICAgICAgIHJl c291cmNlLT5zZXRDUFVSZWFkTWVtU3luY1BlbmRpbmcodHJ1ZSk7CiAgICAgfQogI2VuZGlmCiB9 CkBAIC02MSw2ICs2Miw3IEBAIHZvaWQgRW5zdXJlQ29udGVudFN5bmNlZChDb250ZXh0TXRsICpj b250ZXh0LCBjb25zdCBzdGQ6OnNoYXJlZF9wdHI8VD4gJnJlc291cmNlCiAgICAgICAgIFN5bmND b250ZW50KGNvbnRleHQsIGJsaXRFbmNvZGVyLCByZXNvdXJjZSk7CiAgICAgfQogI2VuZGlmCisg ICAgcmVzb3VyY2UtPnJlc2V0Q1BVUmVhZE1lbU5lZWRTeW5jKCk7CiB9CiAKIH0gIC8vIG5hbWVz cGFjZQpAQCAtNzgsNiArODAsNyBAQCB2b2lkIFJlc291cmNlOjpyZXNldCgpCiAgICAgbVVzYWdl UmVmLT5jbWRCdWZmZXJRdWV1ZVNlcmlhbCA9IDA7CiAgICAgcmVzZXRDUFVSZWFkTWVtRGlydHko KTsKICAgICByZXNldENQVVJlYWRNZW1OZWVkU3luYygpOworICAgIHJlc2V0Q1BVUmVhZE1lbVN5 bmNQZW5kaW5nKCk7CiB9CiAKIGJvb2wgUmVzb3VyY2U6OmlzQmVpbmdVc2VkQnlHUFUoQ29udGV4 dCAqY29udGV4dCkgY29uc3QKQEAgLTEwMDAsNyArMTAwMyw3IEBAIHVpbnQ4X3QgKkJ1ZmZlcjo6 bWFwV2l0aE9wdChDb250ZXh0TXRsICpjb250ZXh0LCBib29sIHJlYWRvbmx5LCBib29sIG5vU3lu YykKIHsKICAgICBtTWFwUmVhZE9ubHkgPSByZWFkb25seTsKIAotICAgIGlmICghbm9TeW5jICYm IChpc0NQVVJlYWRNZW1OZWVkU3luYygpIHx8ICFyZWFkb25seSkpCisgICAgaWYgKCFub1N5bmMg JiYgKGlzQ1BVUmVhZE1lbVN5bmNQZW5kaW5nKCkgfHwgaXNDUFVSZWFkTWVtTmVlZFN5bmMoKSB8 fCAhcmVhZG9ubHkpKQogICAgIHsKICAgICAgICAgQ29tbWFuZFF1ZXVlICZjbWRRdWV1ZSA9IGNv bnRleHQtPmNtZFF1ZXVlKCk7CiAKQEAgLTEwMTIsNiArMTAxNSw3IEBAIHVpbnQ4X3QgKkJ1ZmZl cjo6bWFwV2l0aE9wdChDb250ZXh0TXRsICpjb250ZXh0LCBib29sIHJlYWRvbmx5LCBib29sIG5v U3luYykKICAgICAgICAgfQogCiAgICAgICAgIGNtZFF1ZXVlLmVuc3VyZVJlc291cmNlUmVhZHlG b3JDUFUodGhpcyk7CisgICAgICAgIHJlc2V0Q1BVUmVhZE1lbVN5bmNQZW5kaW5nKCk7CiAgICAg fQogCiAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCAqPihbZ2V0KCkgY29udGVu dHNdKTsK