232878 2021-11-09 06:19:08 -0800 REGRESSION(r285436): Broke WPE build 2021-11-09 06:32:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232798 1 commit-queue commit-queue dino lmoura mmaxfield webkit-bug-importer oldest_to_newest 1813117 0 commit-queue 2021-11-09 06:19:08 -0800 https://commits.webkit.org/r285436 introduced a regression: Broke WPE build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1813119 1 443688 commit-queue 2021-11-09 06:19:14 -0800 Created attachment 443688 REVERT of r285436 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1813126 2 ews-feeder 2021-11-09 06:31:47 -0800 Committed r285494 (244018@main): <https://commits.webkit.org/244018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443688. 1813127 3 webkit-bug-importer 2021-11-09 06:32:19 -0800 <rdar://problem/85200331> 443688 2021-11-09 06:19:14 -0800 2021-11-09 06:31:48 -0800 REVERT of r285436 bug-232878-20211109061914.patch text/plain 7076 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQzZWE5MjljMjIwODc5 MDUzODRlNTcyOWUxN2RlNmJjMjMzYjNmYy4uYTdhMGM3NDc3NWZmMGNlZGEzMzk3MWMwMTUyY2Ey NmUxYzE5MzQ2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTExLTA5ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI4NTQzNi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMjg3OAorCisgICAgICAgIEJyb2tlIFdQRSBidWlsZAorCisgICAgICAg IFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiW1dlYlhSXSB0aHJlZS5qcyBkZW1vcyBk b24ndCB3b3JrIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyNzk4CisgICAgICAgIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnL3IyODU0MzYKKwog MjAyMS0xMS0wOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyODU0ODYuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcAppbmRleCA0 YjYzZGI5N2NhNzcyMGU2YzJkNDM4NDlhMTY4YzViMGMxM2FiOGYzLi41ZTc2NTgwZmM3MzAyN2U1 YTdlYTYwM2NkZjY1NzM0YWViZWVkOTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2VieHIvV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlci5jcHAKQEAgLTEwMiwyMCArMTAy LDE0IEBAIHZvaWQgV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlcjo6c3RhcnRGcmFtZShjb25zdCBQbGF0 Zm9ybVhSOjpEZXZpY2U6OkZyYW1lRGF0YTo6TGF5CiAgICAgaWYgKCFtX2NvbnRleHQuZ3JhcGhp Y3NDb250ZXh0R0woKSkKICAgICAgICAgcmV0dXJuOwogICAgIGF1dG8mIGdsID0gKm1fY29udGV4 dC5ncmFwaGljc0NvbnRleHRHTCgpOwotICAgIGF1dG8gZ0NHTCA9IHN0YXRpY19jYXN0PEdyYXBo aWNzQ29udGV4dEdMT3BlbkdMKj4obV9jb250ZXh0LmdyYXBoaWNzQ29udGV4dEdMKCkpOwotICAg IEdDR0xlbnVtIHRleHR1cmVUYXJnZXQgPSBnQ0dMLT5kcmF3aW5nQnVmZmVyVGV4dHVyZVRhcmdl dCgpOwotICAgIEdDR0xlbnVtIHRleHR1cmVUYXJnZXRCaW5kaW5nID0gZ0NHTC0+ZHJhd2luZ0J1 ZmZlclRleHR1cmVUYXJnZXRRdWVyeUZvckRyYXdpbmdUYXJnZXQodGV4dHVyZVRhcmdldCk7CiAK ICAgICBtX2ZyYW1lYnVmZmVyLT5zZXRPcGFxdWVBY3RpdmUodHJ1ZSk7CiAKICAgICBHQ0dMaW50 IGJvdW5kRkJPIHsgMCB9OwotICAgIEdDR0xpbnQgYm91bmRUZXh0dXJlIHsgMCB9OwotICAgIGds LmdldEludGVnZXJ2KEdMOjpGUkFNRUJVRkZFUl9CSU5ESU5HLCBtYWtlR0NHTFNwYW4oJmJvdW5k RkJPLCAxKSk7Ci0gICAgZ2wuZ2V0SW50ZWdlcnYodGV4dHVyZVRhcmdldEJpbmRpbmcsIG1ha2VH Q0dMU3BhbigmYm91bmRUZXh0dXJlLCAxKSk7CiAKLSAgICBhdXRvIHNjb3BlZEJpbmRpbmdzID0g bWFrZVNjb3BlRXhpdChbJmdsLCBib3VuZEZCTywgYm91bmRUZXh0dXJlLCB0ZXh0dXJlVGFyZ2V0 XSgpIHsKKyAgICBnbC5nZXRJbnRlZ2VydihHTDo6RlJBTUVCVUZGRVJfQklORElORywgbWFrZUdD R0xTcGFuKCZib3VuZEZCTywgMSkpOworICAgIGF1dG8gc2NvcGVkRkJPcyA9IG1ha2VTY29wZUV4 aXQoWyZnbCwgYm91bmRGQk9dKCkgewogICAgICAgICBnbC5iaW5kRnJhbWVidWZmZXIoR0w6OkZS QU1FQlVGRkVSLCBib3VuZEZCTyk7Ci0gICAgICAgIGdsLmJpbmRUZXh0dXJlKHRleHR1cmVUYXJn ZXQsIGJvdW5kVGV4dHVyZSk7CiAgICAgfSk7CiAKICAgICBnbC5iaW5kRnJhbWVidWZmZXIoR3Jh cGhpY3NDb250ZXh0R0w6OkZSQU1FQlVGRkVSLCBtX2ZyYW1lYnVmZmVyLT5vYmplY3QoKSk7CkBA IC0xMjgsNiArMTIyLDkgQEAgdm9pZCBXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzdGFydEZyYW1l KGNvbnN0IFBsYXRmb3JtWFI6OkRldmljZTo6RnJhbWVEYXRhOjpMYXkKICNpZiBVU0UoSU9TVVJG QUNFX0ZPUl9YUl9MQVlFUl9EQVRBKQogICAgIEFTU0VSVChkYXRhLnN1cmZhY2UpOwogCisgICAg YXV0byBnQ0dMID0gc3RhdGljX2Nhc3Q8R3JhcGhpY3NDb250ZXh0R0xPcGVuR0wqPihtX2NvbnRl eHQuZ3JhcGhpY3NDb250ZXh0R0woKSk7CisgICAgR0NHTGVudW0gdGV4dHVyZVRhcmdldCA9IGdD R0wtPmRyYXdpbmdCdWZmZXJUZXh0dXJlVGFyZ2V0KCk7CisKICAgICBpZiAoIW1fb3BhcXVlVGV4 dHVyZSkKICAgICAgICAgbV9vcGFxdWVUZXh0dXJlID0gZ0NHTC0+Y3JlYXRlVGV4dHVyZSgpOwog CkBAIC0xNTksMTIgKzE1NiwxMSBAQCB2b2lkIFdlYlhST3BhcXVlRnJhbWVidWZmZXI6OnN0YXJ0 RnJhbWUoY29uc3QgUGxhdGZvcm1YUjo6RGV2aWNlOjpGcmFtZURhdGE6OkxheQogICAgICAgICBy ZXR1cm47CiAgICAgfQogCi0gICAgLy8gU2V0IHVwIHRoZSBmcmFtZWJ1ZmZlciB0byB1c2UgdGhl IHRleHR1cmUgdGhhdCBwb2ludHMgdG8gdGhlIElPU3VyZmFjZS4gSWYgd2UncmUgbm90IG11bHRp c2FtcGxpbmcsCi0gICAgLy8gdGhlIHRhcmdldCBmcmFtZWJ1ZmZlciBpcyBtX2ZyYW1lYnVmZmVy LT5vYmplY3QoKSAoYm91bmQgYWJvdmUpLiBJZiB3ZSBhcmUgbXVsdGlzYW1wbGluZywgdGhlIHRh cmdldAotICAgIC8vIGlzIHRoZSByZXNvbHZlZCBmcmFtZWJ1ZmZlciB3ZSBjcmVhdGVkIGluIHNl dHVwRnJhbWVidWZmZXIuCi0gICAgaWYgKG1fbXVsdGlzYW1wbGVDb2xvckJ1ZmZlcikKLSAgICAg ICAgZ2wuYmluZEZyYW1lYnVmZmVyKEdMOjpGUkFNRUJVRkZFUiwgbV9yZXNvbHZlZEZCTyk7Ci0g ICAgZ2wuZnJhbWVidWZmZXJUZXh0dXJlMkQoR0w6OkZSQU1FQlVGRkVSLCBHTDo6Q09MT1JfQVRU QUNITUVOVDAsIHRleHR1cmVUYXJnZXQsIG1fb3BhcXVlVGV4dHVyZSwgMCk7CisgICAgLy8gSWYg d2UncmUgbm90IG11bHRpc2FtcGxpbmcsIHNldCB1cCB0aGUgZnJhbWVidWZmZXIgdG8gdXNlIHRo ZSB0ZXh0dXJlIHRoYXQgcG9pbnRzIHRvIHRoZSBJT1N1cmZhY2UuIFRoZSBkZXB0aCBhbmQKKyAg ICAvLyBzdGVuY2lsIGJ1ZmZlcnMgd2VyZSBhdHRhY2hlZCBieSBzZXR1cEZyYW1lYnVmZmVyLiBJ ZiB3ZSBhcmUgbXVsdGlzYW1wbGluZywgdGhlIGZyYW1lYnVmZmVyIHdhcyBpbml0aWFsaXplZCBp biBzZXR1cEZyYW1lYnVmZmVyLAorICAgIC8vIGFuZCB3ZSdsbCByZXNvbHZlIGludG8gdGhlIG1f b3BhcXVlVGV4dHVyZSBpbiBlbmRGcmFtZS4KKyAgICBpZiAoIW1fbXVsdGlzYW1wbGVDb2xvckJ1 ZmZlcikKKyAgICAgICAgZ2wuZnJhbWVidWZmZXJUZXh0dXJlMkQoR0w6OkZSQU1FQlVGRkVSLCBH TDo6Q09MT1JfQVRUQUNITUVOVDAsIEdMOjpURVhUVVJFXzJELCBtX29wYXF1ZVRleHR1cmUsIDAp OwogCiAgICAgLy8gQXQgdGhpcyBwb2ludCB0aGUgZnJhbWVidWZmZXIgc2hvdWxkIGJlICJjb21w bGV0ZSIuCiAgICAgQVNTRVJUKGdsLmNoZWNrRnJhbWVidWZmZXJTdGF0dXMoR0w6OkZSQU1FQlVG RkVSKSA9PSBHTDo6RlJBTUVCVUZGRVJfQ09NUExFVEUpOwpAQCAtMjAzLDIxICsxOTksMjAgQEAg dm9pZCBXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjplbmRGcmFtZSgpCiAgICAgICAgIFRlbXBvcmFy eU9wZW5HTFNldHRpbmcgc2NvcGVkU3RlbmNpbChHTDo6U1RFTkNJTF9URVNULCAwKTsKICNlbmRp ZgogCi0gICAgICAgIEdDR0xpbnQgYm91bmRGQk8geyAwIH07CiAgICAgICAgIEdDR0xpbnQgYm91 bmRSZWFkRkJPIHsgMCB9OwogICAgICAgICBHQ0dMaW50IGJvdW5kRHJhd0ZCTyB7IDAgfTsKLSAg ICAgICAgZ2wuZ2V0SW50ZWdlcnYoR0w6OkZSQU1FQlVGRkVSX0JJTkRJTkcsIG1ha2VHQ0dMU3Bh bigmYm91bmRGQk8sIDEpKTsKICAgICAgICAgZ2wuZ2V0SW50ZWdlcnYoR0w6OlJFQURfRlJBTUVC VUZGRVJfQklORElORywgbWFrZUdDR0xTcGFuKCZib3VuZFJlYWRGQk8sIDEpKTsKICAgICAgICAg Z2wuZ2V0SW50ZWdlcnYoR0w6OkRSQVdfRlJBTUVCVUZGRVJfQklORElORywgbWFrZUdDR0xTcGFu KCZib3VuZERyYXdGQk8sIDEpKTsKIAotICAgICAgICBhdXRvIHNjb3BlZEJpbmRpbmdzID0gbWFr ZVNjb3BlRXhpdChbJmdsLCBib3VuZEZCTywgYm91bmRSZWFkRkJPLCBib3VuZERyYXdGQk9dKCkg ewotICAgICAgICAgICAgZ2wuYmluZEZyYW1lYnVmZmVyKEdMOjpGUkFNRUJVRkZFUiwgYm91bmRG Qk8pOworICAgICAgICBhdXRvIHNjb3BlZEZCT3MgPSBtYWtlU2NvcGVFeGl0KFsmZ2wsIGJvdW5k UmVhZEZCTywgYm91bmREcmF3RkJPXSgpIHsKICAgICAgICAgICAgIGdsLmJpbmRGcmFtZWJ1ZmZl cihHTDo6UkVBRF9GUkFNRUJVRkZFUiwgYm91bmRSZWFkRkJPKTsKICAgICAgICAgICAgIGdsLmJp bmRGcmFtZWJ1ZmZlcihHTDo6RFJBV19GUkFNRUJVRkZFUiwgYm91bmREcmF3RkJPKTsKICAgICAg ICAgfSk7CiAKLSAgICAgICAgZ2wuYmluZEZyYW1lYnVmZmVyKEdMOjpSRUFEX0ZSQU1FQlVGRkVS LCBtX2ZyYW1lYnVmZmVyLT5vYmplY3QoKSk7CiAgICAgICAgIGdsLmJpbmRGcmFtZWJ1ZmZlcihH TDo6RFJBV19GUkFNRUJVRkZFUiwgbV9yZXNvbHZlZEZCTyk7CisgICAgICAgIGdsLmZyYW1lYnVm ZmVyVGV4dHVyZTJEKEdMOjpGUkFNRUJVRkZFUiwgR0w6OkNPTE9SX0FUVEFDSE1FTlQwLCBHTDo6 VEVYVFVSRV8yRCwgbV9vcGFxdWVUZXh0dXJlLCAwKTsKKworICAgICAgICBnbC5iaW5kRnJhbWVi dWZmZXIoR0w6OlJFQURfRlJBTUVCVUZGRVIsIG1fZnJhbWVidWZmZXItPm9iamVjdCgpKTsKICAg ICAgICAgZ2wuYmxpdEZyYW1lYnVmZmVyKDAsIDAsIG1fd2lkdGgsIG1faGVpZ2h0LCAwLCAwLCBt X3dpZHRoLCBtX2hlaWdodCwgR0w6OkNPTE9SX0JVRkZFUl9CSVQsIEdMOjpORUFSRVNUKTsKICAg ICB9CiAKQEAgLTI1MCwxOSArMjQ1LDE5IEBAIGJvb2wgV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlcjo6 c2V0dXBGcmFtZWJ1ZmZlcigpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBhdXRvJiBnbCA9 ICptX2NvbnRleHQuZ3JhcGhpY3NDb250ZXh0R0woKTsKIAotICAgIC8vIFJlc3RvcmUgYmluZGlu Z3Mgd2hlbiBleGl0aW5nIHRoZSBmdW5jdGlvbi4KKyAgICAvLyBCaW5kIGN1cnJlbnQgRkJPcyB3 aGVuIGV4aXRpbmcgdGhlIGZ1bmN0aW9uCiAgICAgR0NHTGludCBib3VuZEZCTyB7IDAgfTsKICAg ICBHQ0dMaW50IGJvdW5kUmVuZGVyYnVmZmVyIHsgMCB9OwogICAgIGdsLmdldEludGVnZXJ2KEdM OjpGUkFNRUJVRkZFUl9CSU5ESU5HLCBtYWtlR0NHTFNwYW4oJmJvdW5kRkJPLCAxKSk7CiAgICAg Z2wuZ2V0SW50ZWdlcnYoR0w6OlJFTkRFUkJVRkZFUl9CSU5ESU5HLCBtYWtlR0NHTFNwYW4oJmJv dW5kUmVuZGVyYnVmZmVyLCAxKSk7Ci0KLSAgICBhdXRvIHNjb3BlZEJpbmRpbmdzID0gbWFrZVNj b3BlRXhpdChbJmdsLCBib3VuZEZCTywgYm91bmRSZW5kZXJidWZmZXJdKCkgeworICAgIGF1dG8g c2NvcGVkRkJPID0gbWFrZVNjb3BlRXhpdChbJmdsLCBib3VuZEZCTywgYm91bmRSZW5kZXJidWZm ZXJdKCkgewogICAgICAgICBnbC5iaW5kRnJhbWVidWZmZXIoR0w6OkZSQU1FQlVGRkVSLCBib3Vu ZEZCTyk7CiAgICAgICAgIGdsLmJpbmRSZW5kZXJidWZmZXIoR0w6OlJFTkRFUkJVRkZFUiwgYm91 bmRSZW5kZXJidWZmZXIpOwogICAgIH0pOwogCiAgICAgLy8gU2V0IHVwIGNvbG9yLCBkZXB0aCBh bmQgc3RlbmNpbCBmb3JtYXRzCiAgICAgYm9vbCBoYXNEZXB0aE9yU3RlbmNpbCA9IG1fYXR0cmli dXRlcy5zdGVuY2lsIHx8IG1fYXR0cmlidXRlcy5kZXB0aDsKKyAgICBhdXRvIGNvbG9yRm9ybWF0 ID0gbV9hdHRyaWJ1dGVzLmFscGhhID8gR0w6OlJHQkE4IDogR0w6OlJHQjg7CiAjaWYgVVNFKE9Q RU5HTF9FUykKICAgICBhdXRvJiBleHRlbnNpb25zID0gcmVpbnRlcnByZXRfY2FzdDxFeHRlbnNp b25zR0xPcGVuR0xFUyY+KGdsLmdldEV4dGVuc2lvbnMoKSk7CiAgICAgYm9vbCBwbGF0Zm9ybVN1 cHBvcnRzUGFja2VkRGVwdGhTdGVuY2lsID0gaGFzRGVwdGhPclN0ZW5jaWwgJiYgZXh0ZW5zaW9u cy5zdXBwb3J0cygiR0xfT0VTX3BhY2tlZF9kZXB0aF9zdGVuY2lsIik7CkBAIC0zMzAsNyArMzI1 LDcgQEAgYm9vbCBXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzZXR1cEZyYW1lYnVmZmVyKCkKICAg ICAgICAgbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVyID0gZ2wuY3JlYXRlUmVuZGVyYnVmZmVyKCk7 CiAgICAgICAgIGdsLmJpbmRGcmFtZWJ1ZmZlcihHTDo6RlJBTUVCVUZGRVIsIG1fZnJhbWVidWZm ZXItPm9iamVjdCgpKTsKICAgICAgICAgZ2wuYmluZFJlbmRlcmJ1ZmZlcihHTDo6UkVOREVSQlVG RkVSLCBtX211bHRpc2FtcGxlQ29sb3JCdWZmZXIpOwotICAgICAgICBnbC5yZW5kZXJidWZmZXJT dG9yYWdlTXVsdGlzYW1wbGUoR0w6OlJFTkRFUkJVRkZFUiwgbV9zYW1wbGVDb3VudCwgR0w6OlJH QkE4LCBtX3dpZHRoLCBtX2hlaWdodCk7CisgICAgICAgIGdsLnJlbmRlcmJ1ZmZlclN0b3JhZ2VN dWx0aXNhbXBsZShHTDo6UkVOREVSQlVGRkVSLCBtX3NhbXBsZUNvdW50LCBjb2xvckZvcm1hdCwg bV93aWR0aCwgbV9oZWlnaHQpOwogICAgICAgICBnbC5mcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlcihH TDo6RlJBTUVCVUZGRVIsIEdMOjpDT0xPUl9BVFRBQ0hNRU5UMCwgR0w6OlJFTkRFUkJVRkZFUiwg bV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVyKTsKICAgICAgICAgaWYgKGhhc0RlcHRoT3JTdGVuY2ls KSB7CiAgICAgICAgICAgICBtX2RlcHRoU3RlbmNpbEJ1ZmZlciA9IGdsLmNyZWF0ZVJlbmRlcmJ1 ZmZlcigpOwo=