232863 2021-11-08 19:52:29 -0800 Fix wrong frame count of CARingBuffer in SpeechRecognitionRemoteRealtimeMediaSource 2021-11-09 13:36:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1812968 0 sihui_liu 2021-11-08 19:52:29 -0800 ... 1812970 1 sihui_liu 2021-11-08 19:53:01 -0800 <rdar://83381842> 1812972 2 443650 sihui_liu 2021-11-08 20:18:06 -0800 Created attachment 443650 Patch 1813006 3 443650 youennf 2021-11-08 23:50:27 -0800 Comment on attachment 443650 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443650&action=review > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > + m_description = description; Do we need to set m_description here again, since we already set it when allocating m_ringBuffer? It seems we should set m_description once and I would tend to do it in audioSamplesAvailable. 1813175 4 sihui_liu 2021-11-09 09:06:26 -0800 (In reply to youenn fablet from comment #3) > Comment on attachment 443650 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443650&action=review > > > Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:86 > > + m_description = description; > > Do we need to set m_description here again, since we already set it when > allocating m_ringBuffer? > It seems we should set m_description once and I would tend to do it in > audioSamplesAvailable. I don't understand. Do we set m_description elsewhere in SpeechRecognitionRemoteRealtimeMediaSource? Do you mean m_description in SpeechRecognitionRealtimeMediaSourceManager::Source? 1813215 5 443650 sihui_liu 2021-11-09 10:47:12 -0800 Comment on attachment 443650 Patch Land the patch as it is to fix the bug first. Let me know if you think we should set m_description in a different place, and I will follow up. 1813219 6 ews-feeder 2021-11-09 10:53:21 -0800 Committed r285509 (244032@main): <https://commits.webkit.org/244032@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443650. 1813295 7 sihui_liu 2021-11-09 13:34:37 -0800 Reopening to attach new patch. 1813296 8 443722 sihui_liu 2021-11-09 13:34:39 -0800 Created attachment 443722 [fast-cq] Patch 1813297 9 443722 sihui_liu 2021-11-09 13:35:22 -0800 Comment on attachment 443722 [fast-cq] Patch Unreviewed build fix. 1813298 10 ews-feeder 2021-11-09 13:36:56 -0800 Committed r285531 (244048@main): <https://commits.webkit.org/244048@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443722. 443650 2021-11-08 20:18:06 -0800 2021-11-09 13:34:34 -0800 Patch bug-232863-20211108201805.patch text/plain 5585 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1NDQ1N2U1NDJkYWRjNDg5 NTdmMTZlYjA1YjY2ODhiZTg5OTg5NjQuLmIzZjcxOWEyODI5MmE2NGU5OWZiZDk3NzdkNGI1YzMz MWEzODg0YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMTEtMDggIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHdyb25nIGZyYW1lIGNvdW50 IG9mIENBUmluZ0J1ZmZlciBpbiBTcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFT b3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz Mjg2MworICAgICAgICA8cmRhcjovLzgzMzgxODQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWVjaFJlY29nbml0aW9uUmVhbHRpbWVNZWRpYVNv dXJjZU1hbmFnZXI6OlNvdXJjZSB1c2VzIHNoYXJlZCByaW5nIGJ1ZmZlciB0byBwYXNzIGF1ZGlv IGRhdGEgdG8gCisgICAgICAgIFNwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNv dXJjZS4gV2UgdXNlZCB0byBhc2sgQ0FSaW5nQnVmZmVyIGluIAorICAgICAgICBTcGVlY2hSZWNv Z25pdGlvblJlYWx0aW1lTWVkaWFTb3VyY2VNYW5hZ2VyOjpTb3VyY2UgdG8gYWxsb2NhdGUgd2l0 aCBtX251bWJlck9mRnJhbWVzIGFuZCBzZW5kIG1fbnVtYmVyT2ZGcmFtZXMKKyAgICAgICAgdG8g U3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlIChzbyBTcGVlY2hSZWNv Z25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2UgY2FuIGNyZWF0ZSBhIAorICAgICAgICBj b3JyZXNwb25kaW5nIENBUmluZ0J1ZmZlcikuIFRoaXMgaXMgd3JvbmcgYmVjYXVzZSBDQVJpbmdC dWZmZXI6OmFsbG9jYXRlKCkgcm91bmRzIHVwIGZyYW1lQ291bnQgdG8gcG93ZXIgb2YgCisgICAg ICAgIHR3bywgd2hpY2ggbWVhbnMgbV9udW1iZXJPZkZyYW1lcyBtYXkgYmUgbm90IHRoZSBudW1i ZXIgdXNlZC4gV2Ugc2hvdWxkIGdldCB0aGUgYWN0dWFsIGZyYW1lQ291bnQgaW4gdGhlIAorICAg ICAgICBzZXRTdG9yYWdlIGNhbGxiYWNrIG9mIFNoYXJlZFJpbmdCdWZmZXJTdG9yYWdlLCBhbmQg cGFzcyB0aGF0IHZhbHVlIHRvIFNwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNv dXJjZS4KKworICAgICAgICBNYW51YWxseSB0ZXN0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv U3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmNwcDoKKyAgICAgICAg KFdlYktpdDo6U3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlOjpzZXRT dG9yYWdlKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvblJl YWx0aW1lTWVkaWFTb3VyY2VNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U3BlZWNoUmVj b2duaXRpb25SZWFsdGltZU1lZGlhU291cmNlTWFuYWdlcjo6U291cmNlOjpTb3VyY2UpOgorICAg ICAgICAoV2ViS2l0OjpTcGVlY2hSZWNvZ25pdGlvblJlYWx0aW1lTWVkaWFTb3VyY2VNYW5hZ2Vy OjpTb3VyY2U6OnN0b3JhZ2VDaGFuZ2VkKToKKwogMjAyMS0xMS0wOCAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1N5bnRoZXRpY1RhcEdlc3R1cmVS ZWNvZ25pemVyJ3MgYWN0aW9uIHRhcmdldHMgc2hvdWxkIGJlIHdlYWsgcG9pbnRlcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1NwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVh bHRpbWVNZWRpYVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9TcGVlY2hSZWNv Z25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2UuY3BwCmluZGV4IDUzY2FkZDM0YWI5Mjgw ZTIwZjczZjFhMmJhM2JjMTNkMWE1NDE5MzguLmY1YTYxNjRlODMxYzk2ODk5NWUzMzJlZjAyNjlj MGI4YzE4Y2Y5ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1NwZWVjaFJl Y29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvU3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmNw cApAQCAtNzcsOCArNzcsMTMgQEAgdm9pZCBTcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1l TWVkaWFTb3VyY2U6OnN0b3BQcm9kdWNpbmdEYXRhKCkKIAogdm9pZCBTcGVlY2hSZWNvZ25pdGlv blJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2U6OnNldFN0b3JhZ2UoY29uc3QgU2hhcmVkTWVtb3J5 OjpIYW5kbGUmIGhhbmRsZSwgY29uc3QgV2ViQ29yZTo6Q0FBdWRpb1N0cmVhbURlc2NyaXB0aW9u JiBkZXNjcmlwdGlvbiwgdWludDY0X3QgbnVtYmVyT2ZGcmFtZXMpCiB7Ci0gICAgbV9kZXNjcmlw dGlvbiA9IGRlc2NyaXB0aW9uOworICAgIGlmICghbnVtYmVyT2ZGcmFtZXMpIHsKKyAgICAgICAg bV9yaW5nQnVmZmVyID0gbnVsbHB0cjsKKyAgICAgICAgbV9idWZmZXIgPSBudWxscHRyOworICAg ICAgICByZXR1cm47CisgICAgfQogCisgICAgbV9kZXNjcmlwdGlvbiA9IGRlc2NyaXB0aW9uOwog ICAgIG1fcmluZ0J1ZmZlciA9IFdlYkNvcmU6OkNBUmluZ0J1ZmZlcjo6YWRvcHRTdG9yYWdlKG1h a2VVbmlxdWVSZWY8UmVhZE9ubHlTaGFyZWRSaW5nQnVmZmVyU3RvcmFnZT4oaGFuZGxlKSwgZGVz Y3JpcHRpb24sIG51bWJlck9mRnJhbWVzKS5tb3ZlVG9VbmlxdWVQdHIoKTsKICAgICBtX2J1ZmZl ciA9IG1ha2VVbmlxdWU8V2ViQ29yZTo6V2ViQXVkaW9CdWZmZXJMaXN0PihkZXNjcmlwdGlvbik7 CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvU3BlZWNoL1NwZWVjaFJl Y29nbml0aW9uUmVhbHRpbWVNZWRpYVNvdXJjZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1NwZWVjaC9TcGVlY2hSZWNvZ25pdGlvblJlYWx0aW1lTWVkaWFTb3VyY2VNYW5h Z2VyLmNwcAppbmRleCBlMGMyOWMxMDFjNTIyMzAxNDA2YjgxMzczMmYyOTJjZmZjZjRiYTdmLi5i ODFkYmIyM2VmZjQ1MzNhMDcyNTU3ODhhMjZlZWE3YzMzZTA1YWUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvU3BlZWNoL1NwZWVjaFJlY29nbml0aW9uUmVhbHRpbWVNZWRp YVNvdXJjZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9TcGVlY2gv U3BlZWNoUmVjb2duaXRpb25SZWFsdGltZU1lZGlhU291cmNlTWFuYWdlci5jcHAKQEAgLTYzLDcg KzYzLDcgQEAgcHVibGljOgogICAgICAgICAsIG1fc291cmNlKFdURk1vdmUoc291cmNlKSkKICAg ICAgICAgLCBtX2Nvbm5lY3Rpb24oV1RGTW92ZShjb25uZWN0aW9uKSkKICNpZiBQTEFURk9STShD T0NPQSkKLSAgICAgICAgLCBtX3JpbmdCdWZmZXIobWFrZVVuaXF1ZVJlZjxTaGFyZWRSaW5nQnVm ZmVyU3RvcmFnZT4oc3RkOjpiaW5kKCZTb3VyY2U6OnN0b3JhZ2VDaGFuZ2VkLCB0aGlzLCBzdGQ6 OnBsYWNlaG9sZGVyczo6XzEpKSkKKyAgICAgICAgLCBtX3JpbmdCdWZmZXIobWFrZVVuaXF1ZVJl ZjxTaGFyZWRSaW5nQnVmZmVyU3RvcmFnZT4oc3RkOjpiaW5kKCZTb3VyY2U6OnN0b3JhZ2VDaGFu Z2VkLCB0aGlzLCBzdGQ6OnBsYWNlaG9sZGVyczo6XzEsIHN0ZDo6cGxhY2Vob2xkZXJzOjpfMiwg c3RkOjpwbGFjZWhvbGRlcnM6Ol8zKSkpCiAjZW5kaWYKICAgICB7CiAgICAgICAgIG1fc291cmNl LT5hZGRPYnNlcnZlcigqdGhpcyk7CkBAIC0xMTMsOSArMTEzLDcgQEAgcHJpdmF0ZToKICAgICAg ICAgaWYgKG1fZGVzY3JpcHRpb24gIT0gZGVzY3JpcHRpb24pIHsKICAgICAgICAgICAgIEFTU0VS VChkZXNjcmlwdGlvbi5wbGF0Zm9ybURlc2NyaXB0aW9uKCkudHlwZSA9PSBQbGF0Zm9ybURlc2Ny aXB0aW9uOjpDQUF1ZGlvU3RyZWFtQmFzaWNUeXBlKTsKICAgICAgICAgICAgIG1fZGVzY3JpcHRp b24gPSAqc3RkOjpnZXQ8Y29uc3QgQXVkaW9TdHJlYW1CYXNpY0Rlc2NyaXB0aW9uKj4oZGVzY3Jp cHRpb24ucGxhdGZvcm1EZXNjcmlwdGlvbigpLmRlc2NyaXB0aW9uKTsKLQotICAgICAgICAgICAg bV9udW1iZXJPZkZyYW1lcyA9IG1fZGVzY3JpcHRpb24uc2FtcGxlUmF0ZSgpICogMjsKLSAgICAg ICAgICAgIG1fcmluZ0J1ZmZlci5hbGxvY2F0ZShtX2Rlc2NyaXB0aW9uLnN0cmVhbURlc2NyaXB0 aW9uKCksIG1fbnVtYmVyT2ZGcmFtZXMpOworICAgICAgICAgICAgbV9yaW5nQnVmZmVyLmFsbG9j YXRlKG1fZGVzY3JpcHRpb24uc3RyZWFtRGVzY3JpcHRpb24oKSwgbV9kZXNjcmlwdGlvbi5zYW1w bGVSYXRlKCkgKiAyKTsKICAgICAgICAgfQogCiAgICAgICAgIEFTU0VSVChpczxXZWJBdWRpb0J1 ZmZlckxpc3Q+KGF1ZGlvRGF0YSkpOwpAQCAtMTMxLDcgKzEyOSw3IEBAIHByaXZhdGU6CiAKICNp ZiBQTEFURk9STShDT0NPQSkKIAotICAgIHZvaWQgc3RvcmFnZUNoYW5nZWQoU2hhcmVkTWVtb3J5 KiBzdG9yYWdlKQorICAgIHZvaWQgc3RvcmFnZUNoYW5nZWQoU2hhcmVkTWVtb3J5KiBzdG9yYWdl LCBjb25zdCBXZWJDb3JlOjpDQUF1ZGlvU3RyZWFtRGVzY3JpcHRpb24mIGRlc2NyaXB0aW9uLCBz aXplX3QgbnVtYmVyT2ZGcmFtZXMpCiAgICAgewogICAgICAgICBEaXNhYmxlTWFsbG9jUmVzdHJp Y3Rpb25zRm9yQ3VycmVudFRocmVhZFNjb3BlIHNjb3BlOwogICAgICAgICBTaGFyZWRNZW1vcnk6 OkhhbmRsZSBoYW5kbGU7CkBAIC0xNDIsNyArMTQwLDcgQEAgcHJpdmF0ZToKICNlbHNlCiAgICAg ICAgIHVpbnQ2NF90IGRhdGFTaXplID0gMDsKICNlbmRpZgotICAgICAgICBtX2Nvbm5lY3Rpb24t PnNlbmQoTWVzc2FnZXM6OlNwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJj ZU1hbmFnZXI6OlNldFN0b3JhZ2UobV9pZGVudGlmaWVyLCBTaGFyZWRNZW1vcnk6OklQQ0hhbmRs ZSB7IFdURk1vdmUoaGFuZGxlKSwgIGRhdGFTaXplIH0sIG1fZGVzY3JpcHRpb24sIG1fbnVtYmVy T2ZGcmFtZXMpLCAwKTsKKyAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpTcGVl Y2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2VNYW5hZ2VyOjpTZXRTdG9yYWdl KG1faWRlbnRpZmllciwgU2hhcmVkTWVtb3J5OjpJUENIYW5kbGUgeyBXVEZNb3ZlKGhhbmRsZSks ICBkYXRhU2l6ZSB9LCBkZXNjcmlwdGlvbiwgbnVtYmVyT2ZGcmFtZXMpLCAwKTsKICAgICB9CiAK ICNlbmRpZgpAQCAtMTYyLDcgKzE2MCw2IEBAIHByaXZhdGU6CiAgICAgUmVmPElQQzo6Q29ubmVj dGlvbj4gbV9jb25uZWN0aW9uOwogCiAjaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgdWludDY0X3Qg bV9udW1iZXJPZkZyYW1lcyB7IDAgfTsKICAgICBDQVJpbmdCdWZmZXIgbV9yaW5nQnVmZmVyOwog ICAgIENBQXVkaW9TdHJlYW1EZXNjcmlwdGlvbiBtX2Rlc2NyaXB0aW9uIHsgfTsKICNlbmRpZgo= 443722 2021-11-09 13:34:39 -0800 2021-11-09 13:36:57 -0800 [fast-cq] Patch bug-232863-20211109133439.patch text/plain 1168 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdlYzJmNmJhNDhhMjNj ODAwZDkyYWJmM2VkOTc2Yzk0NzI1Y2FjNi4uYzMxZmIzOTYwODU2ZTQyMTI4MTRmZjQyODVlMDMy MjMzMTg5Y2U1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTExLTA5ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBtYWNDYXRhbHlzdCBi dWlsZCBhZnRlciByMjg1NTA5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzI4NjMKKworICAgICAgICBVbnJldmlld2VkLgorCisgICAgICAgICogTW9k dWxlcy9zcGVlY2gvY29jb2EvU3BlZWNoUmVjb2duaXplckNvY29hLm1tOgorCiAyMDIxLTExLTA5 ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgU2Ny b2xsIFRvIFRleHQgRnJhZ21lbnQgZGlyZWN0aXZlIHBhcnNpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL2NvY29hL1NwZWVjaFJlY29nbml6ZXJDb2NvYS5tbSBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL2NvY29hL1NwZWVjaFJlY29nbml6ZXJDb2Nv YS5tbQppbmRleCAzOTJkOWFiNjcxMjdiMDZkMGZkYmY4YWQ0ZjkwZTZjZDk1N2M4NjUzLi5lNTk2 YWI2YmExMzkyNGZmNDU3Yzg0OTZlMTdkYWNjYmM4MGZlMmM1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9jb2NvYS9TcGVlY2hSZWNvZ25pemVyQ29jb2EubW0KKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zcGVlY2gvY29jb2EvU3BlZWNoUmVjb2duaXplckNv Y29hLm1tCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpZiBIQVZFKFNQRUVDSFJFQ09HTklaRVIpCiAK KyNpbXBvcnQgIkF1ZGlvU3RyZWFtRGVzY3JpcHRpb24uaCIKICNpbXBvcnQgIk1lZGlhVXRpbGl0 aWVzLmgiCiAjaW1wb3J0ICJTcGVlY2hSZWNvZ25pdGlvblVwZGF0ZS5oIgogI2ltcG9ydCAiV2Vi U3BlZWNoUmVjb2duaXplclRhc2tNb2NrLmgiCg==