232856 2021-11-08 16:07:17 -0800 format detection applies to DOMParser and interferes with transformations of documents on iOS 2022-08-10 04:33:27 -0700 1 1 1 Unclassified WebKit DOM Safari 15 iPhone / iPad iOS 15 NEW InRadar P2 Normal --- 1 hartman.wiki webkit-unassigned ahmad.saleem792 ap bdakin bfulgham cdumez rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1812905 0 hartman.wiki 2021-11-08 16:07:17 -0800 https://phabricator.wikimedia.org/T116525 We were trying to figure out why the WYSIWYG/HTML editor for Wikipedia kept adding tel: links in places where we had number/year ranges (like for instance 788-7705), and this was pinpointed to iOS Safari, which supports format-detection https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html#//apple_ref/doc/uid/TP40008193-SW5. After disabling this feature with the meta tag in our main document, the problem still occurred. Further investigation made us discover that not only is format-detection applied to the current/primary document, it is applied to ALL documents including ones generated by DOMParser.parseFromString() which our WYSIWYG/HTML editor relies on. When as a developer you parse the DOM, do transformations etc, you should be able to somewhat accurately predict what DOM is being returned and these links being autogenerated are very unexpected honestly, they are not part of the document that was specified. I know we can adapt all documents we feed the parser, but I highly question these iOS features being applied to more than just the primary document and maybe iframes (and lets be honest they are annoying even there). There also is no way to IDENTIFY these auto generated links from normal links (adding an attribute to identify this as custom iOS generate node seems like an easy/quick win). Alternatively, DOMParser could inherit format-detection settings from the main document, or there could be some sort of flag to toggle this behavior in DOMParser without us having to rewrite the entire html blobstring ..... 1813995 1 443941 hartman.wiki 2021-11-11 05:45:43 -0800 Created attachment 443941 testcase 1813998 2 hartman.wiki 2021-11-11 05:53:33 -0800 Added test case, showing the different behaviour on iOS (red) and macOS (green) 1815267 3 webkit-bug-importer 2021-11-15 16:08:54 -0800 <rdar://problem/85433241> 1890257 4 ahmad.saleem792 2022-08-10 04:33:15 -0700 I am able to reproduce this bug in iPhone 13 Pro Max using iOS 15.6 and it shows "Red" compared to "Green" on Safari 15.6 on macOS 12.5. Just wanted to share updated results. Thanks! 443941 2021-11-11 05:45:43 -0800 2021-11-11 05:45:43 -0800 testcase domparser_format_detection.html text/html 1093 hartman.wiki PGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBuYW1lID0gImZvcm1hdC1kZXRlY3Rpb24iIGNvbnRl bnQgPSAidGVsZXBob25lPW5vIj4KICAgIDxzdHlsZT4KICAgICAgYm9keS5wYXNzZWQgewogICAg ICAgIGJhY2tncm91bmQ6Z3JlZW47CiAgICAgIH0KICAgICAgYm9keS5mYWlsZWQgewogICAgICAg IGJhY2tncm91bmQ6cmVkOwogICAgICB9CiAgICA8L3N0eWxlPgogIDwvaGVhZD4KICA8Ym9keT4K ICAgICAgPHA+VGVzdGNhc2Ugb2YgZm9ybWF0IGRldGVjdGlvbiBhcHBseWluZyBET01QYXJzZXIu cGFyc2VGcm9tU3RyaW5nKCkgdG8gZXZlbiBpZiB0aGUgcGFyZW50IGRvY3VtZW50IGhhcyBpdCBk aXNhYmxlZDwvcD4KICAgIDxwPgogICAgICBUaGUgZm9sbG93aW5nIGZyYWdtZW50IHdhcyBwYXJz ZWQgc2VwYXJhdGVseSBhbmQgYWRkZWQgdG8gdGhpcyBkb2N1bWVudCBhcyB2aXN1YWwgY2hlY2s6 CiAgICA8L3A+CiAgICA8c2NyaXB0PgogICAgZnVuY3Rpb24gdGVzdCAoKSB7CiAgICAgIGNvbnN0 IG5ld0h0bWwgPSBgCiAgICAgIDxodG1sPgogICAgICAgIDxib2R5PgogICAgICAgIDxwPkNhbGwg dXMgbm93OiA1NTUtMTIzNDwvcD4KICAgICAgICA8L2JvZHk+CiAgICAgIDwvaHRtbD5gCiAgICAg IGNvbnN0IGRvbVBhcnNlciA9IG5ldyBET01QYXJzZXIoKTsKICAgICAgY29uc3QgbmV3RG9jdW1l bnQgPSBkb21QYXJzZXIucGFyc2VGcm9tU3RyaW5nKG5ld0h0bWwsICd0ZXh0L2h0bWwnKQogICAg ICBjb25zdCBsaW5rcyA9IG5ld0RvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoJ2FbaHJlZl49InRl bDoiXScpCiAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoIG5ld0RvY3VtZW50LmJvZHku Y2hpbGRyZW5bMF0gKTsKICAgICAgaWYgKGxpbmtzLmxlbmd0aCA+IDApIHsKICAgICAgICBkb2N1 bWVudC5ib2R5LmNsYXNzTmFtZSA9ICdmYWlsZWQnOwogICAgICAgIGNvbnNvbGUuZXJyb3IoJ2Zh aWxlZCcpOwogICAgICAgIHJldHVybjsKICAgICAgfQogICAgICBkb2N1bWVudC5ib2R5LmNsYXNz TmFtZSA9ICdwYXNzZWQnOwogICAgfQoKICAgIHRlc3QoKTsKICAgIDwvc2NyaXB0PgogIDwvYm9k eT4KPC9odG1sPg==