232830 2021-11-08 12:02:51 -0800 Re-use isCSSWideKeyword in CSSVariableParser.cpp & CSSPropertyParser.cpp 2021-11-09 14:18:07 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224816 1 ntim ntim darin esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto macpherson menard webkit-bug-importer oldest_to_newest 1812749 0 ntim 2021-11-08 12:02:51 -0800 Sub-set of bug 224816 1812751 1 443584 ntim 2021-11-08 12:09:20 -0800 Created attachment 443584 Patch 1813005 2 443584 koivisto 2021-11-08 23:46:53 -0800 Comment on attachment 443584 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443584&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 > - CSSValueID id = m_range.peek().id(); > - if (id == CSSValueInherit || id == CSSValueInitial || id == CSSValueRevert) > + if (isCSSWideKeyword(m_range.peek().id())) Can we make a test for this? 1813009 3 ntim 2021-11-09 00:12:16 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 443584 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443584&action=review > > > Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 > > - CSSValueID id = m_range.peek().id(); > > - if (id == CSSValueInherit || id == CSSValueInitial || id == CSSValueRevert) > > + if (isCSSWideKeyword(m_range.peek().id())) > > Can we make a test for this? I don't see any easily extendable test in https://github.com/web-platform-tests/wpt/tree/master/css/css-properties-values-api unfortunately, or similar test for the matter. 1813010 4 ews-feeder 2021-11-09 00:16:00 -0800 Committed r285483 (244007@main): <https://commits.webkit.org/244007@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443584. 1813011 5 webkit-bug-importer 2021-11-09 00:17:21 -0800 <rdar://problem/85191933> 1813330 6 443584 darin 2021-11-09 14:18:07 -0800 Comment on attachment 443584 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443584&action=review >>> Source/WebCore/css/parser/CSSPropertyParser.cpp:4568 >>> + if (isCSSWideKeyword(m_range.peek().id())) >> >> Can we make a test for this? > > I don't see any easily extendable test in https://github.com/web-platform-tests/wpt/tree/master/css/css-properties-values-api unfortunately, or similar test for the matter. Is this a behavior change, because we now check for "unset" as well? But not testable? 443584 2021-11-08 12:09:20 -0800 2021-11-09 00:16:02 -0800 Patch bug-232830-20211108200918.patch text/plain 2499 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY2YWIyYjIwMTg0NmQ1 MTJlMDRlODM0YzU3Mjk0ODYxNTQ0ZTY3ZC4uYzE3MmRmZWEwNjdmZGQwNjY3MTVkOWExNGJmZTM4 MDg0OTczNjZiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTExLTA4ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmUtdXNlIGlzQ1NTV2lkZUtleXdv cmQgaW4gQ1NTVmFyaWFibGVQYXJzZXIuY3BwICYgQ1NTUHJvcGVydHlQYXJzZXIuY3BwCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI4MzAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9wYXJzZXIv Q1NTUHJvcGVydHlQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJvcGVydHlQYXJz ZXI6OmNhblBhcnNlVHlwZWRDdXN0b21Qcm9wZXJ0eVZhbHVlKToKKyAgICAgICAgKiBjc3MvcGFy c2VyL0NTU1ZhcmlhYmxlUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNsYXNzaWZ5VmFy aWFibGVSYW5nZSk6CisKIDIwMjEtMTEtMDggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjg1NDA4LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAppbmRleCAy MzYzZjQ3ZGU3MjhiMjFiMzhkZWZiZTEyMGM4MTMyN2RiNWNhYjY0Li4xMTZlZDc2MmI2ZDc3ZjQ2 NDBmZjc3OTYyOTIxOWI2ZmExYTFjNDI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv cGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFy c2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcApAQCAtNDU2NSw4ICs0NTY1LDcgQEAgYm9vbCBDU1NQ cm9wZXJ0eVBhcnNlcjo6Y2FuUGFyc2VUeXBlZEN1c3RvbVByb3BlcnR5VmFsdWUoY29uc3QgU3Ry aW5nJiBzeW50YXgpCiAgICAgICAgIG1fcmFuZ2UuY29uc3VtZVdoaXRlc3BhY2UoKTsKIAogICAg ICAgICAvLyBGaXJzdCBjaGVjayBmb3Iga2V5d29yZHMKLSAgICAgICAgQ1NTVmFsdWVJRCBpZCA9 IG1fcmFuZ2UucGVlaygpLmlkKCk7Ci0gICAgICAgIGlmIChpZCA9PSBDU1NWYWx1ZUluaGVyaXQg fHwgaWQgPT0gQ1NTVmFsdWVJbml0aWFsIHx8IGlkID09IENTU1ZhbHVlUmV2ZXJ0KQorICAgICAg ICBpZiAoaXNDU1NXaWRlS2V5d29yZChtX3JhbmdlLnBlZWsoKS5pZCgpKSkKICAgICAgICAgICAg IHJldHVybiB0cnVlOwogCiAgICAgICAgIGF1dG8gbG9jYWxSYW5nZSA9IG1fcmFuZ2U7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1ZhcmlhYmxlUGFyc2VyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTVmFyaWFibGVQYXJzZXIuY3BwCmluZGV4IDkz Yzc4NmQ2MzlmNGU3NzgzMTk1NGZhNDcyMDQ3MTFlYmEzNzA5N2MuLmI1NTE3NjE2OTllZWRlYTQw Y2FkNzEwYjFjY2E4ZTkyY2NhZmZiYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9w YXJzZXIvQ1NTVmFyaWFibGVQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJz ZXIvQ1NTVmFyaWFibGVQYXJzZXIuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAKICNpbmNsdWRlICJD U1NDdXN0b21Qcm9wZXJ0eVZhbHVlLmgiCiAjaW5jbHVkZSAiQ1NTUGFyc2VyQ29udGV4dC5oIgor I2luY2x1ZGUgIkNTU1BhcnNlcklkaW9tcy5oIgogI2luY2x1ZGUgIkNTU1BhcnNlclRva2VuUmFu Z2UuaCIKICNpbmNsdWRlICJDU1NQcm9wZXJ0eVBhcnNlckhlbHBlcnMuaCIKIApAQCAtMTYxLDcg KzE2Miw3IEBAIHN0YXRpYyBDU1NWYWx1ZUlEIGNsYXNzaWZ5VmFyaWFibGVSYW5nZShDU1NQYXJz ZXJUb2tlblJhbmdlIHJhbmdlLCBib29sJiBoYXNSZWZlCiAgICAgcmFuZ2UuY29uc3VtZVdoaXRl c3BhY2UoKTsKICAgICBpZiAocmFuZ2UucGVlaygpLnR5cGUoKSA9PSBJZGVudFRva2VuKSB7CiAg ICAgICAgIENTU1ZhbHVlSUQgaWQgPSByYW5nZS5jb25zdW1lSW5jbHVkaW5nV2hpdGVzcGFjZSgp LmlkKCk7Ci0gICAgICAgIGlmIChyYW5nZS5hdEVuZCgpICYmIChpZCA9PSBDU1NWYWx1ZUluaGVy aXQgfHwgaWQgPT0gQ1NTVmFsdWVJbml0aWFsIHx8IGlkID09IENTU1ZhbHVlVW5zZXQgfHwgaWQg PT0gQ1NTVmFsdWVSZXZlcnQpKQorICAgICAgICBpZiAocmFuZ2UuYXRFbmQoKSAmJiBpc0NTU1dp ZGVLZXl3b3JkKGlkKSkKICAgICAgICAgICAgIHJldHVybiBpZDsKICAgICB9CiAK