23279 2009-01-12 15:53:30 -0800 [GTK] fix crash after WebView dispose 2009-01-13 11:57:47 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 a.butenka webkit-unassigned oldest_to_newest 105415 0 a.butenka 2009-01-12 15:53:30 -0800 Bug is related to #23194. The WebCore::Page is deleted by the dispose implementation and webkit_web_view_set_scroll_adjustments() doesn't check is Page still exist. Mischeck leads to a crash sometimes. 105416 1 26653 a.butenka 2009-01-12 15:58:24 -0800 Created attachment 26653 patch 105474 2 zecke 2009-01-13 03:35:45 -0800 Looks good. I have this as well: @@ -883,6 +887,9 @@ static gboolean webkit_navigation_request_handled(GSignalInvocationHint* ihint, static AtkObject* webkit_web_view_get_accessible(GtkWidget* widget) { WebKitWebView* webView = WEBKIT_WEB_VIEW(widget); + if (!core(webView)) + return NULL; + 105482 3 26653 zecke 2009-01-13 06:29:11 -0800 Comment on attachment 26653 patch I will land this with the atk hunk from the comments. there was mutual agreement on #webkit-gtk on this issue. 105541 4 zecke 2009-01-13 11:57:47 -0800 Landed in r39855. 26653 2009-01-12 15:58:24 -0800 2009-01-13 06:29:11 -0800 patch webkit_web_view_set_scroll_adjustments_crashfix.patch text/plain 1053 a.butenka SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAzOTg0MikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMTIgIEFsZXhhbmRlciBWLiBCdXRlbmtv ICA8YWxleEBkaWdpcXViZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz Mjc5CisKKyAgICAgICAgRml4IGNyYXNoIG9uIFdlYlZpZXcgZGlzcG9zZSBzdGFnZQorCisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorCiAyMDA5LTAxLTExICBYYW4gTG9wZXog IDx4YW5AZ25vbWUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4K SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAzOTgzMCkKKysr IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 MDEsNiArNjAxLDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3JlYWxpemUoR3RrVwog CiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0X3Njcm9sbF9hZGp1c3RtZW50cyhXZWJL aXRXZWJWaWV3KiB3ZWJWaWV3LCBHdGtBZGp1c3RtZW50KiBoYWRqLCBHdGtBZGp1c3RtZW50KiB2 YWRqKQogeworICAgIGlmICghY29yZSh3ZWJWaWV3KSkKKwkgcmV0dXJuOworCiAgICAgRnJhbWVW aWV3KiB2aWV3ID0gY29yZSh3ZWJraXRfd2ViX3ZpZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldykp LT52aWV3KCk7CiAKICAgICBpZiAoaGFkaikK