23277 2009-01-12 14:55:06 -0800 space bar scrolls the page when typed in any text field 2009-03-02 16:03:51 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All Windows Vista RESOLVED FIXED InRadar P1 Normal --- 1 alice.barraclough darin mad mario.bensi oldest_to_newest 105399 0 alice.barraclough 2009-01-12 14:55:06 -0800 pressing the space bar in a text field ends up scrolling the page instead of entering a space. steps to repro: 1) any textfield should work, but i noticed this on gmail login page (resize window to have scrollbars) 2) type space! This reproduces with revision 39773, and I suspect http://trac.webkit.org/changeset/39771 to be the cause <rdar://problem/6490249> 105414 1 26652 darin 2009-01-12 15:51:22 -0800 Created attachment 26652 patch 105497 2 darin 2009-01-13 08:58:16 -0800 I'll have this fixed in a few minutes. I've figured it out, but I'm taking the time to write a regression test. 105507 3 26671 darin 2009-01-13 09:45:30 -0800 Created attachment 26671 patch 105519 4 darin 2009-01-13 10:00:20 -0800 http://trac.webkit.org/changeset/39864 111923 5 mad 2009-03-02 16:03:51 -0800 This fix introduced a new bug (found using Chromium "http://crbug.com/7112") that also reproduces with a recent version of WebKit without Chromium. So I created a new bug for it on the WebKit side: https://bugs.webkit.org/show_bug.cgi?id=24304 26652 2009-01-12 15:51:22 -0800 2009-01-13 09:45:30 -0800 patch SpaceBarPatch.txt text/plain 1779 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTg0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMTIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy MzI3Nzogc3BhY2UgYmFyIHNjcm9sbHMgdGhlIHBhZ2Ugd2hlbiB0eXBlZCBpbiBhbnkgdGV4dCBm aWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMy NzcKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNjQ5MDI0OQorCisgICAgICAgICogcGFnZS9FdmVu dEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpkZWZhdWx0S2V5 Ym9hcmRFdmVudEhhbmRsZXIpOiBIYW5kbGUgdGhlIGtleXByZXNzIGV2ZW50LCBub3QgdGhlCisg ICAgICAgIGtleWRvd24gZXZlbnQuCisKIDIwMDktMDEtMTIgIEtldmluIE9sbGl2aWVyICA8a2V2 aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgd3ggYnVpbGQgdHlwbyBmaXguCkluZGV4 OiBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcAkocmV2aXNpb24gMzk4NDIpCisrKyBXZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg3NywxMSArMTg3Nyw4IEBAIHZvaWQg RXZlbnRIYW5kbGVyOjpkZWZhdWx0S2V5Ym9hcmRFdmVudEgKICAgICAgICAgbV9mcmFtZS0+ZWRp dG9yKCktPmhhbmRsZUtleWJvYXJkRXZlbnQoZXZlbnQpOwogICAgICAgICBpZiAoZXZlbnQtPmRl ZmF1bHRIYW5kbGVkKCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIGNvbnN0IFN0cmlu ZyYga2V5SWRlbnRpZmllciA9IGV2ZW50LT5rZXlJZGVudGlmaWVyKCk7Ci0gICAgICAgIGlmIChr ZXlJZGVudGlmaWVyID09ICJVKzAwMDkiKQorICAgICAgICBpZiAoZXZlbnQtPmtleUlkZW50aWZp ZXIoKSA9PSAiVSswMDA5IikKICAgICAgICAgICAgIGRlZmF1bHRUYWJFdmVudEhhbmRsZXIoZXZl bnQpOwotICAgICAgICBlbHNlIGlmIChrZXlJZGVudGlmaWVyID09ICJVKzAwMjAiKQotICAgICAg ICAgICAgZGVmYXVsdFNwYWNlRXZlbnRIYW5kbGVyKGV2ZW50KTsKIAogICAgICAgIC8vIHByb3Zp ZGVzIEtCIG5hdmlnYXRpb24gYW5kIHNlbGVjdGlvbiBmb3IgZW5oYW5jZWQgYWNjZXNzaWJpbGl0 eSB1c2VycwogICAgICAgIGlmIChBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5oYW5jZWRV c2VySW50ZXJmYWNlRW5hYmxlZCgpKQpAQCAtMTg5MSw2ICsxODg4LDggQEAgdm9pZCBFdmVudEhh bmRsZXI6OmRlZmF1bHRLZXlib2FyZEV2ZW50SAogICAgICAgICBtX2ZyYW1lLT5lZGl0b3IoKS0+ aGFuZGxlS2V5Ym9hcmRFdmVudChldmVudCk7CiAgICAgICAgIGlmIChldmVudC0+ZGVmYXVsdEhh bmRsZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgaWYgKGV2ZW50LT5jaGFyQ29k ZSgpID09ICcgJykKKyAgICAgICAgICAgIGRlZmF1bHRTcGFjZUV2ZW50SGFuZGxlcihldmVudCk7 CiAgICB9CiB9CiAK 26671 2009-01-13 09:45:30 -0800 2009-01-13 09:56:35 -0800 patch SpaceBarPatch.txt text/plain 4252 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTg2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDktMDEtMTMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy MzI3Nzogc3BhY2UgYmFyIHNjcm9sbHMgdGhlIHBhZ2Ugd2hlbiB0eXBlZCBpbiBhbnkgdGV4dCBm aWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMy NzcKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNjQ5MDI0OQorCisgICAgICAgIFRoZXJlJ3MgYWxy ZWFkeSBhIHJlZ3Jlc3Npb24gdGVzdCBmb3IgdGhpcywgc2luY2UgYnVnIDE2NDIxIHdhcyB0aGUg c2FtZSBwcm9ibGVtLAorICAgICAgICBidXQgb24gTWFjIE9TIFguIFRoZSByZWdyZXNzaW9uIHRl c3QgaXMgZmFzdC9ldmVudHMvc3BhY2Utc2Nyb2xsLWV2ZW50Lmh0bWwsIHNvIEkKKyAgICAgICAg d29uJ3Qgd3JpdGUgYSBuZXcgb25lLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVUZXh0SW5wdXRFdmVudCk6 IFJldHVybiB3aGV0aGVyIHRoZSBldmVudCdzIGRlZmF1bHQgd2FzCisgICAgICAgIGhhbmRsZWQs IG5vdCB0aGUgcmVzdWx0IG9mIHRoZSBkaXNwYXRjaEV2ZW50IGZ1bmN0aW9uLCB3aGljaCBpbmRp Y2F0ZXMgb25seSB3aGV0aGVyIHRoZQorICAgICAgICBkZWZhdWx0IGJlaGF2aW9yIHdhcyBwcmV2 ZW50ZWQsIG5vdCBpZiB0aGUgZGVmYXVsdCBiZWhhdmlvciBkaWQgc29tZSBpbnNlcnRpb24uIFRo aXMgZml4CisgICAgICAgIG1ha2VzIGl0IHNvIHRoZSBrZXlib2FyZCBldmVudCBoYW5kbGVyIGNh biBkZXRlY3QgdGhhdCBubyBzcGFjZSB3YXMgaW5zZXJ0ZWQgYW5kIGtub3cgdGhhdAorICAgICAg ICB0aGUgc3BhY2UgYmFyIGtleXByZXNzIGV2ZW50IGNhbiBiZSB0cmVhdGVkIGFzIGEgc2Nyb2xs aW5nIGNvbW1hbmQuCisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmRlZmF1bHRLZXli b2FyZEV2ZW50SGFuZGxlcik6IEhhbmRsZSB0aGUga2V5cHJlc3MgZXZlbnQsIG5vdCB0aGUKKyAg ICAgICAga2V5ZG93biBldmVudC4gV2l0aG91dCB0aGUgY2hhbmdlIGFib3ZlLCBtYWtpbmcgdGhp cyBjaGFuZ2Ugd291bGQgaGF2ZSByZXN0b3JlZCB0aGUgb2xkCisgICAgICAgIGJlaGF2aW9yLCBy ZWludHJvZHVjaW5nIGJ1ZyAyMjkxMyB3aGVyZSB0aGUgc3BhY2UgYmFyIGRvZXNuJ3Qgc2Nyb2xs IGF0IGFsbCBvbiBXaW5kb3dzLgorCiAyMDA5LTAxLTEzICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBX ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcAkocmV2aXNpb24gMzk4NjIpCisrKyBXZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg3NywxMSArMTg3Nyw4IEBAIHZvaWQgRXZl bnRIYW5kbGVyOjpkZWZhdWx0S2V5Ym9hcmRFdmVudEgKICAgICAgICAgbV9mcmFtZS0+ZWRpdG9y KCktPmhhbmRsZUtleWJvYXJkRXZlbnQoZXZlbnQpOwogICAgICAgICBpZiAoZXZlbnQtPmRlZmF1 bHRIYW5kbGVkKCkpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIGNvbnN0IFN0cmluZyYg a2V5SWRlbnRpZmllciA9IGV2ZW50LT5rZXlJZGVudGlmaWVyKCk7Ci0gICAgICAgIGlmIChrZXlJ ZGVudGlmaWVyID09ICJVKzAwMDkiKQorICAgICAgICBpZiAoZXZlbnQtPmtleUlkZW50aWZpZXIo KSA9PSAiVSswMDA5IikKICAgICAgICAgICAgIGRlZmF1bHRUYWJFdmVudEhhbmRsZXIoZXZlbnQp OwotICAgICAgICBlbHNlIGlmIChrZXlJZGVudGlmaWVyID09ICJVKzAwMjAiKQotICAgICAgICAg ICAgZGVmYXVsdFNwYWNlRXZlbnRIYW5kbGVyKGV2ZW50KTsKIAogICAgICAgIC8vIHByb3ZpZGVz IEtCIG5hdmlnYXRpb24gYW5kIHNlbGVjdGlvbiBmb3IgZW5oYW5jZWQgYWNjZXNzaWJpbGl0eSB1 c2VycwogICAgICAgIGlmIChBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5oYW5jZWRVc2Vy SW50ZXJmYWNlRW5hYmxlZCgpKQpAQCAtMTg5MSw2ICsxODg4LDggQEAgdm9pZCBFdmVudEhhbmRs ZXI6OmRlZmF1bHRLZXlib2FyZEV2ZW50SAogICAgICAgICBtX2ZyYW1lLT5lZGl0b3IoKS0+aGFu ZGxlS2V5Ym9hcmRFdmVudChldmVudCk7CiAgICAgICAgIGlmIChldmVudC0+ZGVmYXVsdEhhbmRs ZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgaWYgKGV2ZW50LT5jaGFyQ29kZSgp ID09ICcgJykKKyAgICAgICAgICAgIGRlZmF1bHRTcGFjZUV2ZW50SGFuZGxlcihldmVudCk7CiAg ICB9CiB9CiAKQEAgLTIwODYsMTcgKzIwODUsMTUgQEAgY2xlYW51cERyYWc6CiAgICAgcmV0dXJu IHRydWU7CiB9CiAgIAotYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVRleHRJbnB1dEV2ZW50KGNv bnN0IFN0cmluZyYgdGV4dCwgRXZlbnQqIHVuZGVybHlpbmdFdmVudCwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGlzTGluZUJyZWFrLCBib29sIGlzQmFja1Rh YikKK2Jvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVUZXh0SW5wdXRFdmVudChjb25zdCBTdHJpbmcm IHRleHQsIEV2ZW50KiB1bmRlcmx5aW5nRXZlbnQsIGJvb2wgaXNMaW5lQnJlYWssIGJvb2wgaXNC YWNrVGFiKQogewotICAgIGlmICghbV9mcmFtZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotI2lm bmRlZiBOREVCVUcKICAgICAvLyBQbGF0Zm9ybXMgc2hvdWxkIGRpZmZlcmVudGlhdGUgcmVhbCBj b21tYW5kcyBsaWtlIHNlbGVjdEFsbCBmcm9tIHRleHQgaW5wdXQgaW4gZGlzZ3Vpc2UgKGxpa2Ug aW5zZXJ0TmV3bGluZSksCiAgICAgLy8gYW5kIGF2b2lkIGRpc3BhdGNoaW5nIHRleHQgaW5wdXQg ZXZlbnRzIGZyb20ga2V5ZG93biBkZWZhdWx0IGhhbmRsZXJzLgotICAgIGlmICh1bmRlcmx5aW5n RXZlbnQgJiYgdW5kZXJseWluZ0V2ZW50LT5pc0tleWJvYXJkRXZlbnQoKSkKLSAgICAgICAgQVNT RVJUKHN0YXRpY19jYXN0PEtleWJvYXJkRXZlbnQqPih1bmRlcmx5aW5nRXZlbnQpLT50eXBlKCkg PT0gZXZlbnROYW1lcygpLmtleXByZXNzRXZlbnQpOwotI2VuZGlmCisgICAgQVNTRVJUKCF1bmRl cmx5aW5nRXZlbnQgfHwgIXVuZGVybHlpbmdFdmVudC0+aXNLZXlib2FyZEV2ZW50KCkgfHwgc3Rh dGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KHVuZGVybHlpbmdFdmVudCktPnR5cGUoKSA9PSBldmVu dE5hbWVzKCkua2V5cHJlc3NFdmVudCk7CisKKyAgICBpZiAoIW1fZnJhbWUpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKwogICAgIEV2ZW50VGFyZ2V0KiB0YXJnZXQ7CiAgICAgaWYgKHVuZGVybHlp bmdFdmVudCkKICAgICAgICAgdGFyZ2V0ID0gdW5kZXJseWluZ0V2ZW50LT50YXJnZXQoKTsKQEAg LTIxMDQsMTIgKzIxMDEsMTQgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVRleHRJbnB1dEV2 ZW50KAogICAgICAgICB0YXJnZXQgPSBldmVudFRhcmdldE5vZGVGb3JEb2N1bWVudChtX2ZyYW1l LT5kb2N1bWVudCgpKTsKICAgICBpZiAoIXRhcmdldCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwor CiAgICAgUmVmUHRyPFRleHRFdmVudD4gZXZlbnQgPSBUZXh0RXZlbnQ6OmNyZWF0ZShtX2ZyYW1l LT5kb21XaW5kb3coKSwgdGV4dCk7CiAgICAgZXZlbnQtPnNldFVuZGVybHlpbmdFdmVudCh1bmRl cmx5aW5nRXZlbnQpOwogICAgIGV2ZW50LT5zZXRJc0xpbmVCcmVhayhpc0xpbmVCcmVhayk7CiAg ICAgZXZlbnQtPnNldElzQmFja1RhYihpc0JhY2tUYWIpOwogICAgIEV4Y2VwdGlvbkNvZGUgZWM7 Ci0gICAgcmV0dXJuIHRhcmdldC0+ZGlzcGF0Y2hFdmVudChldmVudC5yZWxlYXNlKCksIGVjKTsK KyAgICB0YXJnZXQtPmRpc3BhdGNoRXZlbnQoZXZlbnQsIGVjKTsKKyAgICByZXR1cm4gZXZlbnQt PmRlZmF1bHRIYW5kbGVkKCk7CiB9CiAgICAgCiAgICAgCg==