232766 2021-11-05 14:44:49 -0700 Lookup for text would not show after clicking the page and using key commands to launch. 2021-11-05 21:49:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner ews-watchlist mifenton thorton wenson_hsieh oldest_to_newest 1812244 0 megan_gardner 2021-11-05 14:44:49 -0700 Lookup for text would not show after clicking the page and using key commands to launch. 1812249 1 443440 megan_gardner 2021-11-05 15:00:52 -0700 Created attachment 443440 Patch 1812251 2 megan_gardner 2021-11-05 15:01:19 -0700 rdar://74562619 1812253 3 443440 wenson_hsieh 2021-11-05 15:03:48 -0700 Comment on attachment 443440 Patch r=mews 1812285 4 443440 thorton 2021-11-05 16:02:01 -0700 Comment on attachment 443440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443440&action=review > Source/WebCore/ChangeLog:13 > + The solution was to set ignoreSelectionChanges on the temporary selection, and also to stop propagating temporary selection changes to accessibly, as "accessibly" -> accessibility > Source/WebCore/ChangeLog:14 > + that should not be necessary and that is the code that cause a sync message to be sent to the UI process while it was sync awaiting our reply for the might be good to mention the name of the outgoing message (maybe just in the bug, or here) for posterity's sake. 1812344 5 443475 megan_gardner 2021-11-05 21:22:23 -0700 Created attachment 443475 Patch for landing 1812348 6 ews-feeder 2021-11-05 21:49:55 -0700 Committed r285365 (243923@main): <https://commits.webkit.org/243923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443475. 443440 2021-11-05 15:00:52 -0700 2021-11-05 21:22:20 -0700 Patch bug-232766-20211105170048.patch text/plain 3305 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFkZGVhNjQ0ZTk3ZGYw OGViZWQzYmI2OTEzMTQyNDAzODNmOTExNS4uMGJjNzhhYjQ1Zjk1Y2VlMGE1ZGEzZjAyNDczYTVk Y2FlM2IwYjg1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTExLTA1ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgTG9va3VwIGZv ciB0ZXh0IHdvdWxkIG5vdCBzaG93IGFmdGVyIGNsaWNraW5nIHRoZSBwYWdlIGFuZCB1c2luZyBr ZXkgY29tbWFuZHMgdG8gbGF1bmNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjMyNzY2CisgICAgICAgIHJkYXI6Ly83NDU2MjYxOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdHJpZ2dlcmluZyB0 aGUgbG9va3VwIGNvbW1hbmQgd2l0aCBjb21tYW5kLWNvbnRyb2wtRCBvciB0aGUgdHJpcGxlIGZp bmdlciB0YXAgb24gbWFjLCBpZiB5b3UgaGF2ZSBwcmV2aW91c2x5CisgICAgICAgIGNsaWNrZWQg dGhlIHBhZ2UsIHRoZSBsb29rdXAgd291bGQgdGltZSBvdXQgYW5kIHRoZSBwb3BvdmVyIHdvdWxk IG5ldmVyIHNob3cuIFRoaXMgd2FzIGJlY2F1c2UgYWZ0ZXIgY2xpY2tpbmcgb24gdGhlIHBhZ2Us IAorICAgICAgICBhbiBpbnZpc2libGUgY2FyZXQgc2VsZWN0aW9uIHdvdWxkIGV4aXN0LCB3aGlj aCB3b3VsZCBjaGFuZ2UgdGhlIHBhdGggdGFrZW4gZm9yIGhpZ2hsaWdodGluZyBhbmQgdGVtcG9y YXJpbHkgc2VsZWN0aW5nIHRleHQgdG8gCisgICAgICAgIGJlIHNlbnQgdG8gZGF0YSBkZXRlY3Rv cnMuIAorICAgICAgICBUaGUgc29sdXRpb24gd2FzIHRvIHNldCBpZ25vcmVTZWxlY3Rpb25DaGFu Z2VzIG9uIHRoZSB0ZW1wb3Jhcnkgc2VsZWN0aW9uLCBhbmQgYWxzbyB0byBzdG9wIHByb3BhZ2F0 aW5nIHRlbXBvcmFyeSBzZWxlY3Rpb24gY2hhbmdlcyB0byBhY2Nlc3NpYmx5LCBhcyAKKyAgICAg ICAgdGhhdCBzaG91bGQgbm90IGJlIG5lY2Vzc2FyeSBhbmQgdGhhdCBpcyB0aGUgY29kZSB0aGF0 IGNhdXNlIGEgc3luYyBtZXNzYWdlIHRvIGJlIHNlbnQgdG8gdGhlIFVJIHByb2Nlc3Mgd2hpbGUg aXQgd2FzIHN5bmMgYXdhaXRpbmcgb3VyIHJlcGx5IGZvciB0aGUKKyAgICAgICAgb3JpZ2luYWwg cmVxdWVzdCBmb3IgZGF0YSBkZXRlY3RvcnMuCisKKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBbmRS ZXZlYWxTZWxlY3Rpb24pOgorICAgICAgICAqIHBhZ2UvVGV4dEluZGljYXRvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpUZXh0SW5kaWNhdG9yOjpjcmVhdGVXaXRoUmFuZ2UpOgorCiAyMDIxLTEx LTAzICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFdL QWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3RNYWMubW0gc2hvdWxkIGV4cG9zZSBhY2Nlc3NpYmls aXR5Q2hpbGRyZW5Jbk5hdmlnYXRpb25PcmRlciBhbmQgTlNBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5J bk5hdmlnYXRpb25PcmRlckF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9GcmFtZVNlbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmNwcAppbmRleCA2NWUxNWI3MmJlYWY2OTg5YjExYWIzYTk1NmU0NTY1MmM5ODI0N2Yw Li4zMGZjZDMwZjRkZjY1MTFlOTYyYjFiZjFlZTlmZWNmOWMwZGM5OTYzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcApAQCAtNDk4LDggKzQ5OCw4IEBAIHZvaWQg RnJhbWVTZWxlY3Rpb246OnVwZGF0ZUFuZFJldmVhbFNlbGVjdGlvbihjb25zdCBBWFRleHRTdGF0 ZUNoYW5nZUludGVudCYgaW50CiAKICAgICAgICAgcmV2ZWFsU2VsZWN0aW9uKG1fc2VsZWN0aW9u UmV2ZWFsTW9kZSwgYWxpZ25tZW50LCByZXZlYWxFeHRlbnQsIHNjcm9sbEJlaGF2aW9yKTsKICAg ICB9Ci0KLSAgICBub3RpZnlBY2Nlc3NpYmlsaXR5Rm9yU2VsZWN0aW9uQ2hhbmdlKGludGVudCk7 CisgICAgaWYgKCFtX2RvY3VtZW50LT5lZGl0b3IoKS5pZ25vcmVTZWxlY3Rpb25DaGFuZ2VzKCkp CisgICAgICAgIG5vdGlmeUFjY2Vzc2liaWxpdHlGb3JTZWxlY3Rpb25DaGFuZ2UoaW50ZW50KTsK IH0KIAogdm9pZCBGcmFtZVNlbGVjdGlvbjo6dXBkYXRlRGF0YURldGVjdG9yc0ZvclNlbGVjdGlv bigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcAppbmRleCBkNmZiNzNiNjYxYjA3 MWY3M2I0MzJiNTBjMTJkNDhhM2JiNDg2NzhiLi5kMjYwZDExYTg0NWEyN2NjYWIyYTcyOGRlM2Q0 MTBjODYzZjc3ZTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0 b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dEluZGljYXRvci5jcHAKQEAgLTgx LDggKzgxLDggQEAgUmVmUHRyPFRleHRJbmRpY2F0b3I+IFRleHRJbmRpY2F0b3I6OmNyZWF0ZVdp dGhSYW5nZShjb25zdCBTaW1wbGVSYW5nZSYgcmFuZ2UsIE8KIAogICAgIE9wdGlvblNldDxUZW1w b3JhcnlTZWxlY3Rpb25PcHRpb24+IHRlbXBvcmFyeVNlbGVjdGlvbk9wdGlvbnM7CiAgICAgdGVt cG9yYXJ5U2VsZWN0aW9uT3B0aW9ucy5hZGQoVGVtcG9yYXJ5U2VsZWN0aW9uT3B0aW9uOjpEb05v dFNldEZvY3VzKTsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogICAgIHRlbXBvcmFyeVNlbGVj dGlvbk9wdGlvbnMuYWRkKFRlbXBvcmFyeVNlbGVjdGlvbk9wdGlvbjo6SWdub3JlU2VsZWN0aW9u Q2hhbmdlcyk7CisjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICB0ZW1wb3JhcnlTZWxlY3Rp b25PcHRpb25zLmFkZChUZW1wb3JhcnlTZWxlY3Rpb25PcHRpb246OkVuYWJsZUFwcGVhcmFuY2VV cGRhdGVzKTsKICNlbmRpZgogICAgIFRlbXBvcmFyeVNlbGVjdGlvbkNoYW5nZSBzZWxlY3Rpb25D aGFuZ2UoKmRvY3VtZW50LCB7IHJhbmdlIH0sIHRlbXBvcmFyeVNlbGVjdGlvbk9wdGlvbnMpOwo= 443475 2021-11-05 21:22:23 -0700 2021-11-05 21:49:56 -0700 Patch for landing bug-232766-20211105232222.patch text/plain 3393 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFkZGVhNjQ0ZTk3ZGYw OGViZWQzYmI2OTEzMTQyNDAzODNmOTExNS4uNjRmMDAyNDBmZWY0M2M1MDc1MjY2YjE5YWRlYTk2 MGZkYWQ0NDVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTExLTA1ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgTG9va3VwIGZv ciB0ZXh0IHdvdWxkIG5vdCBzaG93IGFmdGVyIGNsaWNraW5nIHRoZSBwYWdlIGFuZCB1c2luZyBr ZXkgY29tbWFuZHMgdG8gbGF1bmNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjMyNzY2CisgICAgICAgIHJkYXI6Ly83NDU2MjYxOQorCisgICAgICAg IFJldmlld2VkIGJ5IFdlbnNvbiBIc2llaC4KKworICAgICAgICBXaGVuIHRyaWdnZXJpbmcgdGhl IGxvb2t1cCBjb21tYW5kIHdpdGggY29tbWFuZC1jb250cm9sLUQgb3IgdGhlIHRyaXBsZSBmaW5n ZXIgdGFwIG9uIG1hYywgaWYgeW91IGhhdmUgcHJldmlvdXNseQorICAgICAgICBjbGlja2VkIHRo ZSBwYWdlLCB0aGUgbG9va3VwIHdvdWxkIHRpbWUgb3V0IGFuZCB0aGUgcG9wb3ZlciB3b3VsZCBu ZXZlciBzaG93LiBUaGlzIHdhcyBiZWNhdXNlIGFmdGVyIGNsaWNraW5nIG9uIHRoZSBwYWdlLCAK KyAgICAgICAgYW4gaW52aXNpYmxlIGNhcmV0IHNlbGVjdGlvbiB3b3VsZCBleGlzdCwgd2hpY2gg d291bGQgY2hhbmdlIHRoZSBwYXRoIHRha2VuIGZvciBoaWdobGlnaHRpbmcgYW5kIHRlbXBvcmFy aWx5IHNlbGVjdGluZyB0ZXh0IHRvIAorICAgICAgICBiZSBzZW50IHRvIGRhdGEgZGV0ZWN0b3Jz LiAKKyAgICAgICAgVGhlIHNvbHV0aW9uIHdhcyB0byBzZXQgaWdub3JlU2VsZWN0aW9uQ2hhbmdl cyBvbiB0aGUgdGVtcG9yYXJ5IHNlbGVjdGlvbiwgYW5kIGFsc28gdG8gc3RvcCBwcm9wYWdhdGlu ZyB0ZW1wb3Jhcnkgc2VsZWN0aW9uIGNoYW5nZXMgdG8gYWNjZXNzaWJpbGl0eSwgYXMgCisgICAg ICAgIHRoYXQgc2hvdWxkIG5vdCBiZSBuZWNlc3NhcnkgYW5kIHRoYXQgaXMgdGhlIGNvZGUgdGhh dCBjYXVzZSBhIHN5bmMgbWVzc2FnZSAoUm9vdFZpZXdUb1NjcmVlbikgdG8gYmUgc2VudCB0byB0 aGUgVUkgcHJvY2VzcyB3aGlsZSBpdCB3YXMgc3luYyBhd2FpdGluZyBvdXIKKyAgICAgICAgcmVw bHkgdG8gdGhlIHN5bmMgbWVzc2FnZSAoRGlkUGVyZm9ybUltbWVkaWF0ZUFjdGlvbkhpdFRlc3Qp IHNlbnQgZWFybGllciBmb3IgdGhlIG9yaWdpbmFsIHJlcXVlc3QgZm9yIGRhdGEgZGV0ZWN0b3Jz LgorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZVNlbGVjdGlvbjo6dXBkYXRlQW5kUmV2ZWFsU2VsZWN0aW9uKToKKyAgICAgICAg KiBwYWdlL1RleHRJbmRpY2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dEluZGljYXRv cjo6Y3JlYXRlV2l0aFJhbmdlKToKKwogMjAyMS0xMS0wMyAgVHlsZXIgV2lsY29jayAgPHR5bGVy X3dAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBXS0FjY2Vzc2liaWxpdHlXZWJQYWdlT2JqZWN0 TWFjLm1tIHNob3VsZCBleHBvc2UgYWNjZXNzaWJpbGl0eUNoaWxkcmVuSW5OYXZpZ2F0aW9uT3Jk ZXIgYW5kIE5TQWNjZXNzaWJpbGl0eUNoaWxkcmVuSW5OYXZpZ2F0aW9uT3JkZXJBdHRyaWJ1dGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKaW5kZXggNjVlMTViNzJi ZWFmNjk4OWIxMWFiM2E5NTZlNDU2NTJjOTgyNDdmMC4uMzBmY2QzMGY0ZGY2NTExZTk2MmIxYmYx ZWU5ZmVjZjljMGRjOTk2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlv bi5jcHAKQEAgLTQ5OCw4ICs0OTgsOCBAQCB2b2lkIEZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBbmRS ZXZlYWxTZWxlY3Rpb24oY29uc3QgQVhUZXh0U3RhdGVDaGFuZ2VJbnRlbnQmIGludAogCiAgICAg ICAgIHJldmVhbFNlbGVjdGlvbihtX3NlbGVjdGlvblJldmVhbE1vZGUsIGFsaWdubWVudCwgcmV2 ZWFsRXh0ZW50LCBzY3JvbGxCZWhhdmlvcik7CiAgICAgfQotCi0gICAgbm90aWZ5QWNjZXNzaWJp bGl0eUZvclNlbGVjdGlvbkNoYW5nZShpbnRlbnQpOworICAgIGlmICghbV9kb2N1bWVudC0+ZWRp dG9yKCkuaWdub3JlU2VsZWN0aW9uQ2hhbmdlcygpKQorICAgICAgICBub3RpZnlBY2Nlc3NpYmls aXR5Rm9yU2VsZWN0aW9uQ2hhbmdlKGludGVudCk7CiB9CiAKIHZvaWQgRnJhbWVTZWxlY3Rpb246 OnVwZGF0ZURhdGFEZXRlY3RvcnNGb3JTZWxlY3Rpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVGV4dElu ZGljYXRvci5jcHAKaW5kZXggZDZmYjczYjY2MWIwNzFmNzNiNDMyYjUwYzEyZDQ4YTNiYjQ4Njc4 Yi4uZDI2MGQxMWE4NDVhMjdjY2FiMmE3MjhkZTNkNDEwYzg2M2Y3N2UwNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwCkBAIC04MSw4ICs4MSw4IEBAIFJlZlB0cjxUZXh0SW5k aWNhdG9yPiBUZXh0SW5kaWNhdG9yOjpjcmVhdGVXaXRoUmFuZ2UoY29uc3QgU2ltcGxlUmFuZ2Um IHJhbmdlLCBPCiAKICAgICBPcHRpb25TZXQ8VGVtcG9yYXJ5U2VsZWN0aW9uT3B0aW9uPiB0ZW1w b3JhcnlTZWxlY3Rpb25PcHRpb25zOwogICAgIHRlbXBvcmFyeVNlbGVjdGlvbk9wdGlvbnMuYWRk KFRlbXBvcmFyeVNlbGVjdGlvbk9wdGlvbjo6RG9Ob3RTZXRGb2N1cyk7Ci0jaWYgUExBVEZPUk0o SU9TX0ZBTUlMWSkKICAgICB0ZW1wb3JhcnlTZWxlY3Rpb25PcHRpb25zLmFkZChUZW1wb3JhcnlT ZWxlY3Rpb25PcHRpb246Oklnbm9yZVNlbGVjdGlvbkNoYW5nZXMpOworI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpCiAgICAgdGVtcG9yYXJ5U2VsZWN0aW9uT3B0aW9ucy5hZGQoVGVtcG9yYXJ5U2Vs ZWN0aW9uT3B0aW9uOjpFbmFibGVBcHBlYXJhbmNlVXBkYXRlcyk7CiAjZW5kaWYKICAgICBUZW1w b3JhcnlTZWxlY3Rpb25DaGFuZ2Ugc2VsZWN0aW9uQ2hhbmdlKCpkb2N1bWVudCwgeyByYW5nZSB9 LCB0ZW1wb3JhcnlTZWxlY3Rpb25PcHRpb25zKTsK