232733 2021-11-04 16:25:21 -0700 "OffscreenCanvas" in IDLs doesn't seem to be able to be compiled 2022-03-04 11:17:04 -0800 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 232558 1 mmaxfield djg cdumez djg esprehn+autocc ews-watchlist kondapallykalyan sam webkit-bug-importer oldest_to_newest 1812004 0 mmaxfield 2021-11-04 16:25:21 -0700 There are a few comments in our bindings code: // FIXME: OffscreenCanvas doesn't seem to work with our bindings here. 1814261 1 webkit-bug-importer 2021-11-11 15:26:18 -0800 <rdar://problem/85318653> 1847723 2 djg 2022-03-02 19:20:28 -0800 Notes on how to handle OffscreenCanvas from slack: typedef (HTMLImageElement #if defined(ENABLE_VIDEO) && ENABLE_VIDEO or HTMLVideoElement #endif or HTMLCanvasElement or ImageBitmap #if defined(ENABLE_OFFSCREEN_CANVAS) && ENABLE_OFFSCREEN_CANVAS or OffscreenCanvas #endif #if defined(ENABLE_CSS_TYPED_OM) && ENABLE_CSS_TYPED_OM or CSSStyleImageValue #endif ) CanvasImageSource; 1848174 3 453812 djg 2022-03-03 21:58:15 -0800 Created attachment 453812 Patch 1848175 4 453812 djg 2022-03-03 22:02:53 -0800 Comment on attachment 453812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453812&action=review > Source/WebCore/Modules/WebGPU/GPUCanvasContext.h:45 > + using CanvasType = std::variant<RefPtr<HTMLCanvasElement>, RefPtr<OffscreenCanvas>>; I'm happy to bike shed the name `CanvasType`. > Source/WebCore/Modules/WebGPU/GPUImageCopyExternalImage.h:41 > + using SourceType = std::variant<RefPtr<ImageBitmap>, RefPtr<HTMLCanvasElement>, RefPtr<OffscreenCanvas>>; I'm happy to bike shed the name `SourceType`. 1848354 5 ews-feeder 2022-03-04 11:17:00 -0800 Committed r290838 (248074@main): <https://commits.webkit.org/248074@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453812. 453812 2022-03-03 21:58:15 -0800 2022-03-04 11:17:02 -0800 Patch bug-232733-20220304155813.patch text/plain 5586 djg U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwODA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ0ZjBlZDEwZjRhOTg4 MWZmMTdjZTQ3YTQ2NTU4OWJjNmIzZjQyNi4uMTZiYjg4ZWZkNzIwZDM0ZjAxZjFiNmQ2N2JhN2Vm YTYzMWE2ZDE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAzLTAzICBEYW4g R2xhc3RvbmJ1cnkgIDxkamdAYXBwbGUuY29tPgorCisgICAgICAgICJPZmZzY3JlZW5DYW52YXMi IGluIElETHMgZG9lc24ndCBzZWVtIHRvIGJlIGFibGUgdG8gYmUgY29tcGlsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjczMworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vODUzMTg2NTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT2Zmc2NyZWVuQ2FudmFzIGlzIGNvbnRyb2xsZWQgYnkgRU5BQkxF IGZsYWdzLiBBZGQgY29uZGl0aW9uYWwKKyAgICAgICAgY29tcGlsYXRpb24gdG8gaGFuZGxlIE9m ZnNjcmVlbkNhbnZhcyB0byB0aGUgV2ViR1BVIElETCBiaW5kaW5ncworICAgICAgICB3aGVuIHRo ZSBPZmZzY3JlZW5DYW52YXMgZmVhdHVyZSBpcyBlbmFibGVkLgorCisgICAgICAgICogTW9kdWxl cy9XZWJHUFUvR1BVQ2FudmFzQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHUFVDYW52 YXNDb250ZXh0OjpjYW52YXMpOgorICAgICAgICAqIE1vZHVsZXMvV2ViR1BVL0dQVUNhbnZhc0Nv bnRleHQuaDoKKyAgICAgICAgKiBNb2R1bGVzL1dlYkdQVS9HUFVDYW52YXNDb250ZXh0LmlkbDoK KyAgICAgICAgQWRkIE9mZnNjcmVlbkNhbnZhcyB0byBjYW52YXMgYXR0cmlidXRlIHdoZW4gaXQg aXMgZW5hYmxlZC4KKyAgICAgICAgKiBNb2R1bGVzL1dlYkdQVS9HUFVJbWFnZUNvcHlFeHRlcm5h bEltYWdlLmg6CisgICAgICAgICogTW9kdWxlcy9XZWJHUFUvR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJ bWFnZS5pZGw6CisgICAgICAgIEFkZCBPZmZzY3JlZW5DYW52YXMgdG8gc291cmNlIGF0dHJpYnV0 ZSB3aGVuIGl0IGlzIGVuYWJsZWQuCisKIDIwMjItMDMtMDMgIFNpaHVpIExpdSAgPHNpaHVpX2xp dUBhcHBsZS5jb20+CiAKICAgICAgICAgVGV4dCBtYW5pcHVsYXRpb24gZG9lcyBub3Qgb2JzZXJ2 ZSB1cGRhdGVkIHRpdGxlIGVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvV2ViR1BVL0dQVUNhbnZhc0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9X ZWJHUFUvR1BVQ2FudmFzQ29udGV4dC5jcHAKaW5kZXggNTU2NjM0NzgyNmYxYzIxMGNlYmQwMmNh ZTQxNTQwMmUwZDI5YzYxMS4uYmQ5MGQ1Nzk2OTVlZGRkNTZmNGEwMWMyOTNhN2RmNDQ3YzE4NTJi NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29u dGV4dC5jcHAKQEAgLTMxLDcgKzMxLDcgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1SZWZQ dHI8SFRNTENhbnZhc0VsZW1lbnQ+IEdQVUNhbnZhc0NvbnRleHQ6OmNhbnZhcygpCitHUFVDYW52 YXNDb250ZXh0OjpDYW52YXNUeXBlIEdQVUNhbnZhc0NvbnRleHQ6OmNhbnZhcygpCiB7CiAgICAg cmV0dXJuIHsgfTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BV L0dQVUNhbnZhc0NvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUNh bnZhc0NvbnRleHQuaAppbmRleCBhZDRmZjM5MmY0Y2JkMzMxYzRkN2QyYjg0MzA0NjVlZWIxNzUw M2FiLi42YzA3OTY5MmY3NGZkOGI2NjIxMTNhNmZjOTBhYjgxNzY2MzAwZWIxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL1dlYkdQVS9HUFVDYW52YXNDb250ZXh0LmgKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29udGV4dC5oCkBAIC00MSwx MiArNDEsMTggQEAgc3RydWN0IEdQVUNhbnZhc0NvbmZpZ3VyYXRpb247CiAKIGNsYXNzIEdQVUNh bnZhc0NvbnRleHQgOiBwdWJsaWMgUmVmQ291bnRlZDxHUFVDYW52YXNDb250ZXh0PiB7CiBwdWJs aWM6CisjaWYgRU5BQkxFKE9GRlNDUkVFTl9DQU5WQVMpCisgICAgdXNpbmcgQ2FudmFzVHlwZSA9 IHN0ZDo6dmFyaWFudDxSZWZQdHI8SFRNTENhbnZhc0VsZW1lbnQ+LCBSZWZQdHI8T2Zmc2NyZWVu Q2FudmFzPj47CisjZWxzZQorICAgIHVzaW5nIENhbnZhc1R5cGUgPSBzdGQ6OnZhcmlhbnQ8UmVm UHRyPEhUTUxDYW52YXNFbGVtZW50Pj47CisjZW5kaWYKKwogICAgIHN0YXRpYyBSZWY8R1BVQ2Fu dmFzQ29udGV4dD4gY3JlYXRlKCkKICAgICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3 IEdQVUNhbnZhc0NvbnRleHQoKSk7CiAgICAgfQogCi0gICAgUmVmUHRyPEhUTUxDYW52YXNFbGVt ZW50PiBjYW52YXMoKTsKKyAgICBDYW52YXNUeXBlIGNhbnZhcygpOwogCiAgICAgdm9pZCBjb25m aWd1cmUoY29uc3QgR1BVQ2FudmFzQ29uZmlndXJhdGlvbiYpOwogICAgIHZvaWQgdW5jb25maWd1 cmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUNhbnZh c0NvbnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29u dGV4dC5pZGwKaW5kZXggNWFiZTNhZDA4ZjAxOTIyNTQzZmEzNjhiYTZkZDhkZWI5NWFjNjYzNi4u ZGE2YzZkNGNiN2U0MGM4MGNlMmFlZDExZDc1MDBmNjZiMjU1YjMwMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29udGV4dC5pZGwKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVQ2FudmFzQ29udGV4dC5pZGwKQEAgLTMxLDcg KzMxLDExIEBACiAgICAgU2VjdXJlQ29udGV4dAogXQogaW50ZXJmYWNlIEdQVUNhbnZhc0NvbnRl eHQgewotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MQ2FudmFzRWxlbWVudCBjYW52YXM7IC8v IEZJWE1FOiBPZmZzY3JlZW5DYW52YXMgZG9lc24ndCBzZWVtIHRvIHdvcmsgd2l0aCBvdXIgYmlu ZGluZ3MgaGVyZS4KKyAgICByZWFkb25seSBhdHRyaWJ1dGUgKEhUTUxDYW52YXNFbGVtZW50Cisj aWYgZGVmaW5lZChFTkFCTEVfT0ZGU0NSRUVOX0NBTlZBUykgJiYgRU5BQkxFX09GRlNDUkVFTl9D QU5WQVMKKyAgICAgICAgb3IgT2Zmc2NyZWVuQ2FudmFzCisjZW5kaWYKKyAgICApIGNhbnZhczsK IAogICAgIHVuZGVmaW5lZCBjb25maWd1cmUoR1BVQ2FudmFzQ29uZmlndXJhdGlvbiBjb25maWd1 cmF0aW9uKTsKICAgICB1bmRlZmluZWQgdW5jb25maWd1cmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUltYWdlQ29weUV4dGVybmFsSW1hZ2UuaCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUltYWdlQ29weUV4dGVybmFsSW1hZ2UuaApp bmRleCBjMDQ4NjYwMjRiODdhMThhNmE2OTcyMWFhZTdkZjlmNTA5ZWFiNDJkLi45NzNhNGNkM2Vm NGE3NjJhMTZkMjUwZjgxNTE4ZGJhZDA5MmM3MGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL1dlYkdQVS9HUFVJbWFnZUNvcHlFeHRlcm5hbEltYWdlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZS5oCkBAIC0y OCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiR1BVT3JpZ2luMkREaWN0LmgiCiAjaW5jbHVkZSAiSFRN TENhbnZhc0VsZW1lbnQuaCIKICNpbmNsdWRlICJJbWFnZUJpdG1hcC5oIgorI2luY2x1ZGUgIk9m ZnNjcmVlbkNhbnZhcy5oIgogI2luY2x1ZGUgPG9wdGlvbmFsPgogI2luY2x1ZGUgPHBhbC9ncmFw aGljcy9XZWJHUFUvV2ViR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZS5oPgogI2luY2x1ZGUgPHZh cmlhbnQ+CkBAIC0zNiw2ICszNywxMiBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdHJ1Y3Qg R1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZSB7CisjaWYgRU5BQkxFKE9GRlNDUkVFTl9DQU5WQVMp CisgICAgdXNpbmcgU291cmNlVHlwZSA9IHN0ZDo6dmFyaWFudDxSZWZQdHI8SW1hZ2VCaXRtYXA+ LCBSZWZQdHI8SFRNTENhbnZhc0VsZW1lbnQ+LCBSZWZQdHI8T2Zmc2NyZWVuQ2FudmFzPj47Cisj ZWxzZQorICAgIHVzaW5nIFNvdXJjZVR5cGUgPSBzdGQ6OnZhcmlhbnQ8UmVmUHRyPEltYWdlQml0 bWFwPiwgUmVmUHRyPEhUTUxDYW52YXNFbGVtZW50Pj47CisjZW5kaWYKKwogICAgIFBBTDo6V2Vi R1BVOjpJbWFnZUNvcHlFeHRlcm5hbEltYWdlIGNvbnZlcnRUb0JhY2tpbmcoKSBjb25zdAogICAg IHsKICAgICAgICAgcmV0dXJuIHsKQEAgLTQ1LDcgKzUyLDcgQEAgc3RydWN0IEdQVUltYWdlQ29w eUV4dGVybmFsSW1hZ2UgewogICAgICAgICB9OwogICAgIH0KIAotICAgIHN0ZDo6dmFyaWFudDxS ZWZQdHI8SW1hZ2VCaXRtYXA+LCBSZWZQdHI8SFRNTENhbnZhc0VsZW1lbnQ+PiBzb3VyY2U7Cisg ICAgU291cmNlVHlwZSBzb3VyY2U7CiAgICAgc3RkOjpvcHRpb25hbDxHUFVPcmlnaW4yRD4gb3Jp Z2luOwogICAgIGJvb2wgZmxpcFkgeyBmYWxzZSB9OwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvV2ViR1BVL0dQVUltYWdlQ29weUV4dGVybmFsSW1hZ2UuaWRsIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZS5pZGwK aW5kZXggODBmMDU4ZWI5NTFmYjEwNjdmYzBkMTJiMTViZDBmMzQ0M2JhMzU3Ny4uN2M2YThhYTlk ODZjMzRkYjY4NGRmYzAwYjY2ZmVjYjliZTE2MTllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9XZWJHUFUvR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZS5pZGwKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9XZWJHUFUvR1BVSW1hZ2VDb3B5RXh0ZXJuYWxJbWFnZS5pZGwK QEAgLTMzLDcgKzMzLDExIEBAIHR5cGVkZWYgKHNlcXVlbmNlPEdQVUludGVnZXJDb29yZGluYXRl PiBvciBHUFVPcmlnaW4yRERpY3QpIEdQVU9yaWdpbjJEOwogICAgIEVuYWJsZWRCeVNldHRpbmc9 V2ViR1BVCiBdCiBkaWN0aW9uYXJ5IEdQVUltYWdlQ29weUV4dGVybmFsSW1hZ2UgewotICAgIHJl cXVpcmVkIChJbWFnZUJpdG1hcCBvciBIVE1MQ2FudmFzRWxlbWVudCkgc291cmNlOyAvLyBGSVhN RTogT2Zmc2NyZWVuQ2FudmFzIGRvZXNuJ3Qgc2VlbSB0byB3b3JrIHdpdGggb3VyIGJpbmRpbmdz IGhlcmUuCisgICAgcmVxdWlyZWQgKEltYWdlQml0bWFwIG9yIEhUTUxDYW52YXNFbGVtZW50Cisj aWYgZGVmaW5lZChFTkFCTEVfT0ZGU0NSRUVOX0NBTlZBUykgJiYgRU5BQkxFX09GRlNDUkVFTl9D QU5WQVMKKyAgICAgICAgb3IgT2Zmc2NyZWVuQ2FudmFzCisjZW5kaWYKKyAgICApIHNvdXJjZTsK ICAgICBHUFVPcmlnaW4yRCBvcmlnaW47CiAgICAgYm9vbGVhbiBmbGlwWSA9IGZhbHNlOwogfTsK