23273 2009-01-12 13:58:18 -0800 Avoid use of absolute repaint rect in RenderBox::repaintLayerRectsForImage() 2009-01-12 16:20:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser hyatt mitz oldest_to_newest 105386 0 simon.fraser 2009-01-12 13:58:18 -0800 RenderBox::repaintLayerRectsForImage() does some repainting when the image changes that computes an absolute repaint rect. It should not have to use absolute rects for this; it should compute a local rect. 105418 1 26654 simon.fraser 2009-01-12 16:14:44 -0800 Created attachment 26654 Patch, changelog This isn't fixing a bug, so no testcase. I'm doing it to make some future repaint cleanup easier. 105419 2 simon.fraser 2009-01-12 16:20:28 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderBox.cpp Committed r39847 26654 2009-01-12 16:14:44 -0800 2009-01-12 16:18:31 -0800 Patch, changelog 23273_patch.txt text/plain 3142 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGY3NjQzYS4uMmZlNTE3ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wMS0xMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyNzMKKworICAgICAgICBJbiBSZW5kZXJCb3g6OnJlcGFpbnRMYXllclJlY3RzRm9ySW1h Z2UoKSwgdGhlIHJlcGFpbnQgcmVjdCBkb2VzIG5vdCBoYXZlCisgICAgICAgIHRvIGJlIGNvbXB1 dGVkIGluIGFic29sdXRlIGNvb3JkaW50ZXMuIEluc3RlYWQsIHdlIGNvbXB1dGUgYSByZXBhaW50 UmVjdAorICAgICAgICByZWxhdGl2ZSB0byB0aGUgUmVuZGVyT2JqZWN0LCB3aGljaCBjYW4gcmVw YWludCBpdHNlbGYuCisgICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpyZXBhaW50TGF5ZXJSZWN0c0ZvckltYWdl KToKKworMjAwOS0wMS0xMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K KwogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluCiAKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjIwCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cAppbmRleCA1MzQ3MzE0Li5kYWNkZjEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTU3 NSw3ICs1NzUsNyBAQCB2b2lkIFJlbmRlckJveDo6aW1hZ2VDaGFuZ2VkKFdyYXBwZWRJbWFnZVB0 ciBpbWFnZSwgY29uc3QgSW50UmVjdCopCiAKIGJvb2wgUmVuZGVyQm94OjpyZXBhaW50TGF5ZXJS ZWN0c0ZvckltYWdlKFdyYXBwZWRJbWFnZVB0ciBpbWFnZSwgY29uc3QgRmlsbExheWVyKiBsYXll cnMsIGJvb2wgZHJhd2luZ0JhY2tncm91bmQpCiB7Ci0gICAgSW50UmVjdCBhYnNvbHV0ZVJlY3Q7 CisgICAgSW50UmVjdCByZW5kZXJlclJlY3Q7CiAgICAgUmVuZGVyQm94KiBsYXllclJlbmRlcmVy ID0gMDsKIAogICAgIGZvciAoY29uc3QgRmlsbExheWVyKiBjdXJMYXllciA9IGxheWVyczsgY3Vy TGF5ZXI7IGN1ckxheWVyID0gY3VyTGF5ZXItPm5leHQoKSkgewpAQCAtNTk3LDI0ICs1OTcsMjIg QEAgYm9vbCBSZW5kZXJCb3g6OnJlcGFpbnRMYXllclJlY3RzRm9ySW1hZ2UoV3JhcHBlZEltYWdl UHRyIGltYWdlLCBjb25zdCBGaWxsTGF5ZXIKICAgICAgICAgICAgICAgICAgICAgICAgIHJ3ID0g bGF5ZXJSZW5kZXJlci0+d2lkdGgoKTsKICAgICAgICAgICAgICAgICAgICAgICAgIHJoID0gbGF5 ZXJSZW5kZXJlci0+aGVpZ2h0KCk7CiAgICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAg ICAgICAgICAgYWJzb2x1dGVSZWN0ID0gSW50UmVjdCgtbGF5ZXJSZW5kZXJlci0+bWFyZ2luTGVm dCgpLAorICAgICAgICAgICAgICAgICAgICByZW5kZXJlclJlY3QgPSBJbnRSZWN0KC1sYXllclJl bmRlcmVyLT5tYXJnaW5MZWZ0KCksCiAgICAgICAgICAgICAgICAgICAgICAgICAtbGF5ZXJSZW5k ZXJlci0+bWFyZ2luVG9wKCksCiAgICAgICAgICAgICAgICAgICAgICAgICBtYXgobGF5ZXJSZW5k ZXJlci0+d2lkdGgoKSArIGxheWVyUmVuZGVyZXItPm1hcmdpbkxlZnQoKSArIGxheWVyUmVuZGVy ZXItPm1hcmdpblJpZ2h0KCkgKyBsYXllclJlbmRlcmVyLT5ib3JkZXJMZWZ0KCkgKyBsYXllclJl bmRlcmVyLT5ib3JkZXJSaWdodCgpLCBydyksCiAgICAgICAgICAgICAgICAgICAgICAgICBtYXgo bGF5ZXJSZW5kZXJlci0+aGVpZ2h0KCkgKyBsYXllclJlbmRlcmVyLT5tYXJnaW5Ub3AoKSArIGxh eWVyUmVuZGVyZXItPm1hcmdpbkJvdHRvbSgpICsgbGF5ZXJSZW5kZXJlci0+Ym9yZGVyVG9wKCkg KyBsYXllclJlbmRlcmVyLT5ib3JkZXJCb3R0b20oKSwgcmgpKTsKICAgICAgICAgICAgICAgICB9 IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBsYXllclJlbmRlcmVyID0gdGhpczsKLSAgICAg ICAgICAgICAgICAgICAgYWJzb2x1dGVSZWN0ID0gYm9yZGVyQm94KCk7CisgICAgICAgICAgICAg ICAgICAgIHJlbmRlcmVyUmVjdCA9IGJvcmRlckJveCgpOwogICAgICAgICAgICAgICAgIH0KLQot ICAgICAgICAgICAgICAgIGxheWVyUmVuZGVyZXItPmNvbXB1dGVBYnNvbHV0ZVJlcGFpbnRSZWN0 KGFic29sdXRlUmVjdCk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIEludFJlY3QgcmVw YWludFJlY3Q7CiAgICAgICAgICAgICBJbnRQb2ludCBwaGFzZTsKICAgICAgICAgICAgIEludFNp emUgdGlsZVNpemU7Ci0gICAgICAgICAgICBsYXllclJlbmRlcmVyLT5jYWxjdWxhdGVCYWNrZ3Jv dW5kSW1hZ2VHZW9tZXRyeShjdXJMYXllciwgYWJzb2x1dGVSZWN0LngoKSwgYWJzb2x1dGVSZWN0 LnkoKSwgYWJzb2x1dGVSZWN0LndpZHRoKCksIGFic29sdXRlUmVjdC5oZWlnaHQoKSwgcmVwYWlu dFJlY3QsIHBoYXNlLCB0aWxlU2l6ZSk7Ci0gICAgICAgICAgICB2aWV3KCktPnJlcGFpbnRWaWV3 UmVjdGFuZ2xlKHJlcGFpbnRSZWN0KTsKLSAgICAgICAgICAgIGlmIChyZXBhaW50UmVjdCA9PSBh YnNvbHV0ZVJlY3QpCisgICAgICAgICAgICBsYXllclJlbmRlcmVyLT5jYWxjdWxhdGVCYWNrZ3Jv dW5kSW1hZ2VHZW9tZXRyeShjdXJMYXllciwgcmVuZGVyZXJSZWN0LngoKSwgcmVuZGVyZXJSZWN0 LnkoKSwgcmVuZGVyZXJSZWN0LndpZHRoKCksIHJlbmRlcmVyUmVjdC5oZWlnaHQoKSwgcmVwYWlu dFJlY3QsIHBoYXNlLCB0aWxlU2l6ZSk7CisgICAgICAgICAgICBsYXllclJlbmRlcmVyLT5yZXBh aW50UmVjdGFuZ2xlKHJlcGFpbnRSZWN0KTsKKyAgICAgICAgICAgIGlmIChyZXBhaW50UmVjdCA9 PSByZW5kZXJlclJlY3QpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0K ICAgICB9Cg==