232706 2021-11-04 03:23:49 -0700 REGRESSION(r285077) [GLIB] 'MemoryPressureMonitor' has not been declared 2021-11-09 05:34:09 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jmason lmoura aperez bugs-noreply cgarcia clopez lmoura mcatanzaro oldest_to_newest 1811812 0 jmason 2021-11-04 03:23:49 -0700 Bug 232519 introduces some changes to unify the memoryPressureMonitorDisabled implementation. It does this by calling a new static method `MemoryPressureMonitor::disabled`. It appears the MemoryPressureMonitor class is conditionally defined on OS(LINUX). For non-Linux GTK builds, I am getting: /build/rtutils/components/desktop/webkitgtk4-dev/webkit/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:97:9: error: 'MemoryPressureMonitor' has not been declared 97 | if (MemoryPressureMonitor::disabled()) | ^~~~~~~~~~~~~~~~~~~~~ /build/rtutils/components/desktop/webkitgtk4-dev/webkit/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:46:9: error: 'MemoryPressureMonitor' has not been declared 46 | if (MemoryPressureMonitor::disabled()) | ^~~~~~~~~~~~~~~~~~~~~ 1811857 1 443307 lmoura 2021-11-04 08:38:41 -0700 Created attachment 443307 Build fix 1811887 2 ews-feeder 2021-11-04 09:39:05 -0700 Committed r285265 (243876@main): <https://commits.webkit.org/243876@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443307. 1812092 3 jmason 2021-11-05 02:43:23 -0700 Thanks for the quick fix! You missed one: /build/rtutils/components/desktop/webkitgtk4-dev/webkit/Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:46:9: error: 'MemoryPressureMonitor' has not been declared 46 | if (MemoryPressureMonitor::disabled()) | ^~~~~~~~~~~~~~~~~~~~~ 1812831 4 443603 aperez 2021-11-08 14:07:52 -0800 Created attachment 443603 Patch 1812871 5 ews-feeder 2021-11-08 15:10:04 -0800 Committed r285435 (243991@main): <https://commits.webkit.org/243991@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443603. 1813084 6 jmason 2021-11-09 04:43:47 -0800 I can confirm, it now builds as expected. Thanks! 1813096 7 aperez 2021-11-09 05:34:09 -0800 (In reply to Jim Mason from comment #6) > I can confirm, it now builds as expected. Thanks! You're welcome! 👋️ 443307 2021-11-04 08:38:41 -0700 2021-11-08 14:07:41 -0800 Build fix bug-232706-20211104123840.patch text/plain 2208 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkxYzc4OTBmZjc3YjhiMDU3 M2E2ZTRkNGI0MjE3YzIyZWQ2NGU4MDYuLjQzYWFlMmU5NTNhY2E4MjY0ZGQ0NDFhNTFmZmVhOWIx NmMxNWM4YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTEtMDQgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjg1MDc3KSBb R0xJQl0gJ01lbW9yeVByZXNzdXJlTW9uaXRvcicgaGFzIG5vdCBiZWVuIGRlY2xhcmVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI3MDYKKworICAg ICAgICBVbnJldmlld2VkIG5vbi1saW51eCBidWlsZCBmaXguCisKKyAgICAgICAgTWVtb3J5UHJl c3N1cmVNb25pdG9yIGlzIG9ubHkgYXZhaWxhYmxlIG9uIExpbnV4LCBzbyBpdHMgdXNhZ2Ugc2hv dWxkCisgICAgICAgIGJlIGd1YXJkZWQsIGxpa2UgV2ViUHJvY2Vzc1Bvb2wuY3BwIGRvZXMgd2hl biBzdGFydGluZyBpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9nbGliL1dlYlByb2Nlc3NQb29s R0xpYi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRp YWxpemUpOiBBZGQgT1MoTElOVVgpIGd1YXJkLgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNz UG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6IERpdHRvLgorCiAyMDIxLTExLTA0 ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByZXZlcnRpbmcgcjI4NTIyOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Bvb2xHTGliLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2dsaWIvV2ViUHJvY2Vzc1Bvb2xHTGliLmNwcAppbmRleCBiZjEyZWVlOGM4MmJiNGQyOGQ5 ZGExMThlODBmMzRjOWRlYmEzZjNhLi5mOTEwYmVkNDY5MzI5NzZkMWJjODUyNWZhYzU2OTJmNzU4 ZGViNDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9nbGliL1dlYlByb2Nl c3NQb29sR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2xpYi9XZWJQcm9j ZXNzUG9vbEdMaWIuY3BwCkBAIC02MSw4ICs2MSwxMCBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpw bGF0Zm9ybUluaXRpYWxpemUoKQogICAgIGlmIChjb25zdCBjaGFyKiBmb3JjZUNvbXBsZXhUZXh0 ID0gZ2V0ZW52KCJXRUJLSVRfRk9SQ0VfQ09NUExFWF9URVhUIikpCiAgICAgICAgIG1fYWx3YXlz VXNlc0NvbXBsZXhUZXh0Q29kZVBhdGggPSAhc3RyY21wKGZvcmNlQ29tcGxleFRleHQsICIxIik7 CiAKKyNpZiBPUyhMSU5VWCkKICAgICBpZiAoIU1lbW9yeVByZXNzdXJlTW9uaXRvcjo6ZGlzYWJs ZWQoKSkKICAgICAgICAgaW5zdGFsbE1lbW9yeVByZXNzdXJlSGFuZGxlcigpOworI2VuZGlmCiB9 CiAKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29u c3QgV2ViUHJvY2Vzc1Byb3h5JiBwcm9jZXNzLCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJz JiBwYXJhbWV0ZXJzKQpAQCAtOTIsOCArOTQsMTAgQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6cGxh dGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzUHJveHkmIHByb2Nlc3MK IAogICAgIHBhcmFtZXRlcnMubWVtb3J5Q2FjaGVEaXNhYmxlZCA9IG1fbWVtb3J5Q2FjaGVEaXNh YmxlZCB8fCBMZWdhY3lHbG9iYWxTZXR0aW5nczo6c2luZ2xldG9uKCkuY2FjaGVNb2RlbCgpID09 IENhY2hlTW9kZWw6OkRvY3VtZW50Vmlld2VyOwogCisjaWYgT1MoTElOVVgpCiAgICAgaWYgKE1l bW9yeVByZXNzdXJlTW9uaXRvcjo6ZGlzYWJsZWQoKSkKICAgICAgICAgcGFyYW1ldGVycy5zaG91 bGRTdXBwcmVzc01lbW9yeVByZXNzdXJlSGFuZGxlciA9IHRydWU7CisjZW5kaWYKIAogI2lmIFVT RShHU1RSRUFNRVIpCiAgICAgcGFyYW1ldGVycy5nc3RyZWFtZXJPcHRpb25zID0gV2ViQ29yZTo6 ZXh0cmFjdEdTdHJlYW1lck9wdGlvbnNGcm9tQ29tbWFuZExpbmUoKTsK 443603 2021-11-08 14:07:52 -0800 2021-11-08 15:10:06 -0800 Patch bug-232706-20211109000751.patch text/plain 1593 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNlMTc0OWRiZDFmMzk2NWY1 ZTZiZjQyM2NlMDBjZTZjYzMwNzQyZWUuLjIyNjU4MzI2OGU2NWMzZTgwMzYxZWVlNTc5YzlkZWVj NDk2NDJhYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTEtMDggIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl1bU09V UF0gVW5pZnkgbWVtb3J5UHJlc3N1cmVNb25pdG9yRGlzYWJsZWQgaW1wbGVtZW50YXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjcwNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBuZWVkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mvc291cC9XZWJQcm9jZXNzUG9vbFNvdXAu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1Jbml0aWFsaXpl TmV0d29ya1Byb2Nlc3MpOiBBZGQgbWlzc2luZyBPUyhMSU5VWCkgZ3VhcmQKKyAgICAgICAgYXJv dW5kIE1lbW9yeVByZXNzdXJlTW9uaXRvci4KKwogMjAyMS0xMS0wOCAgRGV2aW4gUm91c3NvICA8 ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgd2ViVmlldy5zY3JvbGxWaWV3LmluZGljYXRv clN0eWxlIGRvZXMgbm90IHdvcmsgb24gaU9TIDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29sU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29sU291cC5jcHAKaW5kZXggODhiNzcyNWY1YzYxMWQz MGUwOTk1NDU4ZjE5MWZlNTQxNTI1ZWU5NS4uM2E3NWRkZTExYzc2OTViZjc3ZTgxNmY4YTA3MDRh YTkwN2FjZmM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvc291cC9XZWJQ cm9jZXNzUG9vbFNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3NvdXAvV2Vi UHJvY2Vzc1Bvb2xTb3VwLmNwcApAQCAtNDMsOCArNDMsMTAgQEAgdm9pZCBXZWJQcm9jZXNzUG9v bDo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3MoTmV0d29ya1Byb2Nlc3NDcmVhdGlv blBhcmEKICAgICBwYXJhbWV0ZXJzLmxhbmd1YWdlcyA9IHVzZXJQcmVmZXJyZWRMYW5ndWFnZXMo KTsKICAgICBwYXJhbWV0ZXJzLm1lbW9yeVByZXNzdXJlSGFuZGxlckNvbmZpZ3VyYXRpb24gPSBz X25ldHdvcmtQcm9jZXNzTWVtb3J5UHJlc3N1cmVIYW5kbGVyQ29uZmlndXJhdGlvbjsKIAorI2lm IE9TKExJTlVYKQogICAgIGlmIChNZW1vcnlQcmVzc3VyZU1vbml0b3I6OmRpc2FibGVkKCkpCiAg ICAgICAgIHBhcmFtZXRlcnMuc2hvdWxkU3VwcHJlc3NNZW1vcnlQcmVzc3VyZUhhbmRsZXIgPSB0 cnVlOworI2VuZGlmIC8vIE9TKExJTlVYKQogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK