232670 2021-11-03 10:37:56 -0700 _pasteboardWithName should be thread-safe 2021-11-03 13:13:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez benjamin cmarcelo ews-watchlist simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1811519 0 cdumez 2021-11-03 10:37:56 -0700 _pasteboardWithName should be thread-safe, to match [NSPasteboard _pasteboardWithName]. This could lead to flaky crashes like so: Thread 7 Crashed:: Dispatch queue: com.apple.root.user-initiated-qos 0 CoreFoundation 0x7ff810d9fb12 -[__NSDictionaryM setObject:forKey:] + 428 1 WebKitTestRunner 0x10baa0c66 +[WebKitTestRunnerPasteboard _pasteboardWithName:] + 374 (WebKitTestRunnerPasteboard.mm:63) 2 ShareKit 0x7ff91ded5888 -[NSObject(ShareKitExtension) shareItemURL] + 240 3 ShareKit 0x7ff91ded56d9 +[SHKSandbox filteredItemsFromSingleItem:processWithPID:] + 79 4 ShareKit 0x7ff91ded54b7 +[SHKSandbox filteredItemsFromItems:processWithPID:] + 469 5 ShareKit 0x7ff91ded5290 +[SHKSharingService sandboxProofItemsFromItems:] + 318 6 ShareKit 0x7ff91df03861 __102+[SHKSharingService sharingServicesOnMainQueueForItems:mask:invokedByPicker:allowInactive:completion:]_block_invoke + 42 7 libdispatch.dylib 0x7ff810b63ad8 _dispatch_call_block_and_release + 12 8 libdispatch.dylib 0x7ff810b64cc9 _dispatch_client_callout + 8 9 libdispatch.dylib 0x7ff810b7450b _dispatch_root_queue_drain + 680 10 libdispatch.dylib 0x7ff810b74b5a _dispatch_worker_thread2 + 160 11 libsystem_pthread.dylib 0x7ff810d1802e _pthread_wqthread + 256 12 libsystem_pthread.dylib 0x7ff810d16ffb start_wqthread + 15 1811521 1 443210 cdumez 2021-11-03 10:42:07 -0700 Created attachment 443210 Patch 1811628 2 ews-feeder 2021-11-03 13:12:30 -0700 Committed r285222 (243847@main): <https://commits.webkit.org/243847@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443210. 1811629 3 webkit-bug-importer 2021-11-03 13:13:20 -0700 <rdar://problem/84988401> 443210 2021-11-03 10:42:07 -0700 2021-11-03 13:12:32 -0700 Patch bug-232670-20211103104206.patch text/plain 5712 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMxMzgwYzdmNDJmYWQ2YTAxZmY4OWNl NDM0YzU0MDkzZjZmZjZiYTQuLjNjMDIyNjQ4ZDI4OTQ3NDk2MTdiYjI1ZDU3YWRmY2QwY2ZiYTY0 ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTEtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBfcGFzdGVib2FyZFdpdGhOYW1lIHNob3VsZCBiZSB0aHJl YWQtc2FmZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMyNjcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg d3RmL0F0b21pY3MuaCB1c2VzIFdURl9NQUtFX1NUUlVDVF9GQVNUX0FMTE9DQVRFRCB3aGljaCBp cyBkZWNsYXJlZCBpbgorICAgICAgICB3dGYvRmFzdE1hbGxvYy5oIGJ1dCB3YXMgZmFpbGluZyB0 byBpbmNsdWRlIGl0LiBUaGlzIHdhcyBsZWFkaW5nIHRvIGEKKyAgICAgICAgYnVpbGQgZXJyb3Ig d2hlbiBJIHRyaWVkIGluY2x1ZGluZyB3dGYvTG9jay5oIGluIFdLVFIuCisKKyAgICAgICAgKiB3 dGYvQXRvbWljcy5oOgorCiAyMDIxLTExLTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl LmNvbT4KIAogICAgICAgICBOb3RpZmljYXRpb25zIG9uIGlPUyBlbmFibGVkIGF0IGNvbXBpbGUt dGltZSwgZGlzYWJsZWQgYXQgcnVudGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXRv bWljcy5oIGIvU291cmNlL1dURi93dGYvQXRvbWljcy5oCmluZGV4IGRmODg0NTI5NDFhYTRmNTEw ZjNhOTZjY2YwNzdiODUxZGU1MmUyOGIuLmFiMDMwN2QyMGFiNzgzYTJjMTQzNjRkMDlkOWNkNDYw ZjNmMWYzOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9BdG9taWNzLmgKQEAgLTI2LDYgKzI2LDcgQEAKICNwcmFnbWEgb25jZQogCiAj aW5jbHVkZSA8YXRvbWljPgorI2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjaW5jbHVkZSA8 d3RmL1N0ZExpYkV4dHJhcy5oPgogCiAjaWYgT1MoV0lORE9XUykKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0N2NiOTAzYjk2NmQwOTAxMmZiNWU2 MGI4ZmVhNTA3Y2EwMmU3OTJhLi42YjI2MTA5ZGU3Nzk5MTlhMmE3NTFlNzY5YWViNzM2OTgwNjlk NzE4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMjEtMTEtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KKworICAgICAgICBfcGFzdGVib2FyZFdpdGhOYW1lIHNob3VsZCBiZSB0aHJlYWQtc2FmZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNjcwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgX3Bhc3RlYm9h cmRXaXRoTmFtZSBzaG91bGQgYmUgdGhyZWFkLXNhZmUsIHRvIG1hdGNoIFtOU1Bhc3RlYm9hcmQg X3Bhc3RlYm9hcmRXaXRoTmFtZV0uCisgICAgICAgIFRoaXMgd2FzIGxlYWRpbmcgdG8gZmxha3kg Y3Jhc2hlcyBpbiBfcGFzdGVib2FyZFdpdGhOYW1lIGdldHRpbmcgY2FsbGVkIG9mZiB0aGUgbWFp bgorICAgICAgICB0aHJlYWQgZnJvbSBTaGFyZUtpdCBjb2RlLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlUGFzdGVib2FyZC5tbToKKyAgICAgICAgKCtbRHVt cFJlbmRlclRyZWVQYXN0ZWJvYXJkIF9wYXN0ZWJvYXJkV2l0aE5hbWU6XSk6CisgICAgICAgICgr W0R1bXBSZW5kZXJUcmVlUGFzdGVib2FyZCByZWxlYXNlTG9jYWxQYXN0ZWJvYXJkc10pOgorICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1dlYktpdFRlc3RSdW5uZXJQYXN0ZWJvYXJkLm1t OgorICAgICAgICAoK1tXZWJLaXRUZXN0UnVubmVyUGFzdGVib2FyZCBfcGFzdGVib2FyZFdpdGhO YW1lOl0pOgorICAgICAgICAoK1tXZWJLaXRUZXN0UnVubmVyUGFzdGVib2FyZCByZWxlYXNlTG9j YWxQYXN0ZWJvYXJkc10pOgorCiAyMDIxLTExLTAzICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9j aGVuZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIE5lZWQgQVBJIGZvciBtYXJraW5nIGZp bGUgcmVxdWVzdHMgYXMgbm9uLWFwcC1pbml0aWF0ZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZVBhc3RlYm9hcmQubW0gYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVQYXN0ZWJvYXJkLm1tCmluZGV4IDdlMWFhMDllN2Rj NjIxYWIwNTdkMjM2ZGJmNzhlNDI4YmMyYjAzYWUuLmUyODE4MzU3NzQ1NmE2MzQwMDMyNWNlZTFi ZDIwZDQzNmE4OWYzNWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1w UmVuZGVyVHJlZVBhc3RlYm9hcmQubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1 bXBSZW5kZXJUcmVlUGFzdGVib2FyZC5tbQpAQCAtMzksNiArMzksNyBAQAogI2ltcG9ydCA8d3Rm L0Fzc2VydGlvbnMuaD4KICNpbXBvcnQgPHd0Zi9IYXNoTWFwLmg+CiAjaW1wb3J0IDx3dGYvTGlz dEhhc2hTZXQuaD4KKyNpbXBvcnQgPHd0Zi9Mb2NrLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRy Lmg+CiAKIEBpbnRlcmZhY2UgTG9jYWxQYXN0ZWJvYXJkIDogTlNQYXN0ZWJvYXJkIHsKQEAgLTU1 LDE2ICs1NiwxOCBAQCBAaW50ZXJmYWNlIExvY2FsUGFzdGVib2FyZCA6IE5TUGFzdGVib2FyZCB7 CiAtKGlkKWluaXRXaXRoTmFtZTooTlNTdHJpbmcgKiluYW1lOwogQGVuZAogCi1zdGF0aWMgUmV0 YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IGxvY2FsUGFzdGVib2FyZHM7CitzdGF0aWMgTG9j ayBsb2NhbFBhc3RlYm9hcmRzTG9jazsKK3N0YXRpYyBSZXRhaW5QdHI8TlNNdXRhYmxlRGljdGlv bmFyeT4gbG9jYWxQYXN0ZWJvYXJkcyBXVEZfR1VBUkRFRF9CWV9MT0NLKGxvY2FsUGFzdGVib2Fy ZHNMb2NrKTsKIAogQGltcGxlbWVudGF0aW9uIER1bXBSZW5kZXJUcmVlUGFzdGVib2FyZAogCiAv LyBSZXR1cm4gYSBsb2NhbCBwYXN0ZWJvYXJkIHNvIHdlIGRvbid0IGRpc3R1cmIgdGhlIHJlYWwg cGFzdGVib2FyZHMgd2hlbiBydW5uaW5nIHRlc3RzLgogKyAoTlNQYXN0ZWJvYXJkICopX3Bhc3Rl Ym9hcmRXaXRoTmFtZTooTlNTdHJpbmcgKiluYW1lCiB7Ci0gICAgc3RhdGljIGludCBudW1iZXIg PSAwOworICAgIExvY2tlciBsb2NrZXIgeyBsb2NhbFBhc3RlYm9hcmRzTG9jayB9OworICAgIHN0 YXRpYyB1aW50NjRfdCBudW1iZXIgV1RGX0dVQVJERURfQllfTE9DSyhsb2NhbFBhc3RlYm9hcmRz TG9jaykgPSAwOwogICAgIGlmICghbmFtZSkKLSAgICAgICAgbmFtZSA9IFtOU1N0cmluZyBzdHJp bmdXaXRoRm9ybWF0OkAiTG9jYWxQYXN0ZWJvYXJkJWQiLCArK251bWJlcl07CisgICAgICAgIG5h bWUgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkxvY2FsUGFzdGVib2FyZCVsbHUiLCAr K251bWJlcl07CiAgICAgaWYgKCFsb2NhbFBhc3RlYm9hcmRzKQogICAgICAgICBsb2NhbFBhc3Rl Ym9hcmRzID0gYWRvcHROUyhbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxsb2NdIGluaXRdKTsKICAg ICBpZiAoTG9jYWxQYXN0ZWJvYXJkICpwYXN0ZWJvYXJkID0gW2xvY2FsUGFzdGVib2FyZHMgb2Jq ZWN0Rm9yS2V5Om5hbWVdKQpAQCAtNzYsNiArNzksNyBAQCArIChOU1Bhc3RlYm9hcmQgKilfcGFz dGVib2FyZFdpdGhOYW1lOihOU1N0cmluZyAqKW5hbWUKIAogKyAodm9pZClyZWxlYXNlTG9jYWxQ YXN0ZWJvYXJkcwogeworICAgIExvY2tlciBsb2NrZXIgeyBsb2NhbFBhc3RlYm9hcmRzTG9jayB9 OwogICAgIGxvY2FsUGFzdGVib2FyZHMgPSBuaWw7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvbWFjL1dlYktpdFRlc3RSdW5uZXJQYXN0ZWJvYXJkLm1tIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9tYWMvV2ViS2l0VGVzdFJ1bm5lclBhc3RlYm9hcmQubW0KaW5kZXgg NWUzMTYzMjcyNjVjNTQ2YjhmYmI5MDg3N2Y1YTk3MWFkZTIzOGQ3Zi4uOTJiN2RjNmU3MDJlNjk0 MjU5ZGI0ZGE2YjQ4ZGVjM2EyY2IzYzMzZSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9tYWMvV2ViS2l0VGVzdFJ1bm5lclBhc3RlYm9hcmQubW0KKysrIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9tYWMvV2ViS2l0VGVzdFJ1bm5lclBhc3RlYm9hcmQubW0KQEAgLTMwLDYgKzMw LDcgQEAKIAogI2ltcG9ydCAiTlNQYXN0ZWJvYXJkQWRkaXRpb25zLmgiCiAjaW1wb3J0IDxvYmpj L3J1bnRpbWUuaD4KKyNpbXBvcnQgPHd0Zi9Mb2NrLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRy Lmg+CiAKIEBpbnRlcmZhY2UgTG9jYWxQYXN0ZWJvYXJkIDogTlNQYXN0ZWJvYXJkCkBAIC00NSwx NiArNDYsMTggQEAgQGludGVyZmFjZSBMb2NhbFBhc3RlYm9hcmQgOiBOU1Bhc3RlYm9hcmQKIC0o aWQpaW5pdFdpdGhOYW1lOihOU1N0cmluZyAqKW5hbWU7CiBAZW5kCiAKLXN0YXRpYyBSZXRhaW5Q dHI8TlNNdXRhYmxlRGljdGlvbmFyeT4gbG9jYWxQYXN0ZWJvYXJkczsKK3N0YXRpYyBMb2NrIGxv Y2FsUGFzdGVib2FyZHNMb2NrOworc3RhdGljIFJldGFpblB0cjxOU011dGFibGVEaWN0aW9uYXJ5 PiBsb2NhbFBhc3RlYm9hcmRzIFdURl9HVUFSREVEX0JZX0xPQ0sobG9jYWxQYXN0ZWJvYXJkc0xv Y2spOwogCiBAaW1wbGVtZW50YXRpb24gV2ViS2l0VGVzdFJ1bm5lclBhc3RlYm9hcmQKIAogLy8g UmV0dXJuIGEgbG9jYWwgcGFzdGVib2FyZCBzbyB3ZSBkb24ndCBkaXN0dXJiIHRoZSByZWFsIHBh c3RlYm9hcmRzIHdoZW4gcnVubmluZyB0ZXN0cy4KICsgKE5TUGFzdGVib2FyZCAqKV9wYXN0ZWJv YXJkV2l0aE5hbWU6KE5TU3RyaW5nICopbmFtZQogewotICAgIHN0YXRpYyBpbnQgbnVtYmVyID0g MDsKKyAgICBMb2NrZXIgbG9ja2VyIHsgbG9jYWxQYXN0ZWJvYXJkc0xvY2sgfTsKKyAgICBzdGF0 aWMgdWludDY0X3QgbnVtYmVyIFdURl9HVUFSREVEX0JZX0xPQ0sobG9jYWxQYXN0ZWJvYXJkc0xv Y2spID0gMDsKICAgICBpZiAoIW5hbWUpCi0gICAgICAgIG5hbWUgPSBbTlNTdHJpbmcgc3RyaW5n V2l0aEZvcm1hdDpAIkxvY2FsUGFzdGVib2FyZCVkIiwgKytudW1iZXJdOworICAgICAgICBuYW1l ID0gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJMb2NhbFBhc3RlYm9hcmQlbGx1IiwgKytu dW1iZXJdOwogICAgIGlmICghbG9jYWxQYXN0ZWJvYXJkcykKICAgICAgICAgbG9jYWxQYXN0ZWJv YXJkcyA9IGFkb3B0TlMoW1tOU011dGFibGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XSk7CiAgICAg aWYgKExvY2FsUGFzdGVib2FyZCAqcGFzdGVib2FyZCA9IFtsb2NhbFBhc3RlYm9hcmRzIG9iamVj dEZvcktleTpuYW1lXSkKQEAgLTcyLDYgKzc1LDcgQEAgLSAodm9pZClfdXBkYXRlVHlwZUNhY2hl SWZOZWVkZWQKIAogKyAodm9pZClyZWxlYXNlTG9jYWxQYXN0ZWJvYXJkcwogeworICAgIExvY2tl ciBsb2NrZXIgeyBsb2NhbFBhc3RlYm9hcmRzTG9jayB9OwogICAgIGxvY2FsUGFzdGVib2FyZHMg PSBuaWw7CiB9CiAK