232649 2021-11-02 18:04:09 -0700 Notifications on iOS enabled at compile-time, disabled at runtime 2021-11-03 09:14:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson benjamin calvaris cdumez cmarcelo esprehn+autocc ews-watchlist kondapallykalyan thorton webkit-bug-importer youennf oldest_to_newest 1811332 0 beidson 2021-11-02 18:04:09 -0700 Notifications on iOS enabled at compile-time, disabled at runtime 1811333 1 443154 beidson 2021-11-02 18:06:09 -0700 Created attachment 443154 Patch 1811334 2 443154 thorton 2021-11-02 18:08:21 -0700 Comment on attachment 443154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443154&action=review > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:186 > + macro(Notification) \ plural? 1811336 3 beidson 2021-11-02 18:16:51 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 443154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443154&action=review > > > Source/WebCore/bindings/js/WebCoreBuiltinNames.h:186 > > + macro(Notification) \ > > plural? The IDL object being controlled by the setting here is, indeed, "Notification" singular. 1811342 4 443154 thorton 2021-11-02 18:34:27 -0700 Comment on attachment 443154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443154&action=review >>> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:186 >>> + macro(Notification) \ >> >> plural? > > The IDL object being controlled by the setting here is, indeed, "Notification" singular. Oh I totally missed what this was (A+ review), thought it was Logging.h :P 1811351 5 beidson 2021-11-02 18:49:43 -0700 (In reply to Tim Horton from comment #4) > Comment on attachment 443154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443154&action=review > > >>> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:186 > >>> + macro(Notification) \ > >> > >> plural? > > > > The IDL object being controlled by the setting here is, indeed, "Notification" singular. > > Oh I totally missed what this was (A+ review), thought it was Logging.h :P A++++++ would have review again! 1811399 6 ews-feeder 2021-11-02 23:53:20 -0700 Committed r285199 (243825@main): <https://commits.webkit.org/243825@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443154. 1811400 7 webkit-bug-importer 2021-11-02 23:54:18 -0700 <rdar://problem/84963287> 1811477 8 beidson 2021-11-03 09:02:20 -0700 Yay for being bitten by no API test EWS again. *sigh* Fixing. 1811483 9 443201 beidson 2021-11-03 09:09:56 -0700 Created attachment 443201 [fast-cq] Disable these API tests on iOS 1811484 10 beidson 2021-11-03 09:10:27 -0700 Reopened for API test failure. 1811485 11 ews-feeder 2021-11-03 09:11:59 -0700 ChangeLog entry in Tools/ChangeLog contains OOPS!. 1811486 12 443202 beidson 2021-11-03 09:12:20 -0700 Created attachment 443202 [fast-cq] Disable these API tests on iOS 1811487 13 ews-feeder 2021-11-03 09:14:14 -0700 Committed r285207 (243833@main): <https://commits.webkit.org/243833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443202. 443154 2021-11-02 18:06:09 -0700 2021-11-02 23:53:22 -0700 Patch patch text/plain 4065 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYzUzZjk3NmM1Y2NlLi4zZmE1N2I0NTJhZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MjEtMTEtMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE5v dGlmaWNhdGlvbnMgb24gaU9TIGVuYWJsZWQgYXQgY29tcGlsZS10aW1lLCBkaXNhYmxlZCBhdCBy dW50aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzI2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHd0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmg6CisKIDIwMjEtMTEtMDEgIFBlciBBcm5lICA8cHZv bGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBPcGVuaW5nIGxvY2FsIGh0bWwgZmls ZXMgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVD b2NvYS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCmluZGV4IDZhYjAz YTdiYWIyZC4uZjdkMzkyYzFmOGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bUVuYWJsZUNvY29hLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5o CkBAIC00MzAsNyArNDMwLDcgQEAKICNkZWZpbmUgRU5BQkxFX05PTl9WSVNJQkxFX1dFQlBST0NF U1NfTUVNT1JZX0NMRUFOVVBfVElNRVIgMQogI2VuZGlmCiAKLSNpZiAhZGVmaW5lZChFTkFCTEVf Tk9USUZJQ0FUSU9OUykgJiYgUExBVEZPUk0oTUFDKQorI2lmICFkZWZpbmVkKEVOQUJMRV9OT1RJ RklDQVRJT05TKSAmJiAoUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShJT1MpKQogI2RlZmluZSBF TkFCTEVfTk9USUZJQ0FUSU9OUyAxCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDc5NGY1NWQxMGI4 Yy4uOWYyZWUxZDNkOTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTEtMDIg IEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE5vdGlmaWNhdGlv bnMgb24gaU9TIGVuYWJsZWQgYXQgY29tcGlsZS10aW1lLCBkaXNhYmxlZCBhdCBydW50aW1lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzI2NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgKENoYW5naW5nIGNvbXBpbGVkIGJlaGF2aW9yIGJ1dCBkZWZpbml0ZWx5IG5vdCBydW50aW1l IGJlaGF2aW9yKQorCisgICAgICAgICogTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlv bi5pZGw6CisgICAgICAgICogTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1p c3Npb24uaWRsOgorICAgICAgICAqIE1vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25Q ZXJtaXNzaW9uQ2FsbGJhY2suaWRsOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNvcmVCdWls dGluTmFtZXMuaDoKKwogMjAyMS0xMS0wMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5j b20+CiAKICAgICAgICAgWyBpT1MxNSBFV1MgXSBUZXN0V2ViS2l0QVBJLkNTU1ZpZXdwb3J0VW5p dHMuU2FtZVVub2JzY3VyZWRTaXplT3ZlcnJpZGVzIGZsYWt5IGZhaWxzIG9uIEVXUwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmlk bAppbmRleCA5Y2I3ODQ4NjFmYzUuLmVhZDdiNmQ2MGVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5pZGwKQEAgLTM0LDgg KzM0LDkgQEAKIFsKICAgICBDb25kaXRpb25hbD1OT1RJRklDQVRJT05TLAogICAgIEFjdGl2ZURP TU9iamVjdCwKKyAgICBFbmFibGVkQnlTZXR0aW5nPU5vdGlmaWNhdGlvbnNFbmFibGVkLAogICAg IEV4cG9ydE1hY3JvPVdFQkNPUkVfRVhQT1JULAotICAgIEV4cG9zZWQ9V2luZG93CisgICAgRXhw b3NlZD1XaW5kb3csCiBdIGludGVyZmFjZSBOb3RpZmljYXRpb24gOiBFdmVudFRhcmdldCB7CiAg ICAgW0NhbGxXaXRoPURvY3VtZW50XSBjb25zdHJ1Y3RvcihET01TdHJpbmcgdGl0bGUsIG9wdGlv bmFsIE5vdGlmaWNhdGlvbk9wdGlvbnMgb3B0aW9ucyk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uLmlkbCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNz aW9uLmlkbAppbmRleCA0MjFiYjgyODI3MDcuLjgzNmE3ODM4YTYzYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb24u aWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRp b25QZXJtaXNzaW9uLmlkbApAQCAtMjUsNiArMjUsNyBAQAogCiBbCiAgICAgQ29uZGl0aW9uYWw9 Tk9USUZJQ0FUSU9OUywKKyAgICBFbmFibGVkQnlTZXR0aW5nPU5vdGlmaWNhdGlvbnNFbmFibGVk LAogXSBlbnVtIE5vdGlmaWNhdGlvblBlcm1pc3Npb24gewogICAgICJkZWZhdWx0IiwKICAgICAi ZGVuaWVkIiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9u cy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2suaWRsIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25DYWxsYmFjay5pZGwKaW5k ZXggMzAxOWFjYzM0ZTQyLi5lNTEyYTYwYWY3OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2suaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25Q ZXJtaXNzaW9uQ2FsbGJhY2suaWRsCkBAIC0yNSw0ICsyNSw1IEBACiAKIFsKICAgICBDb25kaXRp b25hbD1OT1RJRklDQVRJT05TLAorICAgIEVuYWJsZWRCeVNldHRpbmc9Tm90aWZpY2F0aW9uc0Vu YWJsZWQsCiBdIGNhbGxiYWNrIE5vdGlmaWNhdGlvblBlcm1pc3Npb25DYWxsYmFjayA9IHVuZGVm aW5lZCAoTm90aWZpY2F0aW9uUGVybWlzc2lvbiBwZXJtaXNzaW9uKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVCdWlsdGluTmFtZXMuaCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVCdWlsdGluTmFtZXMuaAppbmRleCA5NjE0ZWUyY2U5 N2UuLmRiZmVkZjMwODIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv V2ViQ29yZUJ1aWx0aW5OYW1lcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dl YkNvcmVCdWlsdGluTmFtZXMuaApAQCAtMTgzLDYgKzE4Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICBtYWNybyhOYXZpZ2F0b3JNZWRpYURldmljZXMpIFwKICAgICBtYWNybyhOYXZpZ2F0 b3JQZXJtaXNzaW9ucykgXAogICAgIG1hY3JvKE5hdmlnYXRvclVzZXJNZWRpYSkgXAorICAgIG1h Y3JvKE5vdGlmaWNhdGlvbikgXAogICAgIG1hY3JvKE9mZmxpbmVBdWRpb0NvbnRleHQpIFwKICAg ICBtYWNybyhPZmZzY3JlZW5DYW52YXMpIFwKICAgICBtYWNybyhPZmZzY3JlZW5DYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQpIFwK 443201 2021-11-03 09:09:56 -0700 2021-11-03 09:12:20 -0700 [fast-cq] Disable these API tests on iOS patch text/plain 1294 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYWI5 MTZiMDUwZTguLmNmYmYxZmFiMzA5MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTExLTAzICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaU9TIEFQSSB0ZXN0cyBhZnRl ciByMjg1MTk5IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyNjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL05vdGlmaWNhdGlvbkFQSS5tbTog RGVmaW5pdGVseSBub3QgcmVhZHkgZm9yIHRoZXNlIHRlc3RzIHRvIHN0YXJ0IHJ1bm5pbmcuCisK IDIwMjEtMTEtMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5pY29kZURlY29kZUVycm9yIGluIHdyaXRlX3JlZnRlc3QgY29weWluZyBhIG5vbi1V VEY4IGV4cGVjdGVkIHJlc3VsdCBmaWxlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL05vdGlmaWNhdGlvbkFQSS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvTm90aWZpY2F0aW9uQVBJLm1tCmluZGV4IGM0YTQ1ZGRlMmVh MC4uNDI2YjY2ZjU4ODM2IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL05vdGlmaWNhdGlvbkFQSS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL05vdGlmaWNhdGlvbkFQSS5tbQpAQCAtMjUsNyArMjUsNyBAQAogCiAj aW1wb3J0ICJjb25maWcuaCIKIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQorI2lmIEVOQUJM RShOT1RJRklDQVRJT05TKSAmJiAhUExBVEZPUk0oSU9TKQogI2ltcG9ydCAiUGxhdGZvcm1VdGls aXRpZXMuaCIKICNpbXBvcnQgIlRlc3RXS1dlYlZpZXcuaCIKICNpbXBvcnQgPFdlYktpdC9XS1VJ RGVsZWdhdGVQcml2YXRlLmg+CkBAIC0xNzAsNCArMTcwLDQgQEAgVEVTVChOb3RpZmljYXRpb24s IFBhcmFsbGVsUGVybWlzc2lvblJlcXVlc3RzR3JhbnRlZCkKIAogfSAvLyBuYW1lc3BhY2UgVGVz dFdlYktpdEFQSQogCi0jZW5kaWYgLy8gRU5BQkxFKE5PVElGSUNBVElPTlMpCisjZW5kaWYgLy8g RU5BQkxFKE5PVElGSUNBVElPTlMpICYmICFQTEFURk9STShJT1MpCg== 443202 2021-11-03 09:12:20 -0700 2021-11-03 09:14:16 -0700 [fast-cq] Disable these API tests on iOS patch text/plain 1278 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYWI5 MTZiMDUwZTguLmEwYmI5MzJlOTdlNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTExLTAzICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaU9TIEFQSSB0ZXN0cyBhZnRl ciByMjg1MTk5IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMyNjQ5CisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvTm90aWZpY2F0aW9uQVBJLm1tOiBEZWZpbml0ZWx5IG5vdCBy ZWFkeSBmb3IgdGhlc2UgdGVzdHMgdG8gc3RhcnQgcnVubmluZy4KKwogMjAyMS0xMS0wMiAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmljb2RlRGVj b2RlRXJyb3IgaW4gd3JpdGVfcmVmdGVzdCBjb3B5aW5nIGEgbm9uLVVURjggZXhwZWN0ZWQgcmVz dWx0IGZpbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvTm90aWZpY2F0aW9uQVBJLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9Ob3RpZmljYXRpb25BUEkubW0KaW5kZXggYzRhNDVkZGUyZWEwLi40MjZiNjZmNTg4MzYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTm90aWZp Y2F0aW9uQVBJLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev Tm90aWZpY2F0aW9uQVBJLm1tCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbXBvcnQgImNvbmZpZy5o IgogCi0jaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMp ICYmICFQTEFURk9STShJT1MpCiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5oIgogI2ltcG9y dCAiVGVzdFdLV2ViVmlldy5oIgogI2ltcG9ydCA8V2ViS2l0L1dLVUlEZWxlZ2F0ZVByaXZhdGUu aD4KQEAgLTE3MCw0ICsxNzAsNCBAQCBURVNUKE5vdGlmaWNhdGlvbiwgUGFyYWxsZWxQZXJtaXNz aW9uUmVxdWVzdHNHcmFudGVkKQogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCiAKLSNl bmRpZiAvLyBFTkFCTEUoTk9USUZJQ0FUSU9OUykKKyNlbmRpZiAvLyBFTkFCTEUoTk9USUZJQ0FU SU9OUykgJiYgIVBMQVRGT1JNKElPUykK