232643 2021-11-02 15:21:35 -0700 UnicodeDecodeError in write_reftest copying a non-UTF8 expected result file 2021-11-02 20:38:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap dino ews-watchlist glenn gsnedders jbedard simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1811294 0 thorton 2021-11-02 15:21:35 -0700 UnicodeDecodeError in write_reftest copying a non-UTF8 expected result file 1811297 1 443139 thorton 2021-11-02 15:25:08 -0700 Created attachment 443139 Patch 1811300 2 443139 ap 2021-11-02 15:40:31 -0700 Comment on attachment 443139 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443139&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:208 > - self._write_text_file(dst_filepath, fs.read_text_file(src_filepath)) > + fs.copyfile(src_filepath, dst_filepath) I wanted to say r+, but then I did an svn blame and found that r122505 changed this from copyfile to read/write. There was more refactoring there, so this is probably still ok, but I didn't take the time to understand why. Would you mind figuring out and explaining it? 1811337 3 thorton 2021-11-02 18:20:20 -0700 Ooh, good catch, it was so that the code to make the enclosing directory would be run. We should do that in this case too (but in this function directly instead of by re-using _write_text_file). I don't think Dirk's reasoning that reftests should use the same mechanism stands up, because we can (??) ensure that the test output is UTF-8 (since it is the output of WebKit), but can't do the same for the input. Will fix, thank you for the observation :) 1811354 4 443159 thorton 2021-11-02 18:53:30 -0700 Created attachment 443159 Patch 1811381 5 ews-feeder 2021-11-02 20:37:59 -0700 Committed r285198 (243824@main): <https://commits.webkit.org/243824@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443159. 1811382 6 webkit-bug-importer 2021-11-02 20:38:17 -0700 <rdar://problem/84959425> 443139 2021-11-02 15:25:08 -0700 2021-11-02 18:53:28 -0700 Patch bug-232643-20211102152506.patch text/plain 2179 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGI5N2ZmMWVhMTIwZDE3ZDRjNjQ0YmVjYTIxZDU1YTRi NTA0NGIwMi4uYzcyZGNhMmI3YWZhMGY4OGJiYTU0NTI5NTFiYzhkYzRiMWU2ZmEzZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDIxLTExLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFVuaWNvZGVEZWNvZGVFcnJvciBpbiB3cml0ZV9yZWZ0ZXN0IGNvcHlpbmcgYSBu b24tVVRGOCBleHBlY3RlZCByZXN1bHQgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy90ZXN0X3Jlc3VsdF93cml0ZXIucHk6CisgICAgICAgIChUZXN0UmVzdWx0V3JpdGVy LndyaXRlX3JlZnRlc3QpOgorICAgICAgICBJZiBhIHJlZnRlc3QncyAtZXhwZWN0ZWQuaHRtbCBm aWxlIGlzIG5vdCB2YWxpZCBVVEYtOCwgYW5kIHRoZSB0ZXN0IGZhaWxzLAorICAgICAgICB3aGVu IHdlIGNvcHkgdGhlIGV4cGVjdGVkIGZpbGUgZnJvbSB0aGUgbGF5b3V0IHRlc3RzIGRpcmVjdG9y eSB0byB0aGUKKyAgICAgICAgdGVzdCByZXN1bHRzIGRpcmVjdG9yeSwgd2UgYXR0ZW1wdCB0byBw YXJzZSBpdCBhcyBVVEYtOCwgcmVzdWx0aW5nIGluCisgICAgICAgIGFuIGV4Y2VwdGlvbiBiZWlu ZyB0aHJvd24uCisKKyAgICAgICAgSW5zdGVhZCBvZiBuZWVkbGVzc2x5IHJlYWRpbmcgaW4gdGhl IGZpbGUgYXMgYSBzdHJpbmcgYW5kIGltbWVkaWF0ZWx5CisgICAgICAgIHdyaXRpbmcgaXQgYmFj ayBvdXQsIGp1c3QgY29weSB0aGUgZmlsZS4uLgorCisgICAgICAgIEknbSBub3Qgc3VyZSB0aGVy ZSBhcmUgYW55IG5vdC12YWxpZC1VVEYtOCAqcmVmKiB0ZXN0cyBpbiB0aGUgdHJlZSwgYnV0Cisg ICAgICAgIHRoZXJlIGlzIGF0IGxlYXN0IG9uZSBub3QtdmFsaWQtVVRGLTggKnRleHQqIHRlc3Qs IHdoaWNoIGNhbiBiZSBydW4KKyAgICAgICAgYXMgYSByZWYtdGVzdCBpbiBzb21lIHNjZW5hcmlv cyAoc2VlIHIyODUxMzIpLCBpbiB3aGljaCBjYXNlIHRoaXMgcHJvYmxlbQorICAgICAgICBvY2N1 cnM6IGZhc3QvY3NzL2xpbmUtaGVpZ2h0LWRldGVybWluZWQtYnktcHJpbWFyeS1mb250Lmh0bWwu CisKIDIwMjEtMTEtMDIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAg ICAgICAgIFt3ZWJraXRzY21weV0gUmVkdWNlIGF1dG9pbnN0YWxscyBvbiBpbXBvcnQKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3Rl c3RfcmVzdWx0X3dyaXRlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL3Rlc3RfcmVzdWx0X3dyaXRlci5weQppbmRleCA4NjcxYzVlOTZiYjIyYmVm ZjJiNjE1OWFhMzM1MTExNGUzNzdlNGY5Li5jMzRmZWZmZDdhYWNjZjU4N2ZlYmJlZWIxODJhYmE3 YzRmMjBjZThiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9jb250cm9sbGVycy90ZXN0X3Jlc3VsdF93cml0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CkBA IC0yMDUsNCArMjA1LDQgQEAgY2xhc3MgVGVzdFJlc3VsdFdyaXRlcihvYmplY3QpOgogICAgICAg ICBmcyA9IHNlbGYuX2ZpbGVzeXN0ZW0KICAgICAgICAgZHN0X2RpciA9IGZzLmRpcm5hbWUoZnMu am9pbihzZWxmLl9yb290X291dHB1dF9kaXIsIHNlbGYuX3Rlc3RfbmFtZSkpCiAgICAgICAgIGRz dF9maWxlcGF0aCA9IGZzLmpvaW4oZHN0X2RpciwgZnMuYmFzZW5hbWUoc3JjX2ZpbGVwYXRoKSkK LSAgICAgICAgc2VsZi5fd3JpdGVfdGV4dF9maWxlKGRzdF9maWxlcGF0aCwgZnMucmVhZF90ZXh0 X2ZpbGUoc3JjX2ZpbGVwYXRoKSkKKyAgICAgICAgZnMuY29weWZpbGUoc3JjX2ZpbGVwYXRoLCBk c3RfZmlsZXBhdGgpCg== 443159 2021-11-02 18:53:30 -0700 2021-11-02 20:38:00 -0700 Patch bug-232643-20211102185330.patch text/plain 2384 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGI5N2ZmMWVhMTIwZDE3ZDRjNjQ0YmVjYTIxZDU1YTRi NTA0NGIwMi4uNmIzYjZjY2NhZjVmOGQzZDhlNTY5ODk0ZjkxZGZjNDZlNTVkNzNlYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDIxLTExLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIFVuaWNvZGVEZWNvZGVFcnJvciBpbiB3cml0ZV9yZWZ0ZXN0IGNvcHlpbmcgYSBu b24tVVRGOCBleHBlY3RlZCByZXN1bHQgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy90ZXN0X3Jlc3VsdF93cml0ZXIucHk6CisgICAgICAgIChUZXN0UmVzdWx0V3JpdGVy LndyaXRlX3JlZnRlc3QpOgorICAgICAgICBJZiBhIHJlZnRlc3QncyAtZXhwZWN0ZWQuaHRtbCBm aWxlIGlzIG5vdCB2YWxpZCBVVEYtOCwgYW5kIHRoZSB0ZXN0IGZhaWxzLAorICAgICAgICB3aGVu IHdlIGNvcHkgdGhlIGV4cGVjdGVkIGZpbGUgZnJvbSB0aGUgbGF5b3V0IHRlc3RzIGRpcmVjdG9y eSB0byB0aGUKKyAgICAgICAgdGVzdCByZXN1bHRzIGRpcmVjdG9yeSwgd2UgYXR0ZW1wdCB0byBw YXJzZSBpdCBhcyBVVEYtOCwgcmVzdWx0aW5nIGluCisgICAgICAgIGFuIGV4Y2VwdGlvbiBiZWlu ZyB0aHJvd24uCisKKyAgICAgICAgSW5zdGVhZCBvZiBuZWVkbGVzc2x5IHJlYWRpbmcgaW4gdGhl IGZpbGUgYXMgYSBzdHJpbmcgYW5kIGltbWVkaWF0ZWx5CisgICAgICAgIHdyaXRpbmcgaXQgYmFj ayBvdXQsIGp1c3QgY29weSB0aGUgZmlsZS4uLgorCisgICAgICAgIEknbSBub3Qgc3VyZSB0aGVy ZSBhcmUgYW55IG5vdC12YWxpZC1VVEYtOCAqcmVmKiB0ZXN0cyBpbiB0aGUgdHJlZSwgYnV0Cisg ICAgICAgIHRoZXJlIGlzIGF0IGxlYXN0IG9uZSBub3QtdmFsaWQtVVRGLTggKnRleHQqIHRlc3Qs IHdoaWNoIGNhbiBiZSBydW4KKyAgICAgICAgYXMgYSByZWYtdGVzdCBpbiBzb21lIHNjZW5hcmlv cyAoc2VlIHIyODUxMzIpLCBpbiB3aGljaCBjYXNlIHRoaXMgcHJvYmxlbQorICAgICAgICBvY2N1 cnM6IGZhc3QvY3NzL2xpbmUtaGVpZ2h0LWRldGVybWluZWQtYnktcHJpbWFyeS1mb250Lmh0bWwu CisKKyAgICAgICAgQWxzbywgZXhwbGljaXRseSBlbnN1cmUgdGhlIG91dHB1dCBkaXJlY3Rvcnkg ZXhpc3RzIGJlZm9yZSBjb3B5aW5nCisgICAgICAgIHRvIGF2b2lkIHJlZ3Jlc3NpbmcgcjEyMjUw NS4gUHJldmlvdXNseSB0aGlzIHdhcyBkb25lIGluc2lkZSBfd3JpdGVfdGV4dF9maWxlLgorCiAy MDIxLTExLTAyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg ICBbd2Via2l0c2NtcHldIFJlZHVjZSBhdXRvaW5zdGFsbHMgb24gaW1wb3J0CmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy90ZXN0X3Jl c3VsdF93cml0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy90ZXN0X3Jlc3VsdF93cml0ZXIucHkKaW5kZXggODY3MWM1ZTk2YmIyMmJlZmYyYjYx NTlhYTMzNTExMTRlMzc3ZTRmOS4uMjkyYTc5ODkxMjIyNzUyNzQ0Y2VlMDFmODUyNWFmYjY4Mzc5 N2M0MSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3Rlc3RfcmVzdWx0X3dyaXRlci5weQpAQCAtMjA1 LDQgKzIwNSw1IEBAIGNsYXNzIFRlc3RSZXN1bHRXcml0ZXIob2JqZWN0KToKICAgICAgICAgZnMg PSBzZWxmLl9maWxlc3lzdGVtCiAgICAgICAgIGRzdF9kaXIgPSBmcy5kaXJuYW1lKGZzLmpvaW4o c2VsZi5fcm9vdF9vdXRwdXRfZGlyLCBzZWxmLl90ZXN0X25hbWUpKQogICAgICAgICBkc3RfZmls ZXBhdGggPSBmcy5qb2luKGRzdF9kaXIsIGZzLmJhc2VuYW1lKHNyY19maWxlcGF0aCkpCi0gICAg ICAgIHNlbGYuX3dyaXRlX3RleHRfZmlsZShkc3RfZmlsZXBhdGgsIGZzLnJlYWRfdGV4dF9maWxl KHNyY19maWxlcGF0aCkpCisgICAgICAgIHNlbGYuX21ha2Vfb3V0cHV0X2RpcmVjdG9yeSgpCisg ICAgICAgIGZzLmNvcHlmaWxlKHNyY19maWxlcGF0aCwgZHN0X2ZpbGVwYXRoKQo=