232636 2021-11-02 13:29:52 -0700 [MSVC] Remove unused friend class in filter code 2021-11-02 14:51:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead dino ews-watchlist kondapallykalyan webkit-bug-importer ysuzuki oldest_to_newest 1811242 0 don.olmstead 2021-11-02 13:29:52 -0700 In a non-unified build after r284857 which removed WTF:: prefixes causes an error with MSVC. It thinks there's a WebCore::ParallelJobs due to the friend class declaration in some filter classes. Remove them. 1811244 1 443128 don.olmstead 2021-11-02 13:35:36 -0700 Created attachment 443128 Patch 1811252 2 443128 ysuzuki 2021-11-02 13:46:33 -0700 Comment on attachment 443128 Patch r=me 1811279 3 ews-feeder 2021-11-02 14:50:58 -0700 Committed r285185 (243814@main): <https://commits.webkit.org/243814@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443128. 1811280 4 webkit-bug-importer 2021-11-02 14:51:18 -0700 <rdar://problem/84948344> 443128 2021-11-02 13:35:36 -0700 2021-11-02 14:50:59 -0700 Patch bug-232636.diff text/plain 2067 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTQ5NmNhZjI4YjguLjMyMjhmNjE1OWM0NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIxLTExLTAyICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgW01TVkNdIFJlbW92ZSB1bnVzZWQgZnJpZW5kIGNsYXNzIGluIGZp bHRlciBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzI2MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiByMjg0ODU3IHRoZSBXVEYgcHJlZml4IHdhcyByZW1vdmVkIGZyb20gUGFyYWxsZWxKb2Jz IGluIGZpbHRlciBjb2RlLiBEdXJpbmcgYQorICAgICAgICBub24tdW5pZmllZCBidWlsZCBNU1ZD IHRoaW5rcyB0aGF0IHRoZXJlIGlzIGEgV2ViQ29yZTo6UGFyYWxsZWxKb2JzIGR1ZSB0byBhIGZy aWVuZAorICAgICAgICBkZWNsYXJhdGlvbiBpbiBmaWx0ZXIgY29kZSBhbmQgZmFpbHMgdG8gYnVp bGQuIFJlbW92ZSB0aGUgZnJpZW5kIGRlY2xhcmF0aW9uIGFzIHRoZXkgYXJlCisgICAgICAgIG5v dCB1c2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUdhdXNzaWFu Qmx1ci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVUdXJidWxlbmNl Lmg6CisKIDIwMjEtMTEtMDIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBQcm92aWRlIGJpZGkgcHJvcGVydGllcyB3aGVuIGNv bnN0cnVjdGluZyBUZXh0UnVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFR2F1c3NpYW5CbHVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0ZFR2F1c3NpYW5CbHVyLmgKaW5kZXggNWZiOTdmZmIwNzBjLi5h ZDdkOTUwYjliNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVHYXVzc2lhbkJsdXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFR2F1c3NpYW5CbHVyLmgKQEAgLTUxLDkgKzUxLDYgQEAgcHJpdmF0 ZToKIAogICAgIHN0YXRpYyBjb25zdCBpbnQgc19taW5pbWFsUmVjdERpbWVuc2lvbiA9IDEwMCAq IDEwMDsgLy8gRW1waXJpY2FsIGRhdGEgbGltaXQgZm9yIHBhcmFsbGVsIGpvYnMKIAotICAgIHRl bXBsYXRlPHR5cGVuYW1lIFR5cGU+Ci0gICAgZnJpZW5kIGNsYXNzIFBhcmFsbGVsSm9iczsKLQog ICAgIHN0cnVjdCBQbGF0Zm9ybUFwcGx5UGFyYW1ldGVycyB7CiAgICAgICAgIEZFR2F1c3NpYW5C bHVyKiBmaWx0ZXI7CiAgICAgICAgIFJlZlB0cjxVaW50OENsYW1wZWRBcnJheT4gaW9QaXhlbEFy cmF5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVy cy9GRVR1cmJ1bGVuY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvRkVUdXJidWxlbmNlLmgKaW5kZXggNGQ1MzZiMzdhODBhLi42MzdkMjg0ODk1ZTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVUdXJidWxl bmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRVR1 cmJ1bGVuY2UuaApAQCAtOTIsOSArOTIsNiBAQCBwcml2YXRlOgogICAgICAgICBpbnQgd3JhcFkg eyAwIH07CiAgICAgfTsKIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFR5cGU+Ci0gICAgZnJpZW5k IGNsYXNzIFBhcmFsbGVsSm9iczsKLQogICAgIHN0cnVjdCBGaWxsUmVnaW9uUGFyYW1ldGVycyB7 CiAgICAgICAgIEZFVHVyYnVsZW5jZSogZmlsdGVyOwogICAgICAgICBVaW50OENsYW1wZWRBcnJh eSogcGl4ZWxBcnJheTsK