232628 2021-11-02 09:59:52 -0700 Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview() 2021-11-03 14:33:11 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer bfulgham dino kkinnunen webkit-bug-importer oldest_to_newest 1811156 0 ddkilzer 2021-11-02 09:59:52 -0700 Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview(). This leaks a UUID object under MRR: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:[[NSUUID alloc] initWithUUIDString:uuid]]); 1811157 1 webkit-bug-importer 2021-11-02 10:00:54 -0700 <rdar://problem/84935290> 1811160 2 443101 ddkilzer 2021-11-02 10:03:16 -0700 Created attachment 443101 Patch v1 1811545 3 443101 bfulgham 2021-11-03 11:17:39 -0700 Comment on attachment 443101 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review r=me > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 > + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); Could also be: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]); 1811546 4 443101 ddkilzer 2021-11-03 11:21:39 -0700 Comment on attachment 443101 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review >> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 >> + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); > > Could also be: > > auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]); Yep, I found the inline version much harder to parse as a human, which is why I created a separate variable. Thanks for the review! 1811550 5 ews-feeder 2021-11-03 11:26:18 -0700 Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443101. 1811652 6 ddkilzer 2021-11-03 14:33:11 -0700 (In reply to EWS from comment #5) > Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 443101 [details]. Follow-up build fix for internal bots (with newer clang): https://trac.webkit.org/changeset/285229/webkit 443101 2021-11-02 10:03:16 -0700 2021-11-03 11:26:19 -0700 Patch v1 bug-232628-20211102100316.patch text/plain 1821 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1ZDQyMjc0NDllMGRmNmMw NjNiNGNkZjMzODA1NWIxOTczNmFlMzQuLjhiNjY1ZGE1ZGFiNTgzZDE3MDA2MjFkNGI3NmQ3MzA3 ODE0NDQ2Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTEtMDIgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBMZWFrIG9mIFVVSUQgaW4gV2Vi S2l0OjpNb2RlbEVsZW1lbnRDb250cm9sbGVyOjptb2RlbEVsZW1lbnREaWRDcmVhdGVQcmV2aWV3 KCkKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzMjYyOD4KKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzg0OTM1MjkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL01vZGVsRWxlbWVudENvbnRyb2xsZXJDb2Nv YS5tbToKKyAgICAgICAgKFdlYktpdDo6TW9kZWxFbGVtZW50Q29udHJvbGxlcjo6bW9kZWxFbGVt ZW50RGlkQ3JlYXRlUHJldmlldyk6CisgICAgICAgIC0gVXNlIGFkb3B0TlMoKSB0byBmaXggdGhl IGxlYWsuCisKIDIwMjEtMTEtMDIgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBs ZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMjU5MwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvTW9kZWxF bGVtZW50Q29udHJvbGxlckNvY29hLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev TW9kZWxFbGVtZW50Q29udHJvbGxlckNvY29hLm1tCmluZGV4IGE2ZmMzZTZiZDEwNTdlODZlYzBh ZDFhN2ExYjlhMzAwMDU4YWQ5OGQuLjM5ZTkxMTFlNTA5ZTgxYzlmNGMzOTI3NjMxZWM4NTE1ZmEw OWJmNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL01vZGVsRWxl bWVudENvbnRyb2xsZXJDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9Nb2RlbEVsZW1lbnRDb250cm9sbGVyQ29jb2EubW0KQEAgLTEyOSw3ICsxMjksOCBAQCB2b2lk IE1vZGVsRWxlbWVudENvbnRyb2xsZXI6Om1vZGVsRWxlbWVudERpZENyZWF0ZVByZXZpZXcoY29u c3QgV2ViQ29yZTo6RWxlbWVudAogICAgIGlmICghbV93ZWJQYWdlUHJveHkucHJlZmVyZW5jZXMo KS5tb2RlbEVsZW1lbnRFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGF1dG8gcHJl dmlldyA9IGFkb3B0TlMoW2FsbG9jQVNWSW5saW5lUHJldmlld0luc3RhbmNlKCkgaW5pdFdpdGhG cmFtZTpDR1JlY3RNYWtlKDAsIDAsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSkgVVVJRDpb W05TVVVJRCBhbGxvY10gaW5pdFdpdGhVVUlEU3RyaW5nOnV1aWRdXSk7CisgICAgYXV0byB1dWlk ID0gYWRvcHROUyhbW05TVVVJRCBhbGxvY10gaW5pdFdpdGhVVUlEU3RyaW5nOnV1aWRdKTsKKyAg ICBhdXRvIHByZXZpZXcgPSBhZG9wdE5TKFthbGxvY0FTVklubGluZVByZXZpZXdJbnN0YW5jZSgp IGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0 KCkpIFVVSUQ6dXVpZC5nZXQoKV0pOwogCiAgICAgTE9HKE1vZGVsRWxlbWVudCwgIkNyZWF0ZWQg cmVtb3RlIHByZXZpZXcgd2l0aCBVVUlEICVzLiIsIHV1aWQudXRmOCgpLmRhdGEoKSk7CiAK