232623 2021-11-02 07:12:45 -0700 [cmake] Check "cortex" string in the CMAKE_SYSTEM_PROCESSOR for defining WTF_CPU_* vars 2021-11-03 03:37:09 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 psaavedra psaavedra annulen aperez clopez darin ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio ysuzuki oldest_to_newest 1811099 0 psaavedra 2021-11-02 07:12:45 -0700 In a native build, in systems with uname support, the CMAKE_SYSTEM_PROCESSOR was defined as the output of `uname -p` by default. That was true in cmake 3.0 [1]. In newer versions of CMake the documentation of this variable changed for highlighting that this variable has not to correspond with the target architecture [2]. For example, lately, in toolchains generated by Yocto it is very common to see the CMAKE_SYSTEM_PROCESSOR defined using the GCC [3] tune name for compiling the target. Ex: cortexa7t2hf-neon-vfpv4 (rpi3) cortexa9t2hf-neon-vfpv4 (Freescale iMX6q) ... This change add an additional check to evaluate if the system processor is ARM or ARM64 based on the existence of "cortex" in the string. [1] https://cmake.org/cmake/help/v3.0/variable/CMAKE_SYSTEM_PROCESSOR.html The name of the CPU CMake is building for. On systems that support uname, this variable is set to the output of uname -p, on windows it is set to the value of the environment variable PROCESSOR_ARCHITECTURE [2] https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html When not cross-compiling, this variable has the same value as the CMAKE_HOST_SYSTEM_PROCESSOR variable. In many cases, this will correspond to the target architecture for the build, but this is not guaranteed. (E.g. on Windows, the host may be AMD64 even when using a MSVC cl compiler with a 32-bit target.) When cross-compiling, a CMAKE_TOOLCHAIN_FILE should set the CMAKE_SYSTEM_PROCESSOR variable to match target architecture that it specifies (via CMAKE_<LANG>_COMPILER and perhaps CMAKE_<LANG>_COMPILER_TARGET). [3] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html (See: -mtune=name) 1811101 1 443085 psaavedra 2021-11-02 07:16:56 -0700 Created attachment 443085 patch 1811121 2 443092 psaavedra 2021-11-02 08:28:40 -0700 Created attachment 443092 patch 1811197 3 443092 clopez 2021-11-02 11:21:28 -0700 Comment on attachment 443092 patch View in context: https://bugs.webkit.org/attachment.cgi?id=443092&action=review > Source/cmake/WebKitCommon.cmake:89 > + if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64|^cortex-?[am][2-7][2-7])") Maybe is better to use "cortex-?[am][2-7][2-8]" so it matches also Cortex-A78: https://en.wikipedia.org/wiki/ARM_Cortex-A#External_links 1811238 4 psaavedra 2021-11-02 13:23:13 -0700 (In reply to Carlos Alberto Lopez Perez from comment #3) > Comment on attachment 443092 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443092&action=review > > > Source/cmake/WebKitCommon.cmake:89 > > + if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64|^cortex-?[am][2-7][2-7])") > > Maybe is better to use "cortex-?[am][2-7][2-8]" so it matches also > Cortex-A78: https://en.wikipedia.org/wiki/ARM_Cortex-A#External_links yes. Good point. 1811240 5 443127 psaavedra 2021-11-02 13:24:09 -0700 Created attachment 443127 patch 1811429 6 ews-feeder 2021-11-03 03:37:06 -0700 Committed r285201 (243827@main): <https://commits.webkit.org/243827@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443127. 443085 2021-11-02 07:16:56 -0700 2021-11-02 08:28:23 -0700 patch bug-232623-20211102151655.patch text/plain 1487 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCAy M2QwMTU0OTlmZWY3OGY5ZTJkNDZkZmU2NGU3YmFhMjVkM2JiZjdhLi5iZjRjMmJiZmJkOTUwZTgy YWIzYThhNTNkM2UzYWQyODE2ZmU1YzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTg2 LDkgKzg2LDkgQEAgaWYgKE5PVCBIQVNfUlVOX1dFQktJVF9DT01NT04pCiAgICAgZWxzZSAoKQog ICAgICAgICBzdHJpbmcoVE9MT1dFUiAke0NNQUtFX1NZU1RFTV9QUk9DRVNTT1J9IExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SKQogICAgIGVuZGlmICgpCi0gICAgaWYgKExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIiheYWFyY2g2NHxeYXJtNjQpIikKKyAg ICBpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiKF5hYXJjaDY0 fF5hcm02NHxeY29ydGV4W2FtXVsyLTddWzItN10pIikKICAgICAgICAgc2V0KFdURl9DUFVfQVJN NjQgMSkKLSAgICBlbHNlaWYgKExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENI RVMgIl5hcm0iKQorICAgIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1Ig TUFUQ0hFUyAiKF5hcm18XmNvcnRleCkiKQogICAgICAgICBzZXQoV1RGX0NQVV9BUk0gMSkKICAg ICBlbHNlaWYgKExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIl5taXBz NjQiKQogICAgICAgICBzZXQoV1RGX0NQVV9NSVBTNjQgMSkKZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCBlMzRiYjA5Y2Q2YmUxZWE1MmQzMzgwZGNiNjQ4YWUyOTdjMmEw MGFkLi44N2FiYzU1MmNiYTAyMWZmNzQ1OWVkMjJhYTJkNzAyZDFhMzEzMTJhIDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMTEtMDIg IFBhYmxvIFNhYXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2NtYWtl XSBDaGVjayAiY29ydGV4IiBzdHJpbmcgaW4gdGhlIENNQUtFX1NZU1RFTV9QUk9DRVNTT1IgZm9y IGRlZmluaW5nIFdURl9DUFVfKiB2YXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzI2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2U6CisKIDIw MjEtMTEtMDEgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAg ICBbQ3VybF0gRXhwbGljaXRseSBkaXNhYmxlIGxpYmN1cmwncyBpbnRlcm5hbCBjb29raWUgc3Vw cG9ydAo= 443092 2021-11-02 08:28:40 -0700 2021-11-02 13:23:51 -0700 patch bug-232623-20211102162838.patch text/plain 1489 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCAy M2QwMTU0OTlmZWY3OGY5ZTJkNDZkZmU2NGU3YmFhMjVkM2JiZjdhLi5kMmZmYmFmOTdlOGE0MDVi ZWU2YjhjMjJiYjMwMzFjYzVlOWUyNTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTg2 LDkgKzg2LDkgQEAgaWYgKE5PVCBIQVNfUlVOX1dFQktJVF9DT01NT04pCiAgICAgZWxzZSAoKQog ICAgICAgICBzdHJpbmcoVE9MT1dFUiAke0NNQUtFX1NZU1RFTV9QUk9DRVNTT1J9IExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SKQogICAgIGVuZGlmICgpCi0gICAgaWYgKExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIiheYWFyY2g2NHxeYXJtNjQpIikKKyAg ICBpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiKF5hYXJjaDY0 fF5hcm02NHxeY29ydGV4LT9bYW1dWzItN11bMi03XSkiKQogICAgICAgICBzZXQoV1RGX0NQVV9B Uk02NCAxKQotICAgIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFU Q0hFUyAiXmFybSIpCisgICAgZWxzZWlmIChMT1dFUkNBU0VfQ01BS0VfU1lTVEVNX1BST0NFU1NP UiBNQVRDSEVTICIoXmFybXxeY29ydGV4KSIpCiAgICAgICAgIHNldChXVEZfQ1BVX0FSTSAxKQog ICAgIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiXm1p cHM2NCIpCiAgICAgICAgIHNldChXVEZfQ1BVX01JUFM2NCAxKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IGUzNGJiMDljZDZiZTFlYTUyZDMzODBkY2I2NDhhZTI5N2My YTAwYWQuLjg3YWJjNTUyY2JhMDIxZmY3NDU5ZWQyMmFhMmQ3MDJkMWEzMTMxMmEgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0xMS0w MiAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbY21h a2VdIENoZWNrICJjb3J0ZXgiIHN0cmluZyBpbiB0aGUgQ01BS0VfU1lTVEVNX1BST0NFU1NPUiBm b3IgZGVmaW5pbmcgV1RGX0NQVV8qIHZhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMjYyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZToKKwog MjAyMS0xMS0wMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAg ICAgIFtDdXJsXSBFeHBsaWNpdGx5IGRpc2FibGUgbGliY3VybCdzIGludGVybmFsIGNvb2tpZSBz dXBwb3J0Cg== 443127 2021-11-02 13:24:09 -0700 2021-11-03 03:37:08 -0700 patch bug-232623-20211102212408.patch text/plain 1489 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCAy M2QwMTU0OTlmZWY3OGY5ZTJkNDZkZmU2NGU3YmFhMjVkM2JiZjdhLi5lNThjNzA2OWFiYjFmYzdk YzRkN2M2NzU4ZTc3ZjQyNTE2MzMxOWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTg2 LDkgKzg2LDkgQEAgaWYgKE5PVCBIQVNfUlVOX1dFQktJVF9DT01NT04pCiAgICAgZWxzZSAoKQog ICAgICAgICBzdHJpbmcoVE9MT1dFUiAke0NNQUtFX1NZU1RFTV9QUk9DRVNTT1J9IExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SKQogICAgIGVuZGlmICgpCi0gICAgaWYgKExPV0VSQ0FT RV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1BVENIRVMgIiheYWFyY2g2NHxeYXJtNjQpIikKKyAg ICBpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiKF5hYXJjaDY0 fF5hcm02NHxeY29ydGV4LT9bYW1dWzItN11bMi04XSkiKQogICAgICAgICBzZXQoV1RGX0NQVV9B Uk02NCAxKQotICAgIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFU Q0hFUyAiXmFybSIpCisgICAgZWxzZWlmIChMT1dFUkNBU0VfQ01BS0VfU1lTVEVNX1BST0NFU1NP UiBNQVRDSEVTICIoXmFybXxeY29ydGV4KSIpCiAgICAgICAgIHNldChXVEZfQ1BVX0FSTSAxKQog ICAgIGVsc2VpZiAoTE9XRVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiXm1p cHM2NCIpCiAgICAgICAgIHNldChXVEZfQ1BVX01JUFM2NCAxKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IGUzNGJiMDljZDZiZTFlYTUyZDMzODBkY2I2NDhhZTI5N2My YTAwYWQuLjg3YWJjNTUyY2JhMDIxZmY3NDU5ZWQyMmFhMmQ3MDJkMWEzMTMxMmEgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0xMS0w MiAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbY21h a2VdIENoZWNrICJjb3J0ZXgiIHN0cmluZyBpbiB0aGUgQ01BS0VfU1lTVEVNX1BST0NFU1NPUiBm b3IgZGVmaW5pbmcgV1RGX0NQVV8qIHZhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMjYyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZToKKwog MjAyMS0xMS0wMSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAg ICAgIFtDdXJsXSBFeHBsaWNpdGx5IGRpc2FibGUgbGliY3VybCdzIGludGVybmFsIGNvb2tpZSBz dXBwb3J0Cg==