232600 2021-11-01 18:56:22 -0700 [LFC][IFC] Pass in the visual order list to display box construction 2021-11-02 07:57:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1811004 0 zalan 2021-11-01 18:56:22 -0700 so that we can start constructing the display boxes based on the visual order. 1811005 1 443051 zalan 2021-11-01 19:00:48 -0700 Created attachment 443051 Patch 1811053 2 443051 koivisto 2021-11-02 01:04:20 -0700 Comment on attachment 443051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443051&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:298 > + ubidi_reorderVisual(runLevels.data(), runLevels.size(), visualOrderList.data()); boom 1811110 3 ews-feeder 2021-11-02 07:56:52 -0700 Committed r285157 (243793@main): <https://commits.webkit.org/243793@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443051. 1811111 4 webkit-bug-importer 2021-11-02 07:57:15 -0700 <rdar://problem/84930881> 443051 2021-11-01 19:00:48 -0700 2021-11-02 07:56:54 -0700 Patch bug-232600-20211101190047.patch text/plain 6991 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDViZDUwYTkyODJiMTQx ZjEyMTFmZTMxMmQ2ZjgzNGJjOWZjY2UwOC4uYTczZDBlOTkwMGM4ZDU4YTgxMTRlMDZjMmM5YWUy YjlkMGI4YjNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTExLTAxICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIFBhc3MgaW4g dGhlIHZpc3VhbCBvcmRlciBsaXN0IHRvIGRpc3BsYXkgYm94IGNvbnN0cnVjdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNjAwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhpcyBwYXRjaCB3 ZSBjb21wdXRlIHRoZSB2aXN1YWwgb3JkZXIgZm9yIHRoZSBiaWRpIHJ1bnMgaWYgbmVlZGVkLiBU aGlzIHZpc3VhbCBvcmRlciBpcyB0aGVuIHBhc3NlZAorICAgICAgICBpbiB0byB0aGUgZGlzcGxh eSBib3ggYnVpbGRlciBzbyB0aGF0IHRoZSBmaW5hbCBkaXNwbGF5IGJveGVzIGFyZSBjb25zdHJ1 Y3RlZCBpbiB0aGUgcmlnaHQgb3JkZXIgKGhvcml6b250YWwgcG9zaXRpb25zIGFyZSBub3QgeWV0 IGFkanVzdGVkKS4gCisKKyAgICAgICAgKiBsYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGlu ZS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpJbmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXI6OmNyZWF0ZUJveGVzQW5kVXBkYXRlR2Vv bWV0cnlGb3JMaW5lQ29udGVudCk6CisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0 cy9pbmxpbmUvSW5saW5lTGluZS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lOjpj b250ZW50TmVlZHNCaWRpUmVvcmRlcmluZyBjb25zdCk6CisgICAgICAgICogbGF5b3V0L2Zvcm1h dHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6bGF5b3V0SW5saW5lQ29udGVudCk6CisgICAgICAg ICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuaDoK KwogMjAyMS0xMS0wMSAgQWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W0xGQ11bSUZDXSBVc2UgdGhlIGlzTGluZVNwYW5uaW5nSW5saW5lQm94U3RhcnQgbGluZSBydW4g dHlwZSB0byB1cGRhdGUgc3Bhbm5pbmcgaW5saW5lIGJveCBnZW9tZXRyeQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lRGlz cGxheUNvbnRlbnRCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5n Q29udGV4dHMvaW5saW5lL0lubGluZURpc3BsYXlDb250ZW50QnVpbGRlci5jcHAKaW5kZXggYzRk M2MyYjNhZTQ2MmU1Zjg4OWZkNDY0OWQ0ZWM4MDMwMzgzMjY4Yy4uM2VlYThmNTA2MTY3Yjg0NDg3 MjY5M2JmYzc3OGNhNWY1OGU5ZmM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9J bmxpbmVEaXNwbGF5Q29udGVudEJ1aWxkZXIuY3BwCkBAIC02OSw5ICs2OSwxMyBAQCBEaXNwbGF5 Qm94ZXMgSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpidWlsZChjb25zdCBMaW5lQnVpbGRl cjo6TGluZUNvbnRlbnQmCiAKIHZvaWQgSW5saW5lRGlzcGxheUNvbnRlbnRCdWlsZGVyOjpjcmVh dGVCb3hlc0FuZFVwZGF0ZUdlb21ldHJ5Rm9yTGluZUNvbnRlbnQoY29uc3QgTGluZUJ1aWxkZXI6 OkxpbmVDb250ZW50JiBsaW5lQ29udGVudCwgY29uc3QgTGluZUJveCYgbGluZUJveCwgY29uc3Qg SW5saW5lTGF5b3V0UG9pbnQmIGxpbmVCb3hMb2dpY2FsVG9wTGVmdCwgY29uc3Qgc2l6ZV90IGxp bmVJbmRleCwgRGlzcGxheUJveGVzJiBib3hlcykKIHsKLSAgICBhdXRvJiBmb3JtYXR0aW5nU3Rh dGUgPSB0aGlzLT5mb3JtYXR0aW5nU3RhdGUoKTsKICAgICAvLyBDcmVhdGUgdGhlIGlubGluZSBi b3hlcyBvbiB0aGUgY3VycmVudCBsaW5lLiBUaGlzIGlzIG1vc3RseSB0ZXh0IGFuZCBhdG9taWMg aW5saW5lIGJveGVzLgotICAgIGZvciAoYXV0byYgbGluZVJ1biA6IGxpbmVDb250ZW50LnJ1bnMp IHsKKyAgICBhdXRvJiBmb3JtYXR0aW5nU3RhdGUgPSB0aGlzLT5mb3JtYXR0aW5nU3RhdGUoKTsK KyAgICBhdXRvJiBydW5zID0gbGluZUNvbnRlbnQucnVuczsKKyAgICBhdXRvIGNvbnRlbnROZWVk c0JpZGlSZW9yZGVyaW5nID0gIWxpbmVDb250ZW50LnZpc3VhbE9yZGVyTGlzdC5pc0VtcHR5KCk7 CisgICAgQVNTRVJUKCFjb250ZW50TmVlZHNCaWRpUmVvcmRlcmluZyB8fCBsaW5lQ29udGVudC52 aXN1YWxPcmRlckxpc3Quc2l6ZSgpID09IHJ1bnMuc2l6ZSgpKTsKKyAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IHJ1bnMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgYXV0byYgbGluZVJ1biA9IHJ1 bnNbY29udGVudE5lZWRzQmlkaVJlb3JkZXJpbmcgPyBsaW5lQ29udGVudC52aXN1YWxPcmRlckxp c3RbaV0gOiBpXTsKICAgICAgICAgYXV0byYgbGF5b3V0Qm94ID0gbGluZVJ1bi5sYXlvdXRCb3go KTsKICAgICAgICAgYXV0byYgc3R5bGUgPSBbJl0gKCkgLT4gY29uc3QgUmVuZGVyU3R5bGUmIHsK ICAgICAgICAgICAgIHJldHVybiAhbGluZUluZGV4ID8gbGF5b3V0Qm94LmZpcnN0TGluZVN0eWxl KCkgOiBsYXlvdXRCb3guc3R5bGUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmUuaCBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmUuaAppbmRleCA5NzBk YzQxMDY0N2U0ZjU0M2EwZmI0MzVmYjM4MDdhYzQzMGY3MjQ5Li5mYzljMmQyMzA3YTQ1ODE0MmEw MTU3OGUxOWM3YjgzZWQ3N2NhMDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv Zm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lLmgKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZS5oCkBAIC00OSw2 ICs0OSw4IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaGFzQ29udGVudCgpIGNvbnN0IHsgcmV0dXJu ICFtX3J1bnMuaXNFbXB0eSgpICYmICFtX3J1bnMubGFzdCgpLmlzTGluZVNwYW5uaW5nSW5saW5l Qm94U3RhcnQoKTsgfQogCisgICAgYm9vbCBjb250ZW50TmVlZHNCaWRpUmVvcmRlcmluZygpIGNv bnN0IHsgcmV0dXJuIGZhbHNlOyB9CisKICAgICBJbmxpbmVMYXlvdXRVbml0IGNvbnRlbnRMb2dp Y2FsV2lkdGgoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRMb2dpY2FsV2lkdGg7IH0KICAgICBJ bmxpbmVMYXlvdXRVbml0IGNvbnRlbnRMb2dpY2FsUmlnaHQoKSBjb25zdCB7IHJldHVybiBsYXN0 UnVuTG9naWNhbFJpZ2h0KCkgKyBtX2Nsb25lZEVuZERlY29yYXRpb25XaWR0aEZvcklubGluZUJv eFJ1bnM7IH0KICAgICBzaXplX3Qgbm9uU3Bhbm5pbmdJbmxpbmVMZXZlbEJveENvdW50KCkgY29u c3QgeyByZXR1cm4gbV9ub25TcGFubmluZ0lubGluZUxldmVsQm94Q291bnQ7IH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGlu ZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4 dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCA1MmZiNDU2ZDgyNzQ1NDE4N2Jk Y2ZlMGY4MjUyY2UwZDY5MDExNmY4Li5hNmE4ODJhMGVkNDQ2NTc1MjJmYjEyNmI1M2QwYWEwYTg2 YTliNmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRl eHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0y ODMsMTYgKzI4MywzNiBAQCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQgTGluZUJ1aWxkZXI6Omxh eW91dElubGluZUNvbnRlbnQoY29uc3QgSW5saW5lSXRlbVJhbmdlJgogCiAgICAgYXV0byBjb21t aXR0ZWRDb250ZW50ID0gcGxhY2VJbmxpbmVDb250ZW50KG5lZWRzTGF5b3V0UmFuZ2UpOwogICAg IGF1dG8gY29tbWl0dGVkUmFuZ2UgPSBjbG9zZShuZWVkc0xheW91dFJhbmdlLCBjb21taXR0ZWRD b250ZW50KTsKKyAgICBhdXRvJiBsaW5lUnVucyA9IG1fbGluZS5ydW5zKCk7CisKKyAgICBhdXRv IGNvbXB1dGVkVmlzdWFsT3JkZXIgPSBbJl0oKSAtPiBWZWN0b3I8aW50MzJfdD4geworICAgICAg ICBpZiAoIW1fbGluZS5jb250ZW50TmVlZHNCaWRpUmVvcmRlcmluZygpKQorICAgICAgICAgICAg cmV0dXJuIHsgfTsKKworICAgICAgICBWZWN0b3I8VUJpRGlMZXZlbD4gcnVuTGV2ZWxzKGxpbmVS dW5zLnNpemUoKSk7CisgICAgICAgIC8vIEZJWE1FOiBXZSBtYXkgY2FjaGUgdGhlc2UgdmFsdWVz IGluIExpbmUsIGlmIGl0IHR1cm5zIG91dCB0byBiZSBhIHBlcmYgaGl0LgorICAgICAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IGxpbmVSdW5zLnNpemUoKTsgKytpKQorICAgICAgICAgICAgcnVu TGV2ZWxzW2ldID0gbGluZVJ1bnNbaV0uYmlkaUxldmVsKCk7CisKKyAgICAgICAgVmVjdG9yPGlu dDMyX3Q+IHZpc3VhbE9yZGVyTGlzdChsaW5lUnVucy5zaXplKCkpOworICAgICAgICB1YmlkaV9y ZW9yZGVyVmlzdWFsKHJ1bkxldmVscy5kYXRhKCksIHJ1bkxldmVscy5zaXplKCksIHZpc3VhbE9y ZGVyTGlzdC5kYXRhKCkpOworICAgICAgICByZXR1cm4gdmlzdWFsT3JkZXJMaXN0OworICAgIH07 CiAKICAgICBhdXRvIGlzTGFzdExpbmUgPSBpc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQoY29t bWl0dGVkUmFuZ2UsIG5lZWRzTGF5b3V0UmFuZ2UuZW5kLCBjb21taXR0ZWRDb250ZW50LnBhcnRp YWxUcmFpbGluZ0NvbnRlbnRMZW5ndGgpOwotICAgIHJldHVybiBMaW5lQ29udGVudCB7IGNvbW1p dHRlZFJhbmdlLCBjb21taXR0ZWRDb250ZW50LnBhcnRpYWxUcmFpbGluZ0NvbnRlbnRMZW5ndGgs IGNvbW1pdHRlZENvbnRlbnQub3ZlcmZsb3dMb2dpY2FsV2lkdGgsIG1fZmxvYXRzLCBtX2NvbnRl bnRJc0NvbnN0cmFpbmVkQnlGbG9hdAorICAgIHJldHVybiBMaW5lQ29udGVudCB7IGNvbW1pdHRl ZFJhbmdlCisgICAgICAgICwgY29tbWl0dGVkQ29udGVudC5wYXJ0aWFsVHJhaWxpbmdDb250ZW50 TGVuZ3RoCisgICAgICAgICwgY29tbWl0dGVkQ29udGVudC5vdmVyZmxvd0xvZ2ljYWxXaWR0aAor ICAgICAgICAsIG1fZmxvYXRzCisgICAgICAgICwgbV9jb250ZW50SXNDb25zdHJhaW5lZEJ5Rmxv YXQKICAgICAgICAgLCBtX2xpbmVMb2dpY2FsUmVjdC50b3BMZWZ0KCkKICAgICAgICAgLCBtX2xp bmVMb2dpY2FsUmVjdC53aWR0aCgpCiAgICAgICAgICwgbV9saW5lLmNvbnRlbnRMb2dpY2FsV2lk dGgoKQogICAgICAgICAsIG1fbGluZS5oYW5naW5nV2hpdGVzcGFjZVdpZHRoKCkKICAgICAgICAg LCBpc0xhc3RMaW5lCiAgICAgICAgICwgbV9saW5lLm5vblNwYW5uaW5nSW5saW5lTGV2ZWxCb3hD b3VudCgpCi0gICAgICAgICwgbV9saW5lLnJ1bnMoKX07CisgICAgICAgICwgY29tcHV0ZWRWaXN1 YWxPcmRlcigpCisgICAgICAgICwgbGluZVJ1bnMgfTsKIH0KIAogTGluZUJ1aWxkZXI6OkludHJp bnNpY0NvbnRlbnQgTGluZUJ1aWxkZXI6OmNvbXB1dGVkSW50cmluc2ljV2lkdGgoY29uc3QgSW5s aW5lSXRlbVJhbmdlJiBuZWVkc0xheW91dFJhbmdlLCBJbmxpbmVMYXlvdXRVbml0IGF2YWlsYWJs ZVdpZHRoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250 ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9m b3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmgKaW5kZXggN2NmMDll YmZkMzcyOWVjOTRiMmY3MzQyNjgzYWJlMjc1MmZmMjQ2Ny4uOWViNzAyOTk2ZTgxZmQ1N2RjMTc5 YTEyZmFjOTBiY2RjZWM1MTk0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zv cm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRl ci5oCkBAIC02MSw2ICs2MSw3IEBAIHB1YmxpYzoKICAgICAgICAgSW5saW5lTGF5b3V0VW5pdCBo YW5naW5nV2hpdGVzcGFjZVdpZHRoIHsgMCB9OwogICAgICAgICBib29sIGlzTGFzdExpbmVXaXRo SW5saW5lQ29udGVudCB7IHRydWUgfTsKICAgICAgICAgc2l6ZV90IG5vblNwYW5uaW5nSW5saW5l TGV2ZWxCb3hDb3VudCB7IDAgfTsKKyAgICAgICAgVmVjdG9yPGludDMyX3Q+IHZpc3VhbE9yZGVy TGlzdDsKICAgICAgICAgY29uc3QgTGluZTo6UnVuTGlzdCYgcnVuczsKICAgICB9OwogICAgIExp bmVDb250ZW50IGxheW91dElubGluZUNvbnRlbnQoY29uc3QgSW5saW5lSXRlbVJhbmdlJiwgc2l6 ZV90IHBhcnRpYWxMZWFkaW5nQ29udGVudExlbmd0aCwgc3RkOjpvcHRpb25hbDxJbmxpbmVMYXlv dXRVbml0PiBvdmVyZmxvd2luZ0xvZ2ljYWxXaWR0aCwgY29uc3QgSW5saW5lUmVjdCYgaW5pdGlh bExpbmVMb2dpY2FsUmVjdCwgYm9vbCBpc0ZpcnN0TGluZSk7Cg==