232596 2021-11-01 17:06:04 -0700 ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t' 2021-11-01 19:31:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead simon.fraser webkit-bug-importer oldest_to_newest 1810976 0 fujii 2021-11-01 17:06:04 -0700 Since r284764, MSVC reports the following warning. C:\home\webkit\gc\Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t' C:\home\webkit\gc\Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string 1810977 1 443037 fujii 2021-11-01 17:08:30 -0700 Created attachment 443037 Patch 1810986 2 simon.fraser 2021-11-01 17:38:40 -0700 Can we fix the style checker to catch this? 1811002 3 fujii 2021-11-01 18:44:08 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Can we fix the style checker to catch this? The style checker doesn't compile, doesn't know the type of variable. AppleWin treats warning as error. But, unfortunately, it suppresses warnings introduced in Visual Studio 2013 (major version 18) and later. > add_compile_options(/WX /Wv:18) https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level 1811009 4 ews-feeder 2021-11-01 19:30:34 -0700 Committed r285150 (243787@main): <https://commits.webkit.org/243787@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443037. 1811010 5 webkit-bug-importer 2021-11-01 19:31:17 -0700 <rdar://problem/84911625> 443037 2021-11-01 17:08:30 -0700 2021-11-01 19:30:35 -0700 Patch bug-232596-20211102090829.patch text/plain 1845 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQxZjZmMGJmYmJhYWFiOWFiMWM5ZmFiYzhhN2YzYmUz NTBiOWZkMC4uODlmYzJiYjBlYzgyY2Q2YmUwZWEwMGJiZWU2YmRmM2Y3M2E4ZTA5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTExLTAxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIEltYWdlRGlmZi5jcHAoNzQpOiB3YXJuaW5nIEM0NDc3OiAnZnByaW50Zicg OiBmb3JtYXQgc3RyaW5nICclbHUnIHJlcXVpcmVzIGFuIGFyZ3VtZW50IG9mIHR5cGUgJ3Vuc2ln bmVkIGxvbmcnLCBidXQgdmFyaWFkaWMgYXJndW1lbnQgMiBoYXMgdHlwZSAnc2l6ZV90JworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNTk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgcjI4NDc2 NCwgTVNWQyByZXBvcnRzIHRoZSBmb2xsb3dpbmcgd2FybmluZyBhbmQgYSBzdWdnZXN0aW9uLgor CisgICAgICAgID4gVG9vbHNcSW1hZ2VEaWZmXEltYWdlRGlmZi5jcHAoNzQpOiB3YXJuaW5nIEM0 NDc3OiAnZnByaW50ZicgOiBmb3JtYXQgc3RyaW5nICclbHUnIHJlcXVpcmVzIGFuIGFyZ3VtZW50 IG9mIHR5cGUgJ3Vuc2lnbmVkIGxvbmcnLCBidXQgdmFyaWFkaWMgYXJndW1lbnQgMiBoYXMgdHlw ZSAnc2l6ZV90JworICAgICAgICA+IFRvb2xzXEltYWdlRGlmZlxJbWFnZURpZmYuY3BwKDc0KTog bm90ZTogY29uc2lkZXIgdXNpbmcgJyV6dScgaW4gdGhlIGZvcm1hdCBzdHJpbmcKKworICAgICAg ICAqIEltYWdlRGlmZi9JbWFnZURpZmYuY3BwOgorICAgICAgICAocHJvY2Vzc0ltYWdlcyk6IFVz ZSAlenUgZm9yIHNpemVfdC4KKwogMjAyMS0xMS0wMSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFy ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW3dlYmtpdHNjbXB5XSBPbmx5IHJlc3BlY3QgdGhlIGxh dGVzdCByZXZpZXcKZGlmZiAtLWdpdCBhL1Rvb2xzL0ltYWdlRGlmZi9JbWFnZURpZmYuY3BwIGIv VG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAKaW5kZXggOWZlYjc3MTlmYjY1Mzk3Yzc3N2Uw NjM4ZjBjY2QyZTVhNjVhMjc0Yy4uODkwMDk3ZGM5M2RlYjBlY2E5YTQxZGIyZjU2ZGI5NTI4ODhm M2JmNyAxMDA2NDQKLS0tIGEvVG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAKKysrIGIvVG9v bHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAKQEAgLTcxLDcgKzcxLDcgQEAgc3RhdGljIGludCBw cm9jZXNzSW1hZ2VzKHN0ZDo6dW5pcXVlX3B0cjxQbGF0Zm9ybUltYWdlPiYmIGFjdHVhbEltYWdl LCBzdGQ6OnVuaXEKICAgICBmcHJpbnRmKHN0ZG91dCwgImRpZmY6ICUwMS44ZiUlXG4iLCBkaWZm ZXJlbmNlRGF0YS5wZXJjZW50YWdlRGlmZmVyZW5jZSk7CiAKICAgICBpZiAocHJpbnREaWZmZXJl bmNlKQotICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIm1heERpZmZlcmVuY2U9JXU7IHRvdGFsUGl4 ZWxzPSVsdVxuIiwgZGlmZmVyZW5jZURhdGEubWF4RGlmZmVyZW5jZSwgZGlmZmVyZW5jZURhdGEu dG90YWxQaXhlbHMpOworICAgICAgICBmcHJpbnRmKHN0ZG91dCwgIm1heERpZmZlcmVuY2U9JXU7 IHRvdGFsUGl4ZWxzPSV6dVxuIiwgZGlmZmVyZW5jZURhdGEubWF4RGlmZmVyZW5jZSwgZGlmZmVy ZW5jZURhdGEudG90YWxQaXhlbHMpOwogCiAgICAgZnByaW50ZihzdGRvdXQsICIjRU9GXG4iKTsK ICAgICBmZmx1c2goc3Rkb3V0KTsK