232577 2021-11-01 13:10:34 -0700 Web Inspector: Display swatch popovers below the swatch by default, not on the left side 2021-11-03 10:48:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev ews-watchlist hi inspector-bugzilla-changes pangle webkit-bug-importer oldest_to_newest 1810833 0 nvasilyev 2021-11-01 13:10:34 -0700 The popover should be under (or above) the swatch, so it doesn't cover the CSS value it's related to. More context in https://bugs.webkit.org/show_bug.cgi?id=230065#c4. 1810846 1 443007 nvasilyev 2021-11-01 13:40:05 -0700 Created attachment 443007 Patch 1811021 2 443007 pangle 2021-11-01 20:41:44 -0700 Comment on attachment 443007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443007&action=review LGTM with the one suggestion to elaborate in the changelog. > Source/WebInspectorUI/ChangeLog:8 > + The new defaults are: below, above, left. Can you just recap the thoughts behind these three choices in this order here (I'm pretty sure I understand all three, particularly since I pushed for Below to come before Above)? It would be nice if we can look back and understand our decisions unlike how we were somewhat left to wonder why the current defaults were the way they are. 1811395 3 443176 nvasilyev 2021-11-02 22:57:22 -0700 Created attachment 443176 Patch 1811516 4 443176 hi 2021-11-03 10:35:40 -0700 Comment on attachment 443176 Patch r=me 1811530 5 ews-feeder 2021-11-03 10:47:16 -0700 Committed r285215 (243840@main): <https://commits.webkit.org/243840@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443176. 1811531 6 webkit-bug-importer 2021-11-03 10:48:18 -0700 <rdar://problem/84981718> 443007 2021-11-01 13:40:05 -0700 2021-11-02 22:57:22 -0700 Patch patch.txt text/plain 2415 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyNjJhMWQ3MDAxYi4uMGVhNjEwYzFkMDY4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0xMS0wMSAgTmlr aXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBEaXNwbGF5IHN3YXRjaCBwb3BvdmVycyBiZWxvdyB0aGUgc3dhdGNoIGJ5IGRlZmF1bHQs IG5vdCBvbiB0aGUgbGVmdCBzaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzI1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbmV3IGRlZmF1bHRzIGFyZTogYmVsb3csIGFib3ZlLCBsZWZ0Lgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9JbmxpbmVTd2F0Y2guanM6CisgICAgICAg IChXSS5JbmxpbmVTd2F0Y2gucHJvdG90eXBlLl9wcmVzZW50UG9wb3Zlcik6CisgICAgICAgIElu dHJvZHVjZSBhIG1ldGhvZCB0byByZW1vdmUgY29kZSBkdXBsaWNhdGlvbi4KKwogMjAyMS0wNy0y NiAgUWlhb3NvbmcgWmhvdSAgPHFpYW9zb25nX3pob3VAYXBwbGUuY29tPgogCiAgICAgICAgIEZv cm1EYXRhRXZlbnQgYWRkZWQuIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpzCmluZGV4IDgxZTQ4ZGI0NDc3Yi4u NDczNzVmNWI2YmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9JbmxpbmVTd2F0Y2guanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpzCkBAIC0yMzgsMTIgKzIzOCwxMCBAQCBX SS5JbmxpbmVTd2F0Y2ggPSBjbGFzcyBJbmxpbmVTd2F0Y2ggZXh0ZW5kcyBXSS5PYmplY3QKICAg ICAgICAgaWYgKCF2YWx1ZSkKICAgICAgICAgICAgIHZhbHVlID0gdGhpcy5fZmFsbGJhY2tWYWx1 ZSgpOwogCi0gICAgICAgIGxldCBib3VuZHMgPSBXSS5SZWN0LnJlY3RGcm9tQ2xpZW50UmVjdCh0 aGlzLl9zd2F0Y2hFbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpKTsKICAgICAgICAgbGV0 IHBvcG92ZXIgPSBuZXcgV0kuUG9wb3Zlcih0aGlzKTsKIAogICAgICAgICBwb3BvdmVyLndpbmRv d1Jlc2l6ZUhhbmRsZXIgPSAoKSA9PiB7Ci0gICAgICAgICAgICBsZXQgYm91bmRzID0gV0kuUmVj dC5yZWN0RnJvbUNsaWVudFJlY3QodGhpcy5fc3dhdGNoRWxlbWVudC5nZXRCb3VuZGluZ0NsaWVu dFJlY3QoKSk7Ci0gICAgICAgICAgICBwb3BvdmVyLnByZXNlbnQoYm91bmRzLnBhZCgyKSwgW1dJ LlJlY3RFZGdlLk1JTl9YXSk7CisgICAgICAgICAgICB0aGlzLl9wcmVzZW50UG9wb3Zlcihwb3Bv dmVyKTsKICAgICAgICAgfTsKIAogICAgICAgICB0aGlzLl92YWx1ZUVkaXRvciA9IG51bGw7CkBA IC0zMDcsNyArMzA1LDcgQEAgV0kuSW5saW5lU3dhdGNoID0gY2xhc3MgSW5saW5lU3dhdGNoIGV4 dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgcG9wb3Zlci5j b250ZW50ID0gdGhpcy5fdmFsdWVFZGl0b3IuZWxlbWVudDsKLSAgICAgICAgcG9wb3Zlci5wcmVz ZW50KGJvdW5kcy5wYWQoMiksIFtXSS5SZWN0RWRnZS5NSU5fWF0pOworICAgICAgICB0aGlzLl9w cmVzZW50UG9wb3Zlcihwb3BvdmVyKTsKIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xp c3RlbmVycyhXSS5JbmxpbmVTd2F0Y2guRXZlbnQuQWN0aXZhdGVkKTsKIApAQCAtMzgzLDYgKzM4 MSwxMiBAQCBXSS5JbmxpbmVTd2F0Y2ggPSBjbGFzcyBJbmxpbmVTd2F0Y2ggZXh0ZW5kcyBXSS5P YmplY3QKICAgICAgICAgdGhpcy5fdXBkYXRlU3dhdGNoKCk7CiAgICAgfQogCisgICAgX3ByZXNl bnRQb3BvdmVyKHBvcG92ZXIpCisgICAgeworICAgICAgICBsZXQgYm91bmRzID0gV0kuUmVjdC5y ZWN0RnJvbUNsaWVudFJlY3QodGhpcy5fc3dhdGNoRWxlbWVudC5nZXRCb3VuZGluZ0NsaWVudFJl Y3QoKSk7CisgICAgICAgIHBvcG92ZXIucHJlc2VudChib3VuZHMucGFkKDIpLCBbV0kuUmVjdEVk Z2UuTUFYX1ksIFdJLlJlY3RFZGdlLk1JTl9ZLCBXSS5SZWN0RWRnZS5NSU5fWF0pOworICAgIH0K KwogICAgIF9oYW5kbGVDb250ZXh0TWVudUV2ZW50KGV2ZW50KQogICAgIHsKICAgICAgICAgbGV0 IHZhbHVlID0gdGhpcy52YWx1ZTsK 443176 2021-11-02 22:57:22 -0700 2021-11-03 10:47:16 -0700 Patch patch.txt text/plain 2664 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyNjJhMWQ3MDAxYi4uNzI1YzgyZGJiODc3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMS0xMS0wMSAgTmlr aXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBEaXNwbGF5IHN3YXRjaCBwb3BvdmVycyBiZWxvdyB0aGUgc3dhdGNoIGJ5IGRlZmF1bHQs IG5vdCBvbiB0aGUgbGVmdCBzaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzI1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgbmV3IGRlZmF1bHRzIGFyZTogYmVsb3csIGFib3ZlLCBsZWZ0Lgor CisgICAgICAgIERpc3BsYXlpbmcgdGhlIHN3YXRjaCBwb3BvdmVyIG9uIHRoZSBsZWZ0IHNpZGUg Y292ZXJzIHRoZSByZWxldmFudCBwcm9wZXJ0eSBuYW1lLgorICAgICAgICBEaXNwbGF5aW5nIGl0 IGJlbG93IG9yIGFib3ZlIGRvZXNuJ3QgaGF2ZSB0aGlzIHByb2JsZW07IGJlbG93IGlzIHByZWZl cnJlZCBiZWNhdXNlCisgICAgICAgIGl0IGRvZXNuJ3QgaGlkZSB0aGUgQ1NTIHNlbGVjdG9yIG9m IHRoZSByZWxldmFudCBydWxlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Jbmxp bmVTd2F0Y2guanM6CisgICAgICAgIChXSS5JbmxpbmVTd2F0Y2gucHJvdG90eXBlLl9wcmVzZW50 UG9wb3Zlcik6CisgICAgICAgIEludHJvZHVjZSBhIG1ldGhvZCB0byByZW1vdmUgY29kZSBkdXBs aWNhdGlvbi4KKwogMjAyMS0wNy0yNiAgUWlhb3NvbmcgWmhvdSAgPHFpYW9zb25nX3pob3VAYXBw bGUuY29tPgogCiAgICAgICAgIEZvcm1EYXRhRXZlbnQgYWRkZWQuIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpz CmluZGV4IDgxZTQ4ZGI0NDc3Yi4uNDczNzVmNWI2YmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9JbmxpbmVTd2F0Y2guanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSW5saW5lU3dhdGNoLmpzCkBA IC0yMzgsMTIgKzIzOCwxMCBAQCBXSS5JbmxpbmVTd2F0Y2ggPSBjbGFzcyBJbmxpbmVTd2F0Y2gg ZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYgKCF2YWx1ZSkKICAgICAgICAgICAgIHZhbHVl ID0gdGhpcy5fZmFsbGJhY2tWYWx1ZSgpOwogCi0gICAgICAgIGxldCBib3VuZHMgPSBXSS5SZWN0 LnJlY3RGcm9tQ2xpZW50UmVjdCh0aGlzLl9zd2F0Y2hFbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50 UmVjdCgpKTsKICAgICAgICAgbGV0IHBvcG92ZXIgPSBuZXcgV0kuUG9wb3Zlcih0aGlzKTsKIAog ICAgICAgICBwb3BvdmVyLndpbmRvd1Jlc2l6ZUhhbmRsZXIgPSAoKSA9PiB7Ci0gICAgICAgICAg ICBsZXQgYm91bmRzID0gV0kuUmVjdC5yZWN0RnJvbUNsaWVudFJlY3QodGhpcy5fc3dhdGNoRWxl bWVudC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKSk7Ci0gICAgICAgICAgICBwb3BvdmVyLnByZXNl bnQoYm91bmRzLnBhZCgyKSwgW1dJLlJlY3RFZGdlLk1JTl9YXSk7CisgICAgICAgICAgICB0aGlz Ll9wcmVzZW50UG9wb3Zlcihwb3BvdmVyKTsKICAgICAgICAgfTsKIAogICAgICAgICB0aGlzLl92 YWx1ZUVkaXRvciA9IG51bGw7CkBAIC0zMDcsNyArMzA1LDcgQEAgV0kuSW5saW5lU3dhdGNoID0g Y2xhc3MgSW5saW5lU3dhdGNoIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICByZXR1cm47 CiAKICAgICAgICAgcG9wb3Zlci5jb250ZW50ID0gdGhpcy5fdmFsdWVFZGl0b3IuZWxlbWVudDsK LSAgICAgICAgcG9wb3Zlci5wcmVzZW50KGJvdW5kcy5wYWQoMiksIFtXSS5SZWN0RWRnZS5NSU5f WF0pOworICAgICAgICB0aGlzLl9wcmVzZW50UG9wb3Zlcihwb3BvdmVyKTsKIAogICAgICAgICB0 aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXSS5JbmxpbmVTd2F0Y2guRXZlbnQuQWN0aXZh dGVkKTsKIApAQCAtMzgzLDYgKzM4MSwxMiBAQCBXSS5JbmxpbmVTd2F0Y2ggPSBjbGFzcyBJbmxp bmVTd2F0Y2ggZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgdGhpcy5fdXBkYXRlU3dhdGNoKCk7 CiAgICAgfQogCisgICAgX3ByZXNlbnRQb3BvdmVyKHBvcG92ZXIpCisgICAgeworICAgICAgICBs ZXQgYm91bmRzID0gV0kuUmVjdC5yZWN0RnJvbUNsaWVudFJlY3QodGhpcy5fc3dhdGNoRWxlbWVu dC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKSk7CisgICAgICAgIHBvcG92ZXIucHJlc2VudChib3Vu ZHMucGFkKDIpLCBbV0kuUmVjdEVkZ2UuTUFYX1ksIFdJLlJlY3RFZGdlLk1JTl9ZLCBXSS5SZWN0 RWRnZS5NSU5fWF0pOworICAgIH0KKwogICAgIF9oYW5kbGVDb250ZXh0TWVudUV2ZW50KGV2ZW50 KQogICAgIHsKICAgICAgICAgbGV0IHZhbHVlID0gdGhpcy52YWx1ZTsK