232537 2021-10-30 19:44:13 -0700 Change some bitwise OR operators to logical OR 2021-10-31 01:49:28 -0700 1 1 1 Unclassified WebKit Canvas WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim webkit-bug-importer oldest_to_newest 1810472 0 heycam 2021-10-30 19:44:13 -0700 The std::isfinite() checks that various CanvasRenderingContext2DBase methods do should be using logical OR, not bitwise. 1810473 1 webkit-bug-importer 2021-10-30 19:44:42 -0700 <rdar://problem/84845378> 1810474 2 442923 heycam 2021-10-30 19:45:50 -0700 Created attachment 442923 Patch 1810493 3 ews-feeder 2021-10-31 01:49:25 -0700 Committed r285091 (243733@main): <https://commits.webkit.org/243733@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442923. 442923 2021-10-30 19:45:50 -0700 2021-10-31 01:49:26 -0700 Patch bug-232537-20211031134549.patch text/plain 3444 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMzYWIxZDhkMDZkNmYx NGFkZDg0MjQ2YWJhY2ExN2VkY2IwZTM1OS4uN2FiODA1MzZmY2E0MjkxMDY4YWRhMjExMTVjYjYx YzE1MmI3NmNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTEwLTMwICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIHNvbWUg Yml0d2lzZSBPUiBvcGVyYXRvcnMgdG8gbG9naWNhbCBPUgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyNTM3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS84NDg0NTM3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6dHJhbnNsYXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OnRyYW5zZm9y bSk6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpzZXRU cmFuc2Zvcm0pOgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRhdGVSZWN0Rm9yQ2FudmFzKToKKyAg ICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OmNhbkRyYXdUZXh0 KToKKwogMjAyMS0xMC0zMCAgQ2FtZXJvbiBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFVwZGF0ZSBXZWIgSURMIGxpbmtzIHRvIG5ldyBVUkwKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFz ZS5jcHAKaW5kZXggZTc4YTA3MmY4ZmUwOWU0YjYwMDhlZTkzOGI3MTg3YTdmODdkNjJmMS4uMTFi ZDQ2NTAzODU3NWM3MjgxZjRkYjZiMmUwOTMwOWI3OWRiZmMyZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFz ZS5jcHAKQEAgLTc5MCw3ICs3OTAsNyBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJh c2U6OnRyYW5zbGF0ZShkb3VibGUgdHgsIGRvdWJsZSB0eSkKICAgICBpZiAoIXN0YXRlKCkuaGFz SW52ZXJ0aWJsZVRyYW5zZm9ybSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFzdGQ6Omlz ZmluaXRlKHR4KSB8ICFzdGQ6OmlzZmluaXRlKHR5KSkKKyAgICBpZiAoIXN0ZDo6aXNmaW5pdGUo dHgpIHx8ICFzdGQ6OmlzZmluaXRlKHR5KSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQWZmaW5l VHJhbnNmb3JtIG5ld1RyYW5zZm9ybSA9IHN0YXRlKCkudHJhbnNmb3JtOwpAQCAtODEzLDcgKzgx Myw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6dHJhbnNmb3JtKGRvdWJs ZSBtMTEsIGRvdWJsZSBtMTIsIGRvdWJsZSBtMjEsCiAgICAgaWYgKCFzdGF0ZSgpLmhhc0ludmVy dGlibGVUcmFuc2Zvcm0pCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghc3RkOjppc2Zpbml0 ZShtMTEpIHwgIXN0ZDo6aXNmaW5pdGUobTIxKSB8ICFzdGQ6OmlzZmluaXRlKGR4KSB8ICFzdGQ6 OmlzZmluaXRlKG0xMikgfCAhc3RkOjppc2Zpbml0ZShtMjIpIHwgIXN0ZDo6aXNmaW5pdGUoZHkp KQorICAgIGlmICghc3RkOjppc2Zpbml0ZShtMTEpIHx8ICFzdGQ6OmlzZmluaXRlKG0yMSkgfHwg IXN0ZDo6aXNmaW5pdGUoZHgpIHx8ICFzdGQ6OmlzZmluaXRlKG0xMikgfHwgIXN0ZDo6aXNmaW5p dGUobTIyKSB8fCAhc3RkOjppc2Zpbml0ZShkeSkpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFm ZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm0obTExLCBtMTIsIG0yMSwgbTIyLCBkeCwgZHkpOwpAQCAt ODQzLDcgKzg0Myw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6c2V0VHJh bnNmb3JtKGRvdWJsZSBtMTEsIGRvdWJsZSBtMTIsIGRvdWJsZSBtCiAgICAgaWYgKCFjKQogICAg ICAgICByZXR1cm47CiAKLSAgICBpZiAoIXN0ZDo6aXNmaW5pdGUobTExKSB8ICFzdGQ6OmlzZmlu aXRlKG0yMSkgfCAhc3RkOjppc2Zpbml0ZShkeCkgfCAhc3RkOjppc2Zpbml0ZShtMTIpIHwgIXN0 ZDo6aXNmaW5pdGUobTIyKSB8ICFzdGQ6OmlzZmluaXRlKGR5KSkKKyAgICBpZiAoIXN0ZDo6aXNm aW5pdGUobTExKSB8fCAhc3RkOjppc2Zpbml0ZShtMjEpIHx8ICFzdGQ6OmlzZmluaXRlKGR4KSB8 fCAhc3RkOjppc2Zpbml0ZShtMTIpIHx8ICFzdGQ6OmlzZmluaXRlKG0yMikgfHwgIXN0ZDo6aXNm aW5pdGUoZHkpKQogICAgICAgICByZXR1cm47CiAKICAgICByZXNldFRyYW5zZm9ybSgpOwpAQCAt OTY3LDcgKzk2Nyw3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFzZTo6YmVnaW5Q YXRoKCkKIAogc3RhdGljIGJvb2wgdmFsaWRhdGVSZWN0Rm9yQ2FudmFzKGRvdWJsZSYgeCwgZG91 YmxlJiB5LCBkb3VibGUmIHdpZHRoLCBkb3VibGUmIGhlaWdodCkKIHsKLSAgICBpZiAoIXN0ZDo6 aXNmaW5pdGUoeCkgfCAhc3RkOjppc2Zpbml0ZSh5KSB8ICFzdGQ6OmlzZmluaXRlKHdpZHRoKSB8 ICFzdGQ6OmlzZmluaXRlKGhlaWdodCkpCisgICAgaWYgKCFzdGQ6OmlzZmluaXRlKHgpIHx8ICFz dGQ6OmlzZmluaXRlKHkpIHx8ICFzdGQ6OmlzZmluaXRlKHdpZHRoKSB8fCAhc3RkOjppc2Zpbml0 ZShoZWlnaHQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoIXdpZHRoICYmICFo ZWlnaHQpCkBAIC0yMzQ1LDcgKzIzNDUsNyBAQCBib29sIENhbnZhc1JlbmRlcmluZ0NvbnRleHQy REJhc2U6OmNhbkRyYXdUZXh0KGRvdWJsZSB4LCBkb3VibGUgeSwgYm9vbCBmaWxsLCBzdAogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFzdGF0ZSgpLmhhc0ludmVydGlibGVUcmFuc2Zv cm0pCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAoIXN0ZDo6aXNmaW5pdGUoeCkgfCAh c3RkOjppc2Zpbml0ZSh5KSkKKyAgICBpZiAoIXN0ZDo6aXNmaW5pdGUoeCkgfHwgIXN0ZDo6aXNm aW5pdGUoeSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAobWF4V2lkdGggJiYgKCFz dGQ6OmlzZmluaXRlKG1heFdpZHRoLnZhbHVlKCkpIHx8IG1heFdpZHRoLnZhbHVlKCkgPD0gMCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsK