232516 2021-10-29 16:54:19 -0700 [GTK] Remove on-demand hardware acceleration setting 2023-02-01 08:36:37 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=125526 https://bugs.webkit.org/show_bug.cgi?id=244835 P2 Normal --- 210100 1 mcatanzaro mcatanzaro alicem bugs-noreply mcatanzaro oldest_to_newest 1810322 0 mcatanzaro 2021-10-29 16:54:19 -0700 I understand that GTK 4 port requires always-on accelerated compositing mode. Is this correct? If so, we should remove the setting from public API. 1862896 1 mcatanzaro 2022-04-20 05:23:26 -0700 I was planning to remove WebKitHardwareAccelerationPolicy and associated functions altogether. I see Carlos has suggested in bug #125526 that we should maybe not do that after all. Not sure what to do now. Remove only the on demand policy? 1893248 2 mcatanzaro 2022-08-23 08:28:18 -0700 Hi Carlos Garcia, hi Alexander, can you discuss and provide a clear answer as to whether we'll still have hardware acceleration policy in the new API version? Alexander was saying as recently as a couple days ago that hardware acceleration is mandatory with GTK 4, but this is contradicted by Carlos's comment in bug #125526. Which is true? I understand WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND goes away no matter what. The question is whether to continue to provide WEBKIT_HARDWARE_ACCELERATION_POLICY_NEVER or not. 1893249 3 alicem 2022-08-23 08:29:51 -0700 I mean as far as I know nonaccelerated doesn't work with GTK4 at least right now? Certainly I wasn't able to switch to it in minibrowser at least a while ago. 1893252 4 mcatanzaro 2022-08-23 08:45:13 -0700 Talked to Carlos. Sounds like it *could* work but doesn't. I will plan to remove the API. If somebody implements it, then we can restore the API. 1896485 5 mcatanzaro 2022-09-06 06:11:55 -0700 Implemented in bug #244835. So we should only remove the on-demand policy, not the entire API. 1929820 6 mcatanzaro 2023-01-31 11:56:14 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9398 1930127 7 ews-feeder 2023-02-01 08:36:33 -0800 Committed 259686@main (7e5444b964e5): <https://commits.webkit.org/259686@main> Reviewed commits have been landed. Closing PR #9398 and removing active labels.