232514 2021-10-29 15:50:39 -0700 [WTF] Minor clean-up for format-related functions 2021-11-02 15:20:21 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin bfulgham cdumez cmarcelo darin ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1810298 0 ddkilzer 2021-10-29 15:50:39 -0700 Minor clean-up for format-related functions. 1810299 1 442876 ddkilzer 2021-10-29 15:52:50 -0700 Created attachment 442876 Patch v1 1810305 2 442876 ddkilzer 2021-10-29 16:04:35 -0700 Comment on attachment 442876 Patch v1 Need to compile macOS as well! 1811245 3 443129 ddkilzer 2021-11-02 13:36:33 -0700 Created attachment 443129 Patch v2 1811246 4 ddkilzer 2021-11-02 13:37:41 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 443129 [details] > Patch v2 Dropped the changes to Assertions.h since macOS has some `LOG()` calls that don't have any arguments past the `format` string. 1811275 5 443129 ysuzuki 2021-11-02 14:46:38 -0700 Comment on attachment 443129 Patch v2 r=me 1811289 6 443129 ddkilzer 2021-11-02 15:13:54 -0700 Comment on attachment 443129 Patch v2 Marking as cq+ since this built successfully on a sufficient number of platforms. 1811292 7 ews-feeder 2021-11-02 15:19:29 -0700 Committed r285188 (243817@main): <https://commits.webkit.org/243817@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443129. 1811293 8 webkit-bug-importer 2021-11-02 15:20:21 -0700 <rdar://problem/84949628> 442876 2021-10-29 15:52:50 -0700 2021-10-29 16:16:39 -0700 Patch v1 bug-232514-20211029155249.patch text/plain 3357 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI5N2M5NTBjZjljMGVjNmZjMzNjNzRm MmJkNzI4ODQ4ZTE1MWFlOWQuLmIwYjY2NWJjYjZlYTI5ODc3ZGUxOGJmMGQxY2E0ZjJkMjQwYTVl NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMTAtMjkgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBNaW5vciBjbGVhbi11cCBmb3IgZm9ybWF0 LXJlbGF0ZWQgZnVuY3Rpb25zCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzI1MTQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv QXNzZXJ0aW9ucy5jcHA6CisgICAgICAgIChXVEY6OmNyZWF0ZVdpdGhGb3JtYXRBbmRBcmd1bWVu dHMpOgorICAgICAgICAtIFB1dCBXVEZfQVRUUklCVVRFX1BSSU5URigpIG9uIGl0cyBvd24gbGlu ZSB0byBtYXRjaCBvdGhlcgorICAgICAgICAgIGZ1bmN0aW9ucy4KKyAgICAgICAgKFdURjo6dnBy aW50Zl9zdGRlcnJfd2l0aF9wcmVmaXgpOgorICAgICAgICAoV1RGOjp2cHJpbnRmX3N0ZGVycl93 aXRoX3RyYWlsaW5nX25ld2xpbmUpOgorICAgICAgICAtIE1vdmUgQUxMT1dfTk9OTElURVJBTF9G T1JNQVRfe0JFR0lOLEVORH0gYXJvdW5kIHNwZWNpZmljCisgICAgICAgICAgZnVuY3Rpb24gY2Fs bHMgdGhhdCBuZWVkIHRoZW0uCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKyAgICAgICAg KExPRyk6CisgICAgICAgIC0gQWRkIGV4cGxpY2l0IGZvcm1hdCBhcmd1bWVudCB0byBtYXRjaCBX VEZMb2coKSBhcmcgbGlzdC4KKwogMjAyMS0xMC0yOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgWyBNYWMgd2sxIF0gMiBtZWRpYS1jYXBhYmlsaXRpZXMvd2Vi cnRjIHRlc3RzIGFyZSBmbGFreSBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv QXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcAppbmRleCBiMDdj NjE0ODk4ZWE3MmYwZTlmODBhZDg2Yjk0YzlhOTc5NzdlYmI4Li45ZjNmYmE0YzQxMDA3M2VhM2Ux YzNmZTY3MzI3MTBmZWQ3MDlhYjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcApAQCAtNjksNyArNjks OCBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAotV1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMCkgc3Rh dGljIFN0cmluZyBjcmVhdGVXaXRoRm9ybWF0QW5kQXJndW1lbnRzKGNvbnN0IGNoYXIqIGZvcm1h dCwgdmFfbGlzdCBhcmdzKQorV1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMCkKK3N0YXRpYyBTdHJp bmcgY3JlYXRlV2l0aEZvcm1hdEFuZEFyZ3VtZW50cyhjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xp c3QgYXJncykKIHsKICAgICB2YV9saXN0IGFyZ3NDb3B5OwogICAgIHZhX2NvcHkoYXJnc0NvcHks IGFyZ3MpOwpAQCAtMTgyLDggKzE4Myw2IEBAIHN0YXRpYyB2b2lkIHZwcmludGZfc3RkZXJyX2Nv bW1vbihjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xpc3QgYXJncykKICAgICB2ZnByaW50ZihzdGRl cnIsIGZvcm1hdCwgYXJncyk7CiB9CiAKLUFMTE9XX05PTkxJVEVSQUxfRk9STUFUX0JFR0lOCi0K IFdURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDApCiBzdGF0aWMgdm9pZCB2cHJpbnRmX3N0ZGVycl93 aXRoX3ByZWZpeChjb25zdCBjaGFyKiBwcmVmaXgsIGNvbnN0IGNoYXIqIGZvcm1hdCwgdmFfbGlz dCBhcmdzKQogewpAQCAtMTk0LDcgKzE5Myw5IEBAIHN0YXRpYyB2b2lkIHZwcmludGZfc3RkZXJy X3dpdGhfcHJlZml4KGNvbnN0IGNoYXIqIHByZWZpeCwgY29uc3QgY2hhciogZm9ybWF0LCB2CiAg ICAgbWVtY3B5KGZvcm1hdFdpdGhQcmVmaXguZGF0YSgpICsgcHJlZml4TGVuZ3RoLCBmb3JtYXQs IGZvcm1hdExlbmd0aCk7CiAgICAgZm9ybWF0V2l0aFByZWZpeFtwcmVmaXhMZW5ndGggKyBmb3Jt YXRMZW5ndGhdID0gMDsKIAorICAgIEFMTE9XX05PTkxJVEVSQUxfRk9STUFUX0JFR0lOCiAgICAg dnByaW50Zl9zdGRlcnJfY29tbW9uKGZvcm1hdFdpdGhQcmVmaXguZGF0YSgpLCBhcmdzKTsKKyAg ICBBTExPV19OT05MSVRFUkFMX0ZPUk1BVF9FTkQKIH0KIAogV1RGX0FUVFJJQlVURV9QUklOVEYo MSwgMCkKQEAgLTIxMSwxMSArMjEyLDExIEBAIHN0YXRpYyB2b2lkIHZwcmludGZfc3RkZXJyX3dp dGhfdHJhaWxpbmdfbmV3bGluZShjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xpc3QgYXJnCiAgICAg Zm9ybWF0V2l0aE5ld2xpbmVbZm9ybWF0TGVuZ3RoXSA9ICdcbic7CiAgICAgZm9ybWF0V2l0aE5l d2xpbmVbZm9ybWF0TGVuZ3RoICsgMV0gPSAwOwogCisgICAgQUxMT1dfTk9OTElURVJBTF9GT1JN QVRfQkVHSU4KICAgICB2cHJpbnRmX3N0ZGVycl9jb21tb24oZm9ybWF0V2l0aE5ld2xpbmUuZGF0 YSgpLCBhcmdzKTsKKyAgICBBTExPV19OT05MSVRFUkFMX0ZPUk1BVF9FTkQKIH0KIAotQUxMT1df Tk9OTElURVJBTF9GT1JNQVRfRU5ECi0KIFdURl9BVFRSSUJVVEVfUFJJTlRGKDEsIDIpCiBzdGF0 aWMgdm9pZCBwcmludGZfc3RkZXJyX2NvbW1vbihjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3Rm L0Fzc2VydGlvbnMuaAppbmRleCBiZjExZmMxNzA4MzU4OGE5MThhYmRmZWU0ZGQ4MDkwZmRmMjRi N2IyLi5iZjM3YTAwMGE4MDEyYWIxYzIxZjI5NTI1NjM2YmUxNmQzNjVhZTVhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0 aW9ucy5oCkBAIC00OTIsOSArNDkyLDkgQEAgY29uc3RleHByIGJvb2wgYXNzZXJ0aW9uRmFpbHVy ZUR1ZVRvVW5yZWFjaGFibGVDb2RlID0gZmFsc2U7CiAvKiBMT0cgKi8KIAogI2lmIExPR19ESVNB QkxFRAotI2RlZmluZSBMT0coY2hhbm5lbCwgLi4uKSAoKHZvaWQpMCkKKyNkZWZpbmUgTE9HKGNo YW5uZWwsIGZvcm1hdCwgLi4uKSAoKHZvaWQpMCkKICNlbHNlCi0jZGVmaW5lIExPRyhjaGFubmVs LCAuLi4pIFdURkxvZygmTE9HX0NIQU5ORUwoY2hhbm5lbCksIF9fVkFfQVJHU19fKQorI2RlZmlu ZSBMT0coY2hhbm5lbCwgZm9ybWF0LCAuLi4pIFdURkxvZygmTE9HX0NIQU5ORUwoY2hhbm5lbCks IGZvcm1hdCwgX19WQV9BUkdTX18pCiAjZW5kaWYKIAogLyogTE9HX1ZFUkJPU0UgKi8K 443129 2021-11-02 13:36:33 -0700 2021-11-02 15:19:31 -0700 Patch v2 bug-232514-20211102133632.patch text/plain 2597 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMzZDZhN2E5Y2VlMTVjNmI5OTc3Zjg0 MDIzM2JlMTA3MmEyYmY4NzQuLjY0ZTUxMGY0YzFjYmE5OTEzMzIzMTFiYjI0MmEyMDliM2ZmMjc5 NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTEtMDIgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBNaW5vciBjbGVhbi11cCBmb3IgZm9ybWF0 LXJlbGF0ZWQgZnVuY3Rpb25zCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzI1MTQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv QXNzZXJ0aW9ucy5jcHA6CisgICAgICAgIChXVEY6OmNyZWF0ZVdpdGhGb3JtYXRBbmRBcmd1bWVu dHMpOgorICAgICAgICAtIFB1dCBXVEZfQVRUUklCVVRFX1BSSU5URigpIG9uIGl0cyBvd24gbGlu ZSB0byBtYXRjaCBvdGhlcgorICAgICAgICAgIGZ1bmN0aW9ucy4KKyAgICAgICAgKFdURjo6dnBy aW50Zl9zdGRlcnJfd2l0aF9wcmVmaXgpOgorICAgICAgICAoV1RGOjp2cHJpbnRmX3N0ZGVycl93 aXRoX3RyYWlsaW5nX25ld2xpbmUpOgorICAgICAgICAtIE1vdmUgQUxMT1dfTk9OTElURVJBTF9G T1JNQVRfe0JFR0lOLEVORH0gYXJvdW5kIHNwZWNpZmljCisgICAgICAgICAgZnVuY3Rpb24gY2Fs bHMgdGhhdCBuZWVkIHRoZW0uCisKIDIwMjEtMTEtMDIgIFBoaWxpcCBDaGltZW50byAgPHBjaGlt ZW50b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKU0NdIEltcGxlbWVudCBUZW1wb3JhbC5JbnN0 YW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmNwcCBiL1NvdXJjZS9X VEYvd3RmL0Fzc2VydGlvbnMuY3BwCmluZGV4IGIwN2M2MTQ4OThlYTcyZjBlOWY4MGFkODZiOTRj OWE5Nzk3N2ViYjguLjlmM2ZiYTRjNDEwMDczZWEzZTFjM2ZlNjczMjcxMGZlZDcwOWFiNmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XVEYv d3RmL0Fzc2VydGlvbnMuY3BwCkBAIC02OSw3ICs2OSw4IEBACiAKIG5hbWVzcGFjZSBXVEYgewog Ci1XVEZfQVRUUklCVVRFX1BSSU5URigxLCAwKSBzdGF0aWMgU3RyaW5nIGNyZWF0ZVdpdGhGb3Jt YXRBbmRBcmd1bWVudHMoY29uc3QgY2hhciogZm9ybWF0LCB2YV9saXN0IGFyZ3MpCitXVEZfQVRU UklCVVRFX1BSSU5URigxLCAwKQorc3RhdGljIFN0cmluZyBjcmVhdGVXaXRoRm9ybWF0QW5kQXJn dW1lbnRzKGNvbnN0IGNoYXIqIGZvcm1hdCwgdmFfbGlzdCBhcmdzKQogewogICAgIHZhX2xpc3Qg YXJnc0NvcHk7CiAgICAgdmFfY29weShhcmdzQ29weSwgYXJncyk7CkBAIC0xODIsOCArMTgzLDYg QEAgc3RhdGljIHZvaWQgdnByaW50Zl9zdGRlcnJfY29tbW9uKGNvbnN0IGNoYXIqIGZvcm1hdCwg dmFfbGlzdCBhcmdzKQogICAgIHZmcHJpbnRmKHN0ZGVyciwgZm9ybWF0LCBhcmdzKTsKIH0KIAot QUxMT1dfTk9OTElURVJBTF9GT1JNQVRfQkVHSU4KLQogV1RGX0FUVFJJQlVURV9QUklOVEYoMiwg MCkKIHN0YXRpYyB2b2lkIHZwcmludGZfc3RkZXJyX3dpdGhfcHJlZml4KGNvbnN0IGNoYXIqIHBy ZWZpeCwgY29uc3QgY2hhciogZm9ybWF0LCB2YV9saXN0IGFyZ3MpCiB7CkBAIC0xOTQsNyArMTkz LDkgQEAgc3RhdGljIHZvaWQgdnByaW50Zl9zdGRlcnJfd2l0aF9wcmVmaXgoY29uc3QgY2hhciog cHJlZml4LCBjb25zdCBjaGFyKiBmb3JtYXQsIHYKICAgICBtZW1jcHkoZm9ybWF0V2l0aFByZWZp eC5kYXRhKCkgKyBwcmVmaXhMZW5ndGgsIGZvcm1hdCwgZm9ybWF0TGVuZ3RoKTsKICAgICBmb3Jt YXRXaXRoUHJlZml4W3ByZWZpeExlbmd0aCArIGZvcm1hdExlbmd0aF0gPSAwOwogCisgICAgQUxM T1dfTk9OTElURVJBTF9GT1JNQVRfQkVHSU4KICAgICB2cHJpbnRmX3N0ZGVycl9jb21tb24oZm9y bWF0V2l0aFByZWZpeC5kYXRhKCksIGFyZ3MpOworICAgIEFMTE9XX05PTkxJVEVSQUxfRk9STUFU X0VORAogfQogCiBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAwKQpAQCAtMjExLDExICsyMTIsMTEg QEAgc3RhdGljIHZvaWQgdnByaW50Zl9zdGRlcnJfd2l0aF90cmFpbGluZ19uZXdsaW5lKGNvbnN0 IGNoYXIqIGZvcm1hdCwgdmFfbGlzdCBhcmcKICAgICBmb3JtYXRXaXRoTmV3bGluZVtmb3JtYXRM ZW5ndGhdID0gJ1xuJzsKICAgICBmb3JtYXRXaXRoTmV3bGluZVtmb3JtYXRMZW5ndGggKyAxXSA9 IDA7CiAKKyAgICBBTExPV19OT05MSVRFUkFMX0ZPUk1BVF9CRUdJTgogICAgIHZwcmludGZfc3Rk ZXJyX2NvbW1vbihmb3JtYXRXaXRoTmV3bGluZS5kYXRhKCksIGFyZ3MpOworICAgIEFMTE9XX05P TkxJVEVSQUxfRk9STUFUX0VORAogfQogCi1BTExPV19OT05MSVRFUkFMX0ZPUk1BVF9FTkQKLQog V1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMikKIHN0YXRpYyB2b2lkIHByaW50Zl9zdGRlcnJfY29t bW9uKGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4uKQogewo=