232478 2021-10-29 00:34:25 -0700 ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes. 2022-08-11 02:59:12 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 232476 232472 1 kkinnunen kkinnunen dino geofflang kbr kkinnunen kpiddington webkit-bug-importer oldest_to_newest 1809992 0 kkinnunen 2021-10-29 00:34:25 -0700 ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes. ecf27c717f478fc0dfc880a982793fb120284431 1810017 1 442800 kkinnunen 2021-10-29 02:39:43 -0700 Created attachment 442800 Patch 1811397 2 kbr 2021-11-02 23:37:09 -0700 Are you sure you want to cherry-pick this? I'm not sure it increased stability in Chrome, and will only make WebKit's and upstream ANGLE diverge further. 1811508 3 kkinnunen 2021-11-03 10:16:30 -0700 (In reply to Kenneth Russell from comment #2) > Are you sure you want to cherry-pick this? I'm not sure it increased > stability in Chrome, and will only make WebKit's and upstream ANGLE diverge > further. If I understand correctly, bug 232476 is part of mitigation for the crashes. That patch contains a bug that is fixed by this patch? 1811529 4 webkit-bug-importer 2021-11-03 10:46:32 -0700 <rdar://problem/84981626> 1811982 5 kbr 2021-11-04 15:45:24 -0700 I see. Yes, these were all CLs associated with the parent bug (https://crbug.com/1181068). I'm not sure though how much the flush-related work improved stability. Maybe geofflang@ can comment. Chunking TexSubImage2D calls into 120 KB max chunks was the primary workaround for the kernel panics. 1812637 6 geofflang 2021-11-08 09:09:49 -0800 This patch definitely trended the total flush crashes down too. The largest fix was the final one which fixed some invalid GL usage in Chrome. Won't this roll into WebKit when ANGLE synchronizes? 1812822 7 kbr 2021-11-08 14:00:02 -0800 Thanks Geoff. It will come into WebKit during the next ANGLE roll into WebKit. It was unclear whether the WebKit team needed this sooner - we're aiming for a matter of a week or two for that roll. 1890532 8 kkinnunen 2022-08-11 02:59:12 -0700 This was merged as part of ANGLE update. 442800 2021-10-29 02:39:43 -0700 2021-10-29 02:39:43 -0700 Patch bug-232478-20211029123941.patch text/plain 2015 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg1MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZGQ5N2M4Njk1Yzk0NWE4NWY1ZWJmNjhjMjFhYjAxYWNjNjczZjYxNC4uNWRiMjA5MGViMDM5 MTU5MWE1M2ZkMjcyNzVkODRiNjA2OWIzMDk1NSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTEwLTI5ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgT3BlbkdMOiBDaGVycnktcGljayBjb21taXQg R0w6IEZpeCBidWcgd2l0aDogU2tpcCByZWR1bmRhbnQgZmx1c2hlcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjQ3OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyb20gZWNmMjdjNzE3ZjQ3OGZjMGRm Yzg4MGE5ODI3OTNmYjEyMDI4NDQzMSBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKKyAgICAgICAg RnJvbTogSWFuIEVsbGlvdHQgPGlhbmVsbGlvdHRAZ29vZ2xlLmNvbT4KKyAgICAgICAgRGF0ZTog V2VkLCAxNiBKdW4gMjAyMSAxMzoxMzozMSAtMDYwMAorICAgICAgICBHTDogRml4IGJ1ZyB3aXRo OiBTa2lwIHJlZHVuZGFudCBmbHVzaGVzLgorCisgICAgICAgIFRoZSBBTkdMRS1pbnRvLVNraWEg YXV0b3JvbGxlciBpcyBibG9ja2VkIGJlY2F1c2Ugb2YgdGhlIGZvbGxvd2luZyBDTDoKKyAgICAg ICAgaHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS9jL2FuZ2xlL2FuZ2xl LysvMjk1NjQ1MworCisgICAgICAgIE1pY2hhZWwgTHVkd2lnLCBhIFNraWEgZW5naW5lZXIsIGZv dW5kIHRoYXQgdGhpcyBjaGFuZ2UgZml4ZXMgdGhlCisgICAgICAgIHByb2JsZW0gYW5kIHdpbGwg dW5ibG9jayB0aGUgYXV0by1yb2xsZXIuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVy ZXIvZ2wvRmVuY2VOVkdMLmNwcDoKKyAgICAgICAgKHJ4OjpGZW5jZU5WR0w6OnNldCk6CisKIDIw MjEtMTAtMjkgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBBTkdMRSBPcGVuR0w6IENoZXJyeS1waWNrIGNvbW1pdCBHTDogUmVzcGVjdCBUZXhTdWJJbWFn ZSB1cGxvYWQgbGltaXRzIGZvciByb2J1c3QgaW5pdApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL0ZlbmNlTlZHTC5jcHAgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvRmVuY2VOVkdMLmNw cAppbmRleCBhOGMwMDJmNDkzYzk0ZjM2ZmYzZjVhZDU2ZDc3OGExNDVlOWVhYmE5Li4yNDkxYjY4 ZWM0MjZlNWRiNmUxNmVmYWMwMjU5ZGY4MDVmYWM5ODlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvRmVuY2VOVkdMLmNwcAorKysg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvRmVuY2VO VkdMLmNwcApAQCAtMzAsNyArMzAsOSBAQCBGZW5jZU5WR0w6On5GZW5jZU5WR0woKQogYW5nbGU6 OlJlc3VsdCBGZW5jZU5WR0w6OnNldChjb25zdCBnbDo6Q29udGV4dCAqY29udGV4dCwgR0xlbnVt IGNvbmRpdGlvbikKIHsKICAgICBBU1NFUlQoY29uZGl0aW9uID09IEdMX0FMTF9DT01QTEVURURf TlYpOworICAgIENvbnRleHRHTCAqY29udGV4dEdMID0gR2V0SW1wbEFzPENvbnRleHRHTD4oY29u dGV4dCk7CiAgICAgbUZ1bmN0aW9ucy0+c2V0RmVuY2VOVihtRmVuY2UsIGNvbmRpdGlvbik7Cisg ICAgY29udGV4dEdMLT5tYXJrV29ya1N1Ym1pdHRlZCgpOwogICAgIHJldHVybiBhbmdsZTo6UmVz dWx0OjpDb250aW51ZTsKIH0KIAo=