232460 2021-10-28 15:35:58 -0700 Layout test is crashing inside WebChromeClient::createWindow 2021-10-28 21:19:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1809872 0 pvollan 2021-10-28 15:35:58 -0700 The test fast/frames/sandboxed-iframe-close-top-noclose.html is crashing under WebChromeClient::createWindow. 1809873 1 pvollan 2021-10-28 15:36:22 -0700 <rdar://81344393> 1809875 2 442755 pvollan 2021-10-28 15:41:34 -0700 Created attachment 442755 Patch 1809879 3 442755 bfulgham 2021-10-28 15:47:08 -0700 Comment on attachment 442755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442755&action=review r=me > Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm:315 > + if (hostProxy && !hostProxy->isMenuBarVisible()) { Should we log something when we have a set of plugin hosts with no host? Should we remove the m_pluginHosts entry if the value is nil? 1809885 4 442761 pvollan 2021-10-28 16:13:17 -0700 Created attachment 442761 Patch 1809889 5 pvollan 2021-10-28 16:19:46 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 442755 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442755&action=review > > r=me > > > Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm:315 > > + if (hostProxy && !hostProxy->isMenuBarVisible()) { > > Should we log something when we have a set of plugin hosts with no host? > > Should we remove the m_pluginHosts entry if the value is nil? That is a good point. I have added logging in the latest patch. It would also be good to remove the items with nil value, although I did not include that in the latest patch, since there could possibly be side effects from doing that. Thanks for reviewing! 1809942 6 442775 pvollan 2021-10-28 20:23:03 -0700 Created attachment 442775 Patch 1809953 7 ews-feeder 2021-10-28 21:19:07 -0700 Committed r285018 (243662@main): <https://commits.webkit.org/243662@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442775. 442755 2021-10-28 15:41:34 -0700 2021-10-28 15:47:08 -0700 Patch bug-232460-20211028154133.patch text/plain 1577 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTAwNSkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDIxLTEwLTI4ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dCB0ZXN0IGlzIGNyYXNoaW5nIGluc2lkZSBXZWJDaHJvbWVDbGllbnQ6OmNyZWF0 ZVdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMyNDYwCisgICAgICAgIDxyZGFyOi8vODEzNDQzOTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG51bGwgY2hlY2sgZm9yIGxvY2FsIE5ldHNj YXBlUGx1Z2luSG9zdFByb3h5IHBvaW50ZXIgdmFyaWFibGUuCisKKyAgICAgICAgKiBQbHVnaW5z L0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tOgorICAgICAgICAoV2ViS2l0OjpO ZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyOjpkaWRDcmVhdGVXaW5kb3cpOgorCiAyMDIxLTEwLTI4 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg RGlzYWJsZSBORVRTQ0FQRV9QTFVHSU5fQVBJIGF0IGJ1aWxkIHRpbWUgb24gbWFjT1MgYW5kIFdp bmRvd3MKSW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvSG9zdGVkL05ldHNj YXBlUGx1Z2luSG9zdE1hbmFnZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbQkocmV2aXNp b24gMjg0NzgzKQorKysgU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0 c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMzEyLDcgKzMxMiw3 IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlcjo6ZGlkQ3JlYXQKICAgICBmb3IgKFBs dWdpbkhvc3RNYXA6Oml0ZXJhdG9yIGl0ID0gbV9wbHVnaW5Ib3N0cy5iZWdpbigpOyBpdCAhPSBl bmQ7ICsraXQpIHsKICAgICAgICAgTmV0c2NhcGVQbHVnaW5Ib3N0UHJveHkqIGhvc3RQcm94eSA9 IGl0LT52YWx1ZTsKICAgICAgICAgCi0gICAgICAgIGlmICghaG9zdFByb3h5LT5pc01lbnVCYXJW aXNpYmxlKCkpIHsKKyAgICAgICAgaWYgKGhvc3RQcm94eSAmJiAhaG9zdFByb3h5LT5pc01lbnVC YXJWaXNpYmxlKCkpIHsKICAgICAgICAgICAgIC8vIE1ha2Ugb3Vyc2VsdmVzIHRoZSBmcm9udCBw cm9jZXNzLgogICAgICAgICAgICAgUHJvY2Vzc1NlcmlhbE51bWJlciBwc247CiAgICAgICAgICAg ICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgo= 442761 2021-10-28 16:13:17 -0700 2021-10-28 16:13:17 -0700 Patch bug-232460-20211028161316.patch text/plain 1692 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTAwNSkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDIxLTEwLTI4ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dCB0ZXN0IGlzIGNyYXNoaW5nIGluc2lkZSBXZWJDaHJvbWVDbGllbnQ6OmNyZWF0 ZVdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMyNDYwCisgICAgICAgIDxyZGFyOi8vODEzNDQzOTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QnJlbnQgRnVsZ2hhbS4KKworICAgICAgICBBZGQgbnVsbCBjaGVjayBmb3IgbG9jYWwgTmV0c2Nh cGVQbHVnaW5Ib3N0UHJveHkgcG9pbnRlciB2YXJpYWJsZS4KKworICAgICAgICAqIFBsdWdpbnMv SG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdE1hbmFnZXIubW06CisgICAgICAgIChXZWJLaXQ6Ok5l dHNjYXBlUGx1Z2luSG9zdE1hbmFnZXI6OmRpZENyZWF0ZVdpbmRvdyk6CisKIDIwMjEtMTAtMjgg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBE aXNhYmxlIE5FVFNDQVBFX1BMVUdJTl9BUEkgYXQgYnVpbGQgdGltZSBvbiBtYWNPUyBhbmQgV2lu ZG93cwpJbmRleDogU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2Nh cGVQbHVnaW5Ib3N0TWFuYWdlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tCShyZXZpc2lv biAyODQ3ODMpCisrKyBTb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRz Y2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMTEsNyArMzExLDEy IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlcjo6ZGlkQ3JlYXQKICAgICBQbHVnaW5I b3N0TWFwOjppdGVyYXRvciBlbmQgPSBtX3BsdWdpbkhvc3RzLmVuZCgpOwogICAgIGZvciAoUGx1 Z2luSG9zdE1hcDo6aXRlcmF0b3IgaXQgPSBtX3BsdWdpbkhvc3RzLmJlZ2luKCk7IGl0ICE9IGVu ZDsgKytpdCkgewogICAgICAgICBOZXRzY2FwZVBsdWdpbkhvc3RQcm94eSogaG9zdFByb3h5ID0g aXQtPnZhbHVlOwotICAgICAgICAKKworICAgICAgICBpZiAoIWhvc3RQcm94eSkgeworICAgICAg ICAgICAgTE9HX0VSUk9SKCJDb3VsZCBub3QgZmluZCBhIE5ldHNjYXBlUGx1Z2luSG9zdFByb3h5 IGZvciBrZXkgJXMuIiwgaXQtPmtleS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgICAgIGNvbnRp bnVlOworICAgICAgICB9CisKICAgICAgICAgaWYgKCFob3N0UHJveHktPmlzTWVudUJhclZpc2li bGUoKSkgewogICAgICAgICAgICAgLy8gTWFrZSBvdXJzZWx2ZXMgdGhlIGZyb250IHByb2Nlc3Mu CiAgICAgICAgICAgICBQcm9jZXNzU2VyaWFsTnVtYmVyIHBzbjsK 442775 2021-10-28 20:23:03 -0700 2021-10-28 21:19:07 -0700 Patch bug-232460-20211028202302.patch text/plain 1698 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTAwNSkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE2IEBACisyMDIxLTEwLTI4ICBQZXIgQXJuZSBWb2xsYW4gPHB2b2xsYW5AYXBwbGUuY29tPgor CisgICAgICAgIExheW91dCB0ZXN0IGlzIGNyYXNoaW5nIGluc2lkZSBXZWJDaHJvbWVDbGllbnQ6 OmNyZWF0ZVdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjMyNDYwCisgICAgICAgIDxyZGFyOi8vODEzNDQzOTM+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICBBZGQgbnVsbCBjaGVjayBmb3IgbG9jYWwg TmV0c2NhcGVQbHVnaW5Ib3N0UHJveHkgcG9pbnRlciB2YXJpYWJsZS4KKworICAgICAgICAqIFBs dWdpbnMvSG9zdGVkL05ldHNjYXBlUGx1Z2luSG9zdE1hbmFnZXIubW06CisgICAgICAgIChXZWJL aXQ6Ok5ldHNjYXBlUGx1Z2luSG9zdE1hbmFnZXI6OmRpZENyZWF0ZVdpbmRvdyk6CisKIDIwMjEt MTAtMjggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBEaXNhYmxlIE5FVFNDQVBFX1BMVUdJTl9BUEkgYXQgYnVpbGQgdGltZSBvbiBtYWNPUyBh bmQgV2luZG93cwpJbmRleDogU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQv TmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tCShy ZXZpc2lvbiAyODQ3ODMpCisrKyBTb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL0hvc3Rl ZC9OZXRzY2FwZVBsdWdpbkhvc3RNYW5hZ2VyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMTEsNyAr MzExLDEyIEBAIHZvaWQgTmV0c2NhcGVQbHVnaW5Ib3N0TWFuYWdlcjo6ZGlkQ3JlYXQKICAgICBQ bHVnaW5Ib3N0TWFwOjppdGVyYXRvciBlbmQgPSBtX3BsdWdpbkhvc3RzLmVuZCgpOwogICAgIGZv ciAoUGx1Z2luSG9zdE1hcDo6aXRlcmF0b3IgaXQgPSBtX3BsdWdpbkhvc3RzLmJlZ2luKCk7IGl0 ICE9IGVuZDsgKytpdCkgewogICAgICAgICBOZXRzY2FwZVBsdWdpbkhvc3RQcm94eSogaG9zdFBy b3h5ID0gaXQtPnZhbHVlOwotICAgICAgICAKKworICAgICAgICBpZiAoIWhvc3RQcm94eSkgewor ICAgICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZCBub3QgZmluZCBhIE5ldHNjYXBlUGx1Z2luSG9z dFByb3h5IGZvciBrZXkgJXMuIiwgaXQtPmtleS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgICAg IGNvbnRpbnVlOworICAgICAgICB9CisKICAgICAgICAgaWYgKCFob3N0UHJveHktPmlzTWVudUJh clZpc2libGUoKSkgewogICAgICAgICAgICAgLy8gTWFrZSBvdXJzZWx2ZXMgdGhlIGZyb250IHBy b2Nlc3MuCiAgICAgICAgICAgICBQcm9jZXNzU2VyaWFsTnVtYmVyIHBzbjsK