232435 2021-10-28 07:11:31 -0700 [WPE][Qt] String memory leak in WPEQtView.cpp 2021-10-28 10:09:41 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia don.olmstead mcatanzaro pnormand webkit-bug-importer oldest_to_newest 1809657 0 aperez 2021-10-28 07:11:31 -0700 In WPEQtView.cpp currently there is something like this, around line 435: variant.setValue(QString(g_strdup(strValue.get()))); Note that the pointer returned by g_strdup() is not freed, and the QString constructor makes a copy of the string. Not only this makes one uneeded copy, but also the one done by g_strdup() gets leaked. 1809658 1 442704 aperez 2021-10-28 07:24:17 -0700 Created attachment 442704 Patch 1809689 2 ews-feeder 2021-10-28 09:04:56 -0700 Committed r284983 (243630@main): <https://commits.webkit.org/243630@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442704. 1809690 3 webkit-bug-importer 2021-10-28 09:05:29 -0700 <rdar://problem/84759895> 442704 2021-10-28 07:24:17 -0700 2021-10-28 10:09:41 -0700 Patch bug-232435-20211028172416.patch text/plain 1746 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViYzEwZjE0NzdjMDBiMWEz ZmUzZjM3ZTVhM2E4MDRkZGMxM2U4YzguLmFhMDQ3Nzk5ZWFiZmM1NTI3OWM0OTI0NTI5M2QzNmY3 MWVkNWY5N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMjggIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtRdF0g U3RyaW5nIG1lbW9yeSBsZWFrIGluIFdQRVF0Vmlldy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjQzNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwOgorICAgICAgICAoanNBc3lu Y1JlYWR5Q2FsbGJhY2spOiBSZW1vdmUgdW5uZWVkZWQgdXNhZ2Ugb2YgZ19zdHJkdXAoKSwgYW5k IHJlcGxhY2UgZGlyZWN0IHVzYWdlCisgICAgICAgIG9mIHRoZSBRU3RyaW5nIGNvbnN0cnVjdG9y IHdpdGggUVN0cmluZzo6ZnJvbVV0ZjgoKSwgd2hpY2ggYmV0dGVyIGluZGljYXRlcyB0aGF0IHRo ZQorICAgICAgICBjYWxsIHdpbGwgY29weSB0aGUgc3RyaW5nIGNvbnRlbnRzLgorCiAyMDIxLTEw LTI4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyB3 azEgXSAyIG1lZGlhLWNhcGFiaWxpdGllcy93ZWJydGMgdGVzdHMgYXJlIGZsYWt5IGZhaWx1cmVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAK aW5kZXggZjc1M2ZlMjNkMDExMzA1M2FiYWM3MDk2N2M4Yzc3M2EzMTZmNDk2Mi4uNDZmZmFlOTEx NjAzNjFkNDg5ODgwOWVlYzcyMTllN2ZiMjcwNDU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNwcApAQCAtNDMyLDcgKzQzMiw3IEBAIHN0 YXRpYyB2b2lkIGpzQXN5bmNSZWFkeUNhbGxiYWNrKEdPYmplY3QqIG9iamVjdCwgR0FzeW5jUmVz dWx0KiByZXN1bHQsIGdwb2ludGVyCiAgICAgICAgICAgICAgICAgcVdhcm5pbmcoIkVycm9yIHJ1 bm5pbmcgamF2YXNjcmlwdDogJXMiLCBqc2NfZXhjZXB0aW9uX2dldF9tZXNzYWdlKGV4Y2VwdGlv bikpOwogICAgICAgICAgICAgICAgIGpzY19jb250ZXh0X2NsZWFyX2V4Y2VwdGlvbihjb250ZXh0 KTsKICAgICAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgICAgIHZhcmlhbnQuc2V0VmFsdWUo UVN0cmluZyhnX3N0cmR1cChzdHJWYWx1ZS5nZXQoKSkpKTsKKyAgICAgICAgICAgICAgICB2YXJp YW50LnNldFZhbHVlKFFTdHJpbmc6OmZyb21VdGY4KHN0clZhbHVlLmdldCgpKSk7CiAgICAgICAg IH0KICAgICAgICAgYXJncy5hcHBlbmQoZW5naW5lLT50b1NjcmlwdFZhbHVlKHZhcmlhbnQpKTsK ICAgICAgICAgZGF0YS0+Y2FsbGJhY2suY2FsbChhcmdzKTsK