232423 2021-10-27 23:20:33 -0700 [watchOS] Fix logging 2021-10-28 10:11:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield eric.carlson ews-watchlist glenn jer.noble philipj sergio sihui_liu webkit-bug-importer oldest_to_newest 1809580 0 mmaxfield 2021-10-27 23:20:33 -0700 [watchOS] Fix logging 1809581 1 442677 mmaxfield 2021-10-27 23:22:48 -0700 Created attachment 442677 Patch 1809708 2 ews-feeder 2021-10-28 09:39:00 -0700 Committed r284988 (243635@main): <https://commits.webkit.org/243635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442677. 1809709 3 webkit-bug-importer 2021-10-28 09:39:20 -0700 <rdar://problem/84761390> 1809713 4 442677 ap 2021-10-28 09:46:05 -0700 Comment on attachment 442677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442677&action=review > Source/WebCore/ChangeLog:10 > + OSStatus is typedef'ed to an SInt32. On watchOS, SInt32 is typedef'ed to be a signed long. > + A signed long on watchOS is 4 bytes long. On non-watchOS, SInt32 is typedef'ed to be a signed int. > + So, if we want to use printf formatting strings, we have to cast the OSStatus to an int. It sounds like it would be nicer to cast it to signed long instead, given this explanation. 1809732 5 442677 mmaxfield 2021-10-28 10:11:28 -0700 Comment on attachment 442677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442677&action=review >> Source/WebCore/ChangeLog:10 >> + So, if we want to use printf formatting strings, we have to cast the OSStatus to an int. > > It sounds like it would be nicer to cast it to signed long instead, given this explanation. Really? OSStatus ends up being 4 bytes on every platform, and int is also 4 bytes on every platform - so I thought it would be a perfect fit. Why is long better? 442677 2021-10-27 23:22:48 -0700 2021-10-28 09:39:01 -0700 Patch bug-232423-20211027232247.patch text/plain 3062 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFlMzA3YjU2NjAzMWNl MWQ5ODg0MjJhODk0YzVhZDVjZDJmNDcyYy4uMjViNjA1OTU3NTE2NTRhMmJhYzRkYzBhOWY4ZDQx Y2QxYzljMDk2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEwLTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW3dhdGNoT1Nd IEZpeCBsb2dnaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzI0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPU1N0YXR1cyBpcyB0eXBlZGVmJ2VkIHRvIGFuIFNJbnQzMi4gT24gd2F0Y2hPUywgU0lu dDMyIGlzIHR5cGVkZWYnZWQgdG8gYmUgYSBzaWduZWQgbG9uZy4KKyAgICAgICAgQSBzaWduZWQg bG9uZyBvbiB3YXRjaE9TIGlzIDQgYnl0ZXMgbG9uZy4gT24gbm9uLXdhdGNoT1MsIFNJbnQzMiBp cyB0eXBlZGVmJ2VkIHRvIGJlIGEgc2lnbmVkIGludC4KKyAgICAgICAgU28sIGlmIHdlIHdhbnQg dG8gdXNlIHByaW50ZiBmb3JtYXR0aW5nIHN0cmluZ3MsIHdlIGhhdmUgdG8gY2FzdCB0aGUgT1NT dGF0dXMgdG8gYW4gaW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlz IG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2NvY29hL01lZGlhVXRp bGl0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUF1ZGlvRm9ybWF0RGVzY3JpcHRp b24pOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlQXVkaW9TYW1wbGVCdWZmZXIpOgorCiAyMDIx LTEwLTI3ICBHYWJyaWVsIE5hdmEgTWFyaW5vICA8Z25hdmFtYXJpbm9AYXBwbGUuY29tPgogCiAg ICAgICAgIEFzc2VydGlvbnMgaW4gZmluZEZpcnN0U2xvdEVsZW1lbnQgaGl0IHdoZW4gcmVtb3Zp bmcgdHdvIHNsb3RzIHdpdGggdGhlIHNhbWUgbmFtZSBpbiBhIHNpbmdsZSBzaGFkb3cgdHJlZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWVkaWFVdGlsaXRpZXMu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWVkaWFVdGlsaXRpZXMuY3BwCmlu ZGV4IGM4YzAxYWUyMGFkY2Q0ZGJjOGRiNmE4NjhmOTY2NzM3YTYwZTk2NjIuLmM1NWQyYTU2ZGU5 NzM0MGJhMWM0YWI3ODYwOTE0ZmZmYWZmOTBjNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NvY29hL01lZGlhVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jb2NvYS9NZWRpYVV0aWxpdGllcy5jcHAKQEAgLTM5LDcgKzM5LDcgQEAgUmV0YWlu UHRyPENNRm9ybWF0RGVzY3JpcHRpb25SZWY+IGNyZWF0ZUF1ZGlvRm9ybWF0RGVzY3JpcHRpb24o Y29uc3QgQXVkaW9TdHJlYW0KICAgICBDTUZvcm1hdERlc2NyaXB0aW9uUmVmIGZvcm1hdCA9IG51 bGxwdHI7CiAgICAgYXV0byBlcnJvciA9IFBBTDo6Q01BdWRpb0Zvcm1hdERlc2NyaXB0aW9uQ3Jl YXRlKGtDRkFsbG9jYXRvckRlZmF1bHQsIGJhc2ljRGVzY3JpcHRpb24sIDAsIG51bGxwdHIsIG1h Z2ljQ29va2llU2l6ZSwgbWFnaWNDb29raWUsIG51bGxwdHIsICZmb3JtYXQpOwogICAgIGlmIChl cnJvcikgewotICAgICAgICBMT0dfRVJST1IoImNyZWF0ZUF1ZGlvRm9ybWF0RGVzY3JpcHRpb24g ZmFpbGVkIHdpdGggJWQiLCBlcnJvcik7CisgICAgICAgIExPR19FUlJPUigiY3JlYXRlQXVkaW9G b3JtYXREZXNjcmlwdGlvbiBmYWlsZWQgd2l0aCAlZCIsIHN0YXRpY19jYXN0PGludD4oZXJyb3Ip KTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogICAgIHJldHVybiBhZG9wdENGKGZv cm1hdCk7CkBAIC01NSwxNCArNTUsMTQgQEAgUmV0YWluUHRyPENNU2FtcGxlQnVmZmVyUmVmPiBj cmVhdGVBdWRpb1NhbXBsZUJ1ZmZlcihjb25zdCBQbGF0Zm9ybUF1ZGlvRGF0YSYgZGEKICAgICBD TVNhbXBsZUJ1ZmZlclJlZiBzYW1wbGVCdWZmZXIgPSBudWxscHRyOwogICAgIGF1dG8gZXJyb3Ig PSBQQUw6OkNNQXVkaW9TYW1wbGVCdWZmZXJDcmVhdGVXaXRoUGFja2V0RGVzY3JpcHRpb25zKGtD RkFsbG9jYXRvckRlZmF1bHQsIG51bGxwdHIsIGZhbHNlLCBudWxscHRyLCBudWxscHRyLCBmb3Jt YXQuZ2V0KCksIHNhbXBsZUNvdW50LCB0aW1lLCBudWxscHRyLCAmc2FtcGxlQnVmZmVyKTsKICAg ICBpZiAoZXJyb3IpIHsKLSAgICAgICAgTE9HX0VSUk9SKCJjcmVhdGVBdWRpb1NhbXBsZUJ1ZmZl ciB3aXRoIHBhY2tldCBkZXNjcmlwdGlvbnMgZmFpbGVkIC0gJWQiLCBlcnJvcik7CisgICAgICAg IExPR19FUlJPUigiY3JlYXRlQXVkaW9TYW1wbGVCdWZmZXIgd2l0aCBwYWNrZXQgZGVzY3JpcHRp b25zIGZhaWxlZCAtICVkIiwgc3RhdGljX2Nhc3Q8aW50PihlcnJvcikpOwogICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICB9CiAgICAgYXV0byBidWZmZXIgPSBhZG9wdENGKHNhbXBsZUJ1ZmZl cik7CiAKICAgICBlcnJvciA9IFBBTDo6Q01TYW1wbGVCdWZmZXJTZXREYXRhQnVmZmVyRnJvbUF1 ZGlvQnVmZmVyTGlzdChidWZmZXIuZ2V0KCksIGtDRkFsbG9jYXRvckRlZmF1bHQsIGtDRkFsbG9j YXRvckRlZmF1bHQsIDAsIGRvd25jYXN0PFdlYkF1ZGlvQnVmZmVyTGlzdD4oZGF0YSkubGlzdCgp KTsKICAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAgTE9HX0VSUk9SKCJjcmVhdGVBdWRpb1NhbXBs ZUJ1ZmZlciBmcm9tIGF1ZGlvIGJ1ZmZlciBsaXN0IGZhaWxlZCAtICVkIiwgZXJyb3IpOworICAg ICAgICBMT0dfRVJST1IoImNyZWF0ZUF1ZGlvU2FtcGxlQnVmZmVyIGZyb20gYXVkaW8gYnVmZmVy IGxpc3QgZmFpbGVkIC0gJWQiLCBzdGF0aWNfY2FzdDxpbnQ+KGVycm9yKSk7CiAgICAgICAgIHJl dHVybiBudWxscHRyOwogICAgIH0KICAgICByZXR1cm4gYnVmZmVyOwo=