232358 2021-10-26 19:03:19 -0700 [ANGLE] Enable -Wformat=2 warnings 2021-11-01 06:18:05 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/angleproject/issues/detail?id=6623 InRadar P2 Normal --- 1 ddkilzer ddkilzer dino ews-watchlist kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1809150 0 ddkilzer 2021-10-26 19:03:19 -0700 Enable -Wformat=2 warnings in the ANGLE project. This includes -Wformat-nonliteral among other warnings. <rdar://problem/84568935> 1809152 1 442555 ddkilzer 2021-10-26 19:14:12 -0700 Created attachment 442555 Patch v1 1809153 2 ews-watchlist 2021-10-26 19:15:01 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1809186 3 kbr 2021-10-26 22:39:51 -0700 It would be most beneficial to add this upstream in ANGLE in https://chromium.googlesource.com/angle/angle . We're actively in the process of upstreaming all of Apple's changes in preparation for taking a new ANGLE snapshot. Kyle (CC'd) can also help with this. 1809193 4 ddkilzer 2021-10-27 00:30:00 -0700 (In reply to Kenneth Russell from comment #3) > It would be most beneficial to add this upstream in ANGLE in > https://chromium.googlesource.com/angle/angle . We're actively in the > process of upstreaming all of Apple's changes in preparation for taking a > new ANGLE snapshot. > > Kyle (CC'd) can also help with this. Yep, I filed <https://bugs.chromium.org/p/angleproject/issues/detail?id=6623> to track upstreaming. It’s in the See Also field as well. 1809523 5 442661 ddkilzer 2021-10-27 18:06:54 -0700 Created attachment 442661 Patch v2 1809524 6 ddkilzer 2021-10-27 18:07:39 -0700 (In reply to David Kilzer (:ddkilzer) from comment #5) > Created attachment 442661 [details] > Patch v2 Use `constexpr const char *` instead of `const char *const`. 1810120 7 ddkilzer 2021-10-29 10:11:39 -0700 Adding Simon and Jon since I don't know who's reviewing ANGLE patches these days. This is a pretty simple patch. 1810597 8 ews-feeder 2021-11-01 06:18:02 -0700 Committed r285102 (243744@main): <https://commits.webkit.org/243744@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442661. 442555 2021-10-26 19:14:12 -0700 2021-10-27 18:11:01 -0700 Patch v1 bug-232358-20211026191411.patch text/plain 3466 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggN2FmM2UyZjdlM2FlYWEzYzhmYmRiMGJiMzA5NmYwZjlkYzVhMmY0Zi4uMTE4ZjMxM2MzMGYy YWRkZDJkNmJjYTNmYWViNGZhMTI1MTM0NzIzZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTEwLTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFXSBFbmFibGUgLVdmb3JtYXQ9MiB3YXJuaW5ncwor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMyMzU4PgorICAgICAgICA8cmRhcjovL3By b2JsZW0vODQ1Njg5MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorICAgICAgICAoV0FSTklO R19DRkxBR1MpOgorICAgICAgICAtIEFkZCAtV2Zvcm1hdD0yIHN3aXRjaCwgd2hpY2ggaW5jbHVk ZXMgLVdmb3JtYXQtbm9ubGl0ZXJhbC4KKyAgICAgICAgKiBzcmMvY29tbW9uL2FuZ2xldXRpbHMu aDoKKyAgICAgICAgKEZvcm1hdFN0cmluZ0ludG9WZWN0b3IpOgorICAgICAgICAtIE1vdmUgYmVs b3cgZGVmaW5pdGlvbiBvZiBBTkdMRV9GT1JNQVRfUFJJTlRGKCkgYW5kIGFkZCBtYWNybworICAg ICAgICAgIHRvIHRoZSBmdW5jdGlvbiBkZWNsYXJhdGlvbiB0byBmaXggLVdmb3JtYXQtbm9ubGl0 ZXJhbAorICAgICAgICAgIHdhcm5pbmcuCisgICAgICAgICogc3JjL2NvbXBpbGVyL3RyYW5zbGF0 b3IvQ29tbW9uLmg6CisgICAgICAgIChzaDo6c3RyKToKKyAgICAgICAgLSBNYWtlIGBmb3JtYXRT dHJgIGEgcG9pbnRlciB0byBhIGNvbnN0YW50IEMtc3RyaW5nIHRvIGZpeAorICAgICAgICAgIC1X Zm9ybWF0LW5vbmxpdGVyYWwgd2FybmluZy4KKwogMjAyMS0xMC0xNSAgUm9zcyBLaXJzbGluZyAg PHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgUmVhbGl6ZSBNYWMgQ01ha2UgYnVp bGQgb2YgV2ViQ29yZSBhbmQgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwppbmRleCAyMTg2NzI3ZjA5ZTBkODZlNDgz Mzg4ZjgyZGE3MjQ4NDFlMWM2NTJmLi4xMWQxYjE1NWU5NTAwZjAxYjNiMTNkZTE4MzRmNzhiYzhk NDJmYjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9u cy9CYXNlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRp b25zL0Jhc2UueGNjb25maWcKQEAgLTYxLDcgKzYxLDcgQEAgR0NDX1dBUk5fVU5VU0VEX1ZBUklB QkxFID0gWUVTOwogCiBQUkVCSU5ESU5HID0gTk87CiAKLVdBUk5JTkdfQ0ZMQUdTID0gLVdnbG9i YWwtY29uc3RydWN0b3JzIC1Xbm8taW5jb25zaXN0ZW50LW1pc3Npbmctb3ZlcnJpZGU7CitXQVJO SU5HX0NGTEFHUyA9IC1XZm9ybWF0PTIgLVdnbG9iYWwtY29uc3RydWN0b3JzIC1Xbm8taW5jb25z aXN0ZW50LW1pc3Npbmctb3ZlcnJpZGU7CiAKIFNVUFBPUlRFRF9QTEFURk9STVMgPSBpcGhvbmVv cyBpcGhvbmVzaW11bGF0b3IgbWFjb3N4IGFwcGxldHZvcyBhcHBsZXR2c2ltdWxhdG9yIHdhdGNo b3Mgd2F0Y2hzaW11bGF0b3I7CiBTVVBQT1JUU19NQUNDQVRBTFlTVCA9IFlFUzsKZGlmZiAtLWdp dCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21tb24vYW5nbGV1dGlscy5oIGIvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9hbmdsZXV0aWxzLmgKaW5kZXggZmU4Nzc3 ZWVjOGRiZWVkMjEyNTZhOTE4OTg4NGMxYWZjZTRlOGQxZC4uYTMzOTQ2YjE3N2E2MWU1ZjA0MWI2 MGRkY2M4M2JmZDEyMThjN2Y5OSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbW1vbi9hbmdsZXV0aWxzLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2NvbW1vbi9hbmdsZXV0aWxzLmgKQEAgLTE4Niw4ICsxODYsNiBAQCBpbmxpbmUgc3RkOjpzdHJp bmcgU3RyKGludCBpKQogICAgIHJldHVybiBzdHJzdHIuc3RyKCk7CiB9CiAKLXNpemVfdCBGb3Jt YXRTdHJpbmdJbnRvVmVjdG9yKGNvbnN0IGNoYXIgKmZtdCwgdmFfbGlzdCB2YXJhcmcsIHN0ZDo6 dmVjdG9yPGNoYXI+ICZidWZmZXIpOwotCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIHN0ZDo6c3Ry aW5nIFRvU3RyaW5nKGNvbnN0IFQgJnZhbHVlKQogewpAQCAtMzcyLDQgKzM3MCw2IEBAIGlubGlu ZSBib29sIElzTGl0dGxlRW5kaWFuKCkKICMgICAgZGVmaW5lIEFOR0xFX1JFUVVJUkVfQ09OU1RB TlRfSU5JVAogI2VuZGlmICAvLyBfX2hhc19jcHBfYXR0cmlidXRlKHJlcXVpcmVfY29uc3RhbnRf aW5pdGlhbGl6YXRpb24pCiAKK3NpemVfdCBGb3JtYXRTdHJpbmdJbnRvVmVjdG9yKGNvbnN0IGNo YXIgKmZtdCwgdmFfbGlzdCB2YXJhcmcsIHN0ZDo6dmVjdG9yPGNoYXI+ICZidWZmZXIpIEFOR0xF X0ZPUk1BVF9QUklOVEYoMSwgMCk7CisKICNlbmRpZiAgLy8gQ09NTU9OX0FOR0xFVVRJTFNfSF8K ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xh dG9yL0NvbW1vbi5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5z bGF0b3IvQ29tbW9uLmgKaW5kZXggMWMwOWNkYWE4MjEyYzNlMTc3ODAzOTA4ZjQ3ZmE0MDJmYzY5 MzcwMC4uMDA0M2JjMzhkMGVmZTBkNTBiYjA4ZTYyOTMzYmZmYzJjMzg1MTA3OCAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvQ29tbW9u LmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3Iv Q29tbW9uLmgKQEAgLTIxNSw3ICsyMTUsNyBAQCBpbmxpbmUgVFN0cmluZyBzdHIoVCBpKQogewog ICAgIEFTU0VSVChzdGQ6Om51bWVyaWNfbGltaXRzPFQ+Ojppc19pbnRlZ2VyKTsKICAgICBjaGFy IGJ1ZmZlclsoKDggKiBzaXplb2YoVCkpIC8gMykgKyAzXTsKLSAgICBjb25zdCBjaGFyICpmb3Jt YXRTdHIgPSBzdGQ6Om51bWVyaWNfbGltaXRzPFQ+Ojppc19zaWduZWQgPyAiJWQiIDogIiV1IjsK KyAgICBjb25zdCBjaGFyICpjb25zdCBmb3JtYXRTdHIgPSBzdGQ6Om51bWVyaWNfbGltaXRzPFQ+ Ojppc19zaWduZWQgPyAiJWQiIDogIiV1IjsKICAgICBzbnByaW50ZihidWZmZXIsIHNpemVvZihi dWZmZXIpLCBmb3JtYXRTdHIsIGkpOwogICAgIHJldHVybiBidWZmZXI7CiB9Cg== 442661 2021-10-27 18:06:54 -0700 2021-11-01 06:18:04 -0700 Patch v2 bug-232358-20211027180653.patch text/plain 3449 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggN2FmM2UyZjdlM2FlYWEzYzhmYmRiMGJiMzA5NmYwZjlkYzVhMmY0Zi4uMjM0Zjg4YjcyZWI4 ODdmMDU0NjA0N2E4YmU2YTc5OGNkZGVkNjdiMiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTEwLTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFXSBFbmFibGUgLVdmb3JtYXQ9MiB3YXJuaW5ncwor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjMyMzU4PgorICAgICAgICA8cmRhcjovL3By b2JsZW0vODQ1Njg5MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorICAgICAgICAoV0FSTklO R19DRkxBR1MpOgorICAgICAgICAtIEFkZCAtV2Zvcm1hdD0yIHN3aXRjaCwgd2hpY2ggaW5jbHVk ZXMgLVdmb3JtYXQtbm9ubGl0ZXJhbC4KKyAgICAgICAgKiBzcmMvY29tbW9uL2FuZ2xldXRpbHMu aDoKKyAgICAgICAgKEZvcm1hdFN0cmluZ0ludG9WZWN0b3IpOgorICAgICAgICAtIE1vdmUgYmVs b3cgZGVmaW5pdGlvbiBvZiBBTkdMRV9GT1JNQVRfUFJJTlRGKCkgYW5kIGFkZCBtYWNybworICAg ICAgICAgIHRvIHRoZSBmdW5jdGlvbiBkZWNsYXJhdGlvbiB0byBmaXggLVdmb3JtYXQtbm9ubGl0 ZXJhbAorICAgICAgICAgIHdhcm5pbmcuCisgICAgICAgICogc3JjL2NvbXBpbGVyL3RyYW5zbGF0 b3IvQ29tbW9uLmg6CisgICAgICAgIChzaDo6c3RyKToKKyAgICAgICAgLSBNYWtlIGBmb3JtYXRT dHJgIGEgY29uc3RleHByIHRvIGZpeCAtV2Zvcm1hdC1ub25saXRlcmFsCisgICAgICAgICAgd2Fy bmluZy4KKwogMjAyMS0xMC0xNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5j b20+CiAKICAgICAgICAgUmVhbGl6ZSBNYWMgQ01ha2UgYnVpbGQgb2YgV2ViQ29yZSBhbmQgV2Vi S2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9C YXNlLnhjY29uZmlnIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQmFz ZS54Y2NvbmZpZwppbmRleCAyMTg2NzI3ZjA5ZTBkODZlNDgzMzg4ZjgyZGE3MjQ4NDFlMWM2NTJm Li4xMWQxYjE1NWU5NTAwZjAxYjNiMTNkZTE4MzRmNzhiYzhkNDJmYjI1IDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAg LTYxLDcgKzYxLDcgQEAgR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0gWUVTOwogCiBQUkVCSU5E SU5HID0gTk87CiAKLVdBUk5JTkdfQ0ZMQUdTID0gLVdnbG9iYWwtY29uc3RydWN0b3JzIC1Xbm8t aW5jb25zaXN0ZW50LW1pc3Npbmctb3ZlcnJpZGU7CitXQVJOSU5HX0NGTEFHUyA9IC1XZm9ybWF0 PTIgLVdnbG9iYWwtY29uc3RydWN0b3JzIC1Xbm8taW5jb25zaXN0ZW50LW1pc3Npbmctb3ZlcnJp ZGU7CiAKIFNVUFBPUlRFRF9QTEFURk9STVMgPSBpcGhvbmVvcyBpcGhvbmVzaW11bGF0b3IgbWFj b3N4IGFwcGxldHZvcyBhcHBsZXR2c2ltdWxhdG9yIHdhdGNob3Mgd2F0Y2hzaW11bGF0b3I7CiBT VVBQT1JUU19NQUNDQVRBTFlTVCA9IFlFUzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21tb24vYW5nbGV1dGlscy5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbW1vbi9hbmdsZXV0aWxzLmgKaW5kZXggZmU4Nzc3ZWVjOGRiZWVkMjEyNTZhOTE4OTg4 NGMxYWZjZTRlOGQxZC4uYTMzOTQ2YjE3N2E2MWU1ZjA0MWI2MGRkY2M4M2JmZDEyMThjN2Y5OSAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9hbmdsZXV0aWxz LmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi9hbmdsZXV0aWxzLmgK QEAgLTE4Niw4ICsxODYsNiBAQCBpbmxpbmUgc3RkOjpzdHJpbmcgU3RyKGludCBpKQogICAgIHJl dHVybiBzdHJzdHIuc3RyKCk7CiB9CiAKLXNpemVfdCBGb3JtYXRTdHJpbmdJbnRvVmVjdG9yKGNv bnN0IGNoYXIgKmZtdCwgdmFfbGlzdCB2YXJhcmcsIHN0ZDo6dmVjdG9yPGNoYXI+ICZidWZmZXIp OwotCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIHN0ZDo6c3RyaW5nIFRvU3RyaW5nKGNvbnN0IFQg JnZhbHVlKQogewpAQCAtMzcyLDQgKzM3MCw2IEBAIGlubGluZSBib29sIElzTGl0dGxlRW5kaWFu KCkKICMgICAgZGVmaW5lIEFOR0xFX1JFUVVJUkVfQ09OU1RBTlRfSU5JVAogI2VuZGlmICAvLyBf X2hhc19jcHBfYXR0cmlidXRlKHJlcXVpcmVfY29uc3RhbnRfaW5pdGlhbGl6YXRpb24pCiAKK3Np emVfdCBGb3JtYXRTdHJpbmdJbnRvVmVjdG9yKGNvbnN0IGNoYXIgKmZtdCwgdmFfbGlzdCB2YXJh cmcsIHN0ZDo6dmVjdG9yPGNoYXI+ICZidWZmZXIpIEFOR0xFX0ZPUk1BVF9QUklOVEYoMSwgMCk7 CisKICNlbmRpZiAgLy8gQ09NTU9OX0FOR0xFVVRJTFNfSF8KZGlmZiAtLWdpdCBhL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xhdG9yL0NvbW1vbi5oIGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvQ29tbW9uLmgKaW5kZXgg MWMwOWNkYWE4MjEyYzNlMTc3ODAzOTA4ZjQ3ZmE0MDJmYzY5MzcwMC4uMjBkOTVmYzI3ZjVkYzM0 YWY3MzQ4YWQ2NDc4ODQ3MWI3MzVhZjg4NiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvQ29tbW9uLmgKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvQ29tbW9uLmgKQEAgLTIxNSw3ICsy MTUsNyBAQCBpbmxpbmUgVFN0cmluZyBzdHIoVCBpKQogewogICAgIEFTU0VSVChzdGQ6Om51bWVy aWNfbGltaXRzPFQ+Ojppc19pbnRlZ2VyKTsKICAgICBjaGFyIGJ1ZmZlclsoKDggKiBzaXplb2Yo VCkpIC8gMykgKyAzXTsKLSAgICBjb25zdCBjaGFyICpmb3JtYXRTdHIgPSBzdGQ6Om51bWVyaWNf bGltaXRzPFQ+Ojppc19zaWduZWQgPyAiJWQiIDogIiV1IjsKKyAgICBjb25zdGV4cHIgY29uc3Qg Y2hhciAqZm9ybWF0U3RyID0gc3RkOjpudW1lcmljX2xpbWl0czxUPjo6aXNfc2lnbmVkID8gIiVk IiA6ICIldSI7CiAgICAgc25wcmludGYoYnVmZmVyLCBzaXplb2YoYnVmZmVyKSwgZm9ybWF0U3Ry LCBpKTsKICAgICByZXR1cm4gYnVmZmVyOwogfQo=