232354 2021-10-26 17:04:42 -0700 webkitdirs.pm should use JSON::XS when available 2021-10-27 08:30:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap dewei_zhu ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1809114 0 ap 2021-10-26 17:04:42 -0700 JSON::XS is faster than JSON::PP. While it doesn't matter for webkitdirs' own use, where JSONs are tiny, other scripts that import webkitdirs.pm do care. 1809115 1 442544 ap 2021-10-26 17:08:05 -0700 Created attachment 442544 proposed patch It's intentional that the script doesn't die if import fails - there is a lot of functionality that doesn't require JSON, so it's better to not break everything even in the super unlikely case that JSON::PP cannot be loaded. 1809131 2 442544 dewei_zhu 2021-10-26 17:48:14 -0700 Comment on attachment 442544 proposed patch rme 1809265 3 ews-feeder 2021-10-27 08:29:59 -0700 Committed r284922 (243593@main): <https://commits.webkit.org/243593@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442544. 1809266 4 webkit-bug-importer 2021-10-27 08:30:26 -0700 <rdar://problem/84710691> 442544 2021-10-26 17:08:05 -0700 2021-10-27 08:30:00 -0700 proposed patch JSONXS.txt text/plain 1380 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4NDkxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTEwLTI2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIHdlYmtpdGRpcnMucG0gc2hvdWxkIHVzZSBKU09OOjpYUyB3aGVuIGF2YWls YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMy MzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNP Tjo6WFMgaXMgZmFzdGVyIHRoYW4gSlNPTjo6UFAuIFdoaWxlIGl0IGRvZXNuJ3QgbWF0dGVyIGZv ciB3ZWJraXRkaXJzJyBvd24gdXNlLAorICAgICAgICB3aGVyZSBKU09OcyBhcmUgdGlueSwgb3Ro ZXIgc2NyaXB0cyB0aGF0IGltcG9ydCB3ZWJraXRkaXJzLnBtIGRvIGNhcmUuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisKIDIwMjEtMTAtMjYgIFJveSBSZWFwb3IgIDxycmVh cG9yQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweS9hdXRvaW5zdGFsbGVkL3B5b2JqY19m cmFtZXdvcmtzLnB5IHNob3VsZCBub3QgYXV0b2luc3RhbGwgZnJhbWV3b3JrcyBpZiB0aGV5IGNh biBiZSBpbXBvcnRlZCB3aXRob3V0IGV4Y2VwdGlvbnMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJl dmlzaW9uIDI4NDkwNikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBj b3B5KQpAQCAtNDIsMTIgKzQyLDE2IEBAIHVzZSBGaWxlOjpQYXRoIHF3KG1ha2VfcGF0aCBta3Bh dGggcm10cmUKIHVzZSBGaWxlOjpTcGVjOwogdXNlIEZpbGU6OlRlbXAgcXcodGVtcGRpcik7CiB1 c2UgRmlsZTo6c3RhdDsKLXVzZSBKU09OOjpQUDsKIHVzZSBMaXN0OjpVdGlsOwogdXNlIFBPU0lY OwogdXNlIFRpbWU6OkhpUmVzIHF3KHVzbGVlcCk7CiB1c2UgVkNTVXRpbHM7CiAKK3VubGVzcyAo ZGVmaW5lZCgmZGVjb2RlX2pzb24pKSB7CisgICAgZXZhbCAidXNlIEpTT046OlhTOyI7CisgICAg ZXZhbCAidXNlIEpTT046OlBQOyIgaWYgJEA7Cit9CisKIEJFR0lOIHsKICAgIHVzZSBFeHBvcnRl ciAgICgpOwogICAgb3VyICgkVkVSU0lPTiwgQElTQSwgQEVYUE9SVCwgQEVYUE9SVF9PSywgJUVY UE9SVF9UQUdTKTsK