<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>232333</bug_id>
          
          <creation_ts>2021-10-26 14:30:52 -0700</creation_ts>
          <short_desc>[WebKitLegacy] Enable -Wformat=2 warnings</short_desc>
          <delta_ts>2021-10-29 14:08:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>darin</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1809035</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2021-10-26 14:30:52 -0700</bug_when>
    <thetext>Enable -Wformat=2 warnings for WebKitLegacy.

This includes -Wformat-nonliteral among other warnings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1809036</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-10-26 14:31:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/84681560&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1809039</commentid>
    <comment_count>2</comment_count>
      <attachid>442532</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2021-10-26 14:33:41 -0700</bug_when>
    <thetext>Created attachment 442532
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1810231</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-10-29 14:08:29 -0700</bug_when>
    <thetext>Committed r285049 (243692@main): &lt;https://commits.webkit.org/243692@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442532.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>442532</attachid>
            <date>2021-10-26 14:33:41 -0700</date>
            <delta_ts>2021-10-29 14:08:30 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-232333-20211026143340.patch</filename>
            <type>text/plain</type>
            <size>3407</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Nzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn
YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k
ZXggMTY1ZTA1ZmZhNWFlYzE5ZWNlMWU3YTY0OGIyNzZmNjViNjM3YzJkYy4uMGM1ZThjMjM4MGNk
ZjQ1YjNiMjc0MjdjOTk3MGRkMzhhNmI2NWYwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl
Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEwLTI2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh
cHBsZS5jb20+CisKKyAgICAgICAgW1dlYktpdExlZ2FjeV0gRW5hYmxlIC1XZm9ybWF0PTIgd2Fy
bmluZ3MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzMjMzMz4KKyAgICAgICAgPHJk
YXI6Ly9wcm9ibGVtLzg0NjgxNTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZzoKKyAgICAgICAg
KFdBUk5JTkdfQ0ZMQUdTKToKKyAgICAgICAgLSBSZXBsYWNlIC1XZm9ybWF0LXNlY3VyaXR5IHdp
dGggLVdmb3JtYXQ9Miwgd2hpY2ggZW5hYmxlcyBtb3JlCisgICAgICAgICAgd2FybmluZ3MgbGlr
ZSAtV2Zvcm1hdC1ub25saXRlcmFsLgorICAgICAgICAqIE1pc2MvV2ViTG9jYWxpemFibGVTdHJp
bmdzSW50ZXJuYWwuaDoKKyAgICAgICAgKFdlYkxvY2FsaXplZFN0cmluZ0ludGVybmFsKToKKyAg
ICAgICAgLSBBZGQgTlNfRk9STUFUX0FSR1VNRU5UKCkgbWFjcm8gdG8gZml4IC1XZm9ybWF0LW5v
bmxpdGVyYWwKKyAgICAgICAgICB3YXJuaW5ncy4KKwogMjAyMS0xMC0yNCAgSWFuIEFuZGVyc29u
ICA8aWFuYUBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIHRoZSBtb2R1bGVzIHZlcmlmaWVy
IGZvciBXZWJLaXRMZWdhY3kgaW4gQXBwbGUgaW50ZXJuYWwgd2hlbiB1c2luZyBhIG5ldyBlbm91
Z2ggWGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NvbmZpZ3VyYXRp
b25zL0Jhc2UueGNjb25maWcgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9Db25maWd1cmF0aW9u
cy9CYXNlLnhjY29uZmlnCmluZGV4IDY5YWRlZWQwM2FmNDA3MmY5NzUwNDQ2OGY1ZmJkZDdiOTY1
YzM4MzYuLjI4MjgwNmFhMzEwMjllYjcxNDQ1MjhmZGM0YWNlZmU0NjE0MmVhZjkgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcK
KysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZp
ZwpAQCAtODgsNyArODgsNyBAQCBDTEFOR19XQVJOX0RPQ1VNRU5UQVRJT05fQ09NTUVOVFMgPSBZ
RVM7CiBPVEhFUl9NSUdGTEFHUyA9IC1GJChCVUlMVF9QUk9EVUNUU19ESVIpOwogQ0xBTkdfQU5B
TFlaRVJfTE9DQUxJWkFCSUxJVFlfTk9OTE9DQUxJWkVEID0gWUVTOwogUFJFQklORElORyA9IE5P
OwotV0FSTklOR19DRkxBR1MgPSAtV2FsbCAtV2V4dHJhIC1XY2FzdC1xdWFsIC1XY2hhci1zdWJz
Y3JpcHRzIC1XY29uZGl0aW9uYWwtdW5pbml0aWFsaXplZCAtV2V4dHJhLXRva2VucyAtV2Zvcm1h
dC1zZWN1cml0eSAtV2luaXQtc2VsZiAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV21pc3Np
bmctbm9yZXR1cm4gLVduby11bnVzZWQtcGFyYW1ldGVyIC1XcGFja2VkIC1XcG9pbnRlci1hcml0
aCAtV3JlZHVuZGFudC1kZWNscyAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAtV2V4aXQtdGltZS1k
ZXN0cnVjdG9ycyAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMgLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSAt
V2ltcGxpY2l0LWZhbGx0aHJvdWdoIC1XdmxhIC1XbGl0ZXJhbC1jb252ZXJzaW9uIC1XdGhyZWFk
LXNhZmV0eTsKK1dBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVdleHRyYSAtV2Nhc3QtcXVhbCAtV2No
YXItc3Vic2NyaXB0cyAtV2NvbmRpdGlvbmFsLXVuaW5pdGlhbGl6ZWQgLVdleHRyYS10b2tlbnMg
LVdmb3JtYXQ9MiAtV2luaXQtc2VsZiAtV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV21pc3Np
bmctbm9yZXR1cm4gLVduby11bnVzZWQtcGFyYW1ldGVyIC1XcGFja2VkIC1XcG9pbnRlci1hcml0
aCAtV3JlZHVuZGFudC1kZWNscyAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAtV2V4aXQtdGltZS1k
ZXN0cnVjdG9ycyAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMgLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSAt
V2ltcGxpY2l0LWZhbGx0aHJvdWdoIC1XdmxhIC1XbGl0ZXJhbC1jb252ZXJzaW9uIC1XdGhyZWFk
LXNhZmV0eTsKIAogVEFSR0VUX01BQ09TX0xFR0FDWV9WRVJTSU9OX0lERU5USUZJRVIgPSAkKFRB
UkdFVF9NQUNPU19MRUdBQ1lfVkVSU0lPTl9JREVOVElGSUVSXyQoTUFDT1NYX0RFUExPWU1FTlRf
VEFSR0VUOmJhc2UpKQogVEFSR0VUX01BQ09TX0xFR0FDWV9WRVJTSU9OX0lERU5USUZJRVJfMTAg
PSAxMCQoTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUOnN1ZmZpeDppZGVudGlmaWVyKQpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvTWlzYy9XZWJMb2NhbGl6YWJsZVN0cmluZ3NJ
bnRlcm5hbC5oIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvTWlzYy9XZWJMb2NhbGl6YWJsZVN0
cmluZ3NJbnRlcm5hbC5oCmluZGV4IDIxNTU4MTljMjE1NjdjNDMwYmJkOTc3NDE0YTNkYWEzZjlh
NDVkNTkuLjU3ZTk4NTRhZWFmNjVkMDdkZDE3OWM5ZWY2YmQ0NTY1NjNlM2RiYTAgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL01pc2MvV2ViTG9jYWxpemFibGVTdHJpbmdzSW50
ZXJuYWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9NaXNjL1dlYkxvY2FsaXphYmxl
U3RyaW5nc0ludGVybmFsLmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAy
MDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAx
MS0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1
dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK
ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp
bmcgY29uZGl0aW9ucwpAQCAtMzIsNyArMzIsNyBAQAogZXh0ZXJuICJDIiB7CiAjZW5kaWYKIAot
TlNTdHJpbmcgKldlYkxvY2FsaXplZFN0cmluZ0ludGVybmFsKGNvbnN0IGNoYXIqIGtleSk7CitO
U1N0cmluZyAqV2ViTG9jYWxpemVkU3RyaW5nSW50ZXJuYWwoY29uc3QgY2hhcioga2V5KSBOU19G
T1JNQVRfQVJHVU1FTlQoMSk7CiAKICNpZmRlZiBfX2NwbHVzcGx1cwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>