232328 2021-10-26 12:59:27 -0700 Fails to execute JavaScript when soft stack limit is unlimited 2021-11-02 15:09:38 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=2017281 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin bugs-noreply cdumez cmarcelo ews-watchlist mcatanzaro nina webkit-bug-importer ysuzuki oldest_to_newest 1808996 0 mcatanzaro 2021-10-26 12:59:27 -0700 Reproducer: $ ulimit -s unlimited $ jsc >>> 1 + 1 Exception: I'm not sure why JSC cannot print the exception, but it's "maximum call stack size exceeded." Problem is since r276695 "[WPE][GTK] More correct fixes for stack size issues on musl libc", WTF::StackBounds::currentThreadStackBoundsInternal now calls getrlimit() to get the soft stack limit. When the limit is unlimited, rlim_cur is -1 and the function is not prepared for that. I don't know how to fix it other than to fall back to some suitable default (8192 seems to be the default soft limit). This is only a regression on Linux, but the Darwin code has the same bug too. 1808998 1 nina 2021-10-26 13:02:22 -0700 let's have it max out at 8M, realistically there is nothing better you can do i think 1808999 2 mcatanzaro 2021-10-26 13:08:41 -0700 Actually I'm not certain it's really a regression, because there are preexisting calls to pthread_getattr_np() (or pthread_get_stacksize_np() on Darwin) that would likely have had the same problem. (In reply to Daniel Kolesa from comment #1) > let's have it max out at 8M, realistically there is nothing better you can > do i think Sounds good. 1809026 3 mcatanzaro 2021-10-26 14:14:29 -0700 (In reply to Michael Catanzaro from comment #0) > When the limit is unlimited, > rlim_cur is -1 and the function is not prepared for that. Actually, it is RLIM_INFINITY. Doesn't change the rest of the analysis, though. 1809028 4 442530 mcatanzaro 2021-10-26 14:16:08 -0700 Created attachment 442530 Patch 1809029 5 mcatanzaro 2021-10-26 14:18:39 -0700 (In reply to Michael Catanzaro from comment #2) > Actually I'm not certain it's really a regression, because there are > preexisting calls to pthread_getattr_np() (or pthread_get_stacksize_np() on > Darwin) that would likely have had the same problem. I think it's OK because this returns the real stack size, not the limit. Also, it works fine in practice with no changes to this. 1809222 6 nina 2021-10-27 04:46:29 -0700 patch lgtm 1811232 7 webkit-bug-importer 2021-11-02 13:00:26 -0700 <rdar://problem/84943302> 1811248 8 mcatanzaro 2021-11-02 13:43:41 -0700 Ping reviewers 1811285 9 442530 ysuzuki 2021-11-02 15:03:23 -0700 Comment on attachment 442530 Patch r=me 1811287 10 ews-feeder 2021-11-02 15:09:33 -0700 Committed r285187 (243816@main): <https://commits.webkit.org/243816@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442530. 442530 2021-10-26 14:16:08 -0700 2021-11-02 15:09:35 -0700 Patch bug-232328-20211026161608.patch text/plain 1883 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0ODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE0MDYzZDcyYTE5ZGZjNTlhODMxZTM4 YTgxOTk3NGUxNjQ0NDc2MTAuLmI2NmFjNzBiNjk3YzQzMGEyMDA5YTg2M2QwYjIxYTdmZjYzNDEy N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTAtMjYgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgRmFpbHMgdG8gZXhlY3V0ZSBKYXZhU2Ny aXB0IHdoZW4gc29mdCBzdGFjayBsaW1pdCBpcyB1bmxpbWl0ZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjMyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZhbGwgYmFjayB0byBhc3N1bWluZyBhbiA4 IE1CIHN0YWNrIGxpbWl0IHdoZW4gdGhlIHJlYWwgbGltaXQgaXMgdW5saW1pdGVkLiBKU0MgbmVl ZHMgdG8KKyAgICAgICAgaGF2ZSBzb21lIG1heGltdW0gc3RhY2sgc2l6ZSB0byB3b3JrIHdpdGgs IGFuZCB0aGlzIGlzIGFzIGdvb2QgYXMgYW55LgorCisgICAgICAgICogd3RmL1N0YWNrQm91bmRz LmNwcDoKKyAgICAgICAgKFdURjo6U3RhY2tCb3VuZHM6OmN1cnJlbnRUaHJlYWRTdGFja0JvdW5k c0ludGVybmFsKToKKwogMjAyMS0xMC0yNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVwZGF0ZSBQQ00gdGVzdCBwdWJsaWMga2V5IHRvIG9u ZSB3aXRoIFJTQS1QU1MgT0lECmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5k cy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKaW5kZXggNThiZGIxODY4ZTEw MWExM2Y4MzY1OWNhZWNmNTExOTAyYTMzNzJlOC4uZTlkOWQ1ODNlMzU1MTkyMjhkNmU4YjAyYmZk OTliN2Q0YzY2NmQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3Bw CisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcApAQCAtNjUsNiArNjUsOCBAQCBT dGFja0JvdW5kcyBTdGFja0JvdW5kczo6Y3VycmVudFRocmVhZFN0YWNrQm91bmRzSW50ZXJuYWwo KQogICAgICAgICBybGltaXQgbGltaXQ7CiAgICAgICAgIGdldHJsaW1pdChSTElNSVRfU1RBQ0ss ICZsaW1pdCk7CiAgICAgICAgIHJsaW1fdCBzaXplID0gbGltaXQucmxpbV9jdXI7CisgICAgICAg IGlmIChzaXplID09IFJMSU1fSU5GSU5JVFkpCisgICAgICAgICAgICBzaXplID0gOCAqIE1COwog ICAgICAgICB2b2lkKiBib3VuZCA9IHN0YXRpY19jYXN0PGNoYXIqPihvcmlnaW4pIC0gc2l6ZTsK ICAgICAgICAgcmV0dXJuIFN0YWNrQm91bmRzIHsgb3JpZ2luLCBib3VuZCB9OwogICAgIH0KQEAg LTEyNSw2ICsxMjcsOCBAQCBTdGFja0JvdW5kcyBTdGFja0JvdW5kczo6Y3VycmVudFRocmVhZFN0 YWNrQm91bmRzSW50ZXJuYWwoKQogICAgICAgICBybGltaXQgbGltaXQ7CiAgICAgICAgIGdldHJs aW1pdChSTElNSVRfU1RBQ0ssICZsaW1pdCk7CiAgICAgICAgIHJsaW1fdCBzaXplID0gbGltaXQu cmxpbV9jdXI7CisgICAgICAgIGlmIChzaXplID09IFJMSU1fSU5GSU5JVFkpCisgICAgICAgICAg ICBzaXplID0gOCAqIE1COwogICAgICAgICAvLyBhY2NvdW50IGZvciBhIGd1YXJkIHBhZ2UKICAg ICAgICAgc2l6ZSAtPSBzdGF0aWNfY2FzdDxybGltX3Q+KHN5c2NvbmYoX1NDX1BBR0VTSVpFKSk7 CiAgICAgICAgIHZvaWQqIGJvdW5kID0gc3RhdGljX2Nhc3Q8Y2hhcio+KG9yaWdpbikgLSBzaXpl Owo=