232318 2021-10-26 10:42:21 -0700 Possible non-unified build issues 2021-10-29 05:42:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Mac (Intel) macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 nina webkit-unassigned don.olmstead dpino ews-watchlist fujii jiewen_tan webkit-bug-importer oldest_to_newest 1808929 0 nina 2021-10-26 10:42:21 -0700 Since the recent refactors regarding moves to standard std:: containers as well as the JSC ArrayBuffer refactoring, there have been issues with forward declarations in Mac builds (both 10.15 Intel and 11 arm64) in the Playwright project. My current suspicion is that the patches in Playwright change the way builds are unified, which exposes missing includes, but have no good way to explicitly verify that. Therefore, I will raise a patch here that contains the includes that need to be added to make that build again, to get comments. 1808930 1 442507 nina 2021-10-26 10:43:11 -0700 Created attachment 442507 possible patch 1808933 2 442508 nina 2021-10-26 10:47:18 -0700 Created attachment 442508 fixed patch apologies, somehow i submitted a malformed patch 1809410 3 442508 fujii 2021-10-27 13:54:19 -0700 Comment on attachment 442508 fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=442508&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:34 > +#include <variant> style checker EWS is failing. ERROR: Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:34: Alphabetical sorting problem. [build/include_order] [4] 1809419 4 fujii 2021-10-27 14:04:43 -0700 (In reply to Daniel Kolesa from comment #0) > but have no good way to explicitly verify that. There is a experimental CMake build of Mac port, and CMake has ENABLE_UNIFIED_BUILDS option. However, this patch looks no problem to me. 1809625 5 442688 nina 2021-10-28 03:45:43 -0700 Created attachment 442688 fixed style (no functional changes) well then, thanks fixed style 1809724 6 442688 don.olmstead 2021-10-28 09:58:53 -0700 Comment on attachment 442688 fixed style (no functional changes) View in context: https://bugs.webkit.org/attachment.cgi?id=442688&action=review I'll just r+ this on Fujii's behalf but in the future that's the workflow when you get an r+ but a cq-. > Source/WebKit/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). When you get an r+ in a previous patch with nits what you do is you replace the `NOBODY (OOPS!)` and then a cq+ is all that's needed. 1809726 7 don.olmstead 2021-10-28 10:00:38 -0700 (In reply to Don Olmstead from comment #6) > Comment on attachment 442688 [details] > fixed style (no functional changes) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442688&action=review > > I'll just r+ this on Fujii's behalf but in the future that's the workflow > when you get an r+ but a cq-. > > > Source/WebKit/ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > When you get an r+ in a previous patch with nits what you do is you replace > the `NOBODY (OOPS!)` and then a cq+ is all that's needed. In this case the line would've been Reviewed by Fujii Hironori. You can just search the ChangeLog and copy paste the reviewer's name from there. 1809727 8 ews-feeder 2021-10-28 10:02:20 -0700 Committed r284990 (243636@main): <https://commits.webkit.org/243636@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442688. 1809728 9 webkit-bug-importer 2021-10-28 10:03:21 -0700 <rdar://problem/84762460> 1810043 10 nina 2021-10-29 05:42:05 -0700 > I'll just r+ this on Fujii's behalf but in the future that's the workflow > when you get an r+ but a cq-. noted, thanks 442507 2021-10-26 10:43:11 -0700 2021-10-26 10:47:18 -0700 possible patch unified.diff text/plain 1659 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzM2MWNhMjEwZDcwLi40MzA1NWE4YTU1N2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMTAtMjYgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjMxOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50 aWNhdGlvbkFzc2VydGlvblJlc3BvbnNlLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2Ev U09BdXRob3JpemF0aW9uL1N1YkZyYW1lU09BdXRob3JpemF0aW9uU2Vzc2lvbi5oOgorCiAyMDIx LTEwLTI2ICBEYW5pZWwgS29sZXNhICA8ZGtvbGVzYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZp eCBidWlsZCB3aXRoIEdDQyA4LjQgb24gVWJ1bnR1IDE4LjA0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25z ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25B c3NlcnRpb25SZXNwb25zZS5jcHAKaW5kZXggZWVlYmQ5YmQwNWY1Li43OWVmODhiMjVkNjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50aWNhdGlv bkFzc2VydGlvblJlc3BvbnNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv QVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25zZS5jcHAKQEAgLTI5LDYgKzI5LDcg QEAKICNpZiBFTkFCTEUoV0VCX0FVVEhOKQogCiAjaW5jbHVkZSAiQVBJRGF0YS5oIgorI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0FycmF5QnVmZmVyLmg+CiAKIG5hbWVzcGFjZSBBUEkgewogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNzaW9uLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVT T0F1dGhvcml6YXRpb25TZXNzaW9uLmgKaW5kZXggMjQ0NzliNDY4MjZmLi5hODQ0ZWZkMzUyMjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlv bi9TdWJGcmFtZVNPQXV0aG9yaXphdGlvblNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNz aW9uLmgKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJOYXZpZ2F0aW9uU09BdXRob3JpemF0 aW9uU2Vzc2lvbi5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVJZGVudGlmaWVyLmg+CiAjaW5j bHVkZSA8d3RmL0RlcXVlLmg+CisjaW5jbHVkZSA8dmFyaWFudD4KIAogbmFtZXNwYWNlIFdlYktp dCB7CiAK 442508 2021-10-26 10:47:18 -0700 2021-10-28 03:45:43 -0700 fixed patch unified.diff text/plain 1659 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzM2MWNhMjEwZDcwLi44ZDBkNWI0MTIxNzEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjEtMTAtMjYgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjMxOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50 aWNhdGlvbkFzc2VydGlvblJlc3BvbnNlLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2Ev U09BdXRob3JpemF0aW9uL1N1YkZyYW1lU09BdXRob3JpemF0aW9uU2Vzc2lvbi5oOgorCiAyMDIx LTEwLTI2ICBEYW5pZWwgS29sZXNhICA8ZGtvbGVzYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZp eCBidWlsZCB3aXRoIEdDQyA4LjQgb24gVWJ1bnR1IDE4LjA0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25z ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25B c3NlcnRpb25SZXNwb25zZS5jcHAKaW5kZXggZWVlYmQ5YmQwNWY1Li43OWVmODhiMjVkNjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50aWNhdGlv bkFzc2VydGlvblJlc3BvbnNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv QVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25zZS5jcHAKQEAgLTI5LDYgKzI5LDcg QEAKICNpZiBFTkFCTEUoV0VCX0FVVEhOKQogCiAjaW5jbHVkZSAiQVBJRGF0YS5oIgorI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0FycmF5QnVmZmVyLmg+CiAKIG5hbWVzcGFjZSBBUEkgewogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNzaW9uLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVT T0F1dGhvcml6YXRpb25TZXNzaW9uLmgKaW5kZXggMjQ0NzliNDY4MjZmLi5hODQ0ZWZkMzUyMjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlv bi9TdWJGcmFtZVNPQXV0aG9yaXphdGlvblNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNz aW9uLmgKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJOYXZpZ2F0aW9uU09BdXRob3JpemF0 aW9uU2Vzc2lvbi5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVJZGVudGlmaWVyLmg+CiAjaW5j bHVkZSA8d3RmL0RlcXVlLmg+CisjaW5jbHVkZSA8dmFyaWFudD4KIAogbmFtZXNwYWNlIFdlYktp dCB7CiAK 442688 2021-10-28 03:45:43 -0700 2021-10-28 10:02:21 -0700 fixed style (no functional changes) includes.patch text/plain 1663 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzYyOGVhZjdkYTNlLi41YmJhNDg5Y2Q1NjUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjEtMTAtMjYgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjMxOAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50 aWNhdGlvbkFzc2VydGlvblJlc3BvbnNlLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2Ev U09BdXRob3JpemF0aW9uL1N1YkZyYW1lU09BdXRob3JpemF0aW9uU2Vzc2lvbi5oOgorCiAyMDIx LTEwLTI2ICBEYW5pZWwgS29sZXNhICA8ZGtvbGVzYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZp eCBidWlsZCB3aXRoIEdDQyA4LjQgb24gVWJ1bnR1IDE4LjA0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25z ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJV2ViQXV0aGVudGljYXRpb25B c3NlcnRpb25SZXNwb25zZS5jcHAKaW5kZXggZWVlYmQ5YmQwNWY1Li43OWVmODhiMjVkNjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElXZWJBdXRoZW50aWNhdGlv bkFzc2VydGlvblJlc3BvbnNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv QVBJV2ViQXV0aGVudGljYXRpb25Bc3NlcnRpb25SZXNwb25zZS5jcHAKQEAgLTI5LDYgKzI5LDcg QEAKICNpZiBFTkFCTEUoV0VCX0FVVEhOKQogCiAjaW5jbHVkZSAiQVBJRGF0YS5oIgorI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0FycmF5QnVmZmVyLmg+CiAKIG5hbWVzcGFjZSBBUEkgewogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNzaW9uLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVT T0F1dGhvcml6YXRpb25TZXNzaW9uLmgKaW5kZXggMjQ0NzliNDY4MjZmLi44YTk1YTNmODAzNmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NPQXV0aG9yaXphdGlv bi9TdWJGcmFtZVNPQXV0aG9yaXphdGlvblNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9TT0F1dGhvcml6YXRpb24vU3ViRnJhbWVTT0F1dGhvcml6YXRpb25TZXNz aW9uLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2lmIEhBVkUoQVBQX1NTTykKIAorI2luY2x1ZGUg PHZhcmlhbnQ+CiAjaW5jbHVkZSAiRnJhbWVMb2FkU3RhdGUuaCIKICNpbmNsdWRlICJOYXZpZ2F0 aW9uU09BdXRob3JpemF0aW9uU2Vzc2lvbi5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRnJhbWVJZGVu dGlmaWVyLmg+Cg==