232311 2021-10-26 09:29:11 -0700 [AppSSO] Avoid attempting to display a nil view controller 2021-10-26 14:13:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham ddkilzer ews-watchlist jiewen_tan katherine_cheney webkit-bug-importer oldest_to_newest 1808898 0 bfulgham 2021-10-26 09:29:11 -0700 Crash logs indicate that it is possible for the delegate for an AppSSO authentication to get called after the view has been dismissed (e.g., when a user grows impatient with a slow authentication). Rather than crashing, we should clean up the session state and make it ready for a new attempt. 1808899 1 bfulgham 2021-10-26 09:29:57 -0700 <rdar://problem/55199117> 1808900 2 442499 bfulgham 2021-10-26 09:33:46 -0700 Created attachment 442499 Patch 1809024 3 ews-feeder 2021-10-26 14:13:08 -0700 Committed r284896 (243573@main): <https://commits.webkit.org/243573@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442499. 442499 2021-10-26 09:33:46 -0700 2021-10-26 14:13:09 -0700 Patch bug-232311-20211026093345.patch text/plain 1875 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUyYWExYmY4YTcwNjU0M2I1 ZGEwMzQ0YzZiMjIxOTZkYjM1ZWYxMTguLmZmZWE4NDZlNjUxYmMxMGQ2MjA1MmMxNjhhZWI2NDMz MzY2MWM1YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMTAtMjYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0FwcFNTT10gQXZvaWQgYXR0 ZW1wdGluZyB0byBkaXNwbGF5IGEgbmlsIHZpZXcgY29udHJvbGxlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMzExCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81NTE5OTExNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBdm9pZCBhdHRlbXB0aW5nIHRvIHByZXNlbnQgYSBuaWwgTlNWaWV3Q29udHJv bGxlci4gSW5zdGVhZCwganVzdCB0cmVhdCB0aGUgaW50ZXJhY3Rpb24gYXMgaWYKKyAgICAgICAg dGhlIGF1dGhlbnRpY2F0aW9uIHdhcyBjYW5jZWxsZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Q29jb2EvU09BdXRob3JpemF0aW9uL1dLU09BdXRob3JpemF0aW9uRGVsZWdhdGUubW06CisgICAg ICAgICgtW1dLU09BdXRob3JpemF0aW9uRGVsZWdhdGUgYXV0aG9yaXphdGlvbjpwcmVzZW50Vmll d0NvbnRyb2xsZXI6d2l0aENvbXBsZXRpb246XSk6CisKIDIwMjEtMTAtMTkgIEdhcnJldHQgRGF2 aWRzb24gIDxnYXJyZXR0X2Rhdmlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJBdXRobiBQ bGF0Zm9ybSBVSSBjYWxsYmFja3MgYXJlIG5vdCBndWFyYW50ZWVkIHRvIGhhcHBlbiBvbiB0aGUg bWFpbiB0aHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1NP QXV0aG9yaXphdGlvbi9XS1NPQXV0aG9yaXphdGlvbkRlbGVnYXRlLm1tIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1dLU09BdXRob3JpemF0aW9uRGVsZWdh dGUubW0KaW5kZXggNzczNjdjN2U4YTU2NmFhNjVlMWEzMjZlZjljNjUxMmY0ZTQxMTdjMS4uNTk2 YmUxMzI5NGRiMzJjMmIwNmVmZTk1N2FjMWYwNGEwMzljOWYwNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3JpemF0aW9uL1dLU09BdXRob3JpemF0aW9u RGVsZWdhdGUubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU09BdXRob3Jp emF0aW9uL1dLU09BdXRob3JpemF0aW9uRGVsZWdhdGUubW0KQEAgLTQ2LDYgKzQ2LDEzIEBACiAg ICAgICAgIGNvbXBsZXRpb24oTk8sIG5pbCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisKKyAg ICBpZiAoIXZpZXdDb250cm9sbGVyKSB7CisgICAgICAgIFdLU09BVVRIT1JJWkFUSU9OREVMRUdB VEVfUkVMRUFTRV9MT0coImF1dGhvcml6YXRpb246IE5vIHZpZXcgY29udHJvbGxlciB0byBwcmVz ZW50LCBzbyBjb21wbGV0aW5nIHdpdGggTk8gYXMgc3VjY2VzcyBzdGF0ZS4iKTsKKyAgICAgICAg Y29tcGxldGlvbihOTywgbmlsKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIFdLU09B VVRIT1JJWkFUSU9OREVMRUdBVEVfUkVMRUFTRV9MT0coImF1dGhvcml6YXRpb246IHByZXNlbnRp bmdWaWV3Q29udHJvbGxlciAlcCIsIHZpZXdDb250cm9sbGVyKTsKICAgICBfc2Vzc2lvbi0+cHJl c2VudFZpZXdDb250cm9sbGVyKHZpZXdDb250cm9sbGVyLCBjb21wbGV0aW9uKTsKIH0K