232305 2021-10-26 08:24:27 -0700 build broken on ubuntu 18.04 2021-11-01 01:43:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 nina webkit-unassigned aperez dpino webkit-bug-importer oldest_to_newest 1808859 0 nina 2021-10-26 08:24:27 -0700 The 18.04 builder has been broken for a while https://build.webkit.org/#/builders/71 because of a compiler ICE. 1808860 1 442492 nina 2021-10-26 08:25:57 -0700 Created attachment 442492 patch This is a workaround that gets over the segfault. It should not affect other compilers. 1808874 2 442492 ap 2021-10-26 08:58:48 -0700 Comment on attachment 442492 patch View in context: https://bugs.webkit.org/attachment.cgi?id=442492&action=review > Source/WebCore/ChangeLog:12 > + Thes sections of the code trigger an internal compiler error with > + GCC 8.4, segfaulting the compiler. This adds a workaround that > + makes it work again. Could you please post the gcc bug report link here? 1808877 3 nina 2021-10-26 09:03:08 -0700 I'm not aware of a GCC bug report yet, this is a new issue (the WeakPtr refactoring is recent) There is GCC 8.5 already, but ubuntu 18.04 does not ship with it (it would be good to test if the problem still happens in 8.5) 1808879 4 nina 2021-10-26 09:08:00 -0700 that said, the .5 release tends to be the last one, so I'd expect there won't be any more gcc 8 fixes either way 1808881 5 nina 2021-10-26 09:09:42 -0700 indeed, there is no more development in the gcc8 branch: https://github.com/gcc-mirror/gcc/commits/releases/gcc-8 1810574 6 ews-feeder 2021-11-01 01:42:27 -0700 Committed r285101 (243743@main): <https://commits.webkit.org/243743@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442492. 1810575 7 webkit-bug-importer 2021-11-01 01:43:23 -0700 <rdar://problem/84873634> 442492 2021-10-26 08:25:57 -0700 2021-11-01 01:42:28 -0700 patch ubuntu1804.patch text/plain 3883 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MThkZDBjNjAxMTAuLjE3OWFkMTFkODQxOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDIxLTEwLTI2ICBEYW5pZWwgS29sZXNhICA8ZGtvbGVzYUBpZ2FsaWEu Y29tPgorCisgICAgICAgIEZpeCBidWlsZCB3aXRoIEdDQyA4LjQgb24gVWJ1bnR1IDE4LjA0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzIzMDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVpbGQg d2l0aCBHQ0MgOC40IG9uIFVidW50dSAxOC4wNAorCisgICAgICAgIFRoZXMgc2VjdGlvbnMgb2Yg dGhlIGNvZGUgdHJpZ2dlciBhbiBpbnRlcm5hbCBjb21waWxlciBlcnJvciB3aXRoCisgICAgICAg IEdDQyA4LjQsIHNlZ2ZhdWx0aW5nIHRoZSBjb21waWxlci4gVGhpcyBhZGRzIGEgd29ya2Fyb3Vu ZCB0aGF0CisgICAgICAgIG1ha2VzIGl0IHdvcmsgYWdhaW4uCisKKyAgICAgICAgKiBNb2R1bGVz L2FzeW5jLWNsaXBib2FyZC9DbGlwYm9hcmRJdGVtQmluZGluZ3NEYXRhU291cmNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZEl0ZW1CaW5kaW5nc0RhdGFTb3VyY2U6OmNvbGxlY3RE YXRhRm9yV3JpdGluZyk6CisKIDIwMjEtMTAtMjYgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGln YWxpYS5jb20+CiAKICAgICAgICAgTWFyayBHTENvbnRleHRHTFguY3BwIGFzIG5vLXVuaWZ5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FzeW5jLWNsaXBib2FyZC9DbGlwYm9h cmRJdGVtQmluZGluZ3NEYXRhU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvYXN5 bmMtY2xpcGJvYXJkL0NsaXBib2FyZEl0ZW1CaW5kaW5nc0RhdGFTb3VyY2UuY3BwCmluZGV4IDky ZTBkMTA3ZTI1YS4uZDA3NDZkYTJkYTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2FzeW5jLWNsaXBib2FyZC9DbGlwYm9hcmRJdGVtQmluZGluZ3NEYXRhU291cmNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2FzeW5jLWNsaXBib2FyZC9DbGlwYm9hcmRJdGVt QmluZGluZ3NEYXRhU291cmNlLmNwcApAQCAtMTM5LDcgKzEzOSw5IEBAIHZvaWQgQ2xpcGJvYXJk SXRlbUJpbmRpbmdzRGF0YVNvdXJjZTo6Y29sbGVjdERhdGFGb3JXcml0aW5nKENsaXBib2FyZCYg ZGVzdGluYXRpCiAgICAgICAgIH0pOwogCiAgICAgICAgIGF1dG8gcHJvbWlzZSA9IHR5cGVBbmRJ dGVtLnZhbHVlOwotICAgICAgICBwcm9taXNlLT53aGVuU2V0dGxlZChbdGhpcywgcHJvdGVjdGVk SXRlbSA9IFJlZiB7IG1faXRlbSB9LCBkZXN0aW5hdGlvbiA9IG1fd3JpdGluZ0Rlc3RpbmF0aW9u LCBwcm9taXNlLCB0eXBlLCB3ZWFrSXRlbVR5cGVMb2FkZXIgPSBXZWFrUHRyIHsgaXRlbVR5cGVM b2FkZXIgfV0gKCkgbXV0YWJsZSB7CisgICAgICAgIC8qIGhhY2s6IGdjYyA4LjQgd2lsbCBzZWdm YXVsdCBpZiB0aGUgV2Vha1B0ciBpcyBpbnN0YW50aWF0ZWQgd2l0aGluIHRoZSBsYW1iZGEgY2Fw dHVyZXMgKi8KKyAgICAgICAgYXV0byB3bCA9IFdlYWtQdHIgeyBpdGVtVHlwZUxvYWRlciB9Owor ICAgICAgICBwcm9taXNlLT53aGVuU2V0dGxlZChbdGhpcywgcHJvdGVjdGVkSXRlbSA9IFJlZiB7 IG1faXRlbSB9LCBkZXN0aW5hdGlvbiA9IG1fd3JpdGluZ0Rlc3RpbmF0aW9uLCBwcm9taXNlLCB0 eXBlLCB3ZWFrSXRlbVR5cGVMb2FkZXIgPSBXVEZNb3ZlKHdsKV0gKCkgbXV0YWJsZSB7CiAgICAg ICAgICAgICBpZiAoIXdlYWtJdGVtVHlwZUxvYWRlcikKICAgICAgICAgICAgICAgICByZXR1cm47 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKaW5kZXggODhiM2Y0OGE0OTkyLi5jMzYxY2EyMTBkNzAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMjEtMTAtMjYgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5j b20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdpdGggR0NDIDguNCBvbiBVYnVudHUgMTguMDQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMjMwNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXMgc2VjdGlv bnMgb2YgdGhlIGNvZGUgdHJpZ2dlciBhbiBpbnRlcm5hbCBjb21waWxlciBlcnJvciB3aXRoCisg ICAgICAgIEdDQyA4LjQsIHNlZ2ZhdWx0aW5nIHRoZSBjb21waWxlci4gVGhpcyBhZGRzIGEgd29y a2Fyb3VuZCB0aGF0CisgICAgICAgIG1ha2VzIGl0IHdvcmsgYWdhaW4uCisKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdv cmtQcm9jZXNzOjpkZWxldGVBbmRSZXN0cmljdFdlYnNpdGVEYXRhRm9yUmVnaXN0cmFibGVEb21h aW5zKToKKwogMjAyMS0xMC0yNiAgUGVyIEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXVtXUF0gUmVkdWNlIHNhbmRib3ggdGVsZW1ldHJ5CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCmluZGV4IGY5NTA2MjYxNGU5Ni4u NGI1Y2E0OTU3ZTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05l dHdvcmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdv cmtQcm9jZXNzLmNwcApAQCAtMTk0MCw3ICsxOTQwLDkgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6 ZGVsZXRlQW5kUmVzdHJpY3RXZWJzaXRlRGF0YUZvclJlZ2lzdHJhYmxlRG9tYWlucyhQQUw6OlNl c3MKIAogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzLmNvbnRhaW5zKFdlYnNpdGVEYXRhVHlwZTo6 RGlza0NhY2hlKSkgewogICAgICAgICBmb3JFYWNoTmV0d29ya1Nlc3Npb24oW3Nlc3Npb25JRCwg ZmV0Y2hPcHRpb25zLCAmZG9tYWluc1RvRGVsZXRlQWxsTm9uQ29va2llV2Vic2l0ZURhdGFGb3Is ICZjYWxsYmFja0FnZ3JlZ2F0b3JdKGF1dG8mIHNlc3Npb24pIHsKLSAgICAgICAgICAgIGZldGNo RGlza0NhY2hlRW50cmllcyhzZXNzaW9uLmNhY2hlKCksIHNlc3Npb25JRCwgZmV0Y2hPcHRpb25z LCBbZG9tYWluc1RvRGVsZXRlQWxsTm9uQ29va2llV2Vic2l0ZURhdGFGb3IsIGNhbGxiYWNrQWdn cmVnYXRvciwgc2Vzc2lvbiA9IFdlYWtQdHIgeyBzZXNzaW9uIH1dKGF1dG8gZW50cmllcykgbXV0 YWJsZSB7CisgICAgICAgICAgICAvKiBoYWNrOiBnY2MgOC40IHdpbGwgc2VnZmF1bHQgaWYgdGhl IFdlYWtQdHIgaXMgaW5zdGFudGlhdGVkIHdpdGhpbiB0aGUgbGFtYmRhIGNhcHR1cmVzICovCisg ICAgICAgICAgICBhdXRvIHdzID0gV2Vha1B0ciB7IHNlc3Npb24gfTsKKyAgICAgICAgICAgIGZl dGNoRGlza0NhY2hlRW50cmllcyhzZXNzaW9uLmNhY2hlKCksIHNlc3Npb25JRCwgZmV0Y2hPcHRp b25zLCBbZG9tYWluc1RvRGVsZXRlQWxsTm9uQ29va2llV2Vic2l0ZURhdGFGb3IsIGNhbGxiYWNr QWdncmVnYXRvciwgc2Vzc2lvbiA9IFdURk1vdmUod3MpXShhdXRvIGVudHJpZXMpIG11dGFibGUg ewogICAgICAgICAgICAgICAgIGlmICghc2Vzc2lvbikKICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuOwogCg==