232259 2021-10-25 12:04:33 -0700 [macOS][GPUP] Block access to mach register 2021-11-12 12:09:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham gavin.p mazander webkit-bug-importer oldest_to_newest 1808509 0 pvollan 2021-10-25 12:04:33 -0700 Based on telemetry, block access to mach register in the GPU process on macOS. 1808510 1 webkit-bug-importer 2021-10-25 12:05:16 -0700 <rdar://problem/84624488> 1808511 2 442392 pvollan 2021-10-25 12:06:11 -0700 Created attachment 442392 Patch 1808513 3 442392 bfulgham 2021-10-25 12:10:29 -0700 Comment on attachment 442392 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442392&action=review > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) I think this is needed for profiling GL content in the GPU Process. I'm not sure it's safe to remove, unless you have tested using the graphics tools on the GPU Process. 1814465 4 444072 pvollan 2021-11-12 08:38:16 -0800 Created attachment 444072 Patch 1814470 5 pvollan 2021-11-12 08:39:46 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 442392 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442392&action=review > > > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) > > I think this is needed for profiling GL content in the GPU Process. I'm not > sure it's safe to remove, unless you have tested using the graphics tools on > the GPU Process. That is a good point. I kept this rule for internal builds, which is the way we've done it in the WebContent process. Thanks for reviewing! 1814489 6 444072 bfulgham 2021-11-12 09:31:58 -0800 Comment on attachment 444072 Patch r=me 1814556 7 ews-feeder 2021-11-12 12:09:20 -0800 Committed r285735 (244194@main): <https://commits.webkit.org/244194@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444072. 442392 2021-10-25 12:06:11 -0700 2021-11-12 08:38:14 -0800 Patch bug-232259-20211025120610.patch text/plain 1874 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODQ4MDApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEwLTI1ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU11bR1BVUF0gQmxvY2sgYWNjZXNz IHRvIG1hY2ggcmVnaXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzMjI1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODQ2MjQ0ODg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gdGVs ZW1ldHJ5LCBibG9jayBhY2Nlc3MgdG8gbWFjaCByZWdpc3RlciBpbiB0aGUgR1BVIHByb2Nlc3Mg b24gbWFjT1MuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQ VVByb2Nlc3Muc2IuaW46CisKIDIwMjEtMTAtMjUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI4NDA3OSk6IEF1ZGlvIGNvbnRp bnVlcyBwbGF5aW5nIG9uIGh1bHUuY29tIGluIHByaXZhdGUgYnJvd3NpbmcgbW9kZSBhZnRlciBj bG9zaW5nIHRoZSB0YWIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFw cGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv R1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCShyZXZpc2lv biAyODQ3ODMpCisrKyBTb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJL aXQuR1BVUHJvY2Vzcy5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtMzcsOSArMzcsNiBAQAogOzs7 IHJlbW92ZSB1bm5lZWRlZCBzYW5kYm94IGV4dGVuc2lvbnMuCiA7OzsKIAotOzs7IEFsbG93IHJl Z2lzdHJhdGlvbiBvZiBwZXItcGlkIHNlcnZpY2VzLgotKGFsbG93IG1hY2gtcmVnaXN0ZXIgKHdp dGggdGVsZW1ldHJ5KSAobG9jYWwtbmFtZS1wcmVmaXggIiIpKQotCiA7OzsgQWxsb3cgcmVhZCBh Y2Nlc3MgdG8gc3RhbmRhcmQgc3lzdGVtIHBhdGhzLgogKGFsbG93IGZpbGUtcmVhZCoKICAgICAo cmVxdWlyZS1hbGwKQEAgLTY4Niw5ICs2ODMsNiBAQAogKHJlYWQtd3JpdGUtYW5kLWlzc3VlLWV4 dGVuc2lvbnMgKGV4dGVuc2lvbiAiY29tLmFwcGxlLmFwcC1zYW5kYm94LnJlYWQtd3JpdGUiKSkK IChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCB0ZWxlbWV0cnkpIChleHRlbnNpb24gImNvbS5hcHBs ZS5hcHAtc2FuZGJveC5tYWNoIikpIDs7IEZJWE1FOiBTaG91bGQgYmUgcmVtb3ZlZCB3aGVuIDxy ZGFyOi8vcHJvYmxlbS8xMzA2NjIwNj4gaXMgZml4ZWQuCiAKLTs7IEFsbG93IHRoZSBPcGVuR0wg UHJvZmlsZXIgdG8gYXR0YWNoLgotKGFsbG93IG1hY2gtcmVnaXN0ZXIgKHdpdGggdGVsZW1ldHJ5 KSAoZ2xvYmFsLW5hbWUtcmVnZXggIyJeX29nbHByb2ZfYXR0YWNoXzxbMC05XSs+JCIpKQotCiAo aWYgKHBvc2l0aXZlPyAoc3RyaW5nLWxlbmd0aCAocGFyYW0gIkRBUldJTl9VU0VSX0NBQ0hFX0RJ UiIpKSkKICAgICAoYWxsb3ctcmVhZC13cml0ZS1kaXJlY3RvcnktYW5kLWlzc3VlLXJlYWQtd3Jp dGUtZXh0ZW5zaW9ucyAocGFyYW0gIkRBUldJTl9VU0VSX0NBQ0hFX0RJUiIpKSkKIAo= 444072 2021-11-12 08:38:16 -0800 2021-11-12 12:09:20 -0800 Patch bug-232259-20211112083815.patch text/plain 1837 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODU2ODApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTExLTEyICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU11bR1BVUF0gQmxvY2sgYWNjZXNz IHRvIG1hY2ggcmVnaXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzMjI1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODQ2MjQ0ODg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gdGVs ZW1ldHJ5LCBibG9jayBhY2Nlc3MgdG8gbWFjaCByZWdpc3RlciBpbiB0aGUgR1BVIHByb2Nlc3Mg b24gbWFjT1MuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQ VVByb2Nlc3Muc2IuaW46CisKIDIwMjEtMTEtMTEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBpbWFnZSBvdmVybGF5IGNvZGUgb3V0IG9mIEhU TUxFbGVtZW50IGFuZCBpbnRvIGEgc2VwYXJhdGUgaGVscGVyIGZpbGUKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5HUFVQcm9jZXNzLnNiLmluCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktp dC5HUFVQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyODU2ODApCisrKyBTb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgkod29ya2luZyBj b3B5KQpAQCAtMzcsOSArMzcsNiBAQAogOzs7IHJlbW92ZSB1bm5lZWRlZCBzYW5kYm94IGV4dGVu c2lvbnMuCiA7OzsKIAotOzs7IEFsbG93IHJlZ2lzdHJhdGlvbiBvZiBwZXItcGlkIHNlcnZpY2Vz LgotKGFsbG93IG1hY2gtcmVnaXN0ZXIgKHdpdGggdGVsZW1ldHJ5KSAobG9jYWwtbmFtZS1wcmVm aXggIiIpKQotCiA7OzsgQWxsb3cgcmVhZCBhY2Nlc3MgdG8gc3RhbmRhcmQgc3lzdGVtIHBhdGhz LgogKGFsbG93IGZpbGUtcmVhZCoKICAgICAocmVxdWlyZS1hbGwKQEAgLTYxOSw3ICs2MTYsOCBA QAogKHJlYWQtd3JpdGUtYW5kLWlzc3VlLWV4dGVuc2lvbnMgKGV4dGVuc2lvbiAiY29tLmFwcGxl LmFwcC1zYW5kYm94LnJlYWQtd3JpdGUiKSkKIAogOzsgQWxsb3cgdGhlIE9wZW5HTCBQcm9maWxl ciB0byBhdHRhY2guCi0oYWxsb3cgbWFjaC1yZWdpc3RlciAod2l0aCB0ZWxlbWV0cnkpIChnbG9i YWwtbmFtZS1yZWdleCAjIl5fb2dscHJvZl9hdHRhY2hfPFswLTldKz4kIikpCisod2l0aC1maWx0 ZXIgKHN5c3RlbS1hdHRyaWJ1dGUgYXBwbGUtaW50ZXJuYWwpCisgICAgKGFsbG93IG1hY2gtcmVn aXN0ZXIgKHdpdGggdGVsZW1ldHJ5KSAoZ2xvYmFsLW5hbWUtcmVnZXggIyJeX29nbHByb2ZfYXR0 YWNoXzxbMC05XSs+JCIpKSkKIAogKGlmIChwb3NpdGl2ZT8gKHN0cmluZy1sZW5ndGggKHBhcmFt ICJEQVJXSU5fVVNFUl9DQUNIRV9ESVIiKSkpCiAgICAgKGFsbG93LXJlYWQtd3JpdGUtZGlyZWN0 b3J5LWFuZC1pc3N1ZS1yZWFkLXdyaXRlLWV4dGVuc2lvbnMgKHBhcmFtICJEQVJXSU5fVVNFUl9D QUNIRV9ESVIiKSkpCg==