232246 2021-10-25 10:25:19 -0700 Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue() 2021-10-26 00:07:19 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino esprehn+autocc ews-watchlist glenn graouts gyuyoung.kim koivisto macpherson menard webkit-bug-importer oldest_to_newest 1808446 0 graouts 2021-10-25 10:25:19 -0700 Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue() 1808447 1 442381 graouts 2021-10-25 10:26:00 -0700 Created attachment 442381 Patch 1808450 2 442381 dino 2021-10-25 10:27:43 -0700 Comment on attachment 442381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442381&action=review > Source/WebCore/css/CSSToStyleMap.cpp:-461 > - return; Might as well keep the return and use "if" instead of "else if". 1808451 3 graouts 2021-10-25 10:28:53 -0700 (In reply to Dean Jackson from comment #2) > Comment on attachment 442381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442381&action=review > > > Source/WebCore/css/CSSToStyleMap.cpp:-461 > > - return; > > Might as well keep the return and use "if" instead of "else if". But it's one whole extra line of code! 1808777 4 ews-feeder 2021-10-26 00:06:35 -0700 Committed r284856 (243533@main): <https://commits.webkit.org/243533@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442381. 1808778 5 webkit-bug-importer 2021-10-26 00:07:19 -0700 <rdar://problem/84650836> 442381 2021-10-25 10:26:00 -0700 2021-10-26 00:06:36 -0700 Patch bug-232246-20211025192559.patch text/plain 3931 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA3YjgzODNlMGE0NTZk MDc3MzM1YTg3OGFiMTAxOWFiMzBhOGZiNC4uZDZmYzgyMDlhNzllNThjZDRmMDE0MjhmNGI3MmU0 ZDU3NjdkMjJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTEwLTI1ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJlZmFjdG9yIENTU1Rv U3R5bGVNYXA6Om1hcEFuaW1hdGlvblRpbWluZ0Z1bmN0aW9uKCkgdG8gdXNlIFRpbWluZ0Z1bmN0 aW9uOjpjcmVhdGVGcm9tQ1NTVmFsdWUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMjQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBjc3MvQ1NTVG9TdHlsZU1hcC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDU1NUb1N0eWxlTWFwOjptYXBBbmltYXRpb25UaW1pbmdGdW5jdGlvbik6CisKIDIwMjEt MTAtMjUgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gQ2hlY2sgYWNyb3NzIGlubGluZSBib3ggYm91bmRhcmllcyBmb3IgYnJlYWthYmxlIHBvc2l0 aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVG9TdHlsZU1hcC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTVG9TdHlsZU1hcC5jcHAKaW5kZXggYmNmZGEwNTJlYTc5MzA3 ZTE0ZmQ1NDc4YTBjYTljZjljZmQwMGU2NS4uOWM4OTg3MDlmZjdjZjliNjcxODU4N2NmY2NjYjE0 OWQzNDdmNjU1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1RvU3R5bGVNYXAu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NUb1N0eWxlTWFwLmNwcApAQCAtNDU2LDUw ICs0NTYsMTAgQEAgdm9pZCBDU1NUb1N0eWxlTWFwOjptYXBBbmltYXRpb25Qcm9wZXJ0eShBbmlt YXRpb24mIGFuaW1hdGlvbiwgY29uc3QgQ1NTVmFsdWUmIHYKIAogdm9pZCBDU1NUb1N0eWxlTWFw OjptYXBBbmltYXRpb25UaW1pbmdGdW5jdGlvbihBbmltYXRpb24mIGFuaW1hdGlvbiwgY29uc3Qg Q1NTVmFsdWUmIHZhbHVlKQogewotICAgIGlmICh2YWx1ZS50cmVhdEFzSW5pdGlhbFZhbHVlKENT U1Byb3BlcnR5QW5pbWF0aW9uVGltaW5nRnVuY3Rpb24pKSB7CisgICAgaWYgKHZhbHVlLnRyZWF0 QXNJbml0aWFsVmFsdWUoQ1NTUHJvcGVydHlBbmltYXRpb25UaW1pbmdGdW5jdGlvbikpCiAgICAg ICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihBbmltYXRpb246OmluaXRpYWxUaW1pbmdG dW5jdGlvbigpKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGlmIChpczxDU1NQcmlt aXRpdmVWYWx1ZT4odmFsdWUpKSB7Ci0gICAgICAgIHN3aXRjaCAoZG93bmNhc3Q8Q1NTUHJpbWl0 aXZlVmFsdWU+KHZhbHVlKS52YWx1ZUlEKCkpIHsKLSAgICAgICAgY2FzZSBDU1NWYWx1ZUxpbmVh cjoKLSAgICAgICAgICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihMaW5lYXJUaW1pbmdG dW5jdGlvbjo6Y3JlYXRlKCkpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgQ1NT VmFsdWVFYXNlOgotICAgICAgICAgICAgYW5pbWF0aW9uLnNldFRpbWluZ0Z1bmN0aW9uKEN1Ymlj QmV6aWVyVGltaW5nRnVuY3Rpb246OmNyZWF0ZSgpKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAg ICAgICBjYXNlIENTU1ZhbHVlRWFzZUluOgotICAgICAgICAgICAgYW5pbWF0aW9uLnNldFRpbWlu Z0Z1bmN0aW9uKEN1YmljQmV6aWVyVGltaW5nRnVuY3Rpb246OmNyZWF0ZShDdWJpY0JlemllclRp bWluZ0Z1bmN0aW9uOjpFYXNlSW4pKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNl IENTU1ZhbHVlRWFzZU91dDoKLSAgICAgICAgICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlv bihDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uOjpjcmVhdGUoQ3ViaWNCZXppZXJUaW1pbmdGdW5j dGlvbjo6RWFzZU91dCkpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgQ1NTVmFs dWVFYXNlSW5PdXQ6Ci0gICAgICAgICAgICBhbmltYXRpb24uc2V0VGltaW5nRnVuY3Rpb24oQ3Vi aWNCZXppZXJUaW1pbmdGdW5jdGlvbjo6Y3JlYXRlKEN1YmljQmV6aWVyVGltaW5nRnVuY3Rpb246 OkVhc2VJbk91dCkpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgQ1NTVmFsdWVT dGVwU3RhcnQ6Ci0gICAgICAgICAgICBhbmltYXRpb24uc2V0VGltaW5nRnVuY3Rpb24oU3RlcHNU aW1pbmdGdW5jdGlvbjo6Y3JlYXRlKDEsIFN0ZXBzVGltaW5nRnVuY3Rpb246OlN0ZXBQb3NpdGlv bjo6U3RhcnQpKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIENTU1ZhbHVlU3Rl cEVuZDoKLSAgICAgICAgICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihTdGVwc1RpbWlu Z0Z1bmN0aW9uOjpjcmVhdGUoMSwgU3RlcHNUaW1pbmdGdW5jdGlvbjo6U3RlcFBvc2l0aW9uOjpF bmQpKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAg YnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGlmIChpczxD U1NDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uVmFsdWU+KHZhbHVlKSkgewotICAgICAgICBhdXRv JiBjdWJpY1RpbWluZ0Z1bmN0aW9uID0gZG93bmNhc3Q8Q1NTQ3ViaWNCZXppZXJUaW1pbmdGdW5j dGlvblZhbHVlPih2YWx1ZSk7Ci0gICAgICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihD dWJpY0JlemllclRpbWluZ0Z1bmN0aW9uOjpjcmVhdGUoY3ViaWNUaW1pbmdGdW5jdGlvbi54MSgp LCBjdWJpY1RpbWluZ0Z1bmN0aW9uLnkxKCksIGN1YmljVGltaW5nRnVuY3Rpb24ueDIoKSwgY3Vi aWNUaW1pbmdGdW5jdGlvbi55MigpKSk7Ci0gICAgfSBlbHNlIGlmIChpczxDU1NTdGVwc1RpbWlu Z0Z1bmN0aW9uVmFsdWU+KHZhbHVlKSkgewotICAgICAgICBhdXRvJiBzdGVwc1RpbWluZ0Z1bmN0 aW9uID0gZG93bmNhc3Q8Q1NTU3RlcHNUaW1pbmdGdW5jdGlvblZhbHVlPih2YWx1ZSk7Ci0gICAg ICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihTdGVwc1RpbWluZ0Z1bmN0aW9uOjpjcmVh dGUoc3RlcHNUaW1pbmdGdW5jdGlvbi5udW1iZXJPZlN0ZXBzKCksIHN0ZXBzVGltaW5nRnVuY3Rp b24uc3RlcFBvc2l0aW9uKCkpKTsKLSAgICB9IGVsc2UgaWYgKGlzPENTU1NwcmluZ1RpbWluZ0Z1 bmN0aW9uVmFsdWU+KHZhbHVlKSkgewotICAgICAgICBhdXRvJiBzcHJpbmdUaW1pbmdGdW5jdGlv biA9IGRvd25jYXN0PENTU1NwcmluZ1RpbWluZ0Z1bmN0aW9uVmFsdWU+KHZhbHVlKTsKLSAgICAg ICAgYW5pbWF0aW9uLnNldFRpbWluZ0Z1bmN0aW9uKFNwcmluZ1RpbWluZ0Z1bmN0aW9uOjpjcmVh dGUoc3ByaW5nVGltaW5nRnVuY3Rpb24ubWFzcygpLCBzcHJpbmdUaW1pbmdGdW5jdGlvbi5zdGlm Zm5lc3MoKSwgc3ByaW5nVGltaW5nRnVuY3Rpb24uZGFtcGluZygpLCBzcHJpbmdUaW1pbmdGdW5j dGlvbi5pbml0aWFsVmVsb2NpdHkoKSkpOwotICAgIH0KKyAgICBlbHNlIGlmIChhdXRvIHRpbWlu Z0Z1bmN0aW9uID0gVGltaW5nRnVuY3Rpb246OmNyZWF0ZUZyb21DU1NWYWx1ZSh2YWx1ZSkpCisg ICAgICAgIGFuaW1hdGlvbi5zZXRUaW1pbmdGdW5jdGlvbihXVEZNb3ZlKHRpbWluZ0Z1bmN0aW9u KSk7CiB9CiAKIHZvaWQgQ1NTVG9TdHlsZU1hcDo6bWFwTmluZVBpZWNlSW1hZ2UoQ1NTUHJvcGVy dHlJRCBwcm9wZXJ0eSwgQ1NTVmFsdWUqIHZhbHVlLCBOaW5lUGllY2VJbWFnZSYgaW1hZ2UpCg==