232194 2021-10-22 20:55:00 -0700 Likely typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks() 2021-10-24 17:04:21 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1808022 0 jean-yves.avenard 2021-10-22 20:55:00 -0700 In MediaPlayerPrivateAVFoundationObjC::updateVideoTracks() we see: ``` for (auto& track : m_audioTracks) track->resetPropertiesFromTrack(); ``` it's almost certainly wrong and should be: ``` for (auto& track : m_videoTracks) track->resetPropertiesFromTrack(); ``` 1808023 1 webkit-bug-importer 2021-10-22 20:55:19 -0700 <rdar://problem/84574134> 1808026 2 442247 jean-yves.avenard 2021-10-22 21:04:15 -0700 Created attachment 442247 Patch 1808075 3 442247 darin 2021-10-23 09:16:59 -0700 Comment on attachment 442247 Patch Typically when we spot an obvious mistake like this, we spend a moment to try to create a test that failed because of the error. It’s frustrating, because likely if we had written the code correctly we would not have to think about how to write a test. Please consider if we could have tested. I have personally been in this situation many times, spotted a typo that’s an obvious mistake and then was frustrated at the challenge of writing a test to prove the code was malfunctioning, and I understand if after thinking it over you do not find it’s practical to test, but I would appreciate a specific comment saying so if that happened. 1808163 4 jean-yves.avenard 2021-10-23 20:53:54 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 442247 [details] > Patch > > Typically when we spot an obvious mistake like this, we spend a moment to > try to create a test that failed because of the error. It’s frustrating, > because likely if we had written the code correctly we would not have to > think about how to write a test. I found this while reading the code for a totally unrelated bug. I did try to understand the consequences of such error. This code was written in 2014, so the severity of the problem is likely low. To hit that code, you would need to write a specially crafted HLS stream, which in itself isn’t trivial as playback of those is non deterministic. And even so, it would likely not be observable via JS. I will add a comment indicating so. 1808271 5 442327 jean-yves.avenard 2021-10-24 16:05:16 -0700 Created attachment 442327 Patch 1808282 6 ews-feeder 2021-10-24 17:04:19 -0700 Committed r284770 (243479@main): <https://commits.webkit.org/243479@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442327. 442247 2021-10-22 21:04:15 -0700 2021-10-24 16:05:12 -0700 Patch bug-232194-20211023150414.patch text/plain 2783 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE4YmYwYTNiNDA3Njk1 YzI0NjMyNzQxMzQwYjhiMTQzYjk2YzBkNy4uMjgyZmU1ZWQxZGRlMTdlYjdhZGI2Mzk4ODdmNDU3 NDBiODY3ZTI0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTIyICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHR5cG8gaW4gTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dXBkYXRlVmlkZW9UcmFja3MoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMTk0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgdmlkZW8g dHJhY2tzJyBwcm9wZXJ0aWVzIHdoZW4gdmlkZW8gdHJhY2tzIGFyZSBjaGFuZ2luZyByYXRoZXIK KyAgICAgICAgdGhhbiB0aGUgYXVkaW8gb25lcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMu bW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD Ojp1cGRhdGVWaWRlb1RyYWNrcyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvVmlkZW9UcmFja1ByaXZhdGVBVkZPYmpDLmg6CisKIDIwMjEtMTAtMjIgIEpl YW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICB2aWRlbyBhcHBlYXJz IGJsYW5rIHdpdGggb25seSBhdWRpbyBwbGF5aW5nIGlmIHZpZGVvIGVsZW1lbnQgaXNuJ3QgYXBw ZW5kZWQgdG8gdGhlIGRvbSB0cmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQppbmRleCBmNzYyZTlj Zjc1NjBhNTM0NWQwMTRlNzc2NWU4YTY4ZWY4ZTU5MzAzLi40N2E2YzdmMTcyOGExY2ViZTJhNTA3 NDYwMWI5NDFiNWM0NThmYjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KQEAgLTIzNzMsNyAr MjM3Myw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dXBkYXRl VmlkZW9UcmFja3MoKQogICAgIGlmIChtX3Zpc3VhbEdyb3VwKQogICAgICAgICBkZXRlcm1pbmVD aGFuZ2VkVHJhY2tzRnJvbU5ld1RyYWNrc0FuZE9sZEl0ZW1zKG1fdmlzdWFsR3JvdXAuZ2V0KCks IG1fdmlkZW9UcmFja3MsIFZlY3RvcjxTdHJpbmc+KCksICZWaWRlb1RyYWNrUHJpdmF0ZUFWRk9i akM6OmNyZWF0ZSwgcGxheWVyKCksICZNZWRpYVBsYXllcjo6cmVtb3ZlVmlkZW9UcmFjaywgJk1l ZGlhUGxheWVyOjphZGRWaWRlb1RyYWNrKTsKIAotICAgIGZvciAoYXV0byYgdHJhY2sgOiBtX2F1 ZGlvVHJhY2tzKQorICAgIGZvciAoYXV0byYgdHJhY2sgOiBtX3ZpZGVvVHJhY2tzKQogICAgICAg ICB0cmFjay0+cmVzZXRQcm9wZXJ0aWVzRnJvbVRyYWNrKCk7CiAKICAgICAvLyBJbiBjYXNlIHRo ZSB2aWRlbyB0cmFjayBjb250ZW50IGNoYW5nZWQsIHdlIG1heSBiZSBhYmxlIHRvIHBlcmZvcm0g YSByZWFkYmFjayBhZ2Fpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1ZpZGVvVHJhY2tQcml2YXRlQVZGT2JqQy5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvVmlkZW9UcmFj a1ByaXZhdGVBVkZPYmpDLmgKaW5kZXggZWYxNDE2Y2Q3ODE4ZjllZDIxZGE2MTIxZDI5YWE5MWQz NzM2YWFlMi4uZjQ1YWZlNGY2OWFkMTM4MmJiMGYxOGZjYzQyZmY1YmE5NjlkOTFiMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMv VmlkZW9UcmFja1ByaXZhdGVBVkZPYmpDLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvVmlkZW9UcmFja1ByaXZhdGVBVkZPYmpDLmgKQEAg LTcxLDYgKzcxLDcgQEAgcHVibGljOgogICAgIE1lZGlhU2VsZWN0aW9uT3B0aW9uQVZGT2JqQyog bWVkaWFTZWxlY3Rpb25PcHRpb24oKTsKIAogcHJpdmF0ZToKKyAgICBmcmllbmQgY2xhc3MgTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzsKICAgICBleHBsaWNpdCBWaWRlb1RyYWNr UHJpdmF0ZUFWRk9iakMoQVZQbGF5ZXJJdGVtVHJhY2sqKTsKICAgICBleHBsaWNpdCBWaWRlb1Ry YWNrUHJpdmF0ZUFWRk9iakMoQVZBc3NldFRyYWNrKik7CiAgICAgZXhwbGljaXQgVmlkZW9UcmFj a1ByaXZhdGVBVkZPYmpDKE1lZGlhU2VsZWN0aW9uT3B0aW9uQVZGT2JqQyYpOwo= 442327 2021-10-24 16:05:16 -0700 2021-10-24 17:04:20 -0700 Patch bug-232194-20211025100515.patch text/plain 3342 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE4YmYwYTNiNDA3Njk1 YzI0NjMyNzQxMzQwYjhiMTQzYjk2YzBkNy4uOTgzNGMzMmMxMDQxNmM4OGJiYzllNTE0N2E5OGE5 YTU3MjhiYjhkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTEwLTIyICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHR5cG8gaW4gTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dXBkYXRlVmlkZW9UcmFja3MoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMTk0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgUmVzZXQgdmlkZW8gdHJh Y2tzJyBwcm9wZXJ0aWVzIHdoZW4gdmlkZW8gdHJhY2tzIGFyZSBjaGFuZ2luZyByYXRoZXIKKyAg ICAgICAgdGhhbiB0aGUgYXVkaW8gb25lcy4KKworICAgICAgICBUaGVyZSBzaG91bGQgYmUgbm8g b2JzZXJ2YWJsZSBjaGFuZ2VzLCByZXNldHRpbmcgdGhlIGF1ZGlvIHRyYWNrIHByb3BlcnRpZXMK KyAgICAgICAgd291bGQgaGF2ZSBiZWVuIGEgbm8tb3AgYXMgQXVkaW9UcmFja1ByaXZhdGVBVkZP YmpDIGlzIGp1c3QgYSB3cmFwcGVyIGFyb3VuZAorICAgICAgICBBVlBsYXllckl0ZW1UcmFjayBh bmQgcHJvcGVydGllcyBhcmUga2VwdCBpbiBzeW5jIHRob3JvdWdoIHBsYXliYWNrLgorICAgICAg ICBOb3QgY2FsbGluZyByZXNldFByb3BlcnRpZXNGcm9tVHJhY2sgb24gdGhlIHZpZGVvIHRyYWNr IHdvdWxkbid0IGhhdmUgbWF0dGVyZWQKKyAgICAgICAgYXMgdGhlIG9wZXJhdGlvbiBpcyBjYWxs ZWQgd2hlbiB0aGUgdHJhY2sgaXMgY29uc3RydWN0ZWQgYWJvdmUgaW4gdGhlCisgICAgICAgIGRl dGVybWluZUNoYW5nZWRUcmFja3NGcm9tTmV3VHJhY2tzQW5kT2xkSXRlbXMgbWV0aG9kLgorICAg ICAgICBTbyB0aGlzIGNvZGUgb25seSBpbXByb3ZlcyByZWFkYWJpbGl0eSwgYW5kIGNvdWxkIGJl IHJlbW92ZWQgZW50aXJlbHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dXBkYXRlVmlk ZW9UcmFja3MpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L1ZpZGVvVHJhY2tQcml2YXRlQVZGT2JqQy5oOgorCiAyMDIxLTEwLTIyICBKZWFuLVl2ZXMgQXZl bmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgdmlkZW8gYXBwZWFycyBibGFuayB3aXRo IG9ubHkgYXVkaW8gcGxheWluZyBpZiB2aWRlbyBlbGVtZW50IGlzbid0IGFwcGVuZGVkIHRvIHRo ZSBkb20gdHJlZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbSBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KaW5kZXggZjc2MmU5Y2Y3NTYwYTUzNDVk MDE0ZTc3NjVlOGE2OGVmOGU1OTMwMy4uNDdhNmM3ZjE3MjhhMWNlYmUyYTUwNzQ2MDFiOTQxYjVj NDU4ZmIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC0yMzczLDcgKzIzNzMsNyBAQCB2 b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnVwZGF0ZVZpZGVvVHJhY2tz KCkKICAgICBpZiAobV92aXN1YWxHcm91cCkKICAgICAgICAgZGV0ZXJtaW5lQ2hhbmdlZFRyYWNr c0Zyb21OZXdUcmFja3NBbmRPbGRJdGVtcyhtX3Zpc3VhbEdyb3VwLmdldCgpLCBtX3ZpZGVvVHJh Y2tzLCBWZWN0b3I8U3RyaW5nPigpLCAmVmlkZW9UcmFja1ByaXZhdGVBVkZPYmpDOjpjcmVhdGUs IHBsYXllcigpLCAmTWVkaWFQbGF5ZXI6OnJlbW92ZVZpZGVvVHJhY2ssICZNZWRpYVBsYXllcjo6 YWRkVmlkZW9UcmFjayk7CiAKLSAgICBmb3IgKGF1dG8mIHRyYWNrIDogbV9hdWRpb1RyYWNrcykK KyAgICBmb3IgKGF1dG8mIHRyYWNrIDogbV92aWRlb1RyYWNrcykKICAgICAgICAgdHJhY2stPnJl c2V0UHJvcGVydGllc0Zyb21UcmFjaygpOwogCiAgICAgLy8gSW4gY2FzZSB0aGUgdmlkZW8gdHJh Y2sgY29udGVudCBjaGFuZ2VkLCB3ZSBtYXkgYmUgYWJsZSB0byBwZXJmb3JtIGEgcmVhZGJhY2sg YWdhaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9WaWRlb1RyYWNrUHJpdmF0ZUFWRk9iakMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1ZpZGVvVHJhY2tQcml2YXRlQVZG T2JqQy5oCmluZGV4IGVmMTQxNmNkNzgxOGY5ZWQyMWRhNjEyMWQyOWFhOTFkMzczNmFhZTIuLmY0 NWFmZTRmNjlhZDEzODJiYjBmMThmY2M0MmZmNWJhOTY5ZDkxYjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1ZpZGVvVHJhY2tQ cml2YXRlQVZGT2JqQy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL1ZpZGVvVHJhY2tQcml2YXRlQVZGT2JqQy5oCkBAIC03MSw2ICs3MSw3 IEBAIHB1YmxpYzoKICAgICBNZWRpYVNlbGVjdGlvbk9wdGlvbkFWRk9iakMqIG1lZGlhU2VsZWN0 aW9uT3B0aW9uKCk7CiAKIHByaXZhdGU6CisgICAgZnJpZW5kIGNsYXNzIE1lZGlhUGxheWVyUHJp dmF0ZUFWRm91bmRhdGlvbk9iakM7CiAgICAgZXhwbGljaXQgVmlkZW9UcmFja1ByaXZhdGVBVkZP YmpDKEFWUGxheWVySXRlbVRyYWNrKik7CiAgICAgZXhwbGljaXQgVmlkZW9UcmFja1ByaXZhdGVB VkZPYmpDKEFWQXNzZXRUcmFjayopOwogICAgIGV4cGxpY2l0IFZpZGVvVHJhY2tQcml2YXRlQVZG T2JqQyhNZWRpYVNlbGVjdGlvbk9wdGlvbkFWRk9iakMmKTsK