232191 2021-10-22 18:50:48 -0700 [LFC][IFC] Breaking before hyphen is only allowed when line-break is loose 2021-10-24 06:55:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan benjamin bfulgham cdumez cmarcelo darin ews-watchlist koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1808008 0 zalan 2021-10-22 18:50:48 -0700 The following breaks are allowed for loose line breaking if the preceding character belongs to the Unicode line breaking class ID [UAX14] (including when the preceding character is treated as ID due to word-break: break-all), and are otherwise forbidden: breaks before hyphens: ‐ U+2010, – U+2013 https://drafts.csswg.org/css-text-3/#line-break-property 1808018 1 442245 zalan 2021-10-22 20:34:22 -0700 Created attachment 442245 Patch 1808070 2 ews-feeder 2021-10-23 08:54:13 -0700 Committed r284744 (243453@main): <https://commits.webkit.org/243453@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442245. 1808071 3 webkit-bug-importer 2021-10-23 08:55:17 -0700 <rdar://problem/84580370> 1808072 4 442245 darin 2021-10-23 09:11:49 -0700 Comment on attachment 442245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442245&action=review > Source/WTF/wtf/unicode/CharacterNames.h:64 > +constexpr UChar endash = 0x2013; Typically we try to exactly follow the naming scheme from Unicode here, which I think would be enDash, two words. 1808084 5 zalan 2021-10-23 09:28:46 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 442245 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442245&action=review > > > Source/WTF/wtf/unicode/CharacterNames.h:64 > > +constexpr UChar endash = 0x2013; > > Typically we try to exactly follow the naming scheme from Unicode here, > which I think would be enDash, two words. Makes sense. Will change it. I was using the postscript name endash, see at https://www.compart.com/en/unicode/U+2013 1808207 6 zalan 2021-10-24 06:55:37 -0700 https://trac.webkit.org/changeset/284753/webkit 442245 2021-10-22 20:34:22 -0700 2021-10-23 08:54:14 -0700 Patch bug-232191-20211022203421.patch text/plain 6561 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRjMzFlMmMzYWZiYTQzOThiYzZiMzNk YThiOTY5MTY3MTZmOTBhMTYuLjMxMTYzYjNiNzc2ZmZiYjk0MDAxYmJmODFiZWNjMmNjY2UwNjNl MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMTAtMjIgIEFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgorCisgICAgICAgIFtMRkNdW0lGQ10gQnJlYWtpbmcgYmVmb3JlIGh5cGhlbiBp cyBvbmx5IGFsbG93ZWQgd2hlbiBsaW5lLWJyZWFrIGlzIGxvb3NlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzIxOTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi91bmljb2RlL0NoYXJhY3Rlck5h bWVzLmg6CisKIDIwMjEtMTAtMjIgIEpvb25naHVuIFBhcmsgIDxwamgwNzE4QGdtYWlsLmNvbT4K IAogICAgICAgICBJbnRlZ2VyIGludGVycG9sYXRpb24gaW4gYW5pbWF0aW9ucyBzaG91bGQgYmUg cm91bmRlZCB0b3dhcmRzIHBvc2l0aXZlIGluZmluaXR5LCBub3QgYXdheSBmcm9tIHplcm8uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNTAwMWYxY2Y2Mzg1ZWM2NjhjY2FlOTRmZTg2YmU1NDc3NWViMDM4Mi4uMmNk MzcxMzlhN2NjMDhmYmQyNTU1ODhlODU4ODFlYjg2ZGQxMGM0ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDIxLTEwLTIyICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTEZDXVtJRkNdIEJyZWFraW5nIGJlZm9yZSBoeXBoZW4gaXMgb25seSBhbGxvd2Vk IHdoZW4gbGluZS1icmVhayBpcyBsb29zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjMyMTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3IgZW5hYmxpbmcgdGhl IGZpeCBmb3Igd2Via2l0Lm9yZy9iLzIzMjE5Mi4KKworICAgICAgICBUd28gaHlwaGVuYXRpb24g cmVsYXRlZCBXUFQgdGVzdHMgKGxpbmUtYnJlYWstbm9ybWFsLWh5cGhlbnMtMDAyLmh0bWwsIGxp bmUtYnJlYWstc3RyaWN0LWh5cGhlbnMtMDAyLmh0bWwpCisgICAgICAgIHNpbXBseSBwYXNzIGJl Y2F1c2Ugb2YgYSBMYXlvdXRVbml0IChibG9jayB3aWR0aCkgdnMuIGZsb2F0IChtZWFzdXJlZCB0 ZXh0IHdpZHRoKSBwcmVjaXNpb24gbWlzbWF0Y2hpbmcgYnVnLgorICAgICAgICBUaGlzIHByZWNp c2lvbiBpc3N1ZSBtYWtlcyB0aGUgbGluZSBicmVha2luZyBjb2RlIGJlbGlldmUgdGhhdCBmZXdl ciBjaGFyYWN0ZXJzIGZpdCB0aGUgbGluZQorICAgICAgICBwcm9kdWNpbmcgdGhlIGV4cGVjdGVk IHJlc3VsdHMgZm9yIHRob3NlIHR3byB0ZXN0cy4KKyAgICAgICAgTGV0J3MgZml4IHRoZSBsaW5l IGJyZWFraW5nIGxvZ2ljIGZpcnN0IGJ5IGFkZGluZyAiYnJlYWtzIGJlZm9yZSBoeXBoZW5zIiBy dWxlcywKKyAgICAgICAgc28gdGhhdCB3aGVuIHdlYmtpdC5vcmcvYi8yMzIxOTIgaXMgYWRkcmVz c2VkLCB3ZSB3b24ndCBiZSBzZWVpbmcgYW55IFdQVCByZWdyZXNzaW9ucy4KKworICAgICAgICAq IGxheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUNvbnRlbnRCcmVha2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6bWlkV29yZEJyZWFrKToKKwogMjAyMS0xMC0y MiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFByZWNvbm5lY3Qg dG8gbGluaydzIHRhcmdldCBvbiBjbGljawpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdW5p Y29kZS9DaGFyYWN0ZXJOYW1lcy5oIGIvU291cmNlL1dURi93dGYvdW5pY29kZS9DaGFyYWN0ZXJO YW1lcy5oCmluZGV4IDNiYjJmNjVkOTMwZmI5OGJmNzBkZGEzY2IyOGEwMWEyY2EyMjc1MjguLmUw MTA5MDI4OTM1MjI4YWU2MDcxMzgxZmQ2NDYyZTg1NWM2ODUzODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL3VuaWNvZGUvQ2hhcmFjdGVyTmFtZXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi91 bmljb2RlL0NoYXJhY3Rlck5hbWVzLmgKQEAgLTYxLDYgKzYxLDcgQEAgY29uc3RleHByIFVDaGFy IGhlYnJld1B1bmN0dWF0aW9uR2VyZXNoID0gMHgwNUYzOwogY29uc3RleHByIFVDaGFyIGhlYnJl d1B1bmN0dWF0aW9uR2Vyc2hheWltID0gMHgwNUY0OwogY29uc3RleHByIFVDaGFyIGhvcml6b250 YWxFbGxpcHNpcyA9IDB4MjAyNjsKIGNvbnN0ZXhwciBVQ2hhciBoeXBoZW4gPSAweDIwMTA7Citj b25zdGV4cHIgVUNoYXIgZW5kYXNoID0gMHgyMDEzOwogY29uc3RleHByIFVDaGFyIGh5cGhlbk1p bnVzID0gMHgwMDJEOwogY29uc3RleHByIFVDaGFyIGlkZW9ncmFwaGljQ29tbWEgPSAweDMwMDE7 CiBjb25zdGV4cHIgVUNoYXIgaWRlb2dyYXBoaWNGdWxsU3RvcCA9IDB4MzAwMjsKQEAgLTE0MSw2 ICsxNDIsNyBAQCB1c2luZyBXVEY6OlVuaWNvZGU6OmhlYnJld1B1bmN0dWF0aW9uR2VyZXNoOwog dXNpbmcgV1RGOjpVbmljb2RlOjpoZWJyZXdQdW5jdHVhdGlvbkdlcnNoYXlpbTsKIHVzaW5nIFdU Rjo6VW5pY29kZTo6aG9yaXpvbnRhbEVsbGlwc2lzOwogdXNpbmcgV1RGOjpVbmljb2RlOjpoeXBo ZW47Cit1c2luZyBXVEY6OlVuaWNvZGU6OmVuZGFzaDsKIHVzaW5nIFdURjo6VW5pY29kZTo6aHlw aGVuTWludXM7CiB1c2luZyBXVEY6OlVuaWNvZGU6OmlkZW9ncmFwaGljQ29tbWE7CiB1c2luZyBX VEY6OlVuaWNvZGU6OmlkZW9ncmFwaGljRnVsbFN0b3A7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVDb250ZW50QnJlYWtl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9J bmxpbmVDb250ZW50QnJlYWtlci5jcHAKaW5kZXggMTFkNDdmZWY1Y2EzNzRhNjhhNjMyMGE1Mjk0 MzFjMDg0Nzc3ZjI3NC4uYmI5NzE2YTNjYjZhYjFhYTIwNTA1ZDJhODk4N2Y5ZThlMzEyZWQ3NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxp bmUvSW5saW5lQ29udGVudEJyZWFrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9m b3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL0lubGluZUNvbnRlbnRCcmVha2VyLmNwcApAQCAtMzA2 LDEzICszMDYsMTQgQEAgc3RhdGljIFRleHRVdGlsOjpNaWRXb3JkQnJlYWsgbWlkV29yZEJyZWFr KGNvbnN0IElubGluZUNvbnRlbnRCcmVha2VyOjpDb250aW51b3UKIHsKICAgICBhdXRvJiBpbmxp bmVUZXh0SXRlbSA9IGRvd25jYXN0PElubGluZVRleHRJdGVtPih0ZXh0UnVuLmlubGluZUl0ZW0p OwogICAgIGF1dG8mIHN0eWxlID0gdGV4dFJ1bi5zdHlsZTsKLSAgICBBU1NFUlQoc3R5bGUubGlu ZUJyZWFrKCkgPT0gTGluZUJyZWFrOjpBbnl3aGVyZSB8fCBzdHlsZS53b3JkQnJlYWsoKSA9PSBX b3JkQnJlYWs6OkJyZWFrQWxsIHx8IHN0eWxlLndvcmRCcmVhaygpID09IFdvcmRCcmVhazo6QnJl YWtXb3JkIHx8IHN0eWxlLm92ZXJmbG93V3JhcCgpID09IE92ZXJmbG93V3JhcDo6QnJlYWtXb3Jk IHx8IHN0eWxlLm92ZXJmbG93V3JhcCgpID09IE92ZXJmbG93V3JhcDo6QW55d2hlcmUpOworICAg IGF1dG8gbGluZUJyZWFrID0gc3R5bGUubGluZUJyZWFrKCk7CisgICAgQVNTRVJUKGxpbmVCcmVh ayA9PSBMaW5lQnJlYWs6OkFueXdoZXJlIHx8IHN0eWxlLndvcmRCcmVhaygpID09IFdvcmRCcmVh azo6QnJlYWtBbGwgfHwgc3R5bGUud29yZEJyZWFrKCkgPT0gV29yZEJyZWFrOjpCcmVha1dvcmQg fHwgc3R5bGUub3ZlcmZsb3dXcmFwKCkgPT0gT3ZlcmZsb3dXcmFwOjpCcmVha1dvcmQgfHwgc3R5 bGUub3ZlcmZsb3dXcmFwKCkgPT0gT3ZlcmZsb3dXcmFwOjpBbnl3aGVyZSk7CiAKICAgICBhdXRv IG1pZFdvcmRCcmVhayA9IFRleHRVdGlsOjptaWRXb3JkQnJlYWsoaW5saW5lVGV4dEl0ZW0sIHN0 eWxlLmZvbnRDYXNjYWRlKCksIHRleHRSdW4ubG9naWNhbFdpZHRoLCBhdmFpbGFibGVXaWR0aCwg cnVuTG9naWNhbExlZnQpOwogICAgIGlmICghbWlkV29yZEJyZWFrLmxlbmd0aCB8fCBtaWRXb3Jk QnJlYWsubGVuZ3RoID09IGlubGluZVRleHRJdGVtLmxlbmd0aCgpKQogICAgICAgICByZXR1cm4g bWlkV29yZEJyZWFrOwogCi0gICAgYXV0byBjYW5CcmVha0JldHdlZW5BbnlUeXBvZ3JhcGhpY0No YXJhY3RlclVuaXQgPSBzdHlsZS5saW5lQnJlYWsoKSA9PSBMaW5lQnJlYWs6OkFueXdoZXJlIHx8 IHN0eWxlLndvcmRCcmVhaygpID09IFdvcmRCcmVhazo6QnJlYWtXb3JkIHx8IHN0eWxlLm92ZXJm bG93V3JhcCgpID09IE92ZXJmbG93V3JhcDo6QnJlYWtXb3JkIHx8IHN0eWxlLm92ZXJmbG93V3Jh cCgpID09IE92ZXJmbG93V3JhcDo6QW55d2hlcmU7CisgICAgYXV0byBjYW5CcmVha0JldHdlZW5B bnlUeXBvZ3JhcGhpY0NoYXJhY3RlclVuaXQgPSBsaW5lQnJlYWsgPT0gTGluZUJyZWFrOjpBbnl3 aGVyZSB8fCBzdHlsZS53b3JkQnJlYWsoKSA9PSBXb3JkQnJlYWs6OkJyZWFrV29yZCB8fCBzdHls ZS5vdmVyZmxvd1dyYXAoKSA9PSBPdmVyZmxvd1dyYXA6OkJyZWFrV29yZCB8fCBzdHlsZS5vdmVy Zmxvd1dyYXAoKSA9PSBPdmVyZmxvd1dyYXA6OkFueXdoZXJlOwogICAgIGlmIChjYW5CcmVha0Jl dHdlZW5BbnlUeXBvZ3JhcGhpY0NoYXJhY3RlclVuaXQpCiAgICAgICAgIHJldHVybiBtaWRXb3Jk QnJlYWs7CiAKQEAgLTMyMSwxNyArMzIyLDI1IEBAIHN0YXRpYyBUZXh0VXRpbDo6TWlkV29yZEJy ZWFrIG1pZFdvcmRCcmVhayhjb25zdCBJbmxpbmVDb250ZW50QnJlYWtlcjo6Q29udGludW91CiAg ICAgY29uc3QgYXV0byBsZWZ0ID0gbWlkV29yZEJyZWFrLnN0YXJ0OwogICAgIGF1dG8gcmlnaHQg PSBsZWZ0ICsgbWlkV29yZEJyZWFrLmxlbmd0aDsKICAgICBmb3IgKDsgcmlnaHQgPiBsZWZ0OyAt LXJpZ2h0KSB7Ci0gICAgICAgIGF1dG8gaXNCcmVha2FibGUgPSBbXShhdXRvIGNoYXJhY3Rlcikg eworICAgICAgICBhdXRvIGNhbkJyZWFrQmVmb3JlID0gWyZdKGF1dG8gY2hhcmFjdGVyKSB7CiAg ICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgaW5jbHVkZSBhbGwgdGhlIGNhc2VzIGZy b20gaHR0cHM6Ly91bmljb2RlLm9yZy9yZXBvcnRzL3RyMTQKICAgICAgICAgICAgIC8vIFVzZSBh IGJyZWFraW5nIG1hdHJpeCBzaW1pbGFyIHRvIGxpbmVCcmVha1RhYmxlIGluIEJyZWFrTGluZXMu Y3BwCiAgICAgICAgICAgICAvLyBBbHNvIHNlZSBrQnJlYWtBbGxMaW5lQnJlYWtDbGFzc1RhYmxl IGluIHRoaXJkX3BhcnR5L2JsaW5rL3JlbmRlcmVyL3BsYXRmb3JtL3RleHQvdGV4dF9icmVha19p dGVyYXRvci5jYworICAgICAgICAgICAgaWYgKGxpbmVCcmVhayAhPSBMaW5lQnJlYWs6Okxvb3Nl KSB7CisgICAgICAgICAgICAgICAgLy8gVGhlIGZvbGxvd2luZyBicmVha3MgYXJlIGFsbG93ZWQg Zm9yIGxvb3NlIGxpbmUgYnJlYWtpbmcgaWYgdGhlIHByZWNlZGluZyBjaGFyYWN0ZXIgYmVsb25n cyB0byB0aGUgVW5pY29kZQorICAgICAgICAgICAgICAgIC8vIGxpbmUgYnJlYWtpbmcgY2xhc3Mg SUQsIGFuZCBhcmUgb3RoZXJ3aXNlIGZvcmJpZGRlbjoKKyAgICAgICAgICAgICAgICAvLyDigJAg VSsyMDEwLCDigJMgVSsyMDEzCisgICAgICAgICAgICAgICAgLy8gaHR0cHM6Ly9kcmFmdHMuY3Nz d2cub3JnL2Nzcy10ZXh0LyNsaW5lLWJyZWFrLXByb3BlcnR5CisgICAgICAgICAgICAgICAgaWYg KGNoYXJhY3RlciA9PSBoeXBoZW4gfHwgY2hhcmFjdGVyID09IGVuZGFzaCkKKyAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKGNo YXJhY3RlciA9PSBub0JyZWFrU3BhY2UpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICAgICAgYXV0byBpc1B1bmN0dWF0aW9uID0gVV9HRVRfR0NfTUFTSyhjaGFyYWN0ZXIp ICYgKFVfR0NfUFNfTUFTSyB8IFVfR0NfUEVfTUFTSyB8IFVfR0NfUElfTUFTSyB8IFVfR0NfUEZf TUFTSyB8IFVfR0NfUE9fTUFTSyk7CiAgICAgICAgICAgICByZXR1cm4gY2hhcmFjdGVyID09IHJl dmVyc2VTb2xpZHVzIHx8ICFpc1B1bmN0dWF0aW9uOwogICAgICAgICB9OwogICAgICAgICBVMTZf U0VUX0NQX1NUQVJUKHRleHQsIGxlZnQsIHJpZ2h0KTsKLSAgICAgICAgaWYgKGlzQnJlYWthYmxl KHRleHRbcmlnaHRdKSkKKyAgICAgICAgaWYgKGNhbkJyZWFrQmVmb3JlKHRleHRbcmlnaHRdKSkK ICAgICAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBSRUxFQVNFX0FTU0VSVChyaWdodCA+PSBs ZWZ0KTsK