<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>232183</bug_id>
          
          <creation_ts>2021-10-22 15:52:45 -0700</creation_ts>
          <short_desc>RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet</short_desc>
          <delta_ts>2021-10-22 17:27:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>232179</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>kkinnunen</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1807914</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-10-22 15:52:45 -0700</bug_when>
    <thetext>SSIA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807925</commentid>
    <comment_count>1</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-10-22 16:05:54 -0700</bug_when>
    <thetext>This bug tracks addressing https://bugs.webkit.org/show_bug.cgi?id=232113#c10, where the WeakHashSet `m_remoteDisplayLists` is accessed from both the rendering backend thread and the main thread in the GPU process.

This is dangerous, given that WeakPtr itself cannot be used from different threads.

We should make this a HashSet or HashMap of Ref/RefPtr, and then manually remove entries from this map when releasing cached image buffers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807974</commentid>
    <comment_count>2</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-10-22 17:26:51 -0700</bug_when>
    <thetext>I think I&apos;m going to fix this as a part of https://bugs.webkit.org/show_bug.cgi?id=232179, since both bugs can be addressed by very similar changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1807975</commentid>
    <comment_count>3</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-10-22 17:27:06 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 232179 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>